Compare commits

..

112 Commits

Author SHA1 Message Date
7bc546e985 Fix Responsive 2026-03-06 16:19:01 +08:00
4fb522f88f Fix Eror Grafik Realisasi-3 2026-03-06 12:03:22 +08:00
85332a8225 Merge pull request 'Fix Eror Grafik Realisasi-2' (#78) from nico/6-mar-26/fix-container-portainer-1 into staggingweb
Reviewed-on: #78
2026-03-06 11:24:46 +08:00
3fe2a5ccab Fix Eror Grafik Realisasi-2 2026-03-06 11:19:45 +08:00
363bfa65fb Merge pull request 'Fix Eror Grafik Realisasi' (#77) from nico/6-mar-26/fix-container-portainer-1 into staggingweb
Reviewed-on: #77
2026-03-06 10:53:19 +08:00
dccf590cbf Fix Eror Grafik Realisasi 2026-03-06 10:52:10 +08:00
f076b81d14 Merge pull request 'Fix Prisma 1' (#76) from nico/6-mar-26/fix-container-portainer-1 into staggingweb
Reviewed-on: #76
2026-03-06 10:35:54 +08:00
b5ea3216e0 Fix Prisma 1 2026-03-06 10:31:19 +08:00
64b116588b Merge pull request 'nico/5-mar-26/fix-musik-fix-apbdes' (#75) from nico/5-mar-26/fix-musik-fix-apbdes into staggingweb
Reviewed-on: #75
2026-03-05 16:38:07 +08:00
63161e1a39 Fix tombolreplay, posisi tombol, posisi icon music. Fix create & edit apbdes upload image dan file optional 2026-03-05 16:36:12 +08:00
8b8c65dd1e fix(apbdes-edit): clear imageId/fileId when user removes preview
Problem:
- Saat user klik X button untuk hapus preview image/file
- Form state masih menyimpan imageId/fileId lama
- Saat submit, data lama tetap terkirim
- User tidak bisa benar-benar menghapus image/file

Solution:
- Clear apbdesState.edit.form.imageId saat hapus preview gambar
- Clear apbdesState.edit.form.fileId saat hapus preview dokumen
- Now user can truly make image/file empty

Files changed:
- src/app/admin/(dashboard)/landing-page/apbdes/[id]/edit/page.tsx

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-05 16:26:34 +08:00
159fb3cec6 feat(apbdes): make image and file optional for edit page too
Changes:

Backend (updt.ts, index.ts):
- Update FormUpdateBody: imageId?: string | null
- Update Elysia schema: t.Optional(t.String())
- Handle null/undefined values when updating

UI (edit/page.tsx):
- Remove mandatory validation for imageId and fileId
- Update labels to show '(Opsional)'
- Simplify handleSubmit logic (no validation check)
- Keep existing file IDs if no new upload

User Flow:
Before: Edit required imageId and fileId to be present
After: Can update APBDes without files, preserve existing or set to null

Files changed:
- src/app/api/[[...slugs]]/_lib/landing_page/apbdes/updt.ts
- src/app/api/[[...slugs]]/_lib/landing_page/apbdes/index.ts
- src/app/admin/(dashboard)/landing-page/apbdes/[id]/edit/page.tsx

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-05 15:53:26 +08:00
4821934224 fix(music-player): fix floating icon position shift on hover
Problem:
- Icon bergeser ke bawah saat hover
- transform: 'scale(1.1)' mengganti transform: 'translateY(-80%)'
- CSS transform property di-replace, bukan di-mix

Solution:
- Gabungkan kedua transform dalam satu string
- Hover: 'translateY(-80%) scale(1.1)' - maintain posisi + scale
- Leave: 'translateY(-80%)' - kembali ke posisi semula

Changes:
- onMouseEnter: transform = 'translateY(-80%) scale(1.1)'
- onMouseLeave: transform = 'translateY(-80%)'
- Added 'ease' timing function for smoother transition

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-05 14:53:38 +08:00
ee39b88b00 feat(music-player): add minimize feature with floating icon and centered controls
Layout Changes:
- Center all control buttons (shuffle, prev, play/pause, next, repeat)
- Center progress bar alongside controls
- Keep volume control + close button on the right
- Song info remains on the left

New Feature - Minimize Player:
- Add isMinimized state to track player visibility
- Replace close button with minimize functionality
- Show floating music icon when minimized (bottom-right corner)
- Click floating icon to restore player bar
- Floating icon has hover scale animation for better UX

UI/UX Improvements:
- Better visual hierarchy with centered controls
- Floating icon uses blue bg with white music icon
- Smooth transitions between states
- Icon scales on hover for interactive feedback
- Persistent player state (song continues playing when minimized)

Files changed:
- src/app/darmasaba/_com/FixedPlayerBar.tsx: Complete redesign

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-05 14:14:46 +08:00
ce46d3b5f7 fix(music-player): fix repeat button not working due to stale closure
Problem:
- Tombol repeat tidak berfungsi saat lagu selesai
- Event listener 'ended' menggunakan variabel state 'isRepeat' dari closure yang lama
- Meskipun state sudah di-toggle, event listener masih menggunakan nilai lama

Solution:
- Tambahkan isRepeatRef untuk menyimpan nilai terbaru dari isRepeat
- Sync ref dengan state menggunakan useEffect
- Gunakan isRepeatRef.current di event listener 'ended'
- Remove isRepeat dari dependency array useEffect

Files changed:
- src/app/context/MusicContext.tsx: Add isRepeatRef and sync with state

This ensures the repeat functionality works correctly when the song ends.

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-05 13:54:15 +08:00
144ac37e12 fix(public-apbdes): fix realisasi display on public APBDes page
- Fix types.ts transformAPBDesData to map totalRealisasi → realisasi
  - Backend returns totalRealisasi, frontend expects realisasi
  - Add fallback to use item.realisasi if totalRealisasi not available

- Fix grafikRealisasi.tsx to use realisasi field
  - Update Summary component to use i.realisasi || i.totalRealisasi
  - Update total calculation to use realisasi field

- Fix apbDesaTable.tsx to use realisasi field
  - Update total calculation to use item.realisasi

- Fix apbDesaProgress.tsx to use realisasi field
  - Update calcTotal to use item.realisasi with fallback

Root cause: Backend Prisma schema uses 'totalRealisasi' field, but public
page components were expecting 'realisasi' field.

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-05 11:27:28 +08:00
f90477ed63 fix(apbdes-edit): preserve realisasi data when editing APBDes
- Fix backend updt.ts to preserve realisasiItems from old items
  - Load existing items with realisasiItems before delete
  - Re-create realisasiItems for new items based on kode match
  - Recalculate totalRealisasi, selisih, persentase after restore

- Update frontend state to handle realisasi fields
  - Add realisasi, selisih, persentase to ApbdesItemSchema
  - Fix edit.load() to map totalRealisasi → realisasi
  - Fix edit.update() to omit calculated fields when sending to backend

- Update edit page.tsx to display realisasi data
  - Fix load data to use item.totalRealisasi (not item.realisasi)
  - Add Realisasi, Selisih, % columns to items table
  - Update handleAddItem and handleReset to preserve realisasi fields

Root cause: Backend was resetting totalRealisasi=0 for all items on update,
and frontend was accessing wrong field name (realisasi vs totalRealisasi)

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-05 11:20:45 +08:00
4a7811e06f Merge pull request 'Fix Tabel Apbdes, & fix muciplayer in background' (#74) from nico/4-mar-26/fix-musik-play-bg into staggingweb
Reviewed-on: #74
2026-03-04 16:41:25 +08:00
f63aaf916d Fix Tabel Apbdes, & fix muciplayer in background 2026-03-04 16:28:06 +08:00
3803c79c95 Merge pull request 'nico/4-mar-26/realiasasi-apbdes' (#73) from nico/4-mar-26/realiasasi-apbdes into staggingweb
Reviewed-on: #73
2026-03-04 12:03:46 +08:00
2d901912ea fix(realisasi): add kode field to RealisasiItem and simplify table display
- Add kode field to RealisasiItem model in Prisma schema
- Update API endpoints (create, update) to accept kode parameter
- Update state management with proper type definitions
- Add kode input field in RealisasiManager component
- Simplify realisasiTable to show flat list (Kode, Uraian, Realisasi, %)
- Remove section grouping and expandable details
- Fix race condition in findUnique.load() with loading guard
- Fix linting errors across multiple files

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-04 11:51:58 +08:00
a791efe76c fix(grafik): sync grafikRealisasi with totalRealisasi field
Fix:
- Change i.realisasi to i.totalRealisasi in Summary component
- Change i.realisasi to i.totalRealisasi in total calculation
- Add fragment wrapper <> to fix Box children type error
- Reorder Total Keseluruhan section to top (before category breakdown)

Now grafik shows correct data from multiple realisasi items.

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-03 16:47:26 +08:00
e9f7bc2043 feat(ui landing): add expandable realisasi detail in RealisasiTable
Features:
- Add expandable rows for each APBDes item
- Show detailed realisasi breakdown per item
- Each realisasi shows:
  * Keterangan/Uraian
  * Jumlah (formatted in Rupiah)
  * Tanggal (formatted date)
- Chevron icon indicator (right/down)
- Click row to expand/collapse
- Hover effect on clickable rows
- Info text: "Klik pada item untuk melihat detail realisasi"

UI Components:
- RealisasiDetail: Component to display list of realisasi
- ItemRow: Expandable row with click handler
- Updated Section: Manage expanded state per item

Styling:
- Gray background for detail section
- Blue color for amount
- Dimmed color for date
- Responsive layout with wrap="nowrap"
- Proper spacing between items

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-03 16:38:15 +08:00
6712da9ac2 fix(ui): replace Title with Text in Modal title to avoid h5 in h2 nesting
Fix:
- Change Modal title from <Title order={5}> to <Text fz='lg' fw={600}>
- Avoids invalid HTML nesting (<h5> cannot be child of <h2>)
- Maintains same visual appearance

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-03 16:21:27 +08:00
ac11a9367c fix(api): correct selisih calculation formula
Bug Fix:
- Change selisih formula from: totalRealisasi - anggaran
- To: anggaran - totalRealisasi

Reason:
- Selisih positif = Sisa anggaran (belum digunakan)
- Selisih negatif = Over budget (melebihi anggaran)

Example:
- Anggaran: Rp 30.000.000
- Realisasi: Rp 5.000.000
- Selisih (OLD): 5jt - 30jt = -25jt  Wrong
- Selisih (NEW): 30jt - 5jt = 25jt  Correct (sisa anggaran)

Files Updated:
- create.ts: Fix initial item creation
- updt.ts: Fix item update
- realisasi/create.ts: Fix after adding realisasi
- realisasi/update.ts: Fix after updating realisasi
- realisasi/delete.ts: Fix after deleting realisasi

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-03 16:16:38 +08:00
67e5ceb254 feat(ui): add Realisasi Manager component for multiple realisasi CRUD
New Component - RealisasiManager:
- Add modal form for create/edit realisasi
- Input fields: Jumlah (Rp), Tanggal, Keterangan/Uraian
- Display list of existing realisasi with edit/delete actions
- Summary cards showing: Anggaran, Total Realisasi, Sisa Anggaran, Persentase
- Color-coded percentage badges (teal ≥100%, blue ≥80%, yellow ≥60%, red <60%)
- Auto-reload data after create/update/delete operations

Features:
- Multiple realisasi per APBDes item
- Each realisasi has its own description (uraian)
- Date picker for realisasi tanggal
- Format currency in IDR (Rupiah)
- Responsive table layout
- Empty state when no realisasi exists

Integration:
- Integrated with existing state.realisasi CRUD functions
- Auto-calculate totalRealisasi and persentase (handled by backend)
- Display realisasi items from API response
- Works with existing APBDes detail page

UI/UX:
- Clean modal design with form validation
- Summary cards with color-coded backgrounds
- Icon indicators for date and currency
- Confirmation dialog before delete
- Loading states during async operations

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-03 15:41:43 +08:00
65942ac9d2 refactor(create): remove realisasiAwal, simplify to anggaran-only input
Refactoring:
- Remove realisasiAwal field from ItemForm type
- Remove NumberInput for realisasi awal from UI
- Remove realisasiAwal column from preview table
- Simplify state management (no realisasiAwal mapping)
- API create: Create items with totalRealisasi=0 (no auto-create realisasi)

Rationale:
- Cleaner separation: Anggaran dan Realisasi adalah entitas terpisah
- User create item untuk ANGGARAN dulu
- Setelah item dibuat, user bisa add MULTIPLE REALISASI dengan:
  * Uraian yang jelas untuk setiap realisasi
  * Tanggal yang spesifik
  * Keterangan detail
  * Bukti file attachment
- Follows the original schema design more closely

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-03 15:30:33 +08:00
e0436cc384 feat(create): add realisasi awal input di create page
Features:
- Add realisasiAwal field to ItemForm type
- Add NumberInput for realisasi awal (optional)
- Update table preview to show realisasi awal
- Update state to send realisasiAwal to API
- Update API create to handle realisasiAwal:
  * Create APBDesItem with totalRealisasi = realisasiAwal
  * Auto-create first RealisasiItem if realisasiAwal > 0
  * Auto-calculate selisih and persentase

UX Improvements:
- User can input initial realization during create
- Optional field with clear label and description
- Auto-calculation of percentages on backend
- Single transaction for item + first realisasi

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-03 15:13:58 +08:00
63682e47b6 feat(state): update APBDes state management for multiple realisasi
State Changes:
- Update ApbdesItemSchema: Remove realisasi, selisih, persentase fields
- Add RealisasiItemSchema for realisasi CRUD operations
- Update normalizeItem: Remove manual calculations (backend handles it)
- Update edit.load: Map items without realisasi fields
- Add realisasi state: create, update, delete functions

UI Changes:
- Update create/page.tsx: Remove realisasi input field and column
- Update edit/page.tsx: Remove realisasi input field and column
- Update ItemForm type: Remove realisasi property
- Simplify forms to only input anggaran, realisasi added separately

Features:
- Support for multiple realisasi per item
- Realisasi CRUD via dedicated state functions
- Auto-reload findUnique after realisasi operations
- Backend auto-calculates totalRealisasi, selisih, persentase

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-03 14:55:06 +08:00
f4705690a9 feat(api): implement multiple realisasi for APBDes
Schema Changes:
- Add RealisasiItem model for multiple realizations per APBDesItem
- Replace realisasi field with totalRealisasi (auto-calculated sum)
- Add selisih and persentase as auto-calculated fields
- Cascade delete realisasi when item is deleted

API Changes:
- Update index.ts: Add realisasi CRUD endpoints
  - POST /:itemId/realisasi - Create realisasi
  - PUT /realisasi/:realisasiId - Update realisasi
  - DELETE /realisasi/:realisasiId - Delete realisasi
- Update create.ts: Auto-calculate totalRealisasi=0, selisih, persentase
- Update updt.ts: Reset calculations when items updated
- Update findUnique.ts: Include realisasiItems in response
- Update findMany.ts: Include realisasiItems in response
- Remove realisasi field from ApbdesItemSchema

New Files:
- realisasi/create.ts - Create realisasi with auto-calculation
- realisasi/update.ts - Update realisasi with recalculation
- realisasi/delete.ts - Soft delete with recalculation

Features:
- Auto-calculate totalRealisasi from sum of all realisasiItems
- Auto-calculate selisih = totalRealisasi - anggaran
- Auto-calculate persentase = (totalRealisasi / anggaran) * 100
- Support for bukti file attachment
- Support for keterangan (notes) per realisasi
- Soft delete support for audit trail

UI Updates:
- Update admin detail page to use totalRealisasi instead of realisasi
- Update landing page realisasiTable to use totalRealisasi

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-03 14:45:21 +08:00
239771a714 fix(apbdes): improve UI components and styling
- Update Apbdes component with better conditional rendering
- Enhance grafikRealisasi with improved percentage display
- Refine color coding and feedback messages
- Optimize layout and spacing for better UX

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-03 14:15:27 +08:00
03451195c8 feat(apbdes) grafik: add detailed percentage comparison
- Display percentage value prominently next to each category title
- Add formatted currency (Rupiah) for better readability
- Color-coded progress bars based on achievement level:
  * Teal: ≥100% (target tercapai)
  * Blue: ≥80% (baik)
  * Yellow: ≥60% (cukup)
  * Red: <60% (perlu perhatian)
- Add contextual feedback messages based on percentage:
  * ✓ Achievement message for 100%
  *  Positive message for 80-99%
  * ⚠️ Warning messages for <80%
- Add TOTAL KESELURUHAN summary section at the top
- Add emoji icons for better visual distinction (💰 💸 📊)
- Animated progress bars for <100% achievement

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-03 13:58:52 +08:00
597af7e716 fix(apbdes) landing page: fix APBDes component not displaying on darmasaba page
- Restore Apbdes component with full functionality (fetch data, year selector, tables, charts)
- Fix realisasiTable.tsx: add missing items variable
- Fix grafikRealisasi.tsx: dynamic year title instead of hardcoded 2026
- Add eslint-disable comments for TypeScript any types
- Remove unused imports in paguTable.tsx
- Integrate PaguTable, RealisasiTable, GrafikRealisasi into main Apbdes component
- Component now fetches data from Valtio state and displays 3 tables + charts

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-03 12:51:53 +08:00
0a8a026b94 fix(apbdes): integrate new APBDes API with admin UI
- Update API schema to support name, deskripsi, and jumlah fields
- Enhance state management with additional form fields
- Add input fields for name, description, and total amount in create/edit pages
- Display description and total amount in detail page
- Fix APBDes component order in landing page
- Update TypeScript types and Prisma schema integration

API Changes:
- POST /api/landingpage/apbdes/create: Added optional fields (name, deskripsi, jumlah)
- PUT /api/landingpage/apbdes/🆔 Added optional fields (name, deskripsi, jumlah)

Admin UI Changes:
- create/page.tsx: Add TextInput for name, deskripsi, and jumlah
- edit/page.tsx: Add TextInput for name, deskripsi, and jumlah; improve reset functionality
- [id]/page.tsx: Display deskripsi and jumlah if available
- page.tsx: Minor formatting fix
- _state/apbdes.ts: Update Zod schema and default form with new fields

Landing Page:
- Move Apbdes component to top of stack for better visibility

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-03 10:56:30 +08:00
a5bd91b580 feat(berita): add multiple images gallery and YouTube video support
- Update schema: add images relation list and linkVideo field
- API: support multiple image upload and YouTube link in create/update
- Admin create page: add gallery upload (max 10) and YouTube embed preview
- Admin edit page: manage existing/new gallery images and YouTube link
- Admin detail page: display gallery grid and YouTube video embed
- Public detail page: show gallery images and YouTube video with responsive layout
- State: add imageIds[] and linkVideo fields with proper type handling
- Music player: fix seek functionality and ESLint warnings

Breaking changes:
- Prisma schema updated - requires migration
- API create/update endpoints now expect imageIds array and linkVideo string

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-02 16:06:53 +08:00
ae3187804e Notes slider musik belum berfungsi 2026-03-02 14:28:20 +08:00
91e32f3f1c fix(musik): fix seek slider reset ke 0 - root cause: useEffect dependency
ROOT CAUSE:
- filteredMusik di-calculate ulang setiap render (.filter() tanpa memoization)
- currentSong = filteredMusik[currentSongIndex] → object reference baru setiap render
- useEffect dependency [currentSong, currentSongIndex] trigger setiap render
- useEffect reset setCurrentTime(0) → slider kembali ke awal

FIX:
1. useMemo untuk filteredMusik - mencegah re-calculate setiap render
2. useEffect dependency [currentSong?.id, currentSongIndex] - hanya trigger saat lagu benar-benar berubah
3. Hapus semua debug console.log yang tidak diperlukan
4. Simplifikasi seekTo function

File Changed:
- src/app/darmasaba/(pages)/musik/musik-desa/page.tsx
- src/app/darmasaba/(pages)/musik/lib/seek.ts

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-02 12:03:26 +08:00
4d03908f23 feat(musik): tambahkan extensive debug logging untuk tracking seek issue
- Tambah key stabil pada audio element untuk mencegah remount
- Log di seekTo: before/after currentTime
- Log di onTimeUpdate: currentTime, rounded, isSeeking
- Log di onChangeEnd slider: value, seekTime
- Log di useEffect song change: currentSong, currentSongIndex
- Log di skipBack/skipForward: index perubahan lagu

Purpose: Track urutan eksekusi dan identifikasi race condition atau re-render yang tidak diinginkan

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-02 11:58:40 +08:00
0563f9664f fix(musik): perbaiki timing dan rounding pada seek slider
- Gunakan durasi dari database sebagai acuan utama (bukan dari audio metadata)
- Ganti Math.floor dengan Math.round untuk smoothing currentTime
- Tambahkan validasi seek time: Math.min(Math.max(0, v), duration)
- Tambahkan debug logging untuk tracking seek behavior
- Hapus override duration di onLoadedMetadata untuk menghindari konflik

Root cause:
- Duration dari database (string 'MM:SS' → seconds) berbeda dengan audio.duration (float)
- Math.floor menyebabkan lompatan kasar dan kehilangan presisi
- onLoadedMetadata override duration dengan audio.duration yang tidak exact

Fix:
- Database duration = source of truth
- Math.round untuk smoothing tanpa kehilangan presisi
- Validasi bounds untuk mencegah seek negatif atau melebihi durasi

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-02 11:53:36 +08:00
961cc32057 fix(musik): slider seek sekarang berfungsi dengan benar
- Fix slider seek reset ke detik awal saat digeser
- Tambahkan isSeeking state untuk mencegah onTimeUpdate mereset posisi slider
- Implementasi pattern preview/commit untuk seek:
  - onChange: update UI state saja (preview)
  - onChangeEnd: commit ke audio player (commit)
- Update seekTo function untuk support optional setCurrentTime callback
- Terapkan fix ke kedua slider (Sedang Diputar dan bottom player)

Bug: Slider seek langsung kembali ke posisi awal saat digeser karena:
1. onTimeUpdate terus menerus update currentTime state
2. seekTo tidak update React state setelah set audio.currentTime
3. Tidak ada isSeeking flag untuk block onTimeUpdate saat user sedang seek

Fix:
1. Set isSeeking=true saat onChange, false saat onChangeEnd
2. onTimeUpdate check isSeeking sebelum update state
3. seekTo sekarang juga update state via callback optional

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-02 11:47:05 +08:00
fe7672e09f refactor(musik): integrate music player library functions and fix build errors
- Integrate togglePlayPause, getNextIndex, getPrevIndex, handleRepeatOrNext, seekTo, toggleShuffle, setAudioVolume, toggleMute library functions
- Fix ESLint warnings: remove unused eslint-disable, add missing useEffect dependencies
- Fix ESLint error in useMusicPlayer.ts togglePlayPause function
- Add force-dynamic export to root layout to prevent prerendering errors
- Improve seek slider with preview/commit functionality
- Add isSeeking state to prevent UI flickering during seek

Fixes: Build PageNotFoundError for admin/darmasaba pages

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-02 11:41:14 +08:00
341ff5779f Fix Durasi Musik Di Tampilan User 2026-02-27 11:52:18 +08:00
69f7b4c162 feat: integrate musik desa page with API and improve audio player
- Fetch musik data from /api/desa/musik/find-many endpoint
- Filter only active musik (isActive: true)
- Add search functionality by title, artist, and genre
- Implement real audio playback with HTML5 audio element
- Add play/pause, next/previous, shuffle, repeat controls
- Add progress bar with seek functionality
- Add volume control with mute toggle
- Auto-play next song when current song ends
- Add loading and empty states
- Use cover image and audio file from database
- Fix skip back/forward button handlers

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-02-26 22:24:25 +08:00
409ad4f1a2 Fix Login KodeOtp WA 2026-02-26 22:10:28 +08:00
55ea3c473a add menu musik 2026-02-26 21:32:33 +08:00
0160fa636d Merge pull request 'Fix Login KodeOtp WA' (#72) from nico/26-feb-26/fix-auth-wa-login into staggingweb
Reviewed-on: #72
2026-02-26 14:14:29 +08:00
a152eaf984 Fix Login KodeOtp WA 2026-02-26 14:12:54 +08:00
3684e83187 Merge pull request 'Fix CORS config for staging environment' (#71) from nico/25-feb-26 into staggingweb
Reviewed-on: #71
2026-02-25 23:15:18 +08:00
223b85a714 Fix CORS config for staging environment
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-02-25 22:55:36 +08:00
77c54b5c8a Merge pull request 'nico/25-feb-26' (#70) from nico/25-feb-26 into staggingweb
Reviewed-on: #70
2026-02-25 21:34:28 +08:00
f1729151b3 Fix themeTokens light mode status colors
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-02-25 21:24:39 +08:00
8e8c133eea Fix eror build 2026-02-25 21:19:56 +08:00
1e7acac193 Fix eror build 2026-02-25 21:18:26 +08:00
bb80b0ecc1 Merge pull request 'fix/admin/menu-desa/berita' (#69) from fix/admin/menu-desa/berita into staggingweb
Reviewed-on: #69
2026-02-25 16:27:35 +08:00
42dcbcfb22 fix-admin-menu-desa-berita 2026-02-25 16:25:59 +08:00
22de1aa1f3 fix-admin-menu-desa-potensi 2026-02-25 15:41:01 +08:00
b1d28a8322 fix-admin-menu-desa-profile 2026-02-25 15:25:51 +08:00
b86a3a85c3 fix: force default light mode for public pages and admin
- Set defaultColorScheme='light' in root MantineProvider
- Change darkModeStore default from system preference to false (light)
- Add MantineProvider with light theme to darmasaba/layout.tsx
- Remove dark mode dependency from ModuleView component
- Prevent system color scheme from affecting initial page load

This ensures consistent light mode on first visit for both
public pages and admin panel, regardless of OS settings.

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-02-25 10:45:27 +08:00
fd63bb0fd4 feat: implement dark mode support & fix Prisma schema validation
- Add dark mode toggle component in admin header
- Integrate dark mode store across admin layout and components
- Add unified typography and surface components for consistent theming
- Implement smooth transitions for dark/light mode switching
- Fix Prisma schema: remove @default(null) from DateTime? fields
- Update form validation for inovasi, lingkungan, and pendidikan modules
- Add form validation and improve UX across multiple admin pages

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-02-25 10:41:48 +08:00
f2c9a922a6 fix(profil-module): QC improvements based on QC-PROFIL-MODULE.md
- Fix fetch method inconsistency (convert to ApiFetch)
  - programInovasi: findUnique, delete, update methods
  - mediaSosial: findUnique, delete, update methods
- Add loading state to findUnique operations
- Fix iconUrl validation (make optional instead of required)
- Add DOMPurify for HTML sanitization (XSS protection)
  - program-inovasi page.tsx (list & detail)
- Remove console.log in production (use dev-only logging)
- Install dompurify and @types/dompurify

Security: Prevent XSS attacks by sanitizing HTML content
Consistency: Use ApiFetch for all API operations
UX: Proper loading states for better user feedback

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-02-23 15:11:00 +08:00
92b24440fe fix: Quality Control improvements & bug fixes
- APBDes: Fix edit form original data tracking (imageId, fileId)
- APBDes: Update formula consistency in state
- PPID modules: Various UI improvements and bug fixes
- PPID Profil: Preview and edit page improvements
- PPID Dasar Hukum: Page structure improvements
- PPID Visi Misi: Page structure improvements
- PPID Struktur: Posisi organisasi page improvements
- PPID Daftar Informasi: Edit page improvements
- Auth login: Route improvements
- Update dependencies (package.json, bun.lockb)
- Update seed data
- Update .gitignore

QC Reports added:
- QC-APBDES-MODULE.md
- QC-PROFIL-MODULE.md
- QC-SDGS-DESA.md
- QC-DESA-ANTI-KORUPSI.md
- QC-PRESTASI-DESA-MODULE.md
- QC-PPID-PROFIL-MODULE.md
- QC-STRUKTUR-PPID-MODULE.md
- QC-VISI-MISI-PPID-MODULE.md
- QC-DASAR-HUKUM-PPID-MODULE.md
- QC-PERMOHONAN-INFORMASI-PUBLIK-MODULE.md
- QC-PERMOHONAN-KEBERATAN-INFORMASI-MODULE.md
- QC-DAFTAR-INFORMASI-PUBLIK-MODULE.md
- QC-IKM-MODULE.md

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-02-23 14:38:28 +08:00
f0558aa0d0 feat: implement dark mode support for admin layout and components
- Add dark mode toggle component in admin header
- Integrate dark mode store across admin layout and child components
- Update header, judulList, and judulListTab components with theme tokens
- Add unified typography components for consistent theming
- Implement smooth transitions for dark/light mode switching
- Add mounted state to prevent hydration mismatches
- Style navbar with dark mode aware colors and hover states
- Update button styles with gradient effects for both themes

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-02-23 10:48:00 +08:00
8132609ccb feat: add form validation for inovasi, lingkungan, and pendidikan modules
- Added isFormValid() and isHtmlEmpty() helper functions for form validation
- Disabled submit buttons when required fields are empty across multiple admin and public pages
- Applied consistent validation pattern for creating and editing records
- Commented out WhatsApp OTP sending in login route for debugging/testing
- Fixed path in NavbarMainMenu tooltip action
2026-02-20 15:08:41 +08:00
1b59d6bf09 Merge pull request 'Fix Coba lagi image stagging' (#66) from nico/5-feb-26-2 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/66
2026-02-05 14:31:53 +08:00
eb1ad54db6 Merge pull request 'Seed create' (#65) from nico/5-feb-26-1 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/65
2026-02-05 14:04:09 +08:00
21ec3ad1c1 Merge pull request 'nico / 5-feb-26 (3)' (#64) from nico/5-feb-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/64
2026-02-05 12:35:21 +08:00
3a115908c4 Merge pull request 'nico / 5-feb-26(2)' (#63) from nico/5-feb-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/63
2026-02-05 12:07:17 +08:00
5ff791642c Merge pull request 'nico / 5-feb-26' (#62) from nico/5-feb-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/62
2026-02-05 11:14:42 +08:00
b803c7a90c Merge pull request 'nico / 4-feb-26' (#61) from nico/4-feb-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/61
2026-02-04 17:10:27 +08:00
fb2fe67c23 Merge pull request 'Nico / 4-Feb-2026' (#60) from nico/4-feb-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/60
2026-02-04 11:49:22 +08:00
51460558d4 Merge pull request 'Seeder Menu Lingkungan dan Pendidikan' (#59) from nico/3-feb-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/59
2026-02-03 17:12:03 +08:00
d105ceeb6b Merge pull request 'nico/2-feb-26' (#58) from nico/2-feb-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/58
2026-02-02 17:32:10 +08:00
c865aee766 Merge pull request 'Fix Eror Code get_images.ts (1)' (#57) from nico/30-jan-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/57
2026-01-30 17:16:42 +08:00
273dfdfd09 Merge pull request 'Fix Seeder Image, Menu Landing Page - Desa' (#56) from nico/30-jan-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/56
2026-01-30 15:57:16 +08:00
1d1d8e50dc Merge pull request 'Fix Seed Image 27 Jan' (#55) from nico/27-jan-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/55
2026-01-27 10:51:22 +08:00
092afe67d2 Merge pull request 'Seed Pendidikan' (#54) from nico/23-jan-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/54
2026-01-23 16:52:25 +08:00
2d9170705d Merge pull request 'Fix seeder statistik kemiskinan' (#53) from nico/21-jan-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/53
2026-01-21 14:27:32 +08:00
fdf9a951a4 Merge pull request 'Fix uploads -1' (#52) from nico/21-jan-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/52
2026-01-21 14:10:42 +08:00
ca74029688 Merge pull request 'nico/21-jan-26' (#51) from nico/21-jan-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/51
2026-01-21 12:10:18 +08:00
1a8fc1a670 Merge pull request 'nico/17-jan-26' (#49) from nico/17-jan-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/49
> Add Layanan Polsek submenu polsek terdekat
> Seeder menu keamanan -> menu ekonomi submenu : demografi pekerjaan, junlah pengangguran, lowongan kerja lokal, pasar desa, program kemiskinan, sektor unggulan, struktur organisasi
2026-01-17 10:36:11 +08:00
19235f0791 Merge pull request 'Fix All Search Admin' (#48) from nico/5-jan-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/48
2026-01-05 17:12:29 +08:00
61de7d8d33 Merge pull request 'Fix QC Kak Inno Mobile Done' (#47) from nico/1-jan-26 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/47
2026-01-02 16:42:08 +08:00
8fb85ce56c Merge pull request 'Fix QC Kak Inno 23 Des' (#46) from nico/24-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/46
2025-12-24 14:38:12 +08:00
1f98b6993d Merge pull request 'nico/23-des-25' (#45) from nico/23-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/45
2025-12-23 17:19:57 +08:00
f3a10d63d1 Merge pull request 'nico/19-des-25' (#44) from nico/19-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/44
2025-12-19 15:44:53 +08:00
7a42bec63b Merge pull request 'nico/17-des-25' (#43) from nico/17-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/43
2025-12-17 17:39:29 +08:00
44c421129e Merge pull request 'nico/16-des-25' (#42) from nico/16-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/42
2025-12-16 16:38:42 +08:00
ddff427926 Merge pull request 'nico/12-des-25' (#41) from nico/12-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/41
2025-12-12 17:07:31 +08:00
00c8caade4 Merge pull request 'nico/10-des-25' (#40) from nico/10-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/40
2025-12-10 17:45:16 +08:00
0209f49449 Merge pull request 'nico/9-des-25' (#39) from nico/9-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/39
2025-12-09 17:40:16 +08:00
344c6ada6d Merge pull request 'nico/5-des-25' (#38) from nico/5-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/38
2025-12-05 14:32:12 +08:00
11acd04419 Merge pull request 'Fix Error Build Staging' (#37) from nico/3-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/37
2025-12-04 11:59:43 +08:00
8d49213b68 Merge pull request 'Menambahkan menu dokter dan tenaga medis, admin bisa create, edit, delet dokter' (#36) from nico/3-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/36
2025-12-03 17:57:33 +08:00
96911e3cf1 Merge pull request 'Fix UI Sosial Media Landing Page in User' (#35) from nico/2-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/35
2025-12-02 16:46:49 +08:00
9950c28b9b Merge pull request 'Fix menu admin landing page, submenu sosial media' (#34) from nico/2-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/34
2025-12-02 16:09:19 +08:00
fa0f3538d1 Merge pull request 'Tambahan filter data sesuai tahun, di landing page apbdes' (#33) from nico/1-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/33
2025-12-01 17:12:34 +08:00
2778f53aff Merge pull request 'Tambah Term of Service di Registrasi' (#32) from nico/1-des-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/32
2025-12-01 14:02:11 +08:00
37ac91d4f4 Push Conflict 2025-12-01 13:58:27 +08:00
217f4a9a3b Tambah Term of Service di Registrasi 2025-12-01 13:53:39 +08:00
5d6a7437ed Merge branch 'nico/1-des-25' into staggingweb 2025-12-01 13:52:11 +08:00
752a6cabee Merge pull request 'Meta-data' (#29) from nico/1-des-25-1 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/29
2025-12-01 10:22:10 +08:00
134ddc6154 Meta-data 2025-12-01 10:21:00 +08:00
28979c6b49 Merge pull request 'Test Google Insight' (#28) from nico/28-nov-25-1 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/28
2025-11-28 19:24:18 +08:00
b2066caa13 Test Google Insight 2025-11-28 17:54:18 +08:00
023c77d636 Merge pull request 'Add <meta charSet=utf-8 />' (#27) from nico/28-nov-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/27
2025-11-28 17:05:14 +08:00
9bf3ec72cf Add <meta charSet=utf-8 /> 2025-11-28 17:04:35 +08:00
f359f5b1ce Merge pull request 'nico/28-nov-25' (#26) from nico/28-nov-25 into staggingweb
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/26
2025-11-28 15:39:08 +08:00
1c1e8fb190 fix ganti role, user menu access ikut ke create fix 2025-11-28 15:38:07 +08:00
54f83da3b8 fix ganti role, user menu access ikut ke create 2025-11-28 15:35:21 +08:00
f8985c550f Merge branch 'nico/28-nov-25' of https://wibugit.wibudev.com/wibu/desa-darmasaba into nico/28-nov-25 2025-11-28 15:32:19 +08:00
e3d909e760 fix ganti role, user menu access ikut ke create 2025-11-28 15:31:10 +08:00
16a8df50c1 Merge pull request 'staggingweb' (#25) from staggingweb into nico/28-nov-25
Reviewed-on: http://wibugit.wibudev.com/wibu/desa-darmasaba/pulls/25
2025-11-28 15:04:30 +08:00
182 changed files with 9800 additions and 11350 deletions

3
.gitignore vendored
View File

@@ -31,6 +31,9 @@ yarn-error.log*
# env
.env*
# QC
QC
# vercel
.vercel

73
AUDIT_REPORT.md Normal file
View File

@@ -0,0 +1,73 @@
# Engineering Audit Report: Desa Darmasaba
**Status:** Production Readiness Review (Critical)
**Auditor:** Staff Technical Architect
---
## 📊 Executive Summary & Scores
| Category | Score | Status |
| :--- | :---: | :--- |
| **Project Architecture** | 3/10 | 🔴 Critical Failure |
| **Code Quality** | 4/10 | 🟠 Poor |
| **Performance** | 5/10 | 🟡 Mediocre |
| **Security** | 5/10 | 🟠 Risk Detected |
| **Production Readiness** | 2/10 | 🔴 Not Ready |
---
## 🏗️ 1. Project Architecture
The project suffers from a **"Frankenstein Architecture"**. It attempts to run a full Elysia.js instance inside a Next.js Catch-All route.
- **Fractured Backend:** Logic is split between standard Next.js routes (`/api/auth`) and embedded Elysia modules.
- **Stateful Dependency:** Reliance on local filesystem (`WIBU_UPLOAD_DIR`) makes the application impossible to deploy on modern serverless platforms like Vercel.
- **Polluted Namespace:** Routing tree contains "test/coba" folders (`src/app/coba`, `src/app/percobaan`) that would be accessible in production.
## ⚛️ 2. Frontend Engineering (React / Next.js)
- **State Management Chaos:** Simultaneous use of `Valtio`, `Jotai`, `React Context`, and `localStorage`.
- **Tight Coupling:** Public pages (`/darmasaba`) import state directly from Admin internal states (`/admin/(dashboard)/_state`).
- **Heavy Client-Side Logic:** Logic that belongs in Server Actions or Hooks is embedded in presentational components (e.g., `Footer.tsx`).
## 📡 3. Backend / API Design
- **Framework Overhead:** Running Elysia inside Next.js adds unnecessary cold-boot overhead and complexity.
- **Weak Validation:** Widespread use of `as Type` casting in API handlers instead of runtime validation (Zod/Schema).
- **Service Integration:** OTP codes are sent via external `GET` requests with sensitive data in the query string—a major logging risk.
## 🗄️ 4. Database & Data Modeling (Prisma)
- **Schema Over-Normalization:** ~2000 lines of schema. Every minor content type (e.g., `LambangDesa`) is a separate table instead of a unified CMS model.
- **Polymorphic Monolith:** `FileStorage` is a "god table" with optional relations to ~40 other tables, creating a massive bottleneck and data integrity risk.
- **Connection Mismanagement:** Manual `prisma.$disconnect()` in API routes kills connection pooling performance.
## 🚀 5. Performance Engineering
- **Bypassing Optimization:** Custom `/api/utils/img` endpoint bypasses `next/image` optimization, serving uncompressed assets.
- **Aggressive Polling:** Client-side 30s polling for notifications is battery-draining and inefficient compared to SSE or SWR.
## 🔒 6. Security Audit
- **Insecure OTP Delivery:** Credentials passed as URL parameters to the WhatsApp service.
- **File Upload Risks:** Potential for Arbitrary File Upload due to direct local filesystem writes without rigorous sanitization.
## 🧹 7. Code Quality
- **Inconsistency:** Mixed English/Indonesian naming (e.g., `nomor` vs `createdAt`).
- **Artifacts:** Root directory is littered with scratch files: `xcoba.ts`, `xx.ts`, `test.txt`.
---
## 🚩 Top 10 Critical Problems
1. **Architectural Fracture:** Embedding Elysia inside Next.js creates a "split-brain" system.
2. **Serverless Incompatibility:** Dependency on local disk storage for uploads.
3. **Database Bloat:** Over-complicated schema with a fragile `FileStorage` monolith.
4. **State Fragmentation:** Mixed usage of Jotai and Valtio without a clear standard.
5. **Credential Leakage:** OTP codes sent via GET query parameters.
6. **Poor Cleanup:** Trial/Test folders and files committed to the production source.
7. **Asset Performance:** Bypassing Next.js image optimization.
8. **Coupling:** High dependency between public UI and internal Admin state.
9. **Type Safety:** Manual casting in APIs instead of runtime validation.
10. **Connection Pooling:** Inefficient Prisma connection management.
---
## 🛠️ Tech Lead Refactoring Priorities
1. **Unify the API:** Decommission the Elysia wrapper. Port all logic to standard Next.js Route Handlers with Zod validation.
2. **Stateless Storage:** Implement an S3-compatible adapter for all file uploads. Remove `fs` usage.
3. **Schema Consolidation:** Refactor the schema to use generic content models where possible.
4. **Standardize State:** Choose one global state manager and migrate all components.
5. **Project Sanitization:** Delete all `coba`, `percobaan`, and scratch files (`xcoba.ts`, etc.).

View File

@@ -1,763 +0,0 @@
# QC Summary - APBDes Module
**Scope:** List APBDes, Create, Edit, Detail
**Date:** 2026-02-23
**Status:** ✅ Secara umum sudah baik, ada beberapa critical issues yang perlu diperbaiki
---
## 📊 OVERVIEW
| Aspect | Schema | API | UI Admin | State Management | Overall |
|--------|--------|-----|----------|-----------------|---------|
| APBDes | ✅ Baik | ✅ Baik | ✅ Baik | ⚠️ Ada issue | 🟡 Perlu fix |
---
## ✅ YANG SUDAH BAIK
### **1. UI/UX Consistency**
- ✅ Responsive design (desktop table + mobile cards)
- ✅ Loading states dengan Skeleton
- ✅ Search dengan debounce (1000ms)
- ✅ Pagination konsisten
- ✅ Empty state handling yang informatif
- ✅ Modal konfirmasi hapus
### **2. File Upload Handling**
- ✅ Dual upload: Gambar + Dokumen
- ✅ Dropzone dengan preview (image + iframe untuk dokumen)
- ✅ Validasi format (gambar: JPEG/PNG/WEBP, dokumen: PDF/DOC/DOCX)
- ✅ Validasi ukuran file (max 5MB untuk gambar, 10MB untuk dokumen di edit)
- ✅ Tombol hapus preview (IconX di pojok kanan atas)
- ✅ URL.createObjectURL untuk preview lokal
### **3. Form Validation**
- ✅ Zod schema untuk validasi typed
- ✅ isFormValid() check sebelum submit
- ✅ Error toast dengan pesan spesifik
- ✅ Button disabled saat invalid/loading
- ✅ Type number input untuk tahun
### **4. Complex Feature - APBDes Items**
- ✅ Hierarchical items dengan level (1, 2, 3)
- ✅ Tipe classification (pendapatan, belanja, pembiayaan)
- ✅ Auto-calculation: selisih & persentase
- ✅ Add/remove items dynamic
- ✅ Table preview dengan badge color coding
- ✅ Indentasi visual berdasarkan level
### **5. Edit Form - Original Data Tracking**
- ✅ Original data state untuk reset form
- ✅ Load data existing dengan benar
- ✅ Preview image & dokumen dari data lama
- ✅ Reset form mengembalikan ke data original
- ✅ File replacement logic (upload baru jika ada perubahan)
**Code Example (✅ GOOD):**
```typescript
// Line ~95-130 - Load data & save original
const data = await apbdesState.edit.load(id);
setOriginalData({
tahun: data.tahun || new Date().getFullYear(),
imageId: data.imageId || '',
fileId: data.fileId || '',
imageUrl: data.image?.link || '',
fileUrl: data.file?.link || '',
});
// Set form dengan data lama (termasuk imageId dan fileId)
apbdesState.edit.form = {
tahun: data.tahun || new Date().getFullYear(),
imageId: data.imageId || '', // ✅ Preserve old ID
fileId: data.fileId || '', // ✅ Preserve old ID
items: (data.items || []).map(...),
};
// Line ~270 - Handle reset
const handleReset = () => {
apbdesState.edit.form = {
tahun: originalData.tahun,
imageId: originalData.imageId, // ✅ Restore old ID
fileId: originalData.fileId, // ✅ Restore old ID
items: [...apbdesState.edit.form.items],
};
setPreviewImage(originalData.imageUrl || null);
setPreviewDoc(originalData.fileUrl || null);
setImageFile(null);
setDocFile(null);
toast.info('Form dikembalikan ke data awal');
};
```
**Verdict:****SUDAH BENAR** - Original data tracking sudah implementasi dengan baik.
---
### **6. Schema Design**
- ✅ Proper relations: APBDes ↔ FileStorage (image & file)
- ✅ Self-relation untuk hierarchical items (parentId → children)
- ✅ Indexing untuk performa (kode, level, apbdesId)
- ✅ Soft delete support (deletedAt, isActive)
- ✅ Nullable deletedAt yang benar (`DateTime? @default(null)`)
**Schema Example (✅ GOOD):**
```prisma
model APBDes {
id String @id @default(cuid())
tahun Int?
name String?
deskripsi String?
jumlah String?
items APBDesItem[]
image FileStorage? @relation("APBDesImage", fields: [imageId], references: [id])
imageId String?
file FileStorage? @relation("APBDesFile", fields: [fileId], references: [id])
fileId String?
deletedAt DateTime? // ✅ Nullable, no default
isActive Boolean @default(true)
}
model APBDesItem {
id String @id @default(cuid())
kode String
uraian String
anggaran Float
realisasi Float
selisih Float // ✅ Formula di komentar
persentase Float
tipe String? // ✅ Nullable untuk level 1
level Int
parentId String?
parent APBDesItem? @relation("APBDesItemParent", fields: [parentId], references: [id])
children APBDesItem[] @relation("APBDesItemParent")
apbdesId String
apbdes APBDes @relation(fields: [apbdesId], references: [id])
@@index([kode])
@@index([level])
@@index([apbdesId])
}
```
**Verdict:****SUDAH BENAR** - Schema design sudah solid.
---
## ⚠️ ISSUES & SARAN PERBAIKAN
### **🔴 CRITICAL**
#### **1. Formula Selisih - SALAH di State, BENAR di Schema/API**
**Lokasi:**
- `src/app/admin/(dashboard)/_state/landing-page/apbdes.ts` (line 36)
- Schema komentar di `prisma/schema.prisma` (line 210)
**Masalah:**
```typescript
// ❌ SALAH di state (line 36)
function normalizeItem(item: Partial<...>): z.infer<typeof ApbdesItemSchema> {
const anggaran = item.anggaran ?? 0;
const realisasi = item.realisasi ?? 0;
// ❌ WRONG FORMULA
const selisih = anggaran - realisasi; // positif = sisa anggaran
const persentase = anggaran > 0 ? (realisasi / anggaran) * 100 : 0;
return { ... };
}
```
```prisma
// ✅ BENAR di schema komentar (line 210)
model APBDesItem {
// ...
realisasi Float
selisih Float // ✅ realisasi - anggaran (komentar benar)
// ...
}
```
**Dampak:**
- **Data salah!** Selisih positif/negatif terbalik
- Jika realisasi > anggaran (over budget), seharusnya **negatif** tapi jadi **positif**
- Jika realisasi < anggaran (under budget/sisa), seharusnya **positif** tapi jadi **negatif**
- Color coding di UI (green/red) juga terbalik!
**Contoh:**
```
Anggaran: Rp 100.000.000
Realisasi: Rp 120.000.000 (over budget!)
❌ Formula sekarang: selisih = 100M - 120M = -20M (negatif)
UI show: merah (over budget) ✅ TAPI karena negatif
✅ Seharusnya: selisih = 120M - 100M = +20M (positif)
UI show: merah (over budget) ✅ Karena positif
```
**Rekomendasi:** Fix formula di state:
```typescript
// ✅ CORRECT FORMULA
const selisih = realisasi - anggaran; // positif = over budget, negatif = under budget
const persentase = anggaran > 0 ? (realisasi / anggaran) * 100 : 0;
```
**Priority:** 🔴 **CRITICAL**
**Effort:** Low (1 line fix)
**Impact:** **HIGH** (data integrity issue)
---
#### **2. State Management - Inconsistency Fetch Pattern**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/apbdes.ts`
**Masalah:** Ada 3 pattern berbeda untuk fetch API:
```typescript
// ❌ Pattern 1: ApiFetch (create, findMany, delete, edit.load, edit.update)
const res = await ApiFetch.api.landingpage.apbdes["create"].post(parsed.data);
const res = await ApiFetch.api.landingpage.apbdes["findMany"].get({ query });
const res = await (ApiFetch.api.landingpage.apbdes as any)["del"][id].delete();
const res = await (ApiFetch.api.landingpage.apbdes as any)[id].get();
const res = await (ApiFetch.api.landingpage.apbdes as any)[this.id].put(requestData);
// ❌ Pattern 2: fetch manual (findUnique)
const response = await fetch(`/api/landingpage/apbdes/${id}`);
const res = await response.json();
```
**Dampak:**
- Code consistency buruk
- Sulit maintenance
- Type safety tidak konsisten
- Duplikasi logic error handling
- Console.log debugging tertinggal di production
**Rekomendasi:** Gunakan **ApiFetch** untuk semua operasi:
```typescript
// ✅ Unified pattern
async load(id: string) {
try {
this.loading = true;
const res = await ApiFetch.api.landingpage.apbdes[id].get();
if (res.data?.success) {
this.data = res.data.data;
} else {
this.data = null;
this.error = res.data?.message || "Gagal memuat detail APBDes";
toast.error(this.error);
}
} catch (error) {
console.error("FindUnique error:", error);
this.data = null;
this.error = "Gagal memuat detail APBDes";
toast.error(this.error);
} finally {
this.loading = false;
}
}
```
**Priority:** 🔴 High
**Effort:** Medium (refactor di findUnique)
---
#### **3. Console.log Debugging di Production**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/apbdes.ts`
**Masalah:**
```typescript
// Line ~175-177
const url = `/api/landingpage/apbdes/${id}`;
console.log("🌐 Fetching:", url); // ❌ Debug log
const response = await fetch(url);
const res = await response.json();
console.log("📦 Response:", res); // ❌ Debug log
```
**Dampak:**
- Performance impact (I/O operation)
- Security risk (expose API structure)
- Log pollution di production
- Unprofessional
**Rekomendasi:** Remove atau gunakan conditional logging:
```typescript
// ✅ Remove completely (recommended)
// Atau gunakan conditional logging
if (process.env.NODE_ENV === 'development') {
console.log("🌐 Fetching:", url);
console.log("📦 Response:", res);
}
```
**Priority:** 🔴 Medium
**Effort:** Low
---
### **🟡 MEDIUM**
#### **4. Type Safety - Any Usage di Edit Methods**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/apbdes.ts`
**Masalah:**
```typescript
// Line ~215
const res = await (ApiFetch.api.landingpage.apbdes as any)[id].get();
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
// Line ~245
const res = await (ApiFetch.api.landingpage.apbdes as any)[this.id].put(requestData);
// ^^^^^^^^^^^^^^^^^^^^^^^^^^
```
**Dampak:**
- Type safety hilang
- Autocomplete tidak bekerja
- Runtime errors tidak terdeteksi di compile time
- Refactoring sulit
**Rekomendasi:** Define typed API client:
```typescript
// Define proper types
interface APBDesAPI {
[id: string]: {
get: () => Promise<ApiResponse<APBDesData>>;
put: (data: APBDesForm) => Promise<ApiResponse<APBDesData>>;
};
del: {
[id: string]: {
delete: () => Promise<ApiResponse<void>>;
};
};
}
// Use typed client
const res = await ApiFetch.api.landingpage.apbdes[id].get();
// No more `as any`
```
**Priority:** 🟡 Medium
**Effort:** Medium (perlu setup types)
---
#### **5. Edit Form - Items Tidak Di-Restore Saat Reset**
**Lokasi:** `src/app/admin/(dashboard)/landing-page/apbdes/[id]/edit/page.tsx`
**Masalah:**
```typescript
// Line ~270-285
const handleReset = () => {
apbdesState.edit.form = {
tahun: originalData.tahun,
imageId: originalData.imageId,
fileId: originalData.fileId,
items: [...apbdesState.edit.form.items], // ⚠️ Keep MODIFIED items
};
// ...
};
```
**Issue:** Saat reset, items yang sudah di-modified (added/removed) tidak di-restore ke original. User expect reset = kembali ke data awal sepenuhnya.
**Rekomendasi:** Save original items dan restore saat reset:
```typescript
// Add to originalData state
const [originalData, setOriginalData] = useState({
tahun: 0,
imageId: '',
fileId: '',
imageUrl: '',
fileUrl: '',
items: [] as ItemForm[], // ✅ Save original items
});
// Load data
setOriginalData({
tahun: data.tahun || new Date().getFullYear(),
imageId: data.imageId || '',
fileId: data.fileId || '',
imageUrl: data.image?.link || '',
fileUrl: data.file?.link || '',
items: (data.items || []).map((item: any) => ({...})), // ✅ Save
});
// Reset
const handleReset = () => {
apbdesState.edit.form = {
tahun: originalData.tahun,
imageId: originalData.imageId,
fileId: originalData.fileId,
items: [...originalData.items], // ✅ Restore original items
};
// ...
};
```
**Priority:** 🟡 Medium
**Effort:** Low
---
#### **6. Zod Schema - Error Message Tidak Akurat**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/apbdes.ts`
**Masalah:**
```typescript
// Line ~10
const ApbdesItemSchema = z.object({
kode: z.string().min(1, "Kode wajib diisi"), // ✅ OK
uraian: z.string().min(1, "Uraian wajib diisi"), // ✅ OK
anggaran: z.number().min(0), // ⚠️ No custom message
realisasi: z.number().min(0), // ⚠️ No custom message
// ...
});
// Line ~17
const ApbdesFormSchema = z.object({
tahun: z.number().int().min(2000, "Tahun tidak valid"), // ⚠️ Generic
imageId: z.string().min(1, "Gambar wajib diunggah"), // ✅ OK
fileId: z.string().min(1, "File wajib diunggah"), // ✅ OK
items: z.array(ApbdesItemSchema).min(1, "Minimal ada 1 item"), // ✅ OK
});
```
**Dampak:** Error messages tidak konsisten, beberapa generic beberapa spesifik.
**Rekomendasi:** Standardisasi error messages:
```typescript
const ApbdesItemSchema = z.object({
kode: z.string().min(1, "Kode wajib diisi"),
uraian: z.string().min(1, "Uraian wajib diisi"),
anggaran: z.number().min(0, "Anggaran tidak boleh negatif"),
realisasi: z.number().min(0, "Realisasi tidak boleh negatif"),
selisih: z.number(),
persentase: z.number(),
level: z.number().int().min(1).max(3, "Level harus antara 1-3"),
tipe: z.enum(['pendapatan', 'belanja', 'pembiayaan']).nullable().optional(),
});
const ApbdesFormSchema = z.object({
tahun: z.number().int().min(2000, "Tahun minimal 2000").max(2100, "Tahun maksimal 2100"),
imageId: z.string().min(1, "Gambar wajib diunggah"),
fileId: z.string().min(1, "Dokumen wajib diunggah"),
items: z.array(ApbdesItemSchema).min(1, "Minimal ada 1 item"),
});
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **7. Console.log di Production (UI Components)**
**Lokasi:** Multiple UI files
**Masalah:**
```typescript
// edit/page.tsx - Line ~220
console.error('Update error:', err);
// create/page.tsx - Line ~120
console.error("Gagal submit:", error);
// detail/page.tsx - Line ~40
console.error('Error loading APBDes:', error);
```
**Rekomendasi:** Gunakan conditional logging:
```typescript
if (process.env.NODE_ENV === 'development') {
console.error('Update error:', err);
}
```
**Priority:** 🟡 Low
**Effort:** Low
---
### **🟢 LOW (Minor Polish)**
#### **8. Mobile Layout - Title Order Inconsistency**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~170 (Mobile)
<Title order={2} size="lg" lh={1.2}>
Daftar APBDes
</Title>
// Line ~70 (Desktop - inside Paper)
<Title order={4} size="lg" lh={1.2}>
Daftar APBDes
</Title>
```
**Issue:** Mobile pakai `order={2}` (heading besar), desktop `order={4}`. Seharusnya konsisten.
**Rekomendasi:** Samakan:
```typescript
<Title order={4} size="lg" lh={1.2}>
Daftar APBDes
</Title>
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **9. Search Placeholder Tidak Spesifik**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~30
<HeaderSearch
title="APBDes"
placeholder="Cari APBDes..." // ⚠️ Generic
// ...
/>
```
**Rekomendasi:** Lebih spesifik:
```typescript
placeholder='Cari nama atau tahun APBDes...'
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **10. Duplicate Comment**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/apbdes.ts`
**Masalah:**
```typescript
// Line ~28-29
// --- Helper: hitung selisih & persentase otomatis (opsional di frontend) ---
// --- Helper: hitung selisih & persentase otomatis (opsional di frontend) ---
// ^ Duplicate line
```
**Priority:** 🟢 Low
**Effort:** Low (remove duplicate)
---
#### **11. Inconsistent Button Label**
**Lokasi:** Multiple files
**Masalah:**
```typescript
// create/page.tsx - Line ~270
<Button ...>Simpan</Button>
// edit/page.tsx - Line ~340
<Button ...>Simpan Perubahan</Button>
// Should be consistent: "Simpan" atau "Simpan Perubahan"
```
**Rekomendasi:** Standardisasi:
```typescript
// Create: "Simpan"
// Edit: "Simpan Perubahan" (lebih descriptive untuk edit)
// OR both: "Simpan"
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **12. Missing Search Feature in Pagination**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~250
<Pagination
value={page}
onChange={(newPage) => {
load(newPage, 10); // ⚠️ Missing search parameter
window.scrollTo({ top: 0, behavior: 'smooth' });
}}
total={totalPages}
// ...
/>
```
**Issue:** Saat ganti page, search query hilang.
**Rekomendasi:** Include search:
```typescript
onChange={(newPage) => {
load(newPage, 10, debouncedSearch); // ✅ Include search
window.scrollTo({ top: 0, behavior: 'smooth' });
}}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **13. Edit Page - Document Max Size Inconsistency**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~230 (Image)
maxSize={5 * 1024 ** 2} // 5MB
// Line ~250 (Document)
maxSize={10 * 1024 ** 2} // 10MB
```
**Issue:** Create page maksimal 5MB untuk semua file, edit page 10MB untuk dokumen. Inconsistent.
**Rekomendasi:** Samakan (prefer 5MB untuk consistency):
```typescript
maxSize={5 * 1024 ** 2} // 5MB for both
```
**Priority:** 🟢 Low
**Effort:** Low
---
## 📋 RINGKASAN ACTION ITEMS
| Priority | Issue | Module | Impact | Effort | Status |
|----------|-------|--------|--------|--------|--------|
| 🔴 P0 | **Formula selisih SALAH** | State | **CRITICAL** | Low | **MUST FIX** |
| 🔴 P0 | Fetch method inconsistency | State | Medium | Medium | Perlu refactor |
| 🔴 P1 | Console.log debugging in production | State | Medium | Low | Should fix |
| 🟡 M | Type safety (any usage) | State | Low | Medium | Optional |
| 🟡 M | Items tidak di-restore saat reset | Edit UI | Medium | Low | Should fix |
| 🟡 M | Zod schema error messages | State | Low | Low | Optional |
| 🟢 L | Console.log in UI components | UI | Low | Low | Optional |
| 🟢 L | Mobile title order inconsistency | List UI | Low | Low | Optional |
| 🟢 L | Search placeholder tidak spesifik | List UI | Low | Low | Optional |
| 🟢 L | Duplicate comment | State | Low | Low | Optional |
| 🟢 L | Inconsistent button label | UI | Low | Low | Optional |
| 🟢 L | Missing search in pagination | List UI | Low | Low | Should fix |
| 🟢 L | Document max size inconsistency | Edit UI | Low | Low | Optional |
---
## ✅ KESIMPULAN
### **Overall Quality: 🟢 BAIK (7/10)**
**Strengths:**
1. UI/UX konsisten & responsive
2. File upload handling solid (dual upload: image + document)
3. Form validation dengan Zod schema
4. State management terstruktur (Valtio)
5. **Edit form reset sudah benar** (original data tracking untuk files)
6. Complex feature: hierarchical items dengan level & tipe
7. Schema design solid (proper relations, indexing, soft delete)
8. Modal konfirmasi hapus untuk user safety
**Critical Issues:**
1. **FORMULA SELISIH SALAH** - Data integrity issue (CRITICAL)
2. Fetch method pattern inconsistency (ApiFetch vs fetch manual)
3. Console.log debugging tertinggal di production
**Areas for Improvement:**
1. **Fix formula selisih** (realisasi - anggaran, bukan anggaran - realisasi)
2. **Refactor fetch methods** untuk gunakan ApiFetch consistently
3. **Remove console.log** debugging dari production code
4. **Save & restore original items** saat reset form di edit page
5. **Improve type safety** dengan remove `as any` usage
6. **Standardisasi error messages** di Zod schema
**Recommended Next Steps:**
1. **🔴 CRITICAL: Fix formula selisih** di state (line 36) - 5 menit fix
2. **🔴 HIGH:** Refactor findUnique ke ApiFetch - 30 menit
3. **🔴 HIGH:** Remove console.log debugging - 10 menit
4. **🟡 MEDIUM:** Save & restore original items - 30 menit
5. **🟡 MEDIUM:** Improve type safety - 1-2 jam
6. **🟢 LOW:** Polish minor issues - 30 menit
---
## 📈 COMPARISON WITH OTHER MODULES
| Aspect | Profil | Desa Anti Korupsi | SDGs Desa | APBDes | Notes |
|--------|--------|-------------------|-----------|--------|-------|
| Fetch Pattern | Mixed | Mixed | Mixed | Mixed | All perlu refactor |
| Loading State | Some missing | Some missing | Missing | Good | APBDes paling baik |
| Edit Form Reset | Good | Good | Good | Good | All consistent |
| Type Safety | Some `any` | Some `any` | Some `any` | Some `any` | Same issue |
| File Upload | Images | Documents | Images | **Dual** | APBDes paling complex |
| Error Handling | Good | Good (better) | Good | Good | Consistent |
| Schema Design | Good | deletedAt issue | deletedAt issue | **Best** | APBDes paling solid |
| **Data Integrity** | Good | Good | Good | **Formula WRONG** | **APBDes CRITICAL issue** |
| Complexity | Low | Medium | Low | **High** | APBDes items hierarchy |
---
## 🎯 UNIQUE FEATURES OF APBDes MODULE
**Most Complex Module So Far:**
1. **Dual file upload** (gambar + dokumen) - unique to APBDes
2. **Hierarchical items** dengan 3 level - unique to APBDes
3. **Auto-calculation** (selisih & persentase) - unique to APBDes
4. **Type classification** (pendapatan, belanja, pembiayaan) - unique to APBDes
5. **Dynamic item management** (add/remove) - unique to APBDes
**Best Practices:**
1. Schema design paling solid (deletedAt nullable, proper indexing)
2. Edit form reset paling comprehensive (preserve files & items)
3. Validation paling thorough (Zod schema untuk items)
**Biggest Issue:**
1. **Formula selisih SALAH** - critical data integrity issue yang tidak ada di modul lain
---
**Catatan:** Secara keseluruhan, modul APBDes adalah **paling complex dan paling solid** dibanding modul lain yang sudah di-QC. Namun, ada **1 CRITICAL BUG** (formula selisih) yang harus **SEGERA DIPERBAIKI** karena menyangkut integritas data. Setelah fix critical issue, module ini production-ready dengan beberapa improvement minor yang bisa dilakukan secara incremental.
**Priority Action:**
```
🔴 FIX INI SEKARANG JUGA (5 MENIT):
File: src/app/admin/(dashboard)/_state/landing-page/apbdes.ts
Line: 36
Change: const selisih = anggaran - realisasi;
To: const selisih = realisasi - anggaran;
```

View File

@@ -1,639 +0,0 @@
# QC Summary - Desa Anti Korupsi Module
**Scope:** List Desa Anti Korupsi, Kategori Desa Anti Korupsi
**Date:** 2026-02-23
**Status:** ✅ Secara umum sudah baik, ada beberapa improvement yang diperlukan
---
## 📊 OVERVIEW
| Module | Schema | API | UI Admin | State Management | Overall |
|--------|--------|-----|----------|-----------------|---------|
| List Desa Anti Korupsi | ✅ Baik | ✅ Baik | ✅ Baik | ⚠️ Ada issue | 🟡 Perlu fix |
| Kategori Desa Anti Korupsi | ✅ Baik | ✅ Baik | ✅ Baik | ⚠️ Ada issue | 🟡 Perlu fix |
---
## ✅ YANG SUDAH BAIK (COMMON)
### **1. UI/UX Consistency**
- ✅ Responsive design (desktop table + mobile cards)
- ✅ Loading states dengan Skeleton
- ✅ Search dengan debounce (1000ms)
- ✅ Pagination konsisten
- ✅ Empty state handling yang informatif
- ✅ Modal konfirmasi hapus
### **2. File Upload Handling** (Desa Anti Korupsi)
- ✅ Dropzone dengan preview iframe untuk dokumen
- ✅ Validasi format dokumen (PDF, DOC, DOCX, XLS, XLSX, PPT, PPTX)
- ✅ Validasi ukuran file (max 5MB)
- ✅ Tombol hapus preview (IconX di pojok kanan atas)
- ✅ URL.createObjectURL untuk preview lokal
### **3. Form Validation**
- ✅ Zod schema untuk validasi typed
- ✅ isFormValid() check sebelum submit
- ✅ Error toast dengan pesan spesifik
- ✅ Button disabled saat invalid/loading
### **4. CRUD Operations**
- ✅ Create dengan upload file
- ✅ FindMany dengan pagination & search
- ✅ FindUnique untuk detail
- ✅ Delete dengan soft delete
- ✅ Update dengan file replacement
### **5. Error Handling**
- ✅ Try-catch di semua async operation
- ✅ Toast error dengan pesan user-friendly
- ✅ Console.error untuk debugging
- ✅ Response cloning untuk error handling yang lebih baik (di kategori update)
---
## ⚠️ ISSUES & SARAN PERBAIKAN
### **🔴 CRITICAL**
#### **1. Edit Form - File Lama Tidak Tersimpan Saat Reset**
**Lokasi:** `src/app/admin/(dashboard)/landing-page/desa-anti-korupsi/list-desa-anti-korupsi/[id]/edit/page.tsx`
**Masalah:**
```typescript
// Line ~70 - Load data
const data = await desaAntiKorupsiState.edit.load(id);
setFormData({
name: data.name,
deskripsi: data.deskripsi,
kategoriId: data.kategoriId,
fileId: data.fileId, // ✅ Sudah benar
});
setOriginalData({
name: data.name,
deskripsi: data.deskripsi,
kategoriId: data.kategoriId,
fileId: data.fileId,
fileUrl: data.file?.link || "", // ✅ Sudah benar
});
// Line ~130 - Handle reset
const handleResetForm = () => {
setFormData({
name: originalData.name,
deskripsi: originalData.deskripsi,
kategoriId: originalData.kategoriId,
fileId: originalData.fileId, // ✅ Sudah benar
});
setPreviewFile(originalData.fileUrl || null); // ✅ Sudah benar
setFile(null); // ✅ Sudah benar
};
```
**Status:****SUDAH BENAR** - Original data tracking sudah implementasi dengan baik.
**Verdict:** Tidak ada action needed.
---
#### **2. State Management - Inconsistency Fetch Pattern**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/desa-anti-korupsi.ts`
**Masalah:** Ada 2 pattern berbeda untuk fetch API:
```typescript
// ❌ Pattern 1: ApiFetch (create operations)
const res = await ApiFetch.api.landingpage.desaantikorupsi["create"].post({...});
// ❌ Pattern 2: fetch manual (findUnique, edit, delete)
const res = await fetch(`/api/landingpage/desaantikorupsi/${id}`);
const response = await fetch(`/api/landingpage/desaantikorupsi/del/${id}`, {
method: "DELETE",
headers: { "Content-Type": "application/json" },
});
```
**Dampak:**
- Code consistency buruk
- Sulit maintenance
- Type safety tidak konsisten
- Duplikasi logic error handling
**Rekomendasi:** Gunakan **ApiFetch** untuk semua operasi:
```typescript
// ✅ Unified pattern
const res = await ApiFetch.api.landingpage.desaantikorupsi["create"].post(data);
const res = await ApiFetch.api.landingpage.desaantikorupsi[id].get();
const res = await ApiFetch.api.landingpage.desaantikorupsi[id].put(data);
const res = await ApiFetch.api.landingpage.desaantikorupsi["del"][id].delete();
```
**Priority:** 🔴 High
**Effort:** Medium (refactor di semua state methods)
---
#### **3. findUnique State - Tidak Ada Loading State Management**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/desa-anti-korupsi.ts`
**Masalah:**
```typescript
// Line ~97 - desaAntikorupsi.findUnique.load()
async load(id: string) {
try {
const res = await fetch(`/api/landingpage/desaantikorupsi/${id}`);
if (res.ok) {
const data = await res.json();
desaAntikorupsi.findUnique.data = data.data ?? null;
} else {
console.error("Failed to fetch data", res.status, res.statusText);
desaAntikorupsi.findUnique.data = null;
}
} catch (error) {
console.error("Error fetching data:", error);
desaAntikorupsi.findUnique.data = null;
}
// ❌ MISSING: finally block untuk stop loading
}
```
**Dampak:** UI mungkin stuck di loading state jika ada error.
**Rekomendasi:** Tambahkan loading state dan finally block:
```typescript
async load(id: string) {
try {
desaAntikorupsi.findUnique.loading = true; // ✅ Start loading
const res = await fetch(`/api/landingpage/desaantikorupsi/${id}`);
if (res.ok) {
const data = await res.json();
desaAntikorupsi.findUnique.data = data.data ?? null;
}
} catch (error) {
console.error("Error:", error);
} finally {
desaAntikorupsi.findUnique.loading = false; // ✅ Stop loading
}
}
```
**Priority:** 🔴 Medium
**Effort:** Low
---
#### **4. Kategori Edit - Response Cloning Overkill**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/desa-anti-korupsi.ts`
**Masalah:**
```typescript
// Line ~370 - kategoriDesaAntiKorupsi.edit.update()
async update() {
// ...
const response = await fetch(...);
// Clone the response to avoid 'body already read' error
const responseClone = response.clone();
try {
const result = await response.json();
// ...
} catch (error) {
// If JSON parsing fails, try to get the response text
try {
const text = await responseClone.text();
console.error("Error response text:", text);
throw new Error(`Gagal memproses respons dari server: ${text}`);
} catch (textError) {
// ...
}
}
}
```
**Analysis:**
-**GOOD:** Error handling sangat thorough
- ⚠️ **OVERKILL:** Untuk production API yang stable, ini berlebihan
- ⚠️ **INCONSISTENT:** Module lain tidak punya error handling se-detail ini
**Rekomendasi:** Simplify untuk consistency:
```typescript
async update() {
try {
kategoriDesaAntiKorupsi.edit.loading = true;
const response = await fetch(`/api/landingpage/kategoridak/${this.id}`, {
method: "PUT",
headers: { "Content-Type": "application/json" },
body: JSON.stringify({ name: this.form.name }),
});
const result = await response.json();
if (!response.ok) {
throw new Error(result?.message || `HTTP ${response.status}`);
}
if (result.success) {
toast.success(result.message || "Berhasil update");
await kategoriDesaAntiKorupsi.findMany.load();
return true;
}
throw new Error(result.message || "Gagal update");
} catch (error) {
console.error("Error updating:", error);
toast.error(error instanceof Error ? error.message : "Gagal update");
return false;
} finally {
kategoriDesaAntiKorupsi.edit.loading = false;
}
}
```
**Priority:** 🟡 Low
**Effort:** Low
---
### **🟡 MEDIUM**
#### **5. HTML Injection Risk - dangerouslySetInnerHTML**
**Lokasi:**
- `list-desa-anti-korupsi/[id]/page.tsx` (line ~105)
- `list-desa-anti-korupsi/create/page.tsx` (CreateEditor component)
- `list-desa-anti-korupsi/[id]/edit/page.tsx` (EditEditor component)
**Masalah:**
```typescript
// ❌ Direct HTML render tanpa sanitization
<Box
dangerouslySetInnerHTML={{ __html: data.deskripsi || '-' }}
style={{ wordBreak: "break-word", whiteSpace: "normal", lineHeight: 1.6 }}
/>
```
**Risk:**
- XSS attack jika admin input script malicious
- Bisa inject iframe, script tag, dll
- Security vulnerability
**Rekomendasi:** Gunakan DOMPurify atau library sanitization:
```typescript
import DOMPurify from 'dompurify';
// Sanitize sebelum render
const sanitizedHtml = DOMPurify.sanitize(data.deskripsi);
<Box
dangerouslySetInnerHTML={{ __html: sanitizedHtml }}
// ...
/>
```
Atau validasi di backend untuk whitelist tag HTML yang diperbolehkan (hanya `<p>`, `<ul>`, `<li>`, `<strong>`, dll).
**Priority:** 🟡 Medium (**Security concern**)
**Effort:** Low
---
#### **6. Type Safety - Any Usage**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/desa-anti-korupsi.ts`
**Masalah:**
```typescript
// Line ~60
data: null as any[] | null, // ❌ Using 'any'
// Line ~280
data: null as any[] | null, // ❌ Using 'any'
// Line ~97
data: null as Prisma.DesaAntiKorupsiGetPayload<{...}> | null, // ✅ Typed
// Line ~310
data: null as Prisma.KategoriDesaAntiKorupsiGetPayload<{...}> | null, // ✅ Typed
```
**Rekomendasi:** Gunakan typed data consistently:
```typescript
// desaAntikorupsi.findMany
data: null as Prisma.DesaAntiKorupsiGetPayload<{
include: { kategori: true; file: true };
}>[] | null,
// kategoriDesaAntiKorupsi.findMany
data: null as Prisma.KategoriDesaAntiKorupsiGetPayload<{}>[] | null,
```
**Priority:** 🟡 Medium
**Effort:** Medium (perlu update semua reference)
---
#### **7. Console.log di Production**
**Lokasi:** Multiple places di state file
**Masalah:**
```typescript
// Line ~50
console.log(error);
toast.error("Gagal menambahkan data");
// Line ~85
console.error("Failed to load media sosial:", res.data?.message);
// Line ~91
console.error("Error loading media sosial:", error);
// Line ~110
console.error("Failed to fetch data", res.status, res.statusText);
// Line ~114
console.error("Error fetching data:", error);
// ... dan banyak lagi
```
**Rekomendasi:** Gunakan conditional logging:
```typescript
if (process.env.NODE_ENV === 'development') {
console.error("Error:", error);
}
```
Atau gunakan logging library (winston, pino, dll) dengan levels yang jelas.
**Priority:** 🟡 Low
**Effort:** Low
---
#### **8. Error Message Tidak Konsisten**
**Lokasi:** Multiple places
**Masalah:**
```typescript
// Create - Line ~40
return toast.error("Gagal menambahkan data");
// Create - Line ~42
toast.error("Gagal menambahkan data");
// Delete - Line ~140
toast.error("Terjadi kesalahan saat menghapus desa anti korupsi");
// Edit - Line ~190
toast.error("Gagal memuat data");
// Edit update - Line ~240
toast.error("Gagal mengupdate desa anti korupsi");
```
**Rekomendasi:** Standardisasi error messages:
```typescript
// Pattern: "[Action] [resource] gagal"
toast.error("Menambahkan data gagal");
toast.error("Menghapus data gagal");
toast.error("Memuat data gagal");
toast.error("Memperbarui data gagal");
// Atau lebih spesifik dengan context
toast.error("Gagal menambahkan data Desa Anti Korupsi");
toast.error("Gagal menghapus Kategori Desa Anti Korupsi");
```
**Priority:** 🟢 Low
**Effort:** Low
---
### **🟢 LOW (Minor Polish)**
#### **9. Placeholder Search Tidak Spesifik**
**Lokasi:**
- `list-desa-anti-korupsi/page.tsx`: `placeholder="Cari nama program atau kategori..."` ✅ Spesifik
- `kategori-desa-anti-korupsi/page.tsx`: `placeholder='pencarian'` ❌ Terlalu generic
**Rekomendasi:**
```typescript
// Kategori page
placeholder="Cari nama kategori..."
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **10. Alert vs Toast**
**Lokasi:** `kategori-desa-anti-korupsi/create/page.tsx`
**Masalah:**
```typescript
// Line ~37
if (!stateKategori.create.form.name) {
return alert('Nama kategori harus diisi'); // ❌ Using alert()
}
```
**Rekomendasi:** Gunakan toast untuk consistency:
```typescript
if (!stateKategori.create.form.name) {
return toast.warn('Nama kategori harus diisi'); // ✅ Using toast
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **11. Component Name Mismatch**
**Lokasi:** `list-desa-anti-korupsi/[id]/page.tsx`
**Masalah:**
```typescript
// Line ~17
export default function DetailKegiatanDesa() { // ❌ Wrong name
// ...
}
```
**Rekomendasi:** Rename ke yang sesuai:
```typescript
export default function DetailDesaAntiKorupsi() { // ✅ Correct name
// ...
}
```
**Priority:** 🟢 Low
**Effort:** Low (hanya rename)
---
#### **12. Duplicate Error Logging**
**Lokasi:** `list-desa-anti-korupsi/[id]/edit/page.tsx`
**Masalah:**
```typescript
// Line ~87
} catch (err) {
console.error(err); // ❌ Duplicate logging
toast.error('Gagal memuat data Desa Anti Korupsi');
}
```
**Rekomendasi:** Cukup satu logging yang informatif:
```typescript
} catch (err) {
console.error('Failed to load Desa Anti Korupsi:', err);
toast.error('Gagal memuat data Desa Anti Korupsi');
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **13. Comment Typo**
**Lokasi:** `kategori-desa-anti-korupsi/[id]/edit/page.tsx`
**Masalah:**
```typescript
// Line ~20
// 🧠 Ambil proxy asli (bisa ditulis) & snapshot (buat render)
const stateKategori = korupsiState.kategoriDesaAntiKorupsi;
const snapshotKategori = useProxy(stateKategori);
// ❌ snapshotKategori declared but never used
```
**Rekomendasi:** Remove unused variable:
```typescript
const stateKategori = korupsiState.kategoriDesaAntiKorupsi;
// const snapshotKategori = useProxy(stateKategori); // ❌ Remove
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **14. Schema - deletedAt Default Value**
**Lokasi:** `prisma/schema.prisma`
**Masalah:**
```prisma
model DesaAntiKorupsi {
// ...
deletedAt DateTime @default(now()) // ❌ Always has default value
isActive Boolean @default(true)
}
```
**Issue:** `deletedAt @default(now())` berarti setiap record baru langsung punya `deletedAt` value, yang bisa membingungkan untuk soft delete logic.
**Rekomendasi:**
```prisma
model DesaAntiKorupsi {
// ...
deletedAt DateTime? @default(null) // ✅ Nullable, null = not deleted
isActive Boolean @default(true)
}
```
**Priority:** 🟢 Medium (potential logic issue)
**Effort:** Medium (perlu migration)
---
## 📋 RINGKASAN ACTION ITEMS
| Priority | Issue | Module | Impact | Effort | Status |
|----------|-------|--------|--------|--------|--------|
| 🔴 P0 | Fetch method inconsistency | State | Medium | Medium | Perlu refactor |
| 🔴 P0 | Missing loading state in findUnique | State | Medium | Low | Perlu fix |
| 🟡 M | HTML injection risk | UI | **High (Security)** | Low | **Should fix** |
| 🟡 M | Type safety (any usage) | State | Low | Medium | Optional |
| 🟡 M | Response cloning overkill | State (Kategori) | Low | Low | Optional |
| 🟢 L | Console.log in production | State | Low | Low | Optional |
| 🟢 L | Error message inconsistency | State | Low | Low | Optional |
| 🟢 L | Placeholder tidak spesifik | Kategori UI | Low | Low | Optional |
| 🟢 L | Alert vs Toast | Kategori Create | Low | Low | Optional |
| 🟢 L | Component name mismatch | Detail page | Low | Low | Optional |
| 🟢 L | Duplicate error logging | Edit page | Low | Low | Optional |
| 🟢 L | Unused variable | Kategori Edit | Low | Low | Optional |
| 🟢 M | deletedAt default value | Schema | Medium | Medium | Should fix |
---
## ✅ KESIMPULAN
### **Overall Quality: 🟢 BAIK (7.5/10)**
**Strengths:**
1. ✅ UI/UX konsisten & responsive
2. ✅ File upload handling solid (iframe preview untuk dokumen)
3. ✅ Form validation dengan Zod schema
4. ✅ State management terstruktur (Valtio)
5. ✅ Error handling comprehensive (terutama di kategori update)
6.**Edit form reset sudah benar** (original data tracking)
7. ✅ Modal konfirmasi hapus untuk user safety
**Areas for Improvement:**
1. ⚠️ **Security:** HTML injection di deskripsi (prioritas)
2. ⚠️ **Consistency:** Fetch method pattern (ApiFetch vs fetch manual)
3. ⚠️ **Loading States:** findUnique tidak ada loading state management
4. ⚠️ **Type Safety:** Reduce `any` usage, gunakan Prisma types
5. ⚠️ **Schema:** deletedAt default value bisa menyebabkan logic issue
**Recommended Next Steps:**
1. **Fix HTML injection** dengan DOMPurify atau backend validation
2. **Refactor fetch methods** untuk gunakan ApiFetch consistently
3. **Add loading state** di findUnique operations
4. **Fix deletedAt schema** untuk soft delete yang benar
5. **Optional:** Improve type safety dengan remove `any`
---
## 📈 COMPARISON WITH OTHER MODULES
| Aspect | Profil Module | Desa Anti Korupsi | Notes |
|--------|--------------|-------------------|-------|
| Fetch Pattern | ⚠️ Mixed | ⚠️ Mixed | Both perlu refactor |
| Loading State | ⚠️ Some missing | ⚠️ Some missing | Same issue |
| Edit Form Reset | ✅ Good | ✅ Good | Consistent |
| Type Safety | ⚠️ Some `any` | ⚠️ Some `any` | Same issue |
| HTML Injection | ⚠️ Present | ⚠️ Present | Both need fix |
| File Upload | ✅ Images | ✅ Documents | Different use case |
| Error Handling | ✅ Good | ✅ Good (better) | DAK more thorough |
---
**Catatan:** Secara keseluruhan, modul Desa Anti Korupsi sudah **production-ready** dengan beberapa improvements yang bisa dilakukan secara incremental. Module ini memiliki error handling yang lebih thorough dibanding module Profil, terutama di kategori update operation.

View File

@@ -1,875 +0,0 @@
# QC Summary - Prestasi Desa Module
**Scope:** List Prestasi Desa, Kategori Prestasi Desa, Create, Edit, Detail
**Date:** 2026-02-23
**Status:** ✅ Secara umum sudah baik, ada beberapa improvement yang diperlukan
---
## 📊 OVERVIEW
| Aspect | Schema | API | UI Admin | State Management | Overall |
|--------|--------|-----|----------|-----------------|---------|
| Prestasi Desa | ⚠️ Ada issue | ✅ Baik | ✅ Baik | ⚠️ Ada issue | 🟡 Perlu fix |
| Kategori Prestasi | ⚠️ Ada issue | ✅ Baik | ✅ Baik | ⚠️ Ada issue | 🟡 Perlu fix |
---
## ✅ YANG SUDAH BAIK
### **1. UI/UX Consistency**
- ✅ Responsive design (desktop table + mobile cards)
- ✅ Loading states dengan Skeleton
- ✅ Search dengan debounce (1000ms)
- ✅ Pagination konsisten
- ✅ Empty state handling yang informatif
- ✅ Modal konfirmasi hapus
### **2. File Upload Handling**
- ✅ Dropzone dengan preview image
- ✅ Validasi format gambar (JPEG, JPG, PNG, WEBP)
- ✅ Validasi ukuran file (max 5MB)
- ✅ Tombol hapus preview (IconX di pojok kanan atas)
- ✅ URL.createObjectURL untuk preview lokal
- ✅ Preview dengan max height yang proper
### **3. Form Validation**
- ✅ Zod schema untuk validasi typed
- ✅ isFormValid() check sebelum submit
- ✅ Error toast dengan pesan spesifik
- ✅ Button disabled saat invalid/loading
### **4. CRUD Operations**
- ✅ Create dengan upload file
- ✅ FindMany dengan pagination & search
- ✅ FindUnique untuk detail
- ✅ Delete dengan hard delete (via Prisma)
- ✅ Update dengan file replacement
### **5. Edit Form - Original Data Tracking**
- ✅ Original data state untuk reset form
- ✅ Load data existing dengan benar
- ✅ Preview image dari data lama
- ✅ Reset form mengembalikan ke data original
**Code Example (✅ GOOD):**
```typescript
// edit/page.tsx - Line ~70-95
const data = await editState.edit.load(id);
setOriginalData({
name: data.name,
deskripsi: data.deskripsi,
kategoriId: data.kategoriId,
imageId: data.imageId,
imageUrl: data.image?.link || "",
});
setFormData({
name: data.name,
deskripsi: data.deskripsi,
kategoriId: data.kategoriId,
imageId: data.imageId,
});
if (data.image?.link) setPreviewFile(data.image.link);
// Line ~105 - Handle reset
const handleResetForm = () => {
setFormData({
name: originalData.name,
deskripsi: originalData.deskripsi,
kategoriId: originalData.kategoriId,
imageId: originalData.imageId,
});
setPreviewFile(originalData.imageUrl || null);
setFile(null);
toast.info("Form dikembalikan ke data awal");
};
```
**Verdict:****SUDAH BENAR** - Original data tracking sudah implementasi dengan baik.
---
### **6. State Management - Good Practices**
- ✅ Proper typing dengan Prisma types
- ✅ Loading state management dengan finally block
- ✅ Error handling yang comprehensive
- ✅ Reset function untuk cleanup
**Code Example (✅ GOOD):**
```typescript
// state file - Line ~70-95
load: async (page = 1, limit = 10, search = "") => {
prestasiDesa.findMany.loading = true; // ✅ Start loading
prestasiDesa.findMany.page = page;
prestasiDesa.findMany.search = search;
try {
const query: any = { page, limit };
if (search) query.search = search;
const res = await ApiFetch.api.landingpage.prestasidesa["find-many"].get({ query });
if (res.status === 200 && res.data?.success) {
prestasiDesa.findMany.data = res.data.data ?? [];
prestasiDesa.findMany.totalPages = res.data.totalPages ?? 1;
} else {
prestasiDesa.findMany.data = [];
prestasiDesa.findMany.totalPages = 1;
}
} catch (err) {
console.error("Gagal fetch prestasi desa paginated:", err);
prestasiDesa.findMany.data = [];
prestasiDesa.findMany.totalPages = 1;
} finally {
prestasiDesa.findMany.loading = false; // ✅ Stop loading
}
};
```
**Verdict:****SUDAH BENAR** - Loading state management sudah proper.
---
## ⚠️ ISSUES & SARAN PERBAIKAN
### **🔴 CRITICAL**
#### **1. Schema - deletedAt Default Value SALAH**
**Lokasi:** `prisma/schema.prisma` (line 239-240)
**Masalah:**
```prisma
model PrestasiDesa {
// ...
deletedAt DateTime @default(now()) // ❌ SALAH - selalu punya default value
isActive Boolean @default(true)
}
model KategoriPrestasiDesa {
// ...
deletedAt DateTime @default(now()) // ❌ SALAH - selalu punya default value
isActive Boolean @default(true)
}
```
**Dampak:**
- **LOGIC ERROR!** Setiap record baru langsung punya `deletedAt` value (timestamp creation)
- Soft delete tidak berfungsi dengan benar
- Query dengan `where: { deletedAt: null }` tidak akan pernah return data
- Data yang "dihapus" vs data "aktif" tidak bisa dibedakan
**Contoh Issue:**
```prisma
// Record baru dibuat
CREATE PrestasiDesa {
name: "Prestasi 1",
// deletedAt otomatis ter-set ke now() ❌
// isActive: true ✅
}
// Query untuk data aktif (seharusnya return data ini)
prisma.prestasiDesa.findMany({
where: { deletedAt: null, isActive: true }
})
// ❌ Return kosong! Karena deletedAt sudah ter-set
```
**Rekomendasi:** Fix schema:
```prisma
model PrestasiDesa {
// ...
deletedAt DateTime? @default(null) // ✅ Nullable, null = not deleted
isActive Boolean @default(true)
}
model KategoriPrestasiDesa {
// ...
deletedAt DateTime? @default(null) // ✅ Nullable, null = not deleted
isActive Boolean @default(true)
}
```
**Priority:** 🔴 **CRITICAL**
**Effort:** Medium (perlu migration)
**Impact:** **HIGH** (data integrity & soft delete logic)
---
#### **2. State Management - Inconsistency Fetch Pattern**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/prestasi-desa.ts`
**Masalah:** Ada 2 pattern berbeda untuk fetch API:
```typescript
// ❌ Pattern 1: ApiFetch (create, findMany)
const res = await ApiFetch.api.landingpage.prestasidesa["create"].post({...});
const res = await ApiFetch.api.landingpage.prestasidesa["find-many"].get({query});
// ❌ Pattern 2: fetch manual (findUnique, edit, delete)
const res = await fetch(`/api/landingpage/prestasidesa/${id}`);
const response = await fetch(`/api/landingpage/prestasidesa/del/${id}`, {
method: "DELETE",
headers: { "Content-Type": "application/json" },
});
```
**Dampak:**
- Code consistency buruk
- Sulit maintenance
- Type safety tidak konsisten
- Duplikasi logic error handling
**Rekomendasi:** Gunakan **ApiFetch** untuk semua operasi:
```typescript
// ✅ Unified pattern
async load(id: string) {
try {
prestasiDesa.edit.loading = true;
const res = await ApiFetch.api.landingpage.prestasidesa[id].get();
if (res.data?.success) {
const data = res.data.data;
this.id = data.id;
this.form = {
name: data.name,
deskripsi: data.deskripsi,
imageId: data.imageId,
kategoriId: data.kategoriId,
};
return data;
} else {
throw new Error(res.data?.message || "Gagal memuat data");
}
} catch (error) {
console.error("Error loading prestasi desa:", error);
toast.error(error instanceof Error ? error.message : "Gagal memuat data");
return null;
} finally {
prestasiDesa.edit.loading = false;
}
}
```
**Priority:** 🔴 High
**Effort:** Medium (refactor di findUnique, edit, delete methods)
---
#### **3. findUnique State - Tidak Ada Loading State Management**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/prestasi-desa.ts`
**Masalah:**
```typescript
// Line ~110 - prestasiDesa.findUnique.load()
async load(id: string) {
try {
const res = await fetch(`/api/landingpage/prestasidesa/${id}`);
if (res.ok) {
const data = await res.json();
prestasiDesa.findUnique.data = data.data ?? null;
} else {
console.error("Failed to fetch data", res.status, res.statusText);
prestasiDesa.findUnique.data = null;
}
} catch (error) {
console.error("Error fetching data:", error);
prestasiDesa.findUnique.data = null;
}
// ❌ MISSING: finally block untuk stop loading
// ❌ MISSING: loading state initialization
}
```
**Dampak:** UI mungkin stuck di loading state jika ada error.
**Rekomendasi:** Tambahkan loading state dan finally block:
```typescript
async load(id: string) {
try {
prestasiDesa.findUnique.loading = true; // ✅ Start loading
const res = await fetch(`/api/landingpage/prestasidesa/${id}`);
if (res.ok) {
const data = await res.json();
prestasiDesa.findUnique.data = data.data ?? null;
}
} catch (error) {
console.error("Error:", error);
} finally {
prestasiDesa.findUnique.loading = false; // ✅ Stop loading
}
}
```
**Priority:** 🔴 Medium
**Effort:** Low
---
### **🟡 MEDIUM**
#### **4. HTML Injection Risk - dangerouslySetInnerHTML**
**Lokasi:**
- `list-prestasi-desa/page.tsx` (line ~90, 145)
- `list-prestasi-desa/[id]/page.tsx` (line ~85)
- `list-prestasi-desa/create/page.tsx` (CreateEditor component)
- `list-prestasi-desa/[id]/edit/page.tsx` (EditEditor component)
**Masalah:**
```typescript
// ❌ Direct HTML render tanpa sanitization
<Text
lineClamp={1}
fz="md"
c="dimmed"
lh={1.5}
dangerouslySetInnerHTML={{ __html: item.deskripsi }}
/>
```
**Risk:**
- XSS attack jika admin input script malicious
- Bisa inject iframe, script tag, dll
- Security vulnerability
**Rekomendasi:** Gunakan DOMPurify atau library sanitization:
```typescript
import DOMPurify from 'dompurify';
// Sanitize sebelum render
const sanitizedHtml = DOMPurify.sanitize(item.deskripsi);
<Text
dangerouslySetInnerHTML={{ __html: sanitizedHtml }}
// ...
/>
```
Atau validasi di backend untuk whitelist tag HTML yang diperbolehkan (hanya `<p>`, `<ul>`, `<li>`, `<strong>`, dll).
**Priority:** 🟡 Medium (**Security concern**)
**Effort:** Low
---
#### **5. Type Safety - Any Usage**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/prestasi-desa.ts`
**Masalah:**
```typescript
// Line ~73
const query: any = { page, limit }; // ❌ Using 'any'
if (search) query.search = search;
// Line ~270
const query: any = { page, limit }; // ❌ Using 'any'
if (search) query.search = search;
```
**Rekomendasi:** Gunakan typed query:
```typescript
// Define type
interface FindManyQuery {
page: number | string;
limit: number | string;
search?: string;
}
// Use typed query
const query: FindManyQuery = { page, limit };
if (search) query.search = search;
```
**Priority:** 🟡 Medium
**Effort:** Low
---
#### **6. Console.log di Production**
**Lokasi:** Multiple places di state file
**Masalah:**
```typescript
// Line ~48
console.log(error);
toast.error("Gagal menambahkan data");
// Line ~120
console.error("Failed to fetch data", res.status, res.statusText);
// Line ~124
console.error("Error fetching data:", error);
// Line ~300
console.log(error);
toast.error("Gagal menambahkan data");
// ... dan banyak lagi
```
**Rekomendasi:** Gunakan conditional logging:
```typescript
if (process.env.NODE_ENV === 'development') {
console.error("Error:", error);
}
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **7. Error Message Tidak Konsisten**
**Lokasi:** Multiple places
**Masalah:**
```typescript
// Create - Line ~46
return toast.error("Gagal menambahkan data");
// Create - Line ~48
toast.error("Gagal menambahkan data");
// Delete - Line ~150
toast.error("Terjadi kesalahan saat menghapus prestasi desa");
// Edit - Line ~200
toast.error("Gagal memuat data");
// Edit update - Line ~240
toast.error("Gagal mengupdate prestasi desa");
// Toast success - Line ~235
toast.success("Berhasil update prestasi desa");
```
**Issue:**
- Inconsistent capitalization
- Mixed patterns ("Gagal menambahkan" vs "Terjadi kesalahan")
- Generic messages
**Rekomendasi:** Standardisasi error messages:
```typescript
// Pattern: "[Action] [resource] gagal" dengan proper casing
toast.error("Menambahkan data Prestasi Desa gagal");
toast.error("Menghapus data Prestasi Desa gagal");
toast.error("Memuat data Prestasi Desa gagal");
toast.error("Memperbarui data Prestasi Desa gagal");
// Atau lebih spesifik dengan context
toast.error("Gagal menambahkan data Prestasi Desa");
toast.error("Gagal menghapus Prestasi Desa");
toast.success("Berhasil memperbarui Prestasi Desa");
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **8. Zod Schema - Error Message Tidak Akurat**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/prestasi-desa.ts`
**Masalah:**
```typescript
// Line ~8
const templateprestasiDesaForm = z.object({
name: z.string().min(1, "Judul minimal 1 karakter"), // ⚠️ "Judul" instead of "Nama"
deskripsi: z.string().min(1, "Deskripsi minimal 1 karakter"), // ✅ OK
imageId: z.string().min(1, "File minimal 1"), // ⚠️ Generic
kategoriId: z.string().min(1, "Kategori minimal 1 karakter"), // ⚠️ "Kategori" instead of "Kategori Prestasi"
});
```
**Dampak:** User confusion saat validasi error muncul.
**Rekomendasi:** Fix error messages:
```typescript
const templateprestasiDesaForm = z.object({
name: z.string().min(1, "Nama prestasi wajib diisi"),
deskripsi: z.string().min(1, "Deskripsi prestasi wajib diisi"),
imageId: z.string().min(1, "Gambar prestasi wajib diunggah"),
kategoriId: z.string().min(1, "Kategori prestasi wajib dipilih"),
});
```
**Priority:** 🟡 Low
**Effort:** Low
---
### **🟢 LOW (Minor Polish)**
#### **9. Component Name Mismatch**
**Lokasi:** `list-prestasi-desa/page.tsx`
**Masalah:**
```typescript
// Line ~11
function ListPrestasiDesa() {
// ...
}
// Line ~27
function ListPrestasi({ search }: { search: string }) {
// ...
}
// ⚠️ Function name tidak konsisten dengan file name
```
**Rekomendasi:** Rename ke yang lebih descriptive:
```typescript
function ListPrestasiDesaPage() {
// ...
}
function ListPrestasiDesaTable({ search }: { search: string }) {
// ...
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **10. Pagination onChange Tidak Include Search**
**Lokasi:** `list-prestasi-desa/page.tsx`
**Masalah:**
```typescript
// Line ~170
<Pagination
value={page}
onChange={load} // ⚠️ Hanya pass page number
total={totalPages}
// ...
/>
```
**Issue:** Saat ganti page, search query hilang karena `load` dipanggil hanya dengan page number.
**Rekomendasi:** Include search dan limit:
```typescript
<Pagination
value={page}
onChange={(newPage) => load(newPage, 10, debouncedSearch)} // ✅ Include all params
total={totalPages}
// ...
/>
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **11. Mobile Pagination - load Function Tidak Lengkap**
**Lokasi:** `kategori-prestasi-desa/page.tsx`
**Masalah:**
```typescript
// Line ~170 (Desktop)
onChange={(newPage) => load(newPage)} // ⚠️ Missing limit & search
// Line ~200 (Mobile)
onChange={(newPage) => load(newPage)} // ⚠️ Missing limit & search
```
**Rekomendasi:** Include all params:
```typescript
onChange={(newPage) => load(newPage, 10, debouncedSearch)}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **12. Duplicate Error Logging**
**Lokasi:** Multiple files
**Masalah:**
```typescript
// edit/page.tsx - Line ~100
} catch (error) {
console.error('Error loading prestasi desa:', error); // ❌ Duplicate
toast.error('Gagal memuat data prestasi desa');
}
// edit/page.tsx - Line ~130
} catch (error) {
console.error('Error updating prestasi desa:', error); // ❌ Duplicate
toast.error('Terjadi kesalahan saat memperbarui prestasi desa');
}
```
**Rekomendasi:** Cukup satu logging yang informatif:
```typescript
} catch (error) {
console.error('Failed to load Prestasi Desa:', err);
toast.error('Gagal memuat data Prestasi Desa');
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **13. Inconsistent Button Label**
**Lokasi:** Multiple files
**Masalah:**
```typescript
// create/page.tsx - Line ~200
<Button ...>Reset</Button>
// edit/page.tsx - Line ~180
<Button ...>Batal</Button>
// Should be consistent: "Reset" atau "Batal"
```
**Rekomendasi:** Standardisasi:
```typescript
// Create: "Reset"
// Edit: "Batal" (lebih descriptive untuk cancel changes)
// OR both: "Reset" / "Batal"
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **14. Search Placeholder Tidak Spesifik**
**Lokasi:**
- `list-prestasi-desa/page.tsx`: `placeholder='Cari nama prestasi...'` ✅ OK
- `kategori-prestasi-desa/page.tsx`: `placeholder='Cari kategori prestasi...'` ✅ OK
**Verdict:****SUDAH BENAR** - Placeholder sudah spesifik.
**Priority:** 🟢 None
**Effort:** None
---
#### **15. Response Clone Overkill di Kategori Edit**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/prestasi-desa.ts`
**Masalah:**
```typescript
// Line ~370 - kategoriPrestasi.edit.update()
const response = await fetch(...);
const responseClone = response.clone();
try {
const result = await response.json();
// ...
} catch (error) {
try {
const text = await responseClone.text();
console.error("Error response text:", text);
throw new Error(`Gagal memproses respons dari server: ${text}`);
} catch (textError) {
console.error("Error parsing response as text:", textError);
console.error("Original error:", error);
throw new Error("Gagal memproses respons dari server");
}
}
```
**Analysis:**
-**GOOD:** Error handling sangat thorough
- ⚠️ **OVERKILL:** Untuk production API yang stable, ini berlebihan
- ⚠️ **INCONSISTENT:** Module lain tidak punya error handling se-detail ini
**Rekomendasi:** Simplify untuk consistency:
```typescript
async update() {
try {
kategoriPrestasi.edit.loading = true;
const response = await fetch(`/api/landingpage/kategoriprestasi/${this.id}`, {
method: "PUT",
headers: { "Content-Type": "application/json" },
body: JSON.stringify({ name: this.form.name }),
});
const result = await response.json();
if (!response.ok) {
throw new Error(result?.message || `HTTP ${response.status}`);
}
if (result.success) {
toast.success(result.message || "Berhasil update");
await kategoriPrestasi.findMany.load();
return true;
}
throw new Error(result.message || "Gagal update");
} catch (error) {
console.error("Error updating:", error);
toast.error(error instanceof Error ? error.message : "Gagal update");
return false;
} finally {
kategoriPrestasi.edit.loading = false;
}
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
## 📋 RINGKASAN ACTION ITEMS
| Priority | Issue | Module | Impact | Effort | Status |
|----------|-------|--------|--------|--------|--------|
| 🔴 P0 | **Schema deletedAt default SALAH** | Schema | **CRITICAL** | Medium | **MUST FIX** |
| 🔴 P0 | Fetch method inconsistency | State | Medium | Medium | Perlu refactor |
| 🔴 P1 | Missing loading state in findUnique | State | Medium | Low | Perlu fix |
| 🟡 M | HTML injection risk | UI | **High (Security)** | Low | **Should fix** |
| 🟡 M | Type safety (any usage) | State | Low | Low | Optional |
| 🟡 M | Console.log in production | State | Low | Low | Optional |
| 🟡 M | Error message inconsistency | State/UI | Low | Low | Optional |
| 🟡 M | Zod schema error messages | State | Low | Low | Should fix |
| 🟢 L | Component name mismatch | List UI | Low | Low | Optional |
| 🟢 L | Pagination missing search param | List UI | Low | Low | Should fix |
| 🟢 L | Duplicate error logging | UI | Low | Low | Optional |
| 🟢 L | Inconsistent button label | UI | Low | Low | Optional |
| 🟢 L | Response clone overkill | State (Kategori) | Low | Low | Optional |
---
## ✅ KESIMPULAN
### **Overall Quality: 🟢 BAIK (7/10)**
**Strengths:**
1. ✅ UI/UX konsisten & responsive
2. ✅ File upload handling solid
3. ✅ Form validation dengan Zod schema
4. ✅ State management terstruktur (Valtio)
5.**Edit form reset sudah benar** (original data tracking)
6. ✅ Loading state management di findMany (dengan finally block)
7. ✅ Modal konfirmasi hapus untuk user safety
**Critical Issues:**
1. ⚠️ **Schema deletedAt default SALAH** - Logic error untuk soft delete (CRITICAL)
2. ⚠️ Fetch method pattern inconsistency (ApiFetch vs fetch manual)
3. ⚠️ findUnique tidak ada loading state management
**Areas for Improvement:**
1. ⚠️ **Fix schema deletedAt** dari `@default(now())` ke `@default(null)` dengan nullable
2. ⚠️ **Refactor fetch methods** untuk gunakan ApiFetch consistently
3. ⚠️ **Add loading state** di findUnique operations
4. ⚠️ **Fix HTML injection** dengan DOMPurify atau backend validation
5. ⚠️ **Improve type safety** dengan remove `any` usage
6. ⚠️ **Standardisasi error messages** di Zod schema dan toast
**Recommended Next Steps:**
1. **🔴 CRITICAL: Fix schema deletedAt** - 30 menit (perlu migration)
2. **🔴 HIGH:** Refactor findUnique, edit, delete ke ApiFetch - 1 jam
3. **🔴 HIGH:** Add loading state di findUnique - 15 menit
4. **🟡 MEDIUM:** Fix HTML injection dengan DOMPurify - 30 menit
5. **🟡 MEDIUM:** Improve type safety - 30 menit
6. **🟢 LOW:** Polish minor issues - 30 menit
---
## 📈 COMPARISON WITH OTHER MODULES
| Aspect | Profil | Desa Anti Korupsi | SDGs Desa | APBDes | Prestasi Desa | Notes |
|--------|--------|-------------------|-----------|--------|---------------|-------|
| Fetch Pattern | ⚠️ Mixed | ⚠️ Mixed | ⚠️ Mixed | ⚠️ Mixed | ⚠️ Mixed | All perlu refactor |
| Loading State | ⚠️ Some missing | ⚠️ Some missing | ⚠️ Missing | ✅ Good | ⚠️ findUnique missing | Similar issue |
| Edit Form Reset | ✅ Good | ✅ Good | ✅ Good | ✅ Good | ✅ Good | All consistent |
| Type Safety | ⚠️ Some `any` | ⚠️ Some `any` | ⚠️ Some `any` | ⚠️ Some `any` | ⚠️ Some `any` | Same issue |
| File Upload | ✅ Images | ✅ Documents | ✅ Images | ✅ Dual | ✅ Images | APBDes paling complex |
| Error Handling | ✅ Good | ✅ Good (better) | ✅ Good | ✅ Good | ✅ Good | Consistent |
| **Schema deletedAt** | ⚠️ Issue | ⚠️ Issue | ⚠️ Issue | ✅ Good | ❌ **WRONG** | **Prestasi CRITICAL** |
| HTML Injection | ⚠️ Present | ⚠️ Present | N/A | N/A | ⚠️ Present | Security concern |
| Complexity | Low | Medium | Low | **High** | Medium | APBDes paling complex |
---
## 🎯 UNIQUE FEATURES OF PRESTASI DESA MODULE
**Standard Complexity:**
1. **Single file upload** (gambar) - similar to SDGs, Profil
2. **Kategori relation** - similar to Desa Anti Korupsi
3. **Rich text editor** (deskripsi) - similar to Desa Anti Korupsi
**Best Practices:**
1. ✅ Loading state management di findMany (dengan finally block) - better than SDGs
2. ✅ Edit form reset comprehensive (preserve all fields)
3. ✅ Proper typing di findMany (Prisma types)
**Critical Issues:**
1.**Schema deletedAt SALAH** - sama seperti SDGs & Desa Anti Korupsi, tapi APBDes sudah benar
---
**Catatan:** Secara keseluruhan, modul Prestasi Desa sudah **production-ready** dengan beberapa improvements yang bisa dilakukan secara incremental. Module ini memiliki struktur yang mirip dengan modul Desa Anti Korupsi (kategori relation, rich text editor, file upload).
**Unique Issues:**
1. Schema deletedAt default value yang salah (sama seperti SDGs & Desa Anti Korupsi)
2. HTML injection risk di deskripsi (sama seperti Desa Anti Korupsi)
3. Fetch pattern inconsistency (sama seperti semua modul lain)
**Priority Action:**
```diff
🔴 FIX INI SEKARANG (30 MENIT + MIGRATION):
File: prisma/schema.prisma
Line: 239-240, 248-249
model PrestasiDesa {
// ...
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
model KategoriPrestasiDesa {
// ...
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
# Lalu jalankan:
bunx prisma db push
# atau
bunx prisma migrate dev --name fix_deletedat_default
```
Setelah fix critical schema issue, module ini production-ready! 🎉

View File

@@ -1,488 +0,0 @@
# QC Summary - Profil Landing Page Module
**Scope:** Media Sosial, Pejabat Desa, Program Inovasi
**Date:** 2026-02-23
**Status:** ✅ Secara umum sudah baik, ada beberapa improvement minor
---
## 📊 OVERVIEW
| Module | Schema | API | UI Admin | Public Page | Overall |
|--------|--------|-----|----------|-------------|---------|
| Media Sosial | ✅ Baik | ✅ Baik | ✅ Baik | N/A | 🟢 Baik |
| Pejabat Desa | ✅ Baik | ⚠️ Ada issue | ✅ Baik | N/A | 🟡 Perlu fix |
| Program Inovasi | ✅ Baik | ✅ Baik | ✅ Baik | N/A | 🟢 Baik |
---
## ✅ YANG SUDAH BAIK (COMMON)
### **1. Konsistensi UI/UX**
- ✅ Semua halaman menggunakan pattern yang sama (list → detail → edit)
- ✅ Responsive design (desktop table + mobile cards)
- ✅ Loading states dengan Skeleton
- ✅ Empty state handling yang informatif
- ✅ Search dengan debounce (1000ms)
- ✅ Pagination konsisten di semua modul
### **2. File Upload Handling**
- ✅ Dropzone dengan preview image
- ✅ Validasi format & ukuran file (max 5MB)
- ✅ Tombol hapus preview (IconX di pojok kanan atas)
- ✅ URL.createObjectURL untuk preview lokal
- ✅ Cleanup file state saat reset form
### **3. Form Validation**
- ✅ Zod schema untuk validasi typed
- ✅ isFormValid() check sebelum submit
- ✅ Error toast dengan pesan spesifik
- ✅ Button disabled saat invalid/loading
### **4. State Management (Valtio)**
- ✅ Proxy state untuk reaktivitas
- ✅ Separate state per modul (programInovasi, pejabatDesa, mediaSosial)
- ✅ Reset form function di setiap create/edit
- ✅ Original data tracking untuk reset
### **5. Error Handling**
- ✅ Try-catch di semua async operation
- ✅ Toast error dengan pesan user-friendly
- ✅ Console.error untuk debugging
- ✅ Modal konfirmasi hapus
---
## ⚠️ ISSUES & SARAN PERBAIKAN
### **🔴 CRITICAL**
#### **1. Pejabat Desa - Edit Form Tidak Reset imageId ke Original**
**Lokasi:** `src/app/admin/(dashboard)/landing-page/profil/pejabat-desa/[id]/edit/page.tsx`
**Masalah:**
```typescript
// Line ~100 - Load data
setFormData({
name: profileData.name || "",
position: profileData.position || "",
imageId: profileData.imageId || "", // ✅ Sudah benar
});
// Line ~170 - Handle reset
setFormData({
name: originalData.name,
position: originalData.position,
imageId: originalData.imageId, // ✅ Sudah benar
});
```
**Status:****SUDAH BENAR** - Tidak ada issue di sini
**Verdict:** Tidak ada action needed.
---
#### **2. Media Sosial - Edit Form Sudah Benar**
**Lokasi:** `src/app/admin/(dashboard)/landing-page/profil/media-sosial/[id]/edit/page.tsx`
**Verdict:****SUDAH BENAR** - Original data tracking sudah implementasi dengan baik:
```typescript
const [originalData, setOriginalData] = useState({
name: '',
icon: '',
iconUrl: '',
imageId: '',
imageUrl: '',
});
// Load data
setOriginalData({
...newForm,
imageUrl: data.image?.link || '',
});
// Reset form
setFormData({
name: originalData.name,
icon: originalData.icon,
iconUrl: originalData.iconUrl,
imageId: originalData.imageId,
});
```
**Verdict:** Tidak ada action needed.
---
#### **3. Program Inovasi - Edit Form Sudah Benar**
**Lokasi:** `src/app/admin/(dashboard)/landing-page/profil/program-inovasi/[id]/edit/page.tsx`
**Verdict:****SUDAH BENAR** - Original data tracking sudah implementasi dengan baik.
**Verdict:** Tidak ada action needed.
---
### **🟡 MEDIUM**
#### **4. Inconsistency: Fetch Method di State**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/profile.ts`
**Masalah:** Ada 3 pattern berbeda untuk fetch API:
```typescript
// ❌ Pattern 1: ApiFetch (programInovasi.create)
const res = await ApiFetch.api.landingpage.programinovasi["create"].post(formData);
// ❌ Pattern 2: fetch manual (programInovasi.findUnique)
const res = await fetch(`/api/landingpage/programinovasi/${id}`);
// ❌ Pattern 3: fetch dengan headers (programInovasi.update)
const response = await fetch(`/api/landingpage/programinovasi/${this.id}`, {
method: "PUT",
headers: { "Content-Type": "application/json" },
body: JSON.stringify({...}),
});
// ❌ Pattern 4: fetch dengan delete (programInovasi.delete)
const response = await fetch(`/api/landingpage/programinovasi/del/${id}`, {
method: "DELETE",
...
});
```
**Dampak:**
- Code consistency buruk
- Sulit maintenance
- Type safety tidak konsisten
**Rekomendasi:** Gunakan **ApiFetch** untuk semua operasi:
```typescript
// ✅统一 pattern
const res = await ApiFetch.api.landingpage.programinovasi["create"].post(formData);
const res = await ApiFetch.api.landingpage.programinovasi[id].get();
const res = await ApiFetch.api.landingpage.programinovasi[id].put(data);
const res = await ApiFetch.api.landingpage.programinovasi["del"][id].delete();
```
**Priority:** 🟡 Medium
**Effort:** Low (refactor saja, tidak ada logic change)
---
#### **5. Media Sosial - Validasi IconUrl Tidak Selalu Relevan**
**Lokasi:** `src/app/admin/(dashboard)/landing-page/profil/media-sosial/create/page.tsx`
**Masalah:**
```typescript
// Line ~67
const isFormValid = () => {
const isNameValid = stateMediaSosial.create.form.name?.trim() !== '';
const isIconUrlValid = stateMediaSosial.create.form.iconUrl?.trim() !== ''; // ❌ Selalu required
const isCustomIconValid = selectedSosmed !== 'custom' || file !== null;
return isNameValid && isIconUrlValid && isCustomIconValid;
};
```
**Scenario:**
- User pilih icon "telephone" → iconUrl **seharusnya** required (nomor telepon)
- User pilih icon "facebook" → iconUrl **seharusnya** required (URL profile)
- Tapi jika user hanya mau tampil icon tanpa link → **tidak bisa**
**Rekomendasi:** Jadikan optional atau berikan default value:
```typescript
const isFormValid = () => {
const isNameValid = stateMediaSosial.create.form.name?.trim() !== '';
// IconUrl optional, atau validasi berdasarkan selectedSosmed
const isIconUrlValid = true; // atau validasi spesifik
const isCustomIconValid = selectedSosmed !== 'custom' || file !== null;
return isNameValid && isCustomIconValid;
};
```
**Priority:** 🟡 Medium
**Effort:** Low
---
#### **6. Pejabat Desa - Hanya Ada 1 Data (Hardcoded ID "edit")**
**Lokasi:** `src/app/admin/(dashboard)/landing-page/profil/pejabat-desa/page.tsx`
**Masalah:**
```typescript
// Line ~17
useShallowEffect(() => {
allList.findUnique.load("edit"); // ❌ Hardcoded ID
}, []);
```
**Dampak:**
- Tidak scalable jika nanti ada multiple pejabat desa
- Pattern berbeda dari modul lain (yang pakai findMany)
- Confusing untuk developer baru
**Rekomendasi:**
- Jika memang hanya 1 data, tambahkan komentar:
```typescript
// Note: "edit" adalah special ID untuk single pejabat desa record
// Backend akan return data pertama jika ID tidak ditemukan
allList.findUnique.load("edit");
```
- Atau gunakan pattern yang lebih clear:
```typescript
allList.findUnique.load("single"); // atau "default"
```
**Priority:** 🟡 Low-Medium
**Effort:** Low
---
#### **7. Program Inovasi - HTML Injection Risk di Deskripsi**
**Lokasi:**
- `src/app/admin/(dashboard)/landing-page/profil/program-inovasi/page.tsx` (line ~107)
- `src/app/admin/(dashboard)/landing-page/profil/program-inovasi/[id]/page.tsx` (line ~105)
**Masalah:**
```typescript
// ❌ Direct HTML render tanpa sanitization
<Text dangerouslySetInnerHTML={{ __html: item.description || '-' }}></Text>
```
**Risk:**
- XSS attack jika admin input script malicious
- Bisa inject iframe, script tag, dll
**Rekomendasi:** Gunakan DOMPurify atau library sanitization:
```typescript
import DOMPurify from 'dompurify';
// Sanitize sebelum render
const sanitizedHtml = DOMPurify.sanitize(item.description);
<Text dangerouslySetInnerHTML={{ __html: sanitizedHtml }}></Text>
```
Atau validasi di backend untuk whitelist tag HTML yang diperbolehkan (hanya `<p>`, `<ul>`, `<li>`, dll).
**Priority:** 🟡 Medium (security concern)
**Effort:** Low
---
### **🟢 LOW (Minor Polish)**
#### **8. Inconsistency: Button Size & Styling**
**Lokasi:** Multiple files
**Masalah:** Button styling tidak konsisten:
```typescript
// Media Sosial create
<Button size="md" ...>Simpan</Button>
// Program Inovasi create
<Button size="md" ...>Simpan</Button>
// Pejabat Desa edit
<Button size="md" ...>Simpan</Button>
// Media Sosial edit
<Button size="md" ...>Simpan</Button>
```
Tapi di detail page:
```typescript
// Semua detail page
<Button size="md" ...> // ✅ Konsisten
```
**Rekomendasi:** Buat konstanta untuk button size:
```typescript
const BUTTON_SIZE = "md";
const BUTTON_VARIANT = "light";
const BUTTON_RADIUS = "md";
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **9. Search Placeholder Tidak Spesifik**
**Lokasi:** Multiple list pages
**Masalah:**
```typescript
// Media Sosial
placeholder='Cari nama media sosial atau kontak...' // ✅ Spesifik
// Program Inovasi
placeholder="Cari program inovasi..." // ✅ Oke
// Pejabat Desa
// ❌ Tidak ada search feature
```
**Rekomendasi:** Tambahkan search feature ke Pejabat Desa jika memungkinkan, atau berikan komentar kenapa tidak ada (karena hanya 1 data).
**Priority:** 🟢 Low
**Effort:** Low
---
#### **10. Loading State Tidak Selalu Akurat**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/profile.ts`
**Masalah:**
```typescript
// Line ~120 - findUnique.load untuk programInovasi
async load(id: string) {
try {
const res = await fetch(`/api/landingpage/programinovasi/${id}`);
// ❌ Tidak ada loading state update di sini
if (res.ok) {
const data = await res.json();
programInovasi.findUnique.data = data.data ?? null;
}
} catch (error) {
// ❌ Tidak ada finally block untuk stop loading
}
}
```
**Dampak:** UI mungkin stuck di loading state jika ada error.
**Rekomendasi:** Tambahkan finally block:
```typescript
async load(id: string) {
try {
programInovasi.findUnique.loading = true; // ✅ Start loading
const res = await fetch(`/api/landingpage/programinovasi/${id}`);
if (res.ok) {
const data = await res.json();
programInovasi.findUnique.data = data.data ?? null;
}
} catch (error) {
console.error("Error:", error);
} finally {
programInovasi.findUnique.loading = false; // ✅ Stop loading
}
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **11. Type Safety - Any Usage**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/profile.ts`
**Masalah:**
```typescript
// Line ~75
data: null as any[] | null, // ❌ Using 'any'
// Line ~120
data: null as Prisma.ProgramInovasiGetPayload<{...}> | null, // ✅ Typed
// Line ~200
data: null as any[] | null, // ❌ Using 'any'
```
**Rekomendasi:** Gunakan typed data:
```typescript
data: null as Prisma.MediaSosialGetPayload<{ include: { image: true } }>[] | null
```
**Priority:** 🟢 Low
**Effort:** Medium (perlu update semua reference)
---
#### **12. Console.log di Production**
**Lokasi:** Multiple files
**Masalah:**
```typescript
// Media Sosial edit page (line ~170)
console.log("Data yang akan dikirim ke backend:", stateMediaSosial.update.form);
// Profile state (multiple places)
console.log("Failed to load program inovasi:", res.statusText);
console.log((error as Error).message);
```
**Rekomendasi:** Gunakan conditional logging:
```typescript
if (process.env.NODE_ENV === 'development') {
console.log("Data:", stateMediaSosial.update.form);
}
```
Atau gunakan logging library (winston, pino, dll).
**Priority:** 🟢 Low
**Effort:** Low
---
## 📋 RINGKASAN ACTION ITEMS
| Priority | Issue | Module | Impact | Effort | Status |
|----------|-------|--------|--------|--------|--------|
| 🟡 M | Fetch method inconsistency | All | Medium | Low | Perlu refactor |
| 🟡 M | IconUrl validation terlalu strict | Media Sosial | Low | Low | Perlu fix logic |
| 🟡 M | HTML injection risk | Program Inovasi | **High (Security)** | Low | **Should fix** |
| 🟢 L | Hardcoded ID "edit" | Pejabat Desa | Low | Low | Optional |
| 🟢 L | Button styling inconsistency | All | Low | Low | Optional |
| 🟢 L | Missing search feature | Pejabat Desa | Low | Low | Optional |
| 🟢 L | Loading state inaccurate | All | Low | Low | Perlu fix |
| 🟢 L | Type safety (any usage) | All | Low | Medium | Optional |
| 🟢 L | Console.log in production | All | Low | Low | Optional |
---
## ✅ KESIMPULAN
### **Overall Quality: 🟢 BAIK (8/10)**
**Strengths:**
1. ✅ UI/UX konsisten & responsive
2. ✅ File upload handling sudah solid
3. ✅ Form validation dengan Zod
4. ✅ State management terstruktur
5. ✅ Error handling comprehensive
6. ✅ Edit form reset sudah benar di semua modul
**Areas for Improvement:**
1. ⚠️ **Security:** HTML injection di deskripsi Program Inovasi (prioritas)
2. ⚠️ **Consistency:** Fetch method pattern (ApiFetch vs fetch manual)
3. ⚠️ **Type Safety:** Reduce `any` usage, gunakan Prisma types
4. ⚠️ **Loading States:** Pastikan selalu ada finally block
**Recommended Next Steps:**
1. **Fix HTML injection** dengan DOMPurify atau backend validation
2. **Refactor fetch methods** untuk gunakan ApiFetch consistently
3. **Add loading state cleanup** di semua async operations
4. **Optional:** Improve type safety dengan remove `any`
---
**Catatan:** Secara keseluruhan, modul Profil sudah **production-ready** dengan minor improvements yang bisa dilakukan secara incremental.

View File

@@ -1,651 +0,0 @@
# QC Summary - SDGs Desa Module
**Scope:** List SDGs Desa, Create, Edit, Detail
**Date:** 2026-02-23
**Status:** ✅ Secara umum sudah baik, ada beberapa improvement yang diperlukan
---
## 📊 OVERVIEW
| Aspect | Schema | API | UI Admin | State Management | Overall |
|--------|--------|-----|----------|-----------------|---------|
| SDGs Desa | ✅ Baik | ✅ Baik | ✅ Baik | ⚠️ Ada issue | 🟡 Perlu fix |
---
## ✅ YANG SUDAH BAIK
### **1. UI/UX Consistency**
- ✅ Responsive design (desktop table + mobile cards)
- ✅ Loading states dengan Skeleton
- ✅ Search dengan debounce (1000ms)
- ✅ Pagination konsisten
- ✅ Empty state handling yang informatif
- ✅ Modal konfirmasi hapus
### **2. File Upload Handling**
- ✅ Dropzone dengan preview image
- ✅ Validasi format gambar (JPEG, JPG, PNG, WEBP)
- ✅ Validasi ukuran file (max 5MB)
- ✅ Tombol hapus preview (IconX di pojok kanan atas)
- ✅ URL.createObjectURL untuk preview lokal
### **3. Form Validation**
- ✅ Zod schema untuk validasi typed
- ✅ isFormValid() check sebelum submit
- ✅ Error toast dengan pesan spesifik
- ✅ Button disabled saat invalid/loading
- ✅ Type number input untuk jumlah
### **4. CRUD Operations**
- ✅ Create dengan upload file
- ✅ FindMany dengan pagination & search
- ✅ FindUnique untuk detail
- ✅ Delete dengan hard delete (via Prisma)
- ✅ Update dengan file replacement
### **5. Edit Form - Original Data Tracking**
- ✅ Original data state untuk reset form
- ✅ Load data existing dengan benar
- ✅ Preview image dari data lama
- ✅ Reset form mengembalikan ke data original
**Code Example (✅ GOOD):**
```typescript
// Line ~60-80 - Load data
const data = await sdgsState.edit.load(id);
setFormData({
name: data.name || "",
jumlah: data.jumlah || "",
imageId: data.imageId || "",
});
setOriginalData({
...newForm,
imageUrl: data.image?.link || "",
});
setPreviewImage(data.image?.link || null);
// Line ~90 - Handle reset
const handleResetForm = () => {
setFormData({
name: originalData.name,
jumlah: originalData.jumlah,
imageId: originalData.imageId,
});
setPreviewImage(originalData.imageUrl || null);
setFile(null);
toast.info("Form dikembalikan ke data awal");
};
```
**Verdict:****SUDAH BENAR** - Original data tracking sudah implementasi dengan baik.
---
## ⚠️ ISSUES & SARAN PERBAIKAN
### **🔴 CRITICAL**
#### **1. State Management - Inconsistency Fetch Pattern**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/sdgs-desa.ts`
**Masalah:** Ada 2 pattern berbeda untuk fetch API:
```typescript
// ❌ Pattern 1: ApiFetch (create, findMany)
const res = await ApiFetch.api.landingpage.sdgsdesa["create"].post({...});
const res = await ApiFetch.api.landingpage.sdgsdesa["findMany"].get({query});
// ❌ Pattern 2: fetch manual (findUnique, edit, delete)
const res = await fetch(`/api/landingpage/sdgsdesa/${id}`);
const response = await fetch(`/api/landingpage/sdgsdesa/del/${id}`, {
method: "DELETE",
headers: { "Content-Type": "application/json" },
});
```
**Dampak:**
- Code consistency buruk
- Sulit maintenance
- Type safety tidak konsisten
- Duplikasi logic error handling
**Rekomendasi:** Gunakan **ApiFetch** untuk semua operasi:
```typescript
// ✅ Unified pattern
const res = await ApiFetch.api.landingpage.sdgsdesa["create"].post(data);
const res = await ApiFetch.api.landingpage.sdgsdesa[id].get();
const res = await ApiFetch.api.landingpage.sdgsdesa[id].put(data);
const res = await ApiFetch.api.landingpage.sdgsdesa["del"][id].delete();
```
**Priority:** 🔴 High
**Effort:** Medium (refactor di semua state methods)
---
#### **2. findUnique State - Tidak Ada Loading State Management**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/sdgs-desa.ts`
**Masalah:**
```typescript
// Line ~125 - sdgsDesa.findUnique.load()
async load(id: string) {
try {
const res = await fetch(`/api/landingpage/sdgsdesa/${id}`);
if (res.ok) {
const data = await res.json();
sdgsDesa.findUnique.data = data.data ?? null;
} else {
console.error("Failed to fetch data", res.status, res.statusText);
sdgsDesa.findUnique.data = null;
}
} catch (error) {
console.error("Error fetching data:", error);
sdgsDesa.findUnique.data = null;
}
// ❌ MISSING: finally block untuk stop loading
}
```
**Dampak:** UI mungkin stuck di loading state jika ada error.
**Rekomendasi:** Tambahkan loading state dan finally block:
```typescript
async load(id: string) {
try {
sdgsDesa.findUnique.loading = true; // ✅ Start loading
const res = await fetch(`/api/landingpage/sdgsdesa/${id}`);
if (res.ok) {
const data = await res.json();
sdgsDesa.findUnique.data = data.data ?? null;
}
} catch (error) {
console.error("Error:", error);
} finally {
sdgsDesa.findUnique.loading = false; // ✅ Stop loading
}
}
```
**Priority:** 🔴 Medium
**Effort:** Low
---
#### **3. findManyAll - Tidak Digunakan di UI**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/sdgs-desa.ts`
**Masalah:**
```typescript
// Line ~95 - findManyAll state
findManyAll: {
data: null as any[] | null,
loading: false,
load: async () => {
// ... fetch all data tanpa pagination
},
}
```
**Analysis:**
- ⚠️ **UNUSED:** Tidak ada component yang menggunakan `findManyAll`
- ⚠️ **DEAD CODE:** Menambah bundle size tanpa manfaat
- ⚠️ **CONFUSING:** Developer baru bisa bingung kapan pakai findMany vs findManyAll
**Rekomendasi:** Remove jika tidak digunakan:
```typescript
// ❌ Remove entire findManyAll block
```
Atau jika diperlukan untuk future feature, tambahkan comment:
```typescript
// Reserved for future use - dropdown select without pagination
findManyAll: { ... }
```
**Priority:** 🔴 Low-Medium
**Effort:** Low
---
### **🟡 MEDIUM**
#### **4. Type Safety - Any Usage**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/sdgs-desa.ts`
**Masalah:**
```typescript
// Line ~58
data: null as any[] | null, // ❌ Using 'any'
// Line ~96
data: null as any[] | null, // ❌ Using 'any'
// Line ~118
data: null as Prisma.SdgsDesaGetPayload<{...}> | null, // ✅ Typed
```
**Rekomendasi:** Gunakan typed data consistently:
```typescript
// findMany
data: null as Prisma.SdgsDesaGetPayload<{
include: { image: true };
}>[] | null,
// findManyAll (jika tidak dihapus)
data: null as Prisma.SdgsDesaGetPayload<{
include: { image: true };
}>[] | null,
```
**Priority:** 🟡 Medium
**Effort:** Medium (perlu update semua reference)
---
#### **5. Console.log di Production**
**Lokasi:** Multiple places di state file
**Masalah:**
```typescript
// Line ~48
console.log(error);
toast.error("Gagal menambahkan data");
// Line ~80
console.error("Failed to load media sosial:", res.data?.message);
// Line ~85
console.error("Error loading media sosial:", error);
// Line ~132
console.error("Failed to fetch data", res.status, res.statusText);
// Line ~136
console.error("Error fetching data:", error);
// ... dan banyak lagi
```
**Rekomendasi:** Gunakan conditional logging:
```typescript
if (process.env.NODE_ENV === 'development') {
console.error("Error:", error);
}
```
Atau gunakan logging library (winston, pino, dll) dengan levels yang jelas.
**Priority:** 🟡 Low
**Effort:** Low
---
#### **6. Error Message Tidak Konsisten**
**Lokasi:** Multiple places
**Masalah:**
```typescript
// Create - Line ~44
return toast.error("Gagal menambahkan data");
// Create - Line ~46
toast.error("Gagal menambahkan data");
// Delete - Line ~165
toast.error("Terjadi kesalahan saat menghapus sdgs desa");
// Edit - Line ~210
toast.error("Gagal memuat data");
// Edit update - Line ~250
toast.error("Gagal mengupdate sdgs desa");
// Toast success - Line ~240
toast.success("Berhasil update sdgs desa");
```
**Issue:**
- Inconsistent capitalization ("sdgs desa" vs "Sdgs Desa")
- Mixed patterns ("Gagal menambahkan" vs "Terjadi kesalahan")
- Typo: "sdgs" seharusnya "SDGs" (acronym)
**Rekomendasi:** Standardisasi error messages:
```typescript
// Pattern: "[Action] [resource] gagal" dengan proper casing
toast.error("Menambahkan data SDGs Desa gagal");
toast.error("Menghapus data SDGs Desa gagal");
toast.error("Memuat data SDGs Desa gagal");
toast.error("Memperbarui data SDGs Desa gagal");
// Atau lebih spesifik dengan context
toast.error("Gagal menambahkan data SDGs Desa");
toast.error("Gagal menghapus SDGs Desa");
toast.success("Berhasil memperbarui SDGs Desa");
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **7. Zod Schema - Error Message Tidak Akurat**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/sdgs-desa.ts`
**Masalah:**
```typescript
// Line ~8
const templatesdgsDesaForm = z.object({
name: z.string().min(1, "Judul minimal 1 karakter"), // ❌ "Judul" instead of "Nama"
jumlah: z.string().min(1, "Deskripsi minimal 1 karakter"), // ❌ "Deskripsi" instead of "Jumlah"
imageId: z.string().min(1, "File minimal 1"),
});
```
**Dampak:** User confusion saat validasi error muncul:
```
Error: "Judul minimal 1 karakter" // User: "Lho, ini field nama bukan judul?"
Error: "Deskripsi minimal 1 karakter" // User: "Ini field jumlah bukan deskripsi?"
```
**Rekomendasi:** Fix error messages:
```typescript
const templatesdgsDesaForm = z.object({
name: z.string().min(1, "Nama SDGs Desa minimal 1 karakter"),
jumlah: z.string().min(1, "Jumlah minimal 1 karakter"),
imageId: z.string().min(1, "Gambar wajib dipilih"),
});
```
**Priority:** 🟡 Low
**Effort:** Low
---
### **🟢 LOW (Minor Polish)**
#### **8. Component Name Mismatch**
**Lokasi:** `src/app/admin/(dashboard)/landing-page/SDGs/[id]/edit/page.tsx`
**Masalah:**
```typescript
// Line ~30
export default function EditKolaborasiInovasi() { // ❌ Wrong name
// ...
}
```
**Dampak:** Confusing untuk developer lain, sulit untuk search/reference.
**Rekomendasi:** Rename ke yang sesuai:
```typescript
export default function EditSDGsDesa() { // ✅ Correct name
// ...
}
```
**Priority:** 🟢 Low
**Effort:** Low (hanya rename)
---
#### **9. Text Label Tidak Konsisten**
**Lokasi:** Multiple files
**Masalah:**
```typescript
// Create page - Line ~100
<Text fw="bold" fz="sm" mb={6}>
Gambar Program Inovasi // ❌ Wrong label
</Text>
// Edit page - Line ~170
<Text fw="bold" fz="sm" mb={6}>
Gambar Program Inovasi // ❌ Wrong label (copy-paste?)
</Text>
```
**Rekomendasi:** Fix label:
```typescript
<Text fw="bold" fz="sm" mb={6}>
Gambar SDGs Desa // ✅ Correct label
</Text>
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **10. Placeholder Search Tidak Spesifik**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~17
<HeaderSearch
title='Sdgs Desa'
placeholder='Cari Sdgs Desa...' // ⚠️ Generic
// ...
/>
```
**Rekomendasi:** Lebih spesifik:
```typescript
placeholder='Cari nama SDGs Desa...'
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **11. Capitalization Inconsistency**
**Lokasi:** Multiple files
**Masalah:**
```typescript
// page.tsx - Line ~17
title='Sdgs Desa' // ❌ Mixed case
// create/page.tsx - Line ~90
<Title>Tambah Sdgs Desa</Title> // ❌ Mixed case
// edit/page.tsx - Line ~160
<Title>Edit Sdgs Desa</Title> // ❌ Mixed case
// Should be:
// "SDGs Desa" (all caps for acronym)
```
**Rekomendasi:** Standardisasi:
```typescript
title='SDGs Desa'
<Title>Tambah SDGs Desa</Title>
<Title>Edit SDGs Desa</Title>
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **12. Schema - deletedAt Default Value**
**Lokasi:** `prisma/schema.prisma`
**Masalah:**
```prisma
model SdgsDesa {
// ...
deletedAt DateTime @default(now()) // ❌ Always has default value
isActive Boolean @default(true)
}
```
**Issue:** `deletedAt @default(now())` berarti setiap record baru langsung punya `deletedAt` value, yang bisa membingungkan untuk soft delete logic.
**Rekomendasi:**
```prisma
model SdgsDesa {
// ...
deletedAt DateTime? @default(null) // ✅ Nullable, null = not deleted
isActive Boolean @default(true)
}
```
**Priority:** 🟢 Medium (potential logic issue)
**Effort:** Medium (perlu migration)
---
#### **13. Duplicate Error Logging**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~80
} catch (error) {
console.error("Error loading sdgs desa:", error); // ❌ Duplicate
toast.error("Gagal memuat data sdgs desa");
}
// Line ~120
} catch (error) {
console.error("Error updating sdgs desa:", error); // ❌ Duplicate
toast.error("Terjadi kesalahan saat memperbarui sdgs desa");
}
```
**Rekomendasi:** Cukup satu logging yang informatif:
```typescript
} catch (error) {
console.error('Failed to load SDGs Desa:', err);
toast.error('Gagal memuat data SDGs Desa');
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **14. API Response Handling - Inconsistent Error Messages**
**Lokasi:** API endpoints
**Masalah:** (dari grep search results)
```typescript
// del.ts - Line ~18
message: "Berhasil menghapus SDGS Desa", // ✅ Proper
// updt.ts - Line ~38
message: "SDGS Desa berhasil diperbarui", // ✅ Proper
// create.ts - (assumed)
// Might have inconsistent casing
```
**Rekomendasi:** Ensure all API responses use consistent "SDGs Desa" casing.
**Priority:** 🟢 Low
**Effort:** Low
---
## 📋 RINGKASAN ACTION ITEMS
| Priority | Issue | Module | Impact | Effort | Status |
|----------|-------|--------|--------|--------|--------|
| 🔴 P0 | Fetch method inconsistency | State | Medium | Medium | Perlu refactor |
| 🔴 P0 | Missing loading state in findUnique | State | Medium | Low | Perlu fix |
| 🔴 P1 | Unused findManyAll code | State | Low | Low | Should remove |
| 🟡 M | Type safety (any usage) | State | Low | Medium | Optional |
| 🟡 M | Console.log in production | State | Low | Low | Optional |
| 🟡 M | Error message inconsistency | State/UI | Low | Low | Optional |
| 🟡 M | Zod schema error messages | State | Low | Low | Should fix |
| 🟢 L | Component name mismatch | Edit page | Low | Low | Optional |
| 🟢 L | Wrong label text ("Program Inovasi") | Create/Edit | Low | Low | Should fix |
| 🟢 L | Placeholder tidak spesifik | List page | Low | Low | Optional |
| 🟢 L | Capitalization inconsistency | All UI | Low | Low | Should fix |
| 🟢 M | deletedAt default value | Schema | Medium | Medium | Should fix |
| 🟢 L | Duplicate error logging | Edit page | Low | Low | Optional |
---
## ✅ KESIMPULAN
### **Overall Quality: 🟢 BAIK (7.5/10)**
**Strengths:**
1. ✅ UI/UX konsisten & responsive
2. ✅ File upload handling solid
3. ✅ Form validation dengan Zod schema
4. ✅ State management terstruktur (Valtio)
5.**Edit form reset sudah benar** (original data tracking)
6. ✅ Modal konfirmasi hapus untuk user safety
7. ✅ Type number input untuk field jumlah
**Areas for Improvement:**
1. ⚠️ **Consistency:** Fetch method pattern (ApiFetch vs fetch manual)
2. ⚠️ **Loading States:** findUnique tidak ada loading state management
3. ⚠️ **Dead Code:** findManyAll tidak digunakan
4. ⚠️ **Type Safety:** Reduce `any` usage, gunakan Prisma types
5. ⚠️ **Schema:** deletedAt default value bisa menyebabkan logic issue
6. ⚠️ **Naming:** Component name & label text masih ada yang salah
**Recommended Next Steps:**
1. **Refactor fetch methods** untuk gunakan ApiFetch consistently
2. **Add loading state** di findUnique operations
3. **Remove findManyAll** jika tidak digunakan
4. **Fix component name** (EditKolaborasiInovasi → EditSDGsDesa)
5. **Fix label text** ("Gambar Program Inovasi" → "Gambar SDGs Desa")
6. **Fix capitalization** (Sdgs → SDGs)
7. **Optional:** Improve type safety dengan remove `any`
---
## 📈 COMPARISON WITH OTHER MODULES
| Aspect | Profil | Desa Anti Korupsi | SDGs Desa | Notes |
|--------|--------|-------------------|-----------|-------|
| Fetch Pattern | ⚠️ Mixed | ⚠️ Mixed | ⚠️ Mixed | All perlu refactor |
| Loading State | ⚠️ Some missing | ⚠️ Some missing | ⚠️ Missing | Same issue |
| Edit Form Reset | ✅ Good | ✅ Good | ✅ Good | Consistent |
| Type Safety | ⚠️ Some `any` | ⚠️ Some `any` | ⚠️ Some `any` | Same issue |
| File Upload | ✅ Images | ✅ Documents | ✅ Images | Different use case |
| Error Handling | ✅ Good | ✅ Good (better) | ✅ Good | Consistent |
| Dead Code | ❌ None | ❌ None | ⚠️ findManyAll | SDGs unique issue |
| Naming Issues | ❌ None | ⚠️ Some | ⚠️ Some | Similar level |
---
**Catatan:** Secara keseluruhan, modul SDGs Desa sudah **production-ready** dengan beberapa improvements yang bisa dilakukan secara incremental. Module ini memiliki struktur yang mirip dengan modul lain (Profil, Desa Anti Korupsi) sehingga pattern improvement yang sama bisa diterapkan.
**Unique Issues:**
1. findManyAll unused code (tidak ada di modul lain)
2. Component name mismatch (EditKolaborasiInovasi)
3. Wrong label text ("Gambar Program Inovasi") - kemungkinan copy-paste dari modul Program Inovasi

View File

@@ -1,879 +0,0 @@
# QC Summary - Daftar Informasi Publik PPID Module
**Scope:** List Daftar Informasi Publik, Create, Edit, Detail
**Date:** 2026-02-23
**Status:** ✅ Secara umum sudah baik, ada beberapa improvement yang diperlukan
---
## 📊 OVERVIEW
| Aspect | Schema | API | UI Admin | State Management | Overall |
|--------|--------|-----|----------|-----------------|---------|
| Daftar Informasi Publik | ⚠️ Ada issue | ✅ Baik | ✅ Baik | ⚠️ Ada issue | 🟡 Perlu fix |
---
## ✅ YANG SUDAH BAIK
### **1. UI/UX Design**
- ✅ Preview layout yang clean dengan responsive design
- ✅ Loading states dengan Skeleton
- ✅ Empty state handling yang informatif dengan icon
- ✅ Search functionality dengan debounce (1000ms)
- ✅ Pagination yang konsisten
- ✅ Desktop table + mobile cards responsive
- ✅ Sticky table header untuk better UX
- ✅ Responsive button text ("Tambah" vs "Tambah Baru")
### **2. Table & Card Layout**
- ✅ Fixed column widths (25%, 40%, 20%)
- ✅ Sticky header table untuk long lists
- ✅ Striped rows untuk readability
- ✅ Highlight on hover
- ✅ HTML tag stripping untuk preview deskripsi
- ✅ Text truncation dengan lineClamp dan substring
- ✅ Mobile card view dengan proper information hierarchy
**Code Example (✅ GOOD):**
```typescript
// page.tsx - Line ~95-120
<Table
highlightOnHover
striped
stickyHeader // ✅ GOOD - Header tetap visible saat scroll
style={{ minWidth: '700px' }} // ✅ GOOD - Minimum width untuk readability
>
<TableThead>
<TableTr>
<TableTh w="25%">
<Text fw={600} lh={1.4}>Jenis Informasi</Text>
</TableTh>
<TableTh w="40%">
<Text fw={600} lh={1.4}>Deskripsi</Text>
</TableTh>
<TableTh ta="center" w="20%">
<Text fw={600} lh={1.4}>Aksi</Text>
</TableTh>
</TableTr>
</TableThead>
```
**Verdict:****BAIK** - Table layout dengan sticky header yang helpful!
---
### **3. State Management**
- ✅ Proper typing dengan Prisma types
- ✅ Loading state management dengan finally block
- ✅ Error handling yang comprehensive
-**ApiFetch consistency** untuk create & findMany! ✅
- ✅ Zod validation untuk form data
- ✅ Proper date formatting untuk update operation
**Code Example (✅ GOOD):**
```typescript
// state file - Line ~50-85
findMany: {
data: null as Prisma.DaftarInformasiPublikGetPayload<{ omit: { isActive: true } }>[] | null,
page: 1,
totalPages: 1,
loading: false,
search: "",
load: async (page = 1, limit = 10, search = "") => {
daftarInformasiPublik.findMany.loading = true; // ✅ Start loading
daftarInformasiPublik.findMany.page = page;
daftarInformasiPublik.findMany.search = search;
try {
const query: any = { page, limit };
if (search) query.search = search;
const res = await ApiFetch.api.ppid.daftarinformasipublik["find-many"].get({ query });
if (res.status === 200 && res.data?.success) {
daftarInformasiPublik.findMany.data = res.data.data ?? [];
daftarInformasiPublik.findMany.totalPages = res.data.totalPages ?? 1;
}
} catch (err) {
console.error("Gagal fetch daftar informasi publik:", err);
daftarInformasiPublik.findMany.data = [];
daftarInformasiPublik.findMany.totalPages = 1;
} finally {
daftarInformasiPublik.findMany.loading = false; // ✅ Stop loading
}
},
}
```
**Verdict:****BAIK** - State management sudah proper dengan ApiFetch!
---
### **4. Zod Schema Validation**
- ✅ Comprehensive validation untuk semua fields
- ✅ Specific error messages untuk setiap field
- ✅ Minimum character validation (3 characters)
**Code Example (✅ GOOD):**
```typescript
// state file - Line ~8-12
const templateDaftarInformasi = z.object({
jenisInformasi: z.string().min(3, "Jenis Informasi minimal 3 karakter"),
deskripsi: z.string().min(3, "Deskripsi minimal 3 karakter"),
tanggal: z.string().min(3, "Tanggal minimal 3 karakter"),
});
```
**Verdict:****BAIK** - Validation yang proper!
---
### **5. Edit Form - Original Data Tracking**
- ✅ Original data state untuk reset form (via useState)
- ✅ Load data existing dengan benar
- ✅ Reset form mengembalikan ke data original
- ✅ Rich text content handling yang proper
- ✅ Date formatting untuk input type="date"
**Code Example (✅ GOOD):**
```typescript
// edit/page.tsx - Line ~30-60
const [formData, setFormData] = useState<FormDaftarInformasi>({
jenisInformasi: '',
deskripsi: '',
tanggal: '',
});
const formatDateForInput = (dateString: string) => {
if (!dateString) return '';
const date = new Date(dateString);
return date.toISOString().split('T')[0]; // ✅ Format untuk input date
};
// Load data
useEffect(() => {
const loadDaftarInformasi = async () => {
const data = await daftarInformasi.edit.load(id);
if (data) {
setFormData({
jenisInformasi: data.jenisInformasi || '',
deskripsi: data.deskripsi || '',
tanggal: data.tanggal || '',
});
}
};
loadDaftarInformasi();
}, [params?.id]);
```
**Verdict:****BAIK** - Original data tracking sudah implementasi dengan baik!
---
### **6. Rich Text Editor**
- ✅ CreateEditor untuk create page
- ✅ EditEditor untuk edit page
- ✅ Reusable component pattern
- ✅ HTML content handling yang proper
---
## ⚠️ ISSUES & SARAN PERBAIKAN
### **🔴 CRITICAL**
#### **1. Schema - deletedAt Default Value SALAH**
**Lokasi:** `prisma/schema.prisma` (line 414)
**Masalah:**
```prisma
model DaftarInformasiPublik {
id String @id @default(cuid())
jenisInformasi String
deskripsi String
tanggal DateTime @db.Date
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now()) // ❌ SALAH - selalu punya default value
isActive Boolean @default(true)
}
```
**Dampak:**
- **LOGIC ERROR!** Setiap record baru langsung punya `deletedAt` value (timestamp creation)
- Soft delete tidak berfungsi dengan benar
- Query dengan `where: { deletedAt: null }` tidak akan pernah return data
- Data yang "dihapus" vs data "aktif" tidak bisa dibedakan
**Contoh Issue:**
```prisma
// Record baru dibuat
CREATE DaftarInformasiPublik {
jenisInformasi: "Informasi 1",
deskripsi: "Deskripsi 1",
tanggal: "2024-01-01",
// deletedAt otomatis ter-set ke now() ❌
// isActive: true ✅
}
// Query untuk data aktif (seharusnya return data ini)
prisma.daftarInformasiPublik.findMany({
where: { deletedAt: null, isActive: true }
})
// ❌ Return kosong! Karena deletedAt sudah ter-set
```
**Rekomendasi:** Fix schema:
```prisma
model DaftarInformasiPublik {
id String @id @default(cuid())
jenisInformasi String
deskripsi String
tanggal DateTime @db.Date
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime? @default(null) // ✅ Nullable, null = not deleted
isActive Boolean @default(true)
}
```
**Priority:** 🔴 **CRITICAL**
**Effort:** Medium (perlu migration)
**Impact:** **HIGH** (data integrity & soft delete logic)
---
#### **2. State Management - Fetch Pattern Inconsistency**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/daftar_informasi_publik/daftarInformasiPublik.ts`
**Masalah:** Ada 2 pattern berbeda untuk fetch API:
```typescript
// ❌ Pattern 1: ApiFetch (create, findMany)
const res = await ApiFetch.api.ppid.daftarinformasipublik["create"].post(form);
const res = await ApiFetch.api.ppid.daftarinformasipublik["find-many"].get({ query });
// ❌ Pattern 2: fetch manual (findUnique, edit, delete)
const res = await fetch(`/api/ppid/daftarinformasipublik/${id}`);
const response = await fetch(`/api/ppid/daftarinformasipublik/del/${id}`, {
method: "DELETE",
headers: { "Content-Type": "application/json" },
});
```
**Dampak:**
- Code consistency buruk
- Sulit maintenance
- Type safety tidak konsisten
- Duplikasi logic error handling
**Rekomendasi:** Gunakan **ApiFetch** untuk semua operasi:
```typescript
// ✅ Unified pattern
async load(id: string) {
try {
const res = await ApiFetch.api.ppid.daftarinformasipublik[id].get();
if (res.data?.success) {
const data = res.data.data;
this.id = data.id;
this.form = {
jenisInformasi: data.jenisInformasi,
deskripsi: data.deskripsi,
tanggal: data.tanggal,
};
return data;
} else {
throw new Error(res.data?.message || "Gagal memuat data");
}
} catch (error) {
console.error("Error:", error);
toast.error("Gagal memuat data");
return null;
}
}
async byId(id: string) {
try {
const res = await ApiFetch.api.ppid.daftarinformasipublik["del"][id].delete();
if (res.data?.success) {
toast.success(res.data.message || "Berhasil hapus");
await daftarInformasiPublik.findMany.load();
} else {
toast.error(res.data?.message || "Gagal hapus");
}
} catch (error) {
console.error("Gagal delete:", error);
toast.error("Terjadi kesalahan saat menghapus");
}
}
```
**Priority:** 🔴 High
**Effort:** Medium (refactor di findUnique, edit, delete methods)
---
#### **3. Missing Loading State di Edit Button**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~130-145
<Button
onClick={handleSubmit}
disabled={!isFormValid()} // ⚠️ Missing loading check
radius="md"
size="md"
// ...
>
Simpan Perubahan
</Button>
```
**Issue:** Button tidak disabled saat submitting. User bisa click multiple times.
**Rekomendasi:** Add loading state:
```typescript
const [isSubmitting, setIsSubmitting] = useState(false);
// In handleSubmit
const handleSubmit = async () => {
setIsSubmitting(true);
try {
await daftarInformasi.edit.update();
router.push('/admin/ppid/daftar-informasi-publik');
} catch (error) {
// ...
} finally {
setIsSubmitting(false);
}
};
// In button
<Button
onClick={handleSubmit}
disabled={!isFormValid() || isSubmitting}
// ...
>
{isSubmitting ? <Loader size="sm" color="white" /> : 'Simpan Perubahan'}
</Button>
```
**Priority:** 🔴 Medium
**Effort:** Low
---
### **🟡 MEDIUM**
#### **4. Console.log di Production**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/daftar_informasi_publik/daftarInformasiPublik.ts`
**Masalah:**
```typescript
// Line ~45
console.log((error as Error).message);
// Line ~80
console.error("Gagal fetch daftar informasi publik paginated:", err);
// Line ~100
console.error("Failed to fetch daftar informasi publik:", res.statusText);
// Line ~104
console.error("Error fetching daftar informasi publik:", error);
// Line ~180
console.error("Error loading daftar informasi publik:", error);
// Line ~230
console.error("Error updating daftar informasi publik:", error);
```
**Rekomendasi:** Gunakan conditional logging:
```typescript
if (process.env.NODE_ENV === 'development') {
console.error("Error:", error);
}
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **5. Type Safety - Any Usage**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/daftar_informasi_publik/daftarInformasiPublik.ts`
**Masalah:**
```typescript
// Line ~70
const query: any = { page, limit }; // ❌ Using 'any'
if (search) query.search = search;
```
**Rekomendasi:** Gunakan typed query:
```typescript
// Define type
interface FindManyQuery {
page: number | string;
limit?: number | string;
search?: string;
}
// Use typed query
const query: FindManyQuery = { page, limit };
if (search) query.search = search;
```
**Priority:** 🟡 Medium
**Effort:** Low
---
#### **6. Alert() Instead of Toast**
**Lokasi:** `create/page.tsx`
**Masalah:**
```typescript
// Line ~30-40
const handleSubmit = async () => {
if (!daftarInformasi.create.form.jenisInformasi) {
return alert('Mohon isi jenis informasi'); // ❌ Using alert()
}
if (!daftarInformasi.create.form.deskripsi) {
return alert('Mohon isi deskripsi'); // ❌ Using alert()
}
if (!daftarInformasi.create.form.tanggal) {
return alert('Mohon pilih tanggal publikasi'); // ❌ Using alert()
}
try {
await daftarInformasi.create.create();
// ...
} catch (error) {
console.error('Error creating informasi publik:', error);
alert('Terjadi kesalahan saat menyimpan data'); // ❌ Using alert()
}
};
```
**Rekomendasi:** Gunakan toast untuk consistency:
```typescript
if (!daftarInformasi.create.form.jenisInformasi) {
return toast.warn('Mohon isi jenis informasi'); // ✅ Using toast
}
// ...
```
**Priority:** 🟡 Medium
**Effort:** Low
---
#### **7. Missing Reset Form Function**
**Lokasi:** `create/page.tsx`
**Masalah:**
```typescript
// Line ~20-25
const resetForm = () => {
daftarInformasi.create.form = {
jenisInformasi: "",
deskripsi: "",
tanggal: "",
};
};
// resetForm dipanggil di handleSubmit tapi tidak ada di form inputs
// Form inputs langsung update state tanpa reset setelah submit
```
**Issue:** Form tidak reset setelah successful submit.
**Rekomendasi:** Ensure reset is called:
```typescript
const handleSubmit = async () => {
// ... validation
try {
await daftarInformasi.create.create();
resetForm(); // ✅ Make sure this is called
router.push("/admin/ppid/daftar-informasi-publik");
} catch (error) {
// ...
}
};
```
**Verdict:****SUDAH BENAR** - resetForm() sudah dipanggil di handleSubmit!
**Priority:** 🟢 None
**Effort:** None
---
### **🟢 LOW (Minor Polish)**
#### **8. Pagination onChange Tidak Include Search**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~190-200
<Pagination
value={page}
onChange={(newPage) => {
load(newPage, 10); // ⚠️ Missing search parameter
window.scrollTo({ top: 0, behavior: 'smooth' });
}}
total={totalPages}
// ...
/>
```
**Issue:** Saat ganti page, search query hilang.
**Rekomendasi:** Include search:
```typescript
onChange={(newPage) => {
load(newPage, 10, debouncedSearch); // ✅ Include search
window.scrollTo({ top: 0, behavior: 'smooth' });
}}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **9. Duplicate Error Logging**
**Lokasi:** Multiple files
**Masalah:**
```typescript
// edit/page.tsx - Line ~60
} catch (error) {
console.error('Error loading daftar informasi:', error); // ❌ Duplicate
toast.error('Gagal memuat data daftar informasi');
}
// edit/page.tsx - Line ~80
} catch (error) {
console.error('Error updating berita:', error); // ❌ Duplicate + wrong module name
toast.error('Terjadi kesalahan saat memperbarui berita'); // ❌ Wrong module name
}
```
**Issue:** Copy-paste error dari module "berita"!
**Rekomendasi:** Fix error messages:
```typescript
} catch (error) {
console.error('Failed to load Daftar Informasi Publik:', err);
toast.error('Gagal memuat data Daftar Informasi Publik');
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **10. Missing Loading State di Detail Page**
**Lokasi:** `[id]/page.tsx`
**Masalah:**
```typescript
// Line ~20-25
useShallowEffect(() => {
stateDaftarInformasi.findUnique.load(params?.id as string)
}, [params?.id])
if (!stateDaftarInformasi.findUnique.data) {
return (
<Stack py={10}>
<Skeleton height={500} radius="md" />
</Stack>
)
}
```
**Issue:** Skeleton ditampilkan untuk semua kondisi (loading, error, not found).
**Rekomendasi:** Add proper loading state:
```typescript
if (stateDaftarInformasi.findUnique.loading) {
return (
<Stack py={10}>
<Skeleton height={500} radius="md" />
</Stack>
);
}
if (!stateDaftarInformasi.findUnique.data) {
return (
<Alert icon={<IconAlertCircle />} color="red">
Data tidak ditemukan
</Alert>
);
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **11. Search Placeholder Tidak Spesifik**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~30-35
<HeaderSearch
title='Daftar Informasi Publik'
placeholder='Cari jenis informasi atau deskripsi...' // ✅ Actually pretty specific!
// ...
/>
```
**Verdict:****SUDAH BENAR** - Placeholder sudah spesifik!
**Priority:** 🟢 None
**Effort:** None
---
#### **12. Empty State Icon Consistency**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~85-95
<Stack align="center" py="xl">
<IconDeviceImacCog size={40} stroke={1.5} color={colors['blue-button']} />
<Text fz={{ base: 'sm', md: 'md' }} fw={500} c="dimmed" lh={1.5}>
Belum ada informasi publik yang tersedia
</Text>
</Stack>
```
**Verdict:****SUDAH BENAR** - Empty state dengan icon yang proper!
**Priority:** 🟢 None
**Effort:** None
---
#### **13. HTML Tag Stripping for Preview**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~125-130
<Text fz="sm" lh={1.5} c="dimmed" lineClamp={1}>
{item.deskripsi?.replace(/<[^>]*>?/gm, '').substring(0, 80)}...
</Text>
```
**Verdict:****SUDAH BENAR** - HTML tag stripping yang proper untuk preview!
**Priority:** 🟢 None
**Effort:** None
---
## 📋 RINGKASAN ACTION ITEMS
| Priority | Issue | Module | Impact | Effort | Status |
|----------|-------|--------|--------|--------|--------|
| 🔴 P0 | **Schema deletedAt default SALAH** | Schema | **CRITICAL** | Medium | **MUST FIX** |
| 🔴 P0 | Fetch method inconsistency | State | Medium | Medium | Perlu refactor |
| 🔴 P1 | Missing loading state di edit button | UI | Medium | Low | Should fix |
| 🟡 M | Console.log in production | State | Low | Low | Optional |
| 🟡 M | Type safety (any usage) | State | Low | Low | Optional |
| 🟡 M | Alert() instead of toast | Create UI | Low | Low | Should fix |
| 🟡 M | Copy-paste error messages (berita) | Edit UI | Low | Low | Should fix |
| 🟢 L | Pagination missing search param | UI | Low | Low | Optional |
| 🟢 L | Missing loading state di detail page | UI | Low | Low | Optional |
| 🟢 L | Duplicate error logging | UI/State | Low | Low | Optional |
---
## ✅ KESIMPULAN
### **Overall Quality: 🟢 BAIK (8/10)**
**Strengths:**
1. ✅ UI/UX clean & responsive
2.**Sticky header table** - Better UX untuk long lists
3.**HTML tag stripping** untuk preview deskripsi
4. ✅ Search functionality dengan debounce
5. ✅ Empty state handling yang informatif
6.**Zod validation** comprehensive
7. ✅ State management dengan ApiFetch untuk create & findMany
8. ✅ Loading state management dengan finally block
9. ✅ Mobile cards responsive
10.**Responsive button text** ("Tambah" vs "Tambah Baru")
11. ✅ Edit form dengan original data tracking
12. ✅ Date formatting untuk input type="date"
**Critical Issues:**
1. ⚠️ **Schema deletedAt default SALAH** - Logic error untuk soft delete (CRITICAL)
2. ⚠️ Fetch method pattern inconsistency (ApiFetch vs fetch manual)
3. ⚠️ Missing loading state di edit button
**Areas for Improvement:**
1. ⚠️ **Fix schema deletedAt** dari `@default(now())` ke `@default(null)` dengan nullable
2. ⚠️ **Refactor fetch methods** untuk gunakan ApiFetch consistently
3. ⚠️ **Add loading state** di edit button
4. ⚠️ **Fix alert()** ke toast
5. ⚠️ **Fix copy-paste error messages** dari module "berita"
**Recommended Next Steps:**
1. **🔴 CRITICAL: Fix schema deletedAt** - 30 menit (perlu migration)
2. **🔴 HIGH: Refactor findUnique, edit, delete** ke ApiFetch - 1 jam
3. **🔴 HIGH: Add loading state** di edit button - 15 menit
4. **🟡 MEDIUM: Fix alert()** ke toast - 15 menit
5. **🟡 MEDIUM: Fix copy-paste error messages** - 10 menit
6. **🟢 LOW: Add pagination search param** - 10 menit
7. **🟢 LOW: Polish minor issues** - 30 menit
---
## 📈 COMPARISON WITH OTHER MODULES
| Module | Fetch Pattern | State | Validation | Schema | Loading State | Overall |
|--------|--------------|-------|------------|--------|---------------|---------|
| Profil | ⚠️ Mixed | ⚠️ Good | ✅ Good | ⚠️ deletedAt | ⚠️ Some missing | 🟢 |
| Desa Anti Korupsi | ⚠️ Mixed | ⚠️ Good | ✅ Good | ⚠️ deletedAt | ⚠️ Some missing | 🟢 |
| SDGs Desa | ⚠️ Mixed | ⚠️ Good | ✅ Good | ⚠️ deletedAt | ⚠️ Missing | 🟢 |
| APBDes | ⚠️ Mixed | ⚠️ Good | ✅ Good | ✅ Good | ✅ Good | 🟢 |
| Prestasi Desa | ⚠️ Mixed | ⚠️ Good | ✅ Good | ❌ WRONG | ⚠️ Some missing | 🟢 |
| PPID Profil | ⚠️ Mixed | ✅ **Best** | ✅ Good | ❌ WRONG | ✅ Good | 🟢⭐ |
| Struktur PPID | ⚠️ Mixed | ✅ Good | ✅ Good | ⚠️ Inconsistent | ✅ Good | 🟢 |
| Visi Misi PPID | ✅ **100% ApiFetch!** | ✅ Best | ✅ Good | ❌ WRONG | ✅ Good | 🟢⭐⭐ |
| Dasar Hukum PPID | ✅ **100% ApiFetch!** | ✅ Best | ✅ Good | ❌ WRONG | ✅ Good | 🟢⭐⭐ |
| Permohonan Informasi | ⚠️ Mixed | ⚠️ Good | ✅ **Best** | ❌ **4 models WRONG** | ✅ Good | 🟡 |
| **Daftar Informasi** | ⚠️ Mixed | ⚠️ Good | ✅ Good | ❌ WRONG | ⚠️ Some missing | 🟢 |
**Daftar Informasi PPID Highlights:**
-**Sticky header table** - Unique feature untuk better UX
-**HTML tag stripping** untuk preview - Good practice
-**Responsive button text** - Attention to detail
- ⚠️ **Same deletedAt issue** seperti modul PPID lain
- ⚠️ **Copy-paste errors** dari module "berita"
---
## 🎯 UNIQUE FEATURES OF DAFTAR INFORMASI MODULE
**Best Table Implementation:**
1.**Sticky header table** - Unique feature!
2.**HTML tag stripping** untuk preview deskripsi
3.**Responsive button text** - "Tambah" vs "Tambah Baru"
4.**Fixed column widths** - 25%, 40%, 20%
5.**Minimum table width** - 700px untuk readability
**Best Practices:**
1.**Sticky header** - Best practice untuk long lists
2.**HTML stripping** - Good practice untuk rich text preview
3.**Loading state management** - Proper dengan finally block
4.**Original data tracking** - Edit form reset yang proper
5.**Date formatting** - Proper untuk input type="date"
**Critical Issues:**
1.**Schema deletedAt SALAH** - Same issue seperti modul PPID lain
2.**Fetch pattern inconsistency** - findUnique, edit, delete pakai fetch manual
3.**Copy-paste error messages** - Dari module "berita"
---
**Catatan:** **Daftar Informasi PPID adalah MODULE DENGAN TABLE IMPLEMENTATION TERBAIK** dengan sticky header dan HTML tag stripping untuk preview. Module ini juga punya attention to detail dengan responsive button text.
**Unique Strengths:**
1.**Sticky header table** - Best table UX
2.**HTML tag stripping** - Best practice untuk preview
3.**Responsive button text** - Attention to detail
4.**Fixed column widths** - Consistent layout
5.**Date formatting** - Proper handling
**Priority Action:**
```diff
🔴 FIX INI SEKARANG (30 MENIT + MIGRATION):
File: prisma/schema.prisma
Line: 414
model DaftarInformasiPublik {
id String @id @default(cuid())
jenisInformasi String
deskripsi String
tanggal DateTime @db.Date
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
# Lalu jalankan:
bunx prisma db push
# atau
bunx prisma migrate dev --name fix_deletedat_daftar_informasi
```
```diff
🔴 FIX COPY-PASTE ERRORS (10 MENIT):
File: edit/page.tsx
// Line ~80
- console.error('Error updating berita:', error);
+ console.error('Error updating daftar informasi:', error);
- toast.error('Terjadi kesalahan saat memperbarui berita');
+ toast.error('Terjadi kesalahan saat memperbarui daftar informasi');
```
Setelah fix critical issues, module ini **PRODUCTION-READY** dengan **BEST TABLE IMPLEMENTATION**! 🎉
---
## 📚 RECOMMENDED AS REFERENCE FOR OTHER MODULES
**Daftar Informasi PPID Module adalah BEST PRACTICE untuk:**
1.**Sticky header table** - Best practice untuk long lists
2.**HTML tag stripping** - Good practice untuk rich text preview
3.**Responsive button text** - Attention to detail
4.**Fixed column widths** - Consistent layout
5.**Date formatting** - Proper handling untuk date inputs
**Modules lain bisa belajar dari Daftar Informasi:**
- **ALL MODULES WITH TABLES:** Use sticky header untuk better UX
- **ALL MODULES WITH RICH TEXT:** Strip HTML tags untuk preview
- **ALL MODULES:** Responsive text untuk buttons
- **ALL MODULES:** Fixed column widths untuk consistency
- **ALL MODULES:** Proper date formatting untuk date inputs
---
**File Location:** `QC/PPID/QC-DAFTAR-INFORMASI-PUBLIK-MODULE.md` 📄

View File

@@ -1,821 +0,0 @@
# QC Summary - Dasar Hukum PPID Module
**Scope:** Preview Dasar Hukum, Edit Dasar Hukum dengan Rich Text Editor
**Date:** 2026-02-23
**Status:** ✅ Secara umum sudah baik, ada beberapa improvement yang diperlukan
---
## 📊 OVERVIEW
| Aspect | Schema | API | UI Admin | State Management | Overall |
|--------|--------|-----|----------|-----------------|---------|
| Dasar Hukum PPID | ⚠️ Ada issue | ✅ Baik | ✅ Baik | ✅ Baik | 🟡 Perlu fix |
---
## ✅ YANG SUDAH BAIK
### **1. UI/UX Design**
- ✅ Preview layout yang clean dengan logo desa
- ✅ Responsive design (mobile & desktop)
- ✅ Loading states dengan Skeleton
- ✅ Empty state handling yang informatif
- ✅ Edit button yang prominent
- ✅ Divider visual yang jelas antara Judul dan Content
### **2. Rich Text Editor (Tiptap)**
- ✅ Full-featured editor dengan toolbar lengkap (reuse dari PPIDTextEditor)
- ✅ Extensions: Bold, Italic, Underline, Highlight, Link, dll
- ✅ Text alignment (left, center, justify, right)
- ✅ Heading levels (H1-H4)
- ✅ Lists (bullet & ordered)
- ✅ Blockquote, code, superscript, subscript
- ✅ Undo/Redo
- ✅ Sticky toolbar untuk UX yang lebih baik
-**Dynamic import dengan `ssr: false`** untuk menghindari hydration issues! ✅
### **3. Form Component Structure**
- ✅ Reusable PPIDTextEditor component (shared dengan Visi Misi)
- ✅ Proper TypeScript typing
- ✅ Controlled components dengan onChange handler
- ✅ SSR handling yang proper dengan dynamic import
**Code Example (✅ EXCELLENT):**
```typescript
// edit/page.tsx - Line ~13-17
const PPIDTextEditor = dynamic(
() => import('../../_com/PPIDTextEditor').then(mod => mod.PPIDTextEditor),
{ ssr: false } // ✅ Disable SSR untuk avoid hydration mismatch
);
```
**Verdict:****EXCELLENT** - Proper SSR handling!
---
### **4. State Management**
- ✅ Proper typing dengan Prisma types
- ✅ Loading state management dengan finally block
- ✅ Error handling yang comprehensive
-**ApiFetch consistency** - Semua operasi pakai ApiFetch! ✅
- ✅ Zod validation untuk form data
**Code Example (✅ EXCELLENT):**
```typescript
// state file - Line ~20-45
findById: {
data: null as DasarHukumForm | null,
loading: false,
initialize() {
stateDasarHukumPPID.findById.data = {
id: '',
judul: '',
content: '',
} as DasarHukumForm;
},
async load(id: string) {
try {
stateDasarHukumPPID.findById.loading = true; // ✅ Start loading
const res = await ApiFetch.api.ppid.dasarhukumppid["find-by-id"].get({
query: { id },
});
if (res.status === 200) {
stateDasarHukumPPID.findById.data = res.data?.data ?? null;
}
} catch (error) {
console.error((error as Error).message);
toast.error("Terjadi kesalahan saat mengambil data dasar hukum");
} finally {
stateDasarHukumPPID.findById.loading = false; // ✅ Stop loading
}
},
}
```
**Verdict:****SANGAT BAIK** - State management sudah konsisten dengan ApiFetch!
---
### **5. Edit Form - Original Data Tracking**
- ✅ Original data state untuk reset form
- ✅ Load data existing dengan benar
- ✅ Reset form mengembalikan ke data original
- ✅ Rich text content handling yang proper
**Code Example (✅ GOOD):**
```typescript
// edit/page.tsx - Line ~20-45
const [formData, setFormData] = useState({ judul: '', content: '' });
const [originalData, setOriginalData] = useState({
judul: '',
content: '',
});
// Initialize from global state
useEffect(() => {
if (dasarHukumState.findById.data) {
setFormData({
judul: dasarHukumState.findById.data.judul ?? '',
content: dasarHukumState.findById.data.content ?? '',
});
setOriginalData({
judul: dasarHukumState.findById.data.judul ?? '',
content: dasarHukumState.findById.data.content ?? '',
});
}
}, [dasarHukumState.findById.data]);
// Line ~65 - Handle reset
const handleResetForm = () => {
setFormData({
judul: originalData.judul,
content: originalData.content,
});
toast.info("Form dikembalikan ke data awal");
};
```
**Verdict:****BAIK** - Original data tracking sudah implementasi dengan baik!
---
### **6. Rich Text Validation**
- ✅ Custom validation function untuk rich text content
- ✅ Check empty content setelah remove HTML tags
- ✅ Validation untuk kedua fields (judul & content)
**Code Example (✅ GOOD):**
```typescript
// edit/page.tsx - Line ~25-35
const isRichTextEmpty = (content: string) => {
// Remove HTML tags and check if the resulting text is empty
const plainText = content.replace(/<[^>]*>/g, '').trim();
return plainText === '' || content.trim() === '<p></p>' || content.trim() === '<p><br></p>';
};
const isFormValid = () => {
return (
!isRichTextEmpty(formData.judul) &&
!isRichTextEmpty(formData.content)
);
};
```
**Verdict:****EXCELLENT** - Rich text validation yang comprehensive!
---
## ⚠️ ISSUES & SARAN PERBAIKAN
### **🔴 CRITICAL**
#### **1. Schema - deletedAt Default Value SALAH**
**Lokasi:** `prisma/schema.prisma` (line 385)
**Masalah:**
```prisma
model DasarHukumPPID {
id String @id @default(cuid())
judul String @db.Text
content String @db.Text
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now()) // ❌ SALAH - selalu punya default value
isActive Boolean @default(true)
}
```
**Dampak:**
- **LOGIC ERROR!** Setiap record baru langsung punya `deletedAt` value (timestamp creation)
- Soft delete tidak berfungsi dengan benar
- Query dengan `where: { deletedAt: null }` tidak akan pernah return data
- Data yang "dihapus" vs data "aktif" tidak bisa dibedakan
**Contoh Issue:**
```prisma
// Record baru dibuat
CREATE DasarHukumPPID {
judul: "Judul 1",
content: "Content 1",
// deletedAt otomatis ter-set ke now() ❌
// isActive: true ✅
}
// Query untuk data aktif (seharusnya return data ini)
prisma.dasarHukumPPID.findMany({
where: { deletedAt: null, isActive: true }
})
// ❌ Return kosong! Karena deletedAt sudah ter-set
```
**Rekomendasi:** Fix schema:
```prisma
model DasarHukumPPID {
id String @id @default(cuid())
judul String @db.Text
content String @db.Text
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime? @default(null) // ✅ Nullable, null = not deleted
isActive Boolean @default(true)
}
```
**Priority:** 🔴 **CRITICAL**
**Effort:** Medium (perlu migration)
**Impact:** **HIGH** (data integrity & soft delete logic)
---
#### **2. HTML Injection Risk - dangerouslySetInnerHTML**
**Lokasi:** `page.tsx` (preview page)
**Masalah:**
```typescript
// Line ~65-75
<Title
order={3}
ta="center"
lh={{ base: 1.15, md: 1.1 }}
fw="bold"
c={colors['blue-button']}
dangerouslySetInnerHTML={{ __html: listDasarHukum.findById.data.judul }} // ❌ No sanitization
style={{ wordBreak: 'break-word', whiteSpace: 'normal' }}
/>
// Line ~80-90 (Content)
<Text
dangerouslySetInnerHTML={{ __html: listDasarHukum.findById.data.content }} // ❌ No sanitization
style={{
wordBreak: 'break-word',
whiteSpace: 'normal',
fontSize: '1rem',
lineHeight: 1.55,
textAlign: 'justify',
}}
/>
```
**Risk:**
- XSS attack jika admin input script malicious
- Bisa inject iframe, script tag, dll
- Security vulnerability
**Rekomendasi:** Gunakan DOMPurify atau library sanitization:
```typescript
import DOMPurify from 'dompurify';
// Sanitize sebelum render
const sanitizedJudul = DOMPurify.sanitize(listDasarHukum.findById.data.judul);
const sanitizedContent = DOMPurify.sanitize(listDasarHukum.findById.data.content);
<Title
dangerouslySetInnerHTML={{ __html: sanitizedJudul }}
// ...
/>
<Text
dangerouslySetInnerHTML={{ __html: sanitizedContent }}
// ...
/>
```
Atau validasi di backend untuk whitelist tag HTML yang diperbolehkan (hanya `<p>`, `<ul>`, `<li>`, `<strong>`, dll).
**Priority:** 🔴 **HIGH** (**Security concern**)
**Effort:** Low
---
#### **3. Missing Delete/Hard Delete Protection**
**Lokasi:** `page.tsx`, `edit/page.tsx`
**Masalah:**
- ❌ Tidak ada tombol delete untuk Dasar Hukum (correct - single record)
-**GOOD:** Single record pattern yang benar
- ⚠️ **ISSUE:** Tidak ada konfirmasi sebelum update (direct save)
**Issue:** User bisa accidentally save changes tanpa konfirmasi.
**Rekomendasi:** Add confirmation dialog sebelum save:
```typescript
const handleSubmit = () => {
// Check if data has changed
if (formData.judul === originalData.judul && formData.content === originalData.content) {
toast.info('Tidak ada perubahan');
return;
}
// Show confirmation
const confirmed = window.confirm('Apakah Anda yakin ingin mengubah Dasar Hukum PPID?');
if (!confirmed) return;
// Then save...
};
```
**Priority:** 🔴 Medium
**Effort:** Low
---
### **🟡 MEDIUM**
#### **4. Console.log di Production**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/dasar_hukum/dasarHukum.ts`
**Masalah:**
```typescript
// Line ~40
console.error((error as Error).message);
// Line ~65
console.error((error as Error).message);
```
**Rekomendasi:** Gunakan conditional logging:
```typescript
if (process.env.NODE_ENV === 'development') {
console.error("Error:", error);
}
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **5. Missing Loading State di Submit Button**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~130-140
<Button
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
// ...
>
{isSubmitting ? <Loader size="sm" color="white" /> : 'Simpan'}
</Button>
```
**Issue:** Button tidak check `dasarHukumState.update.loading` dari global state.
**Rekomendasi:** Check both states:
```typescript
disabled={!isFormValid() || isSubmitting || dasarHukumState.update.loading}
{isSubmitting || dasarHukumState.update.loading ? (
<Loader size="sm" color="white" />
) : (
'Simpan'
)}
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **6. Zod Schema - Could Be More Specific**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/dasar_hukum/dasarHukum.ts`
**Masalah:**
```typescript
// Line ~7
const templateForm = z.object({
judul: z.string().min(3, "Judul minimal 3 karakter"), // ⚠️ Generic
content: z.string().min(3, "Content minimal 3 karakter"), // ⚠️ Generic
});
```
**Rekomendasi:** More specific error messages:
```typescript
const templateForm = z.object({
judul: z.string().min(3, "Judul dasar hukum minimal 3 karakter"),
content: z.string().min(3, "Konten dasar hukum minimal 3 karakter"),
});
```
**Priority:** 🟡 Low
**Effort:** Low
---
### **🟢 LOW (Minor Polish)**
#### **7. Missing Change Detection**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~75-85
const handleSubmit = () => {
try {
setIsSubmitting(true);
if (dasarHukumState.findById.data) {
// Update global state hanya saat submit
const updated = { ...dasarHukumState.findById.data, ...formData };
dasarHukumState.update.save(updated);
}
router.push('/admin/ppid/dasar-hukum');
} catch (error) {
console.error("Error updating dasar hukum:", error);
toast.error("Terjadi kesalahan saat memperbarui dasar hukum");
} finally {
setIsSubmitting(false);
}
};
```
**Issue:** Tidak ada check apakah data sudah berubah. User bisa save tanpa perubahan.
**Rekomendasi:** Add change detection:
```typescript
const handleSubmit = () => {
// Check if data has changed
if (formData.judul === originalData.judul && formData.content === originalData.content) {
toast.info('Tidak ada perubahan');
return;
}
try {
setIsSubmitting(true);
// ... rest of save logic
}
};
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **8. Editor - Duplicate useEffect**
**Lokasi:** `PPIDTextEditor.tsx` (shared component)
**Masalah:**
```typescript
// Line ~30-35 (di PPIDTextEditor.tsx)
const editor = useEditor({
extensions: [...],
immediatelyRender: false,
content: initialContent, // ✅ Set content directly
onUpdate: ({editor}) => {
onChange(editor.getHTML()) // ✅ Handle changes
}
});
// Line ~37-42
useEffect(() => {
if (editor && initialContent !== editor.getHTML()) {
editor.commands.setContent(initialContent || '<p></p>');
}
}, [initialContent, editor]);
```
**Issue:** Ada useEffect tambahan untuk set content, padahal sudah ada di `useEditor`. Bisa menyebabkan double content update.
**Rekomendasi:** Simplify - remove useEffect:
```typescript
const editor = useEditor({
extensions: [...],
immediatelyRender: false,
content: initialContent || '<p></p>', // ✅ Set content directly
onUpdate: ({editor}) => {
onChange(editor.getHTML())
},
});
// Remove useEffect completely
```
**Priority:** 🟢 Low
**Effort:** Low (perlu update shared component)
---
#### **9. Missing Error Boundary**
**Lokasi:** `edit/page.tsx`
**Masalah:**
- Tidak ada error boundary untuk handle unexpected errors
- Jika editor gagal load, tidak ada fallback UI
**Rekomendasi:** Add error boundary:
```typescript
if (dasarHukumState.findById.error) {
return (
<Alert icon={<IconAlertCircle />} color="red">
<Text fw="bold">Error</Text>
<Text>{dasarHukumState.findById.error}</Text>
</Alert>
);
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **10. Preview Page - Title Order Inconsistency**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~40
<Title order={3} ...>Preview Dasar Hukum PPID</Title>
// Line ~65
<Title order={3} ... dangerouslySetInnerHTML={{ __html: listDasarHukum.findById.data.judul }} />
```
**Issue:** Title hierarchy agak confusing. Page title dan content title sama-sama order 3.
**Rekomendasi:** Samakan hierarchy:
```typescript
// Page title: order={2}
// Content title (judul): order={3}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **11. Missing Toast Success After Save**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~75-90
const handleSubmit = () => {
try {
setIsSubmitting(true);
if (dasarHukumState.findById.data) {
const updated = { ...dasarHukumState.findById.data, ...formData };
dasarHukumState.update.save(updated);
}
router.push('/admin/ppid/dasar-hukum'); // ✅ Redirect tanpa toast
} catch (error) {
console.error("Error updating dasar hukum:", error);
toast.error("Terjadi kesalahan saat memperbarui dasar hukum");
} finally {
setIsSubmitting(false);
}
};
```
**Issue:** Toast success ada di state `update.save()`, tapi user mungkin tidak lihat karena langsung redirect.
**Rekomendasi:** Add toast before redirect atau wait untuk toast selesai:
```typescript
const handleSubmit = async () => {
try {
setIsSubmitting(true);
if (dasarHukumState.findById.data) {
const updated = { ...dasarHukumState.findById.data, ...formData };
await dasarHukumState.update.save(updated);
toast.success("Dasar Hukum berhasil diperbarui!");
setTimeout(() => {
router.push('/admin/ppid/dasar-hukum');
}, 1000); // Wait 1 second for toast to show
}
} catch (error) {
console.error("Error updating dasar hukum:", error);
toast.error("Terjadi kesalahan saat memperbarui dasar hukum");
} finally {
setIsSubmitting(false);
}
};
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **12. SSR Dynamic Import - Good but Could Add Loading**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~13-17
const PPIDTextEditor = dynamic(
() => import('../../_com/PPIDTextEditor').then(mod => mod.PPIDTextEditor),
{ ssr: false } // ✅ Good
);
```
**Issue:** Tidak ada loading state untuk dynamic import. Jika editor lambat load, user lihat kosong.
**Rekomendasi:** Add loading option:
```typescript
const PPIDTextEditor = dynamic(
() => import('../../_com/PPIDTextEditor').then(mod => mod.PPIDTextEditor),
{
ssr: false,
loading: () => (
<Center py={40}>
<Loader size="sm" />
<Text ml="md">Loading editor...</Text>
</Center>
)
}
);
```
**Priority:** 🟢 Low
**Effort:** Low
---
## 📋 RINGKASAN ACTION ITEMS
| Priority | Issue | Module | Impact | Effort | Status |
|----------|-------|--------|--------|--------|--------|
| 🔴 P0 | **Schema deletedAt default SALAH** | Schema | **CRITICAL** | Medium | **MUST FIX** |
| 🔴 P0 | **HTML injection risk** | UI | **HIGH (Security)** | Low | **Should fix** |
| 🔴 P1 | Missing delete confirmation | UI | Medium | Low | Should fix |
| 🟡 M | Console.log in production | State | Low | Low | Optional |
| 🟡 M | Missing loading state di submit button | UI | Low | Low | Should fix |
| 🟡 M | Zod schema error messages | State | Low | Low | Optional |
| 🟢 L | Missing change detection | Edit UI | Low | Low | Optional |
| 🟢 L | Duplicate useEffect di editor | Editor | Low | Low | Optional |
| 🟢 L | Missing error boundary | UI | Low | Low | Optional |
| 🟢 L | Title order inconsistency | UI | Low | Low | Optional |
| 🟢 L | Missing toast success timing | UI | Low | Low | Optional |
| 🟢 L | SSR loading state | UI | Low | Low | Optional |
---
## ✅ KESIMPULAN
### **Overall Quality: 🟢 BAIK (8.5/10) - CLEAN & SIMPLE!**
**Strengths:**
1. ✅ UI/UX clean & responsive
2.**Rich Text Editor** full-featured (Tiptap, shared component)
3.**Dynamic import dengan `ssr: false`** - Proper SSR handling! ✅
4.**State management BEST PRACTICES** - **100% ApiFetch!**
5.**Edit form reset sudah benar** (original data tracking)
6.**Rich text validation** comprehensive (check empty content)
7. ✅ Error handling comprehensive
8. ✅ Loading state management dengan finally block
9.**Reusable component** (PPIDTextEditor shared dengan Visi Misi)
**Critical Issues:**
1. ⚠️ **Schema deletedAt default SALAH** - Logic error untuk soft delete (CRITICAL)
2. ⚠️ **HTML injection risk** - dangerouslySetInnerHTML tanpa sanitization (HIGH Security)
3. ⚠️ Missing confirmation sebelum save (Medium UX)
**Areas for Improvement:**
1. ⚠️ **Fix schema deletedAt** dari `@default(now())` ke `@default(null)` dengan nullable
2. ⚠️ **Fix HTML injection** dengan DOMPurify atau backend validation
3. ⚠️ **Add confirmation dialog** sebelum save
4. ⚠️ **Add change detection** untuk avoid unnecessary saves
5. ⚠️ **Fix loading state** di submit button
**Recommended Next Steps:**
1. **🔴 CRITICAL: Fix schema deletedAt** - 30 menit (perlu migration)
2. **🔴 HIGH: Fix HTML injection** dengan DOMPurify - 30 menit
3. **🟡 MEDIUM: Add confirmation dialog** - 15 menit
4. **🟢 LOW: Add change detection** - 15 menit
5. **🟢 LOW: Add SSR loading state** - 10 menit
6. **🟢 LOW: Polish minor issues** - 30 menit
---
## 📈 COMPARISON WITH OTHER MODULES
| Module | Fetch Pattern | State | Edit Reset | Rich Text | SSR Handling | HTML Injection | deletedAt | Overall |
|--------|--------------|-------|------------|-----------|--------------|----------------|-----------|---------|
| Profil | ⚠️ Mixed | ⚠️ Good | ✅ Good | ❌ None | N/A | ⚠️ Present | ⚠️ Issue | 🟢 |
| Desa Anti Korupsi | ⚠️ Mixed | ⚠️ Good | ✅ Good | ✅ Present | ⚠️ None | ⚠️ Present | ⚠️ Issue | 🟢 |
| SDGs Desa | ⚠️ Mixed | ⚠️ Good | ✅ Good | ❌ None | N/A | N/A | ⚠️ Issue | 🟢 |
| APBDes | ⚠️ Mixed | ⚠️ Good | ✅ Good | ❌ None | N/A | N/A | ✅ Good | 🟢 |
| Prestasi Desa | ⚠️ Mixed | ⚠️ Good | ✅ Good | ✅ Present | ⚠️ None | ⚠️ Present | ❌ WRONG | 🟢 |
| PPID Profil | ⚠️ Mixed | ✅ **Best** | ✅ **Excellent** | ✅ **Best** | ⚠️ None | ⚠️ Present | ❌ WRONG | 🟢⭐ |
| Struktur PPID | ⚠️ Mixed | ✅ Good | ✅ Good | ✅ Present | ⚠️ None | ⚠️ Present | ⚠️ Inconsistent | 🟢 |
| Visi Misi PPID | ✅ **100% ApiFetch!** | ✅ **Best** | ✅ Good | ✅ Present | ⚠️ None | ⚠️ Present | ❌ WRONG | 🟢⭐⭐ |
| **Dasar Hukum PPID** | ✅ **100% ApiFetch!** | ✅ **Best** | ✅ Good | ✅ Present | ✅ **EXCELLENT** | ⚠️ Present | ❌ WRONG | 🟢⭐⭐ |
**Dasar Hukum PPID Highlights:**
-**100% ApiFetch** - NO fetch manual sama sekali!
-**SSR Handling** - Dynamic import dengan `ssr: false` (UNIQUE!)
-**Reusable component** - Share PPIDTextEditor dengan Visi Misi
-**Simple & clean** - No unnecessary complexity
- ⚠️ **Same deletedAt issue** seperti modul PPID lain
---
## 🎯 UNIQUE FEATURES OF DASAR HUKUM PPID MODULE
**Simplest & Cleanest Module:**
1.**100% ApiFetch consistency** - NO fetch manual sama sekali!
2.**SSR Handling** - Dynamic import dengan `ssr: false` (UNIQUE!)
3.**Reusable component** - Share PPIDTextEditor dengan Visi Misi
4.**Simple single record pattern** - Only 2 fields (judul, content)
5.**Rich text validation** - Check empty content
**Best Practices:**
1.**API consistency** - 100% ApiFetch
2.**SSR handling** - Best practice untuk Next.js
3.**Loading state management** proper (dengan finally block)
4.**Rich text validation** comprehensive
5.**Original data tracking** untuk reset form
6.**Component reusability** - Share editor component
**Critical Issues:**
1.**Schema deletedAt SALAH** - Same issue seperti modul PPID lain
2.**HTML injection risk** - Same issue seperti modul dengan rich text lain
---
**Catatan:** **Dasar Hukum PPID adalah MODULE PALING CLEAN** bersama Visi Misi PPID dengan codebase paling simple dan **100% PAKAI ApiFetch** (no fetch manual sama sekali!). Module ini juga **SATU-SATUNYA MODULE** yang punya proper SSR handling dengan dynamic import!
**Unique Strengths:**
1.**100% ApiFetch** - Best API consistency
2.**SSR Handling** - Best practice untuk Next.js (UNIQUE!)
3.**Component reusability** - Share editor component
4.**Simple & clean** - No unnecessary complexity
5.**Rich text validation** - Most comprehensive
**Priority Action:**
```diff
🔴 FIX INI SEKARANG (30 MENIT + MIGRATION):
File: prisma/schema.prisma
Line: 385
model DasarHukumPPID {
id String @id @default(cuid())
judul String @db.Text
content String @db.Text
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
# Lalu jalankan:
bunx prisma db push
# atau
bunx prisma migrate dev --name fix_deletedat_dasarhukum_ppid
```
```diff
🔴 FIX HTML INJECTION (30 MENIT):
File: page.tsx
+ import DOMPurify from 'dompurify';
// Line ~65
- dangerouslySetInnerHTML={{ __html: listDasarHukum.findById.data.judul }}
+ dangerouslySetInnerHTML={{ __html: DOMPurify.sanitize(listDasarHukum.findById.data.judul) }}
// Line ~80
- dangerouslySetInnerHTML={{ __html: listDasarHukum.findById.data.content }}
+ dangerouslySetInnerHTML={{ __html: DOMPurify.sanitize(listDasarHukum.findById.data.content) }}
```
Setelah fix critical issues, module ini **PRODUCTION-READY** dan bisa jadi **REFERENCE untuk SSR HANDLING & API CONSISTENCY**! 🎉
---
## 📚 RECOMMENDED AS REFERENCE FOR OTHER MODULES
**Dasar Hukum PPID Module adalah BEST PRACTICE untuk:**
1.**API consistency** - 100% ApiFetch, NO fetch manual!
2.**SSR handling** - Dynamic import dengan `ssr: false`
3.**Simple state management** - Clean, straightforward
4.**Rich text validation** - Check empty content pattern
5.**Component reusability** - Share editor component
**Modules lain bisa belajar dari Dasar Hukum PPID:**
- **ALL MODULES:** Use ApiFetch consistently (NO fetch manual!)
- **ALL MODULES WITH RICH TEXT:** Use dynamic import dengan `ssr: false`
- **ALL MODULES:** Keep it simple (avoid unnecessary complexity)
- **Rich Text Modules:** Implement empty content validation
- **ALL MODULES:** Share reusable components
---
**File Location:** `QC/PPID/QC-DASAR-HUKUM-PPID-MODULE.md` 📄

View File

@@ -1,913 +0,0 @@
# QC Summary - Indeks Kepuasan Masyarakat (IKM) PPID Module
**Scope:** Responden (CRUD), Grafik Kepuasan Masyarakat, Master Data (Jenis Kelamin, Rating, Kelompok Umur)
**Date:** 2026-02-23
**Status:** ✅ Secara umum sudah baik, ada beberapa improvement yang diperlukan
---
## 📊 OVERVIEW
| Sub-Module | Schema | API | UI Admin | State Management | Overall |
|------------|--------|-----|----------|-----------------|---------|
| Responden | ⚠️ Ada issue | ✅ Baik | ✅ Baik | ⚠️ Ada issue | 🟡 |
| Grafik IKM | ✅ Baik | ✅ Baik | ✅ **Excellent** | ✅ Baik | 🟢 |
| Master Data (JK, Rating, Umur) | ⚠️ Ada issue | ✅ Baik | N/A | ⚠️ Ada issue | 🟡 |
---
## ✅ YANG SUDAH BAIK
### **1. UI/UX - Grafik & Charts (UNIQUE FEATURE!)**
-**Mantine Charts** - PieChart & BarChart yang modern
-**3 Distribusi Charts**: Jenis Kelamin, Penilaian, Kelompok Umur
-**Bar Chart Tren** - Monthly respondent trends
-**Responsive design** - SimpleGrid dengan proper breakpoints
-**Empty state handling** - "Tidak ada data" message
-**Loading states** dengan Skeleton
-**Color coding** yang konsisten
-**Legend & Labels** yang informatif
-**Tooltip** untuk interactive charts
**Code Example (✅ EXCELLENT):**
```typescript
// grafik-kepuasan-masyarakat/page.tsx - Line ~100-150
<Paper withBorder bg={colors['white-1']} p="lg" radius="xl" shadow="sm">
<Title order={3} mb="md" ta="center">Tren Jumlah Responden</Title>
<Box h={320}>
<BarChart
h={300}
data={barChartData}
dataKey="month"
series={[{ name: 'count', color: colors['blue-button'] }]}
tickLine="y"
xAxisLabel="Bulan"
yAxisLabel="Jumlah Responden"
withTooltip
tooltipAnimationDuration={200}
/>
</Box>
</Paper>
```
**Verdict:****EXCELLENT** - Best chart implementation di semua modul PPID!
---
### **2. Data Processing untuk Charts**
- ✅ Automatic calculation dari data responden
- ✅ Grouping by gender, rating, age group
- ✅ Monthly aggregation untuk bar chart
- ✅ Date parsing dari multiple fields (createdAt, tanggal)
- ✅ Sorting by month/year
- ✅ Empty data handling (all values = 0)
**Code Example (✅ EXCELLENT):**
```typescript
// grafik-kepuasan-masyarakat/page.tsx - Line ~45-85
// Hitung total berdasarkan jenis kelamin
const totalLaki = data.filter((item: any) =>
item.jenisKelamin?.name?.toLowerCase() === 'laki-laki'
).length;
const totalPerempuan = data.filter((item: any) =>
item.jenisKelamin?.name?.toLowerCase() === 'perempuan'
).length;
// Update gender chart data
setDonutDataJenisKelamin([
{ name: 'Laki-laki', value: totalLaki, color: colors['blue-button'] },
{ name: 'Perempuan', value: totalPerempuan, color: '#10A85AFF' },
]);
// Process data for bar chart (group by month)
const monthYearMap = new Map<string, number>();
data.forEach((item: any) => {
const dateValue = item.tanggal || item.createdAt;
const parsedDate = new Date(dateValue);
const month = parsedDate.getMonth() + 1;
const year = parsedDate.getFullYear();
const monthYearKey = `${year}-${String(month).padStart(2, '0')}`;
monthYearMap.set(monthYearKey, (monthYearMap.get(monthYearKey) || 0) + 1);
});
```
**Verdict:****EXCELLENT** - Data processing yang comprehensive!
---
### **3. Form Validation**
- ✅ Zod schema untuk semua forms
- ✅ Required field validation
- ✅ Multiple dropdown dependencies (Jenis Kelamin, Rating, Umur)
- ✅ Loading state handling untuk dropdown data
**Code Example (✅ GOOD):**
```typescript
// state file - Line ~10-16
const templateResponden = z.object({
name: z.string().min(1, "Nama harus diisi"),
tanggal: z.string().min(1, "Tanggal harus diisi"),
jenisKelaminId: z.string().min(1, "Jenis kelamin harus diisi"),
ratingId: z.string().min(1, "Rating harus diisi"),
kelompokUmurId: z.string().min(1, "Kelompok umur harus diisi"),
});
```
**Verdict:****BAIK** - Validation yang proper!
---
### **4. State Management**
- ✅ Proper typing dengan Prisma types (untuk findUnique)
- ✅ Loading state management dengan finally block
- ✅ Error handling yang comprehensive
-**ApiFetch consistency** untuk create & findMany! ✅
- ✅ Multiple related states (responden, jenisKelamin, rating, umur)
- ✅ Reusable Select component di edit page
**Code Example (✅ GOOD):**
```typescript
// state file - Line ~60-95
findMany: {
data: null as any[] | null,
page: 1,
totalPages: 1,
total: 0,
loading: false,
search: "",
load: async (page = 1, limit = 10, search = "") => {
responden.findMany.loading = true; // ✅ Start loading
responden.findMany.page = page;
responden.findMany.search = search;
try {
const query: any = { page, limit };
if (search) query.search = search;
const res = await ApiFetch.api.landingpage.responden["findMany"].get({ query });
if (res.status === 200 && res.data?.success) {
responden.findMany.data = res.data.data || [];
responden.findMany.total = res.data.total || 0;
responden.findMany.totalPages = res.data.totalPages || 1;
}
} catch (error) {
console.error("Error loading responden:", error);
responden.findMany.data = [];
responden.findMany.total = 0;
responden.findMany.totalPages = 1;
} finally {
responden.findMany.loading = false; // ✅ Stop loading
}
},
}
```
**Verdict:****BAIK** - State management sudah proper dengan ApiFetch!
---
### **5. Edit Form - Original Data Tracking**
- ✅ Original data state untuk reset form
- ✅ Load data existing dengan benar
- ✅ Reset form mengembalikan ke data original
- ✅ Reusable ControlledSelect component
- ✅ Error display untuk setiap field
**Code Example (✅ EXCELLENT):**
```typescript
// edit/page.tsx - Line ~40-60
const [formData, setFormData] = useState<FormResponden>({
name: '',
tanggal: '',
jenisKelaminId: '',
ratingId: '',
kelompokUmurId: '',
});
const [originalData, setOriginalData] = useState<FormResponden>({
name: '',
tanggal: '',
jenisKelaminId: '',
ratingId: '',
kelompokUmurId: '',
});
// Load data
const data = await state.update.load(id);
setFormData(newForm);
setOriginalData(newForm); // ✅ Save original
// Line ~130 - Handle reset
const handleResetForm = () => {
setFormData({ ...originalData });
toast.info('Form dikembalikan ke data awal');
};
// Line ~150 - Reusable Select component
const ControlledSelect = ({
label, value, onChange, options, error, loading,
}) => (
<Select
label={<Text fw="bold" fz="sm" mb={4}>{label}</Text>}
value={value}
onChange={(val) => onChange(val || '')}
data={options}
disabled={loading}
clearable
searchable
required
radius="md"
error={error}
/>
);
```
**Verdict:****EXCELLENT** - Best edit form implementation dengan reusable component!
---
### **6. Master Data Management**
- ✅ 3 master data tables: Jenis Kelamin, Rating, Kelompok Umur
- ✅ Separate proxy states untuk masing-masing
- ✅ Auto-load saat create/edit form
- ✅ Proper filtering dan mapping untuk dropdown options
---
## ⚠️ ISSUES & SARAN PERBAIKAN
### **🔴 CRITICAL**
#### **1. Schema - deletedAt Default Value SALAH (5 MODELS AFFECTED!)**
**Lokasi:** `prisma/schema.prisma` (line 266-297)
**Masalah:**
```prisma
model Responden {
// ...
deletedAt DateTime @default(now()) // ❌ SALAH
isActive Boolean @default(true)
}
model JenisKelaminResponden {
// ...
deletedAt DateTime @default(now()) // ❌ SALAH
isActive Boolean @default(true)
}
model PilihanRatingResponden {
// ...
deletedAt DateTime @default(now()) // ❌ SALAH
isActive Boolean @default(true)
}
model UmurResponden {
// ...
deletedAt DateTime @default(now()) // ❌ SALAH
isActive Boolean @default(true)
}
```
**Dampak:**
- **LOGIC ERROR!** Setiap record baru langsung punya `deletedAt` value
- Soft delete tidak berfungsi dengan benar
- Query dengan `where: { deletedAt: null }` tidak akan pernah return data
- **5 models affected!** (Responden + 3 master data + StrukturPPID)
**Rekomendasi:** Fix semua schema:
```prisma
model Responden {
// ...
deletedAt DateTime? @default(null) // ✅ Nullable
isActive Boolean @default(true)
}
model JenisKelaminResponden {
// ...
deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
model PilihanRatingResponden {
// ...
deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
model UmurResponden {
// ...
deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
```
**Priority:** 🔴 **CRITICAL**
**Effort:** Medium (perlu migration untuk 5 models)
**Impact:** **HIGH** (data integrity & soft delete logic)
---
#### **2. State Management - Fetch Pattern Inconsistency**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/indeks-kepuasan.ts`
**Masalah:** Ada 2 pattern berbeda untuk fetch API:
```typescript
// ❌ Pattern 1: ApiFetch (create, findMany)
const res = await ApiFetch.api.landingpage.responden["create"].post(form);
const res = await ApiFetch.api.landingpage.responden["findMany"].get({ query });
// ❌ Pattern 2: fetch manual (findUnique, update)
const res = await fetch(`/api/landingpage/responden/${id}`);
const response = await fetch(`/api/landingpage/responden/${id}`, {
method: "PUT",
headers: { "Content-Type": "application/json" },
});
```
**Dampak:**
- Code consistency buruk
- Sulit maintenance
- Type safety tidak konsisten
- Duplikasi logic error handling
**Rekomendasi:** Gunakan **ApiFetch** untuk semua operasi:
```typescript
// ✅ Unified pattern
async load(id: string) {
try {
const res = await ApiFetch.api.landingpage.responden[id].get();
if (res.data?.success) {
responden.findUnique.data = res.data.data;
} else {
toast.error(res.data?.message || "Gagal memuat data");
}
} catch (error) {
console.error("Error:", error);
toast.error("Gagal memuat data");
}
}
```
**Priority:** 🔴 High
**Effort:** Medium (refactor di findUnique, update methods)
---
#### **3. Type Safety - Any Usage di findMany**
**Lokasi:** `src/app/admin/(dashboard)/_state/landing-page/indeks-kepuasan.ts`
**Masalah:**
```typescript
// Line ~58
data: null as any[] | null, // ❌ Using 'any'
// Line ~270
data: null as any[] | null, // ❌ Using 'any'
// Line ~370
data: null as any[] | null, // ❌ Using 'any'
// Line ~470
data: null as any[] | null, // ❌ Using 'any'
```
**Issue:** findMany data tidak typed dengan Prisma types, hanya findUnique yang typed.
**Rekomendasi:** Gunakan typed data:
```typescript
// Define type
type RespondenWithRelations = Prisma.RespondenGetPayload<{
include: {
jenisKelamin: true;
rating: true;
kelompokUmur: true;
};
}>;
// Use typed data
data: null as RespondenWithRelations[] | null,
```
**Priority:** 🟡 Medium
**Effort:** Low
---
### **🟡 MEDIUM**
#### **4. Console.log di Production**
**Lokasi:** Multiple places di state file
**Masalah:**
```typescript
// Line ~80
console.error("Failed to load responden:", res.data?.message);
// Line ~85
console.error("Error loading responden:", error);
// Line ~110
console.error("Failed to fetch data", res.status, res.statusText);
// Line ~114
console.error("Error loading responden:", error);
// ... dan banyak lagi di semua master data states
```
**Rekomendasi:** Gunakan conditional logging:
```typescript
if (process.env.NODE_ENV === 'development') {
console.error("Error:", error);
}
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **5. Missing Loading State di Submit Button**
**Lokasi:** `create/page.tsx`
**Masalah:**
```typescript
// Line ~100-110
<Button
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
// ...
>
{isSubmitting ? <Loader size="sm" color="white" /> : 'Simpan'}
</Button>
```
**Verdict:****SUDAH BENAR** - Loading state sudah ada di create page!
**Priority:** 🟢 None
**Effort:** None
---
#### **6. Missing Loading State di Edit Submit Button**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~220-230
<Button
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
// ⚠️ Missing state.update.loading check
>
{isSubmitting ? <Loader size="sm" color="white" /> : 'Simpan'}
</Button>
```
**Issue:** Button tidak check `state.update.loading` dari global state.
**Rekomendasi:** Check both states:
```typescript
disabled={!isFormValid() || isSubmitting || state.update.loading}
{isSubmitting || state.update.loading ? (
<Loader size="sm" color="white" />
) : (
'Simpan'
)}
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **7. Pagination onChange Tidak Include Search**
**Lokasi:** `responden/page.tsx`
**Masalah:**
```typescript
// Line ~200-210
<Pagination
value={page}
onChange={(newPage) => {
load(newPage, 10); // ⚠️ Missing search parameter
window.scrollTo({ top: 0, behavior: 'smooth' });
}}
total={totalPages}
// ...
/>
```
**Issue:** Saat ganti page, search query hilang.
**Rekomendasi:** Include search:
```typescript
onChange={(newPage) => {
load(newPage, 10, debouncedSearch); // ✅ Include search
window.scrollTo({ top: 0, behavior: 'smooth' });
}}
```
**Priority:** 🟡 Low
**Effort:** Low
---
### **🟢 LOW (Minor Polish)**
#### **8. Missing Delete Function di Master Data**
**Lokasi:** State file untuk master data
**Masalah:**
```typescript
// Line ~270-290 (jenisKelaminResponden)
delete: {
loading: false,
async byId(id: string) {
// ✅ Method sudah ada
},
}
```
**Verdict:****SUDAH BENAR** - Delete function sudah ada di semua master data!
**Priority:** 🟢 None
**Effort:** None
---
#### **9. Duplicate Loading State Assignment**
**Lokasi:** State file untuk master data
**Masalah:**
```typescript
// Line ~290-295 (jenisKelaminResponden.create)
async create() {
// ...
jenisKelaminResponden.create.loading = true; // ✅ First assignment
try {
jenisKelaminResponden.create.loading = true; // ❌ Duplicate!
const res = await ApiFetch.api.landingpage.jeniskelaminresponden["create"].post(form);
// ...
}
}
```
**Rekomendasi:** Remove duplicate:
```typescript
async create() {
// ...
jenisKelaminResponden.create.loading = true; // ✅ Keep only this
try {
// Remove duplicate line
const res = await ApiFetch.api.landingpage.jeniskelaminresponden["create"].post(form);
// ...
}
}
```
**Priority:** 🟢 Low
**Effort:** Low (ada di 3 master data states)
---
#### **10. Inconsistent Toast Messages**
**Lokasi:** State file
**Masalah:**
```typescript
// Line ~45 (responden.create)
toast.success("Responden berhasil ditambahkan");
// Line ~295 (jenisKelaminResponden.create)
toast.success("Jenis kelamin responden berhasil ditambahkan");
// Line ~400 (pilihanRatingResponden.create)
toast.success("Jenis kelamin responden berhasil ditambahkan"); // ❌ Wrong message!
// Line ~505 (kelompokUmurResponden.create)
toast.success("Kelompok umur responden berhasil ditambahkan");
```
**Issue:** Copy-paste error di pilihanRatingResponden (masih "Jenis kelamin responden").
**Rekomendasi:** Fix message:
```typescript
toast.success("Pilihan rating responden berhasil ditambahkan");
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **11. Missing Edit Page untuk Master Data**
**Lokasi:** Module structure
**Masalah:**
- ✅ Responden: Create, Edit, Detail, Delete
- ❌ Jenis Kelamin: Create, Delete (NO EDIT)
- ❌ Rating: Create, Delete (NO EDIT)
- ❌ Kelompok Umur: Create, Delete (NO EDIT)
**Issue:** Master data tidak bisa diedit, hanya bisa delete & create ulang.
**Rekomendasi:** Consider adding edit pages untuk master data jika diperlukan:
```typescript
// Add edit method di state (sudah ada)
// Add edit page di UI
/admin/ppid/indeks-kepuasan-masyarakat/jenis-kelamin/[id]/edit
```
**Priority:** 🟢 Low (business decision)
**Effort:** Medium
---
#### **12. Search Placeholder Tidak Spesifik**
**Lokasi:** `responden/page.tsx`
**Masalah:**
```typescript
// Line ~30-35
<HeaderSearch
title="Data Responden"
placeholder="Cari nama responden..." // ✅ Actually pretty specific!
// ...
/>
```
**Verdict:****SUDAH BENAR** - Placeholder sudah spesifik!
**Priority:** 🟢 None
**Effort:** None
---
#### **13. Chart Color Hardcoding**
**Lokasi:** `grafik-kepuasan-masyarakat/page.tsx`
**Masalah:**
```typescript
// Line ~55-60
setDonutDataJenisKelamin([
{ name: 'Laki-laki', value: totalLaki, color: colors['blue-button'] },
{ name: 'Perempuan', value: totalPerempuan, color: '#10A85AFF' }, // ❌ Hardcoded
]);
setDonutDataRating([
{ name: 'Sangat Baik', value: totalSangatBaik, color: colors['blue-button'] },
{ name: 'Baik', value: totalBaik, color: '#10A85AFF' }, // ❌ Hardcoded
{ name: 'Kurang Baik', value: totalKurangBaik, color: '#FFA500' }, // ❌ Hardcoded
{ name: 'Sangat Kurang Baik', value: totalSangatKurangBaik, color: '#FF4500' }, // ❌ Hardcoded
]);
```
**Rekomendasi:** Define color constants:
```typescript
// con/colors.ts atau file terpisah
export const chartColors = {
primary: colors['blue-button'],
success: '#10A85AFF',
warning: '#FFA500',
danger: '#FF4500',
};
// Use in chart data
{ name: 'Perempuan', value: totalPerempuan, color: chartColors.success },
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **14. Date Parsing di Detail Page**
**Lokasi:** `responden/[id]/page.tsx`
**Masalah:**
```typescript
// Line ~65-70
<Text fz="md" c="dimmed">{
stateDetail.findUnique.data?.tanggal
? new Date(stateDetail.findUnique.data.tanggal).toLocaleDateString('id-ID')
: '-'
}</Text>
```
**Verdict:****SUDAH BENAR** - Date formatting yang proper!
**Priority:** 🟢 None
**Effort:** None
---
## 📋 RINGKASAN ACTION ITEMS
| Priority | Issue | Module | Impact | Effort | Status |
|----------|-------|--------|--------|--------|--------|
| 🔴 P0 | **Schema deletedAt default SALAH (5 models)** | Schema | **CRITICAL** | Medium | **MUST FIX** |
| 🔴 P0 | Fetch method inconsistency | State | Medium | Medium | Perlu refactor |
| 🟡 M | Type safety (any usage) | State | Low | Low | Optional |
| 🟡 M | Console.log in production | State | Low | Low | Optional |
| 🟡 M | Missing loading state di edit submit | UI | Low | Low | Should fix |
| 🟡 M | Pagination missing search param | UI | Low | Low | Should fix |
| 🟢 L | Duplicate loading state assignment | State | Low | Low | Optional |
| 🟢 L | Inconsistent toast messages | State | Low | Low | Should fix |
| 🟢 L | Missing edit page untuk master data | UI | Low | Medium | Optional |
| 🟢 L | Chart color hardcoding | UI | Low | Low | Optional |
---
## ✅ KESIMPULAN
### **Overall Quality: 🟢 BAIK (8/10)**
**Strengths:**
1.**Grafik & Charts EXCELLENT** - Best chart implementation di semua modul PPID!
2.**Data processing comprehensive** - Automatic calculation dari data responden
3.**3 Distribusi Charts** - Jenis Kelamin, Penilaian, Kelompok Umur
4.**Bar Chart Tren** - Monthly respondent trends
5. ✅ UI/UX clean & responsive
6. ✅ Form validation comprehensive
7. ✅ State management dengan ApiFetch untuk create & findMany
8.**Edit form EXCELLENT** - Reusable ControlledSelect component
9. ✅ Original data tracking untuk reset form
10. ✅ Master data management proper (3 tables)
11. ✅ Loading state management dengan finally block
12. ✅ Mobile cards responsive
**Critical Issues:**
1. ⚠️ **Schema deletedAt default SALAH** - 5 models affected (CRITICAL)
2. ⚠️ Fetch method pattern inconsistency (ApiFetch vs fetch manual)
3. ⚠️ Type safety (any usage di findMany)
**Areas for Improvement:**
1. ⚠️ **Fix schema deletedAt** untuk 5 models dari `@default(now())` ke `@default(null)` dengan nullable
2. ⚠️ **Refactor fetch methods** untuk gunakan ApiFetch consistently
3. ⚠️ **Improve type safety** dengan remove `any` usage
4. ⚠️ **Add loading state** di edit submit button
5. ⚠️ **Fix duplicate loading state** di master data create methods
6. ⚠️ **Fix copy-paste toast message** di pilihanRatingResponden
**Recommended Next Steps:**
1. **🔴 CRITICAL: Fix schema deletedAt** untuk 5 models - 1 jam (perlu migration)
2. **🔴 HIGH: Refactor findUnique, update** ke ApiFetch - 1 jam
3. **🟡 MEDIUM: Improve type safety** - 30 menit
4. **🟡 MEDIUM: Add loading state** di edit submit - 10 menit
5. **🟡 MEDIUM: Fix pagination search param** - 10 menit
6. **🟢 LOW: Fix duplicate loading state** - 15 menit
7. **🟢 LOW: Fix toast message** - 5 menit
8. **🟢 LOW: Define chart color constants** - 15 menit
---
## 📈 COMPARISON WITH OTHER MODULES
| Module | Charts | Data Processing | Edit Form | State | Schema | Overall |
|--------|--------|----------------|-----------|-------|--------|---------|
| Profil | ❌ None | N/A | ✅ Good | ⚠️ Good | ⚠️ deletedAt | 🟢 |
| Desa Anti Korupsi | ❌ None | N/A | ✅ Good | ⚠️ Good | ⚠️ deletedAt | 🟢 |
| SDGs Desa | ❌ None | N/A | ✅ Good | ⚠️ Good | ⚠️ deletedAt | 🟢 |
| APBDes | ❌ None | ✅ Items hierarchy | ✅ Good | ⚠️ Good | ✅ Good | 🟢 |
| Prestasi Desa | ❌ None | N/A | ✅ Good | ⚠️ Good | ❌ WRONG | 🟢 |
| PPID Profil | ❌ None | N/A | ✅ **Excellent** | ✅ **Best** | ❌ WRONG | 🟢⭐ |
| Struktur PPID | ❌ None | N/A | ✅ Good | ✅ Good | ⚠️ Inconsistent | 🟢 |
| Visi Misi PPID | ❌ None | N/A | ✅ Good | ✅ **Best** | ❌ WRONG | 🟢⭐⭐ |
| Dasar Hukum PPID | ❌ None | N/A | ✅ Good | ✅ **Best** | ❌ WRONG | 🟢⭐⭐ |
| Permohonan Informasi | ❌ None | N/A | ❌ Missing | ⚠️ Good | ❌ **4 models WRONG** | 🟡 |
| Permohonan Keberatan | ❌ None | N/A | ❌ Missing | ⚠️ Good | ❌ WRONG | 🟡 |
| Daftar Informasi | ❌ None | N/A | ✅ Good | ⚠️ Good | ❌ WRONG | 🟢 |
| **IKM (Indeks Kepuasan)** | ✅ **EXCELLENT** | ✅ **EXCELLENT** | ✅ **Excellent** | ⚠️ Good | ❌ **5 models WRONG** | 🟢 |
**IKM Highlights:**
-**BEST CHARTS** - Mantine Charts (PieChart, BarChart)
-**BEST DATA PROCESSING** - Automatic calculation & grouping
-**BEST EDIT FORM** - Reusable ControlledSelect component
- ⚠️ **5 models affected** - deletedAt issue (most affected module!)
---
## 🎯 UNIQUE FEATURES OF IKM MODULE
**Most Advanced Data Visualization:**
1.**Mantine Charts** - PieChart & BarChart (UNIQUE!)
2.**3 Distribusi Charts** - Jenis Kelamin, Penilaian, Kelompok Umur
3.**Monthly Trend Chart** - Bar chart dengan grouping
4.**Automatic Calculation** - Filter & count dari data
5.**Reusable Select Component** - ControlledSelect di edit form
6.**3 Master Data Tables** - Jenis Kelamin, Rating, Kelompok Umur
**Best Practices:**
1.**Chart implementation** - Best practice untuk data visualization
2.**Data processing** - Comprehensive calculation & grouping
3.**Reusable components** - ControlledSelect untuk dropdowns
4.**Loading state management** - Proper dengan finally block
5.**Original data tracking** - Edit form reset yang proper
6.**Master data management** - Separate states untuk masing-masing
**Critical Issues:**
1.**5 models dengan deletedAt SALAH** - Most affected module!
2.**Fetch pattern inconsistency** - findUnique, update pakai fetch manual
3.**Type safety** - any usage di findMany
---
**Catatan:** **IKM adalah MODULE DENGAN CHARTS & DATA VISUALIZATION TERBAIK** dengan Mantine Charts implementation yang excellent. Module ini juga punya **BEST EDIT FORM** dengan reusable ControlledSelect component. Tapi juga **MODULE DENGAN PALING BANYAK MODEL AFFECTED** oleh deletedAt issue (5 models!).
**Unique Strengths:**
1.**Charts EXCELLENT** - Best data visualization
2.**Data processing** - Automatic calculation & grouping
3.**Edit form EXCELLENT** - Reusable ControlledSelect
4.**Master data management** - 3 separate tables
5.**Monthly trends** - Bar chart dengan grouping
**Priority Action:**
```diff
🔴 FIX INI SEKARANG (1 JAM + MIGRATION):
File: prisma/schema.prisma
Line: 266-297
# Fix 5 models:
model Responden {
// ...
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
model JenisKelaminResponden {
// ...
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
model PilihanRatingResponden {
// ...
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
model UmurResponden {
// ...
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
# Lalu jalankan:
bunx prisma db push
# atau
bunx prisma migrate dev --name fix_deletedat_ikm
```
Setelah fix critical issues, module ini **PRODUCTION-READY** dengan **BEST CHARTS & DATA VISUALIZATION**! 🎉
---
## 📚 RECOMMENDED AS REFERENCE FOR OTHER MODULES
**IKM Module adalah BEST PRACTICE untuk:**
1.**Charts & Data Visualization** - Mantine Charts implementation
2.**Data Processing** - Automatic calculation & grouping
3.**Reusable Components** - ControlledSelect untuk dropdowns
4.**Edit Form** - Original data tracking dengan reusable components
5.**Master Data Management** - Separate states untuk multiple tables
**Modules lain bisa belajar dari IKM:**
- **ALL MODULES WITH CHARTS:** Use Mantine Charts (PieChart, BarChart)
- **ALL MODULES WITH DROPDOWNS:** Use reusable ControlledSelect component
- **ALL MODULES:** Automatic data calculation untuk charts
- **ALL MODULES:** Master data management dengan separate states
- **ALL MODULES:** Edit form dengan original data tracking
---
**File Location:** `QC/PPID/QC-IKM-MODULE.md` 📄

View File

@@ -1,844 +0,0 @@
# QC Summary - Permohonan Informasi Publik PPID Module
**Scope:** List Permohonan Informasi Publik, Detail Permohonan
**Date:** 2026-02-23
**Status:** ✅ Secara umum sudah baik, ada beberapa improvement yang diperlukan
---
## 📊 OVERVIEW
| Aspect | Schema | API | UI Admin | State Management | Overall |
|--------|--------|-----|----------|-----------------|---------|
| Permohonan Informasi Publik | ⚠️ Ada issue | ✅ Baik | ✅ Baik | ⚠️ Ada issue | 🟡 Perlu fix |
---
## ✅ YANG SUDAH BAIK
### **1. UI/UX Design**
- ✅ Preview layout yang clean dengan responsive design
- ✅ Loading states dengan Skeleton
- ✅ Empty state handling yang informatif dengan icon
- ✅ Search functionality dengan debounce (1000ms)
- ✅ Pagination yang konsisten
- ✅ Desktop table + mobile cards responsive
- ✅ Icon integration (User, ID, Phone, Info) untuk visual clarity
### **2. Table & Card Layout**
- ✅ Fixed layout table untuk consistency
- ✅ Column headers dengan icon yang descriptive
- ✅ Row numbering otomatis (index + 1)
- ✅ Text truncation dengan lineClamp untuk long text
- ✅ Mobile card view dengan proper information hierarchy
**Code Example (✅ GOOD):**
```typescript
// page.tsx - Line ~130-180
<Table highlightOnHover
layout="fixed" // ✅ PENTING - consistent column widths
withColumnBorders={false}>
<TableThead>
<TableTr>
<TableTh fz="sm" fw={600} ta="center" w={60}>No</TableTh>
<TableTh fz="sm" fw={600}>
<Group gap={5}>
<IconUser size={16} />
Nama
</Group>
</TableTh>
<TableTh fz="sm" fw={600}>
<Group gap={5}>
<IconId size={16} />
NIK
</Group>
</TableTh>
// ...
</TableTr>
</TableThead>
```
**Verdict:****BAIK** - Table layout dengan icon yang helpful!
---
### **3. State Management**
- ✅ Proper typing dengan Prisma types
- ✅ Loading state management dengan finally block
- ✅ Error handling yang comprehensive
-**ApiFetch consistency** untuk create & findMany! ✅
- ✅ Zod validation untuk form data dengan specific rules
- ✅ Separate proxy states untuk related data (jenisInformasi, caraMemperoleh, dll)
**Code Example (✅ GOOD):**
```typescript
// state file - Line ~110-150
findMany: {
data: null as Prisma.PermohonanInformasiPublikGetPayload<{...}>[] | null,
page: 1,
totalPages: 1,
total: 0,
loading: false,
search: "",
load: async (page = 1, limit = 10, search = "") => {
statepermohonanInformasiPublik.findMany.loading = true; // ✅ Start loading
statepermohonanInformasiPublik.findMany.page = page;
statepermohonanInformasiPublik.findMany.search = search;
try {
const query: any = { page, limit };
if (search) query.search = search;
const res = await ApiFetch.api.ppid.permohonaninformasipublik["find-many"].get({ query });
if (res.status === 200 && res.data?.success) {
statepermohonanInformasiPublik.findMany.data = res.data.data || [];
statepermohonanInformasiPublik.findMany.total = res.data.total || 0;
statepermohonanInformasiPublik.findMany.totalPages = res.data.totalPages || 1;
}
} catch (error) {
console.error("Error loading permohonan:", error);
statepermohonanInformasiPublik.findMany.data = [];
// ...
} finally {
statepermohonanInformasiPublik.findMany.loading = false; // ✅ Stop loading
}
},
}
```
**Verdict:****BAIK** - State management sudah proper dengan ApiFetch!
---
### **4. Zod Schema Validation**
- ✅ Comprehensive validation untuk semua fields
- ✅ Specific error messages untuk setiap field
- ✅ Phone number length validation (3-15 chars)
- ✅ NIK length validation (3-16 chars)
- ✅ Email format validation
- ✅ Required field validation untuk dropdowns
**Code Example (✅ EXCELLENT):**
```typescript
// state file - Line ~8-22
const templateForm = z.object({
name: z.string().min(3, "Nama minimal 3 karakter"),
nik: z
.string()
.min(3, "NIK minimal 3 karakter")
.max(16, "NIK maksimal 16 angka"), // ✅ Specific validation
notelp: z
.string()
.min(3, "Nomor Telepon minimal 3 karakter")
.max(15, "Nomor Telepon maksimal 15 angka"), // ✅ Specific validation
alamat: z.string().min(3, "Alamat minimal 3 karakter"),
email: z.string().min(3, "Email minimal 3 karakter"),
jenisInformasiDimintaId: z.string().nonempty(), // ✅ Required dropdown
caraMemperolehInformasiId: z.string().nonempty(), // ✅ Required dropdown
caraMemperolehSalinanInformasiId: z.string().nonempty(), // ✅ Required dropdown
});
```
**Verdict:****EXCELLENT** - Validation yang comprehensive!
---
### **5. Related Data Management**
- ✅ Separate proxy states untuk dropdown data
- ✅ JenisInformasiDiminta, CaraMemperolehInformasi, CaraMemperolehSalinanInformasi
- ✅ Proper typing dengan Prisma types
- ✅ ApiFetch consistency untuk load dropdown data
**Code Example (✅ GOOD):**
```typescript
// state file - Line ~24-40
const jenisInformasiDiminta = proxy({
findMany: {
data: null as Prisma.JenisInformasiDimintaGetPayload<{ omit: { isActive: true } }>[] | null,
async load() {
const res = await ApiFetch.api.ppid.permohonaninformasipublik.jenisInformasi["find-many"].get();
if (res.status === 200) {
jenisInformasiDiminta.findMany.data = res.data?.data ?? [];
}
},
},
});
```
**Verdict:****BAIK** - Related data management yang proper!
---
## ⚠️ ISSUES & SARAN PERBAIKAN
### **🔴 CRITICAL**
#### **1. Schema - deletedAt Default Value SALAH (MULTIPLE MODELS)**
**Lokasi:** `prisma/schema.prisma` (line 435-467)
**Masalah:**
```prisma
model PermohonanInformasiPublik {
// ...
deletedAt DateTime @default(now()) // ❌ SALAH - selalu punya default value
isActive Boolean @default(true)
}
model JenisInformasiDiminta {
// ...
deletedAt DateTime @default(now()) // ❌ SALAH
isActive Boolean @default(true)
}
model CaraMemperolehInformasi {
// ...
deletedAt DateTime @default(now()) // ❌ SALAH
isActive Boolean @default(true)
}
model CaraMemperolehSalinanInformasi {
// ...
deletedAt DateTime @default(now()) // ❌ SALAH
isActive Boolean @default(true)
}
```
**Dampak:**
- **LOGIC ERROR!** Setiap record baru langsung punya `deletedAt` value (timestamp creation)
- Soft delete tidak berfungsi dengan benar
- Query dengan `where: { deletedAt: null }` tidak akan pernah return data
- Data yang "dihapus" vs data "aktif" tidak bisa dibedakan
- **4 models affected!** (PermohonanInformasiPublik + 3 related models)
**Rekomendasi:** Fix semua schema:
```prisma
model PermohonanInformasiPublik {
// ...
deletedAt DateTime? @default(null) // ✅ Nullable, null = not deleted
isActive Boolean @default(true)
}
model JenisInformasiDiminta {
// ...
deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
model CaraMemperolehInformasi {
// ...
deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
model CaraMemperolehSalinanInformasi {
// ...
deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
```
**Priority:** 🔴 **CRITICAL**
**Effort:** Medium (perlu migration untuk 4 models)
**Impact:** **HIGH** (data integrity & soft delete logic)
---
#### **2. State Management - Fetch Pattern Inconsistency**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/permohonan_informasi_publik/permohonanInformasiPublik.ts`
**Masalah:** Ada 2 pattern berbeda untuk fetch API:
```typescript
// ❌ Pattern 1: ApiFetch (create, findMany, dropdowns)
const res = await ApiFetch.api.ppid.permohonaninformasipublik["create"].post(form);
const res = await ApiFetch.api.ppid.permohonaninformasipublik["find-many"].get({ query });
const res = await ApiFetch.api.ppid.permohonaninformasipublik.jenisInformasi["find-many"].get();
// ❌ Pattern 2: fetch manual (findUnique)
const res = await fetch(`/api/ppid/permohonaninformasipublik/${id}`);
```
**Dampak:**
- Code consistency buruk
- Sulit maintenance
- Type safety tidak konsisten
- Duplikasi logic error handling
**Rekomendasi:** Gunakan **ApiFetch** untuk semua operasi:
```typescript
// ✅ Unified pattern
async load(id: string) {
try {
const res = await ApiFetch.api.ppid.permohonaninformasipublik[id].get();
if (res.data?.success) {
statepermohonanInformasiPublik.findUnique.data = res.data.data;
} else {
toast.error(res.data?.message || "Gagal memuat data");
}
} catch (error) {
console.error("Error:", error);
toast.error("Gagal memuat data");
}
}
```
**Priority:** 🔴 High
**Effort:** Medium (refactor di findUnique method)
---
#### **3. Console.log di Production**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/permohonan_informasi_publik/permohonanInformasiPublik.ts`
**Masalah:**
```typescript
// Line ~70
console.log(caraMemperolehSalinanInformasi); // ❌ Debug log
// Line ~160
console.error("Failed to load permohonan keberatan informasi:", res.data?.message);
// Line ~165
console.error("Error loading permohonan keberatan informasi:", error);
// Line ~185
console.error("Failed to fetch program inovasi:", res.statusText);
// Line ~188
console.error("Error fetching program inovasi:", error);
```
**Rekomendasi:** Gunakan conditional logging:
```typescript
if (process.env.NODE_ENV === 'development') {
console.error("Error:", error);
}
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **4. Missing Delete/Hard Delete Protection**
**Lokasi:** `page.tsx`, `[id]/page.tsx`
**Masalah:**
- ❌ Tidak ada tombol delete untuk Permohonan Informasi (correct - read-only data)
-**GOOD:** Read-only pattern yang benar untuk data permohonan
- ⚠️ **ISSUE:** Tidak ada fitur untuk mark sebagai "processed" atau "completed"
**Issue:** User tidak bisa update status permohonan (pending → processed → completed).
**Rekomendasi:** Add status management:
```prisma
// Add to schema
model PermohonanInformasiPublik {
// ...
status String @default("pending") // pending, processed, completed
processedAt DateTime?
processedBy String?
}
```
```typescript
// Add action buttons di detail page
<Group>
<Button color="yellow" onClick={() => updateStatus("processed")}>
Mark as Processed
</Button>
<Button color="green" onClick={() => updateStatus("completed")}>
Mark as Completed
</Button>
</Group>
```
**Priority:** 🔴 Medium
**Effort:** Medium (perlu schema change + UI update)
---
### **🟡 MEDIUM**
#### **5. Type Safety - Any Usage**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/permohonan_informasi_publik/permohonanInformasiPublik.ts`
**Masalah:**
```typescript
// Line ~145
const query: any = { page, limit }; // ❌ Using 'any'
if (search) query.search = search;
```
**Rekomendasi:** Gunakan typed query:
```typescript
// Define type
interface FindManyQuery {
page: number | string;
limit?: number | string;
search?: string;
}
// Use typed query
const query: FindManyQuery = { page, limit };
if (search) query.search = search;
```
**Priority:** 🟡 Medium
**Effort:** Low
---
#### **6. Error Message Tidak Konsisten**
**Lokasi:** Multiple places
**Masalah:**
```typescript
// Line ~160
console.error("Failed to load permohonan keberatan informasi:", res.data?.message);
// ⚠️ Wrong module name - ini "permohonan informasi publik" bukan "keberatan"
// Line ~165
console.error("Error loading permohonan keberatan informasi:", error);
// ⚠️ Same issue
// Line ~185
console.error("Failed to fetch program inovasi:", res.statusText);
// ⚠️ Wrong module name - ini "permohonan informasi" bukan "program inovasi"
// Line ~188
console.error("Error fetching program inovasi:", error);
// ⚠️ Same issue
```
**Issue:** Copy-paste error dari module lain!
**Rekomendasi:** Fix error messages:
```typescript
console.error("Failed to load permohonan informasi publik:", res.data?.message);
console.error("Error loading permohonan informasi publik:", error);
console.error("Failed to fetch permohonan informasi:", res.statusText);
console.error("Error fetching permohonan informasi:", error);
```
**Priority:** 🟡 Medium
**Effort:** Low
---
#### **7. Pagination onChange Tidak Include Search**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~250-260
<Pagination
value={page}
onChange={(newPage) => {
load(newPage, 10); // ⚠️ Missing search parameter
window.scrollTo(0, 0);
}}
total={totalPages}
// ...
/>
```
**Issue:** Saat ganti page, search query hilang.
**Rekomendasi:** Include search:
```typescript
onChange={(newPage) => {
load(newPage, 10, debouncedSearch); // ✅ Include search
window.scrollTo(0, 0);
}}
```
**Priority:** 🟡 Low
**Effort:** Low
---
### **🟢 LOW (Minor Polish)**
#### **8. Missing Loading State di Detail Page**
**Lokasi:** `[id]/page.tsx`
**Masalah:**
```typescript
// Line ~20-25
useShallowEffect(() => {
state.findUnique.load(params?.id as string)
}, [params?.id])
if (!state.findUnique.data) {
return (
<Stack py={10}>
<Skeleton height={500} radius="md" />
</Stack>
)
}
```
**Issue:** Skeleton ditampilkan untuk semua kondisi (loading, error, not found).
**Rekomendasi:** Add proper loading state:
```typescript
if (state.findUnique.loading) {
return (
<Stack py={10}>
<Skeleton height={500} radius="md" />
</Stack>
);
}
if (!state.findUnique.data) {
return (
<Alert icon={<IconAlertCircle />} color="red">
Data tidak ditemukan
</Alert>
);
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **9. Duplicate Error Logging**
**Lokasi:** `page.tsx`, state file
**Masalah:**
```typescript
// page.tsx - Line ~160-165
console.error("Failed to load permohonan keberatan informasi:", res.data?.message);
console.error("Error loading permohonan keberatan informasi:", error);
// state file - Line ~185-188
console.error("Failed to fetch program inovasi:", res.statusText);
console.error("Error fetching program inovasi:", error);
```
**Rekomendasi:** Cukup satu logging yang informatif:
```typescript
console.error('Failed to load Permohonan Informasi Publik:', err);
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **10. Search Placeholder Tidak Spesifik**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~70, 110
<TextInput
placeholder={"Cari nama..."} // ⚠️ Generic
// ...
/>
```
**Rekomendasi:** Lebih spesifik:
```typescript
placeholder={"Cari nama pemohon..."}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **11. Missing Data Relationships di Detail Page**
**Lokasi:** `[id]/page.tsx`
**Masalah:**
```typescript
// Line ~60-90
<Box>
<Text fz="lg" fw="bold" mb={4}>Jenis Informasi</Text>
<Text fz="md" c="dimmed">{data.jenisInformasiDiminta?.name || '-'}</Text>
</Box>
<Box>
<Text fz="lg" fw="bold" mb={4}>Cara Akses Informasi</Text>
<Text fz="md" c="dimmed">{data.caraMemperolehInformasi?.name || '-'}</Text>
</Box>
<Box>
<Text fz="lg" fw="bold" mb={4}>Cara Akses Salinan Informasi</Text>
<Text fz="md" c="dimmed">{data.caraMemperolehSalinanInformasi?.name || '-'}</Text>
</Box>
```
**Issue:** Tidak menampilkan data `alamat` yang ada di schema.
**Rekomendasi:** Add missing field:
```typescript
<Box>
<Text fz="lg" fw="bold" mb={4}>Alamat</Text>
<Text fz="md" c="dimmed">{data.alamat || '-'}</Text>
</Box>
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **12. Unused Console.log**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/permohonan_informasi_publik/permohonanInformasiPublik.ts`
**Masalah:**
```typescript
// Line ~70
console.log(caraMemperolehSalinanInformasi); // ❌ Debug log yang tidak terpakai
```
**Rekomendasi:** Remove:
```typescript
// Remove this line completely
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **13. Missing Empty State Icon di Mobile**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~60-75 (Desktop empty state)
<Stack align="center" py="xl" ta="center">
<IconInfoCircle size={40} stroke={1.5} color={colors['blue-button']} />
<Text fz={{ base: 'sm', md: 'md' }} fw={500} c="dimmed" lh={1.5}>
{search
? 'Tidak ditemukan data yang sesuai dengan pencarian'
: 'Belum ada permohonan yang tercatat'
}
</Text>
</Stack>
// Line ~120-130 (Mobile - missing icon)
<Stack align="center" py={{ base: 'xl', md: 'xl' }}>
<IconInfoCircle size={40} stroke={1.5} color={colors['blue-button']} />
// ✅ Icon ada di sini juga
<Text fz={{ base: 'sm', md: 'md' }} fw={500} c="dimmed" lh={1.5}>
Belum ada permohonan informasi yang tercatat
</Text>
</Stack>
```
**Verdict:****SUDAH BENAR** - Icon ada di kedua empty states!
**Priority:** 🟢 None
**Effort:** None
---
## 📋 RINGKASAN ACTION ITEMS
| Priority | Issue | Module | Impact | Effort | Status |
|----------|-------|--------|--------|--------|--------|
| 🔴 P0 | **Schema deletedAt default SALAH (4 models)** | Schema | **CRITICAL** | Medium | **MUST FIX** |
| 🔴 P0 | Fetch method inconsistency | State | Medium | Medium | Perlu refactor |
| 🔴 P1 | Missing status management | UI/Schema | Medium | Medium | Should add |
| 🟡 M | Console.log in production | State | Low | Low | Optional |
| 🟡 M | Type safety (any usage) | State | Low | Low | Optional |
| 🟡 M | Error message inconsistency (copy-paste) | State | Low | Low | Should fix |
| 🟡 M | Pagination missing search param | UI | Low | Low | Should fix |
| 🟢 L | Missing loading state di detail page | UI | Low | Low | Optional |
| 🟢 L | Duplicate error logging | UI/State | Low | Low | Optional |
| 🟢 L | Search placeholder tidak spesifik | UI | Low | Low | Optional |
| 🟢 L | Missing alamat field di detail page | UI | Low | Low | Optional |
| 🟢 L | Unused console.log | State | Low | Low | Optional |
---
## ✅ KESIMPULAN
### **Overall Quality: 🟢 BAIK (7.5/10)**
**Strengths:**
1. ✅ UI/UX clean & responsive
2. ✅ Table layout dengan icon yang helpful
3. ✅ Search functionality dengan debounce
4. ✅ Empty state handling yang informatif
5.**Zod validation comprehensive** dengan specific rules
6.**Related data management** proper (dropdowns)
7. ✅ State management dengan ApiFetch untuk create & findMany
8. ✅ Loading state management dengan finally block
9. ✅ Mobile cards responsive
**Critical Issues:**
1. ⚠️ **Schema deletedAt default SALAH** - 4 models affected (CRITICAL)
2. ⚠️ Fetch method pattern inconsistency (ApiFetch vs fetch manual)
3. ⚠️ Missing status management untuk permohonan (pending → processed → completed)
**Areas for Improvement:**
1. ⚠️ **Fix schema deletedAt** untuk 4 models dari `@default(now())` ke `@default(null)` dengan nullable
2. ⚠️ **Refactor fetch methods** untuk gunakan ApiFetch consistently
3. ⚠️ **Add status management** untuk tracking status permohonan
4. ⚠️ **Fix error messages** (copy-paste error dari module lain)
5. ⚠️ **Improve type safety** dengan remove `any` usage
**Recommended Next Steps:**
1. **🔴 CRITICAL: Fix schema deletedAt** untuk 4 models - 1 jam (perlu migration)
2. **🔴 HIGH: Refactor findUnique** ke ApiFetch - 30 menit
3. **🔴 HIGH: Add status management** - 1 jam (schema + UI)
4. **🟡 MEDIUM: Fix error messages** (copy-paste) - 10 menit
5. **🟢 LOW: Add pagination search param** - 10 menit
6. **🟢 LOW: Polish minor issues** - 30 menit
---
## 📈 COMPARISON WITH OTHER MODULES
| Module | Fetch Pattern | State | Validation | Schema | Status Mgmt | Overall |
|--------|--------------|-------|------------|--------|-------------|---------|
| Profil | ⚠️ Mixed | ⚠️ Good | ✅ Good | ⚠️ deletedAt | N/A | 🟢 |
| Desa Anti Korupsi | ⚠️ Mixed | ⚠️ Good | ✅ Good | ⚠️ deletedAt | N/A | 🟢 |
| SDGs Desa | ⚠️ Mixed | ⚠️ Good | ✅ Good | ⚠️ deletedAt | N/A | 🟢 |
| APBDes | ⚠️ Mixed | ⚠️ Good | ✅ Good | ✅ Good | N/A | 🟢 |
| Prestasi Desa | ⚠️ Mixed | ⚠️ Good | ✅ Good | ❌ WRONG | N/A | 🟢 |
| PPID Profil | ⚠️ Mixed | ✅ Best | ✅ Good | ❌ WRONG | N/A | 🟢⭐ |
| Struktur PPID | ⚠️ Mixed | ✅ Good | ✅ Good | ⚠️ Inconsistent | ✅ Active/Non-active | 🟢 |
| Visi Misi PPID | ✅ **100% ApiFetch!** | ✅ Best | ✅ Good | ❌ WRONG | N/A | 🟢⭐⭐ |
| Dasar Hukum PPID | ✅ **100% ApiFetch!** | ✅ Best | ✅ Good | ❌ WRONG | N/A | 🟢⭐⭐ |
| **Permohonan Informasi** | ⚠️ Mixed | ⚠️ Good | ✅ **Best** | ❌ **4 models WRONG** | ❌ Missing | 🟡 |
**Permohonan Informasi PPID Highlights:**
-**Best validation** - Comprehensive Zod schema dengan specific rules
-**Related data management** - Separate proxy states untuk dropdowns
-**Icon integration** - Table headers dengan icon yang helpful
- ⚠️ **4 models affected** - deletedAt issue (most affected module!)
- ⚠️ **Missing status management** - No workflow tracking
- ⚠️ **Copy-paste errors** - Error messages dari module lain
---
## 🎯 UNIQUE FEATURES OF PERMOHONAN INFORMASI MODULE
**Most Complex Data Structure:**
1.**3 related dropdown models** - JenisInformasi, CaraMemperoleh, CaraMemperolehSalinan
2.**Comprehensive validation** - Phone length, NIK length, email format
3.**Icon integration** - User, ID, Phone, Info icons di table headers
4.**Auto-increment nomor** - Automatic numbering system
5.**Missing status workflow** - Should have pending → processed → completed
**Best Practices:**
1.**Validation comprehensive** - Best Zod schema dengan specific rules
2.**Related data management** - Separate proxy states
3.**Icon integration** - Visual clarity di table headers
4.**Loading state management** - Proper dengan finally block
**Critical Issues:**
1.**4 models dengan deletedAt SALAH** - Most affected module!
2.**Fetch pattern inconsistency** - findUnique pakai fetch manual
3.**Missing status workflow** - No tracking untuk permohonan status
4.**Copy-paste error messages** - Dari module lain
---
**Catatan:** **Permohonan Informasi PPID adalah MODULE DENGAN VALIDATION TERBAIK** tapi juga **MODULE DENGAN PALING BANYAK MODEL AFFECTED** oleh deletedAt issue (4 models!). Module ini butuh status management workflow untuk tracking status permohonan.
**Unique Strengths:**
1.**Best validation** - Comprehensive Zod schema
2.**Related data management** - 3 dropdown models handled properly
3.**Icon integration** - Visual clarity
4.**Auto-increment nomor** - Automatic numbering
**Priority Action:**
```diff
🔴 FIX INI SEKARANG (1 JAM + MIGRATION):
File: prisma/schema.prisma
Line: 435-467
model PermohonanInformasiPublik {
// ...
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
model JenisInformasiDiminta {
// ...
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
model CaraMemperolehInformasi {
// ...
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
model CaraMemperolehSalinanInformasi {
// ...
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
# Lalu jalankan:
bunx prisma db push
# atau
bunx prisma migrate dev --name fix_deletedat_permohonan_informasi
```
```diff
🔴 ADD STATUS MANAGEMENT (1 JAM):
File: prisma/schema.prisma
model PermohonanInformasiPublik {
// ...
+ status String @default("pending") // pending, processed, completed
+ processedAt DateTime?
+ processedBy String?
}
```
Setelah fix critical issues, module ini **PRODUCTION-READY** dengan **BEST VALIDATION**! 🎉
---
## 📚 RECOMMENDED AS REFERENCE FOR OTHER MODULES
**Permohonan Informasi PPID Module adalah BEST PRACTICE untuk:**
1.**Comprehensive validation** - Zod schema dengan specific rules (phone, NIK length)
2.**Related data management** - Separate proxy states untuk dropdowns
3.**Icon integration** - Visual clarity di table headers
4.**Auto-increment numbering** - Automatic nomor urut
**Modules lain bisa belajar dari Permohonan Informasi:**
- **ALL MODULES:** Use specific validation rules (min/max length)
- **MODULES WITH DROPDOWNS:** Separate proxy states untuk related data
- **ALL MODULES:** Icon integration untuk visual clarity
- **ALL MODULES:** Auto-increment untuk numbering systems
---
**File Location:** `QC/PPID/QC-PERMOHONAN-INFORMASI-PUBLIK-MODULE.md` 📄

View File

@@ -1,771 +0,0 @@
# QC Summary - Permohonan Keberatan Informasi Publik PPID Module
**Scope:** List Permohonan Keberatan, Detail Permohonan Keberatan
**Date:** 2026-02-23
**Status:** ✅ Secara umum sudah baik, ada beberapa improvement yang diperlukan
---
## 📊 OVERVIEW
| Aspect | Schema | API | UI Admin | State Management | Overall |
|--------|--------|-----|----------|-----------------|---------|
| Permohonan Keberatan | ⚠️ Ada issue | ✅ Baik | ✅ Baik | ⚠️ Ada issue | 🟡 Perlu fix |
---
## ✅ YANG SUDAH BAIK
### **1. UI/UX Design**
- ✅ Preview layout yang clean dengan responsive design
- ✅ Loading states dengan Skeleton
- ✅ Empty state handling yang informatif dengan icon
- ✅ Search functionality dengan debounce (1000ms)
- ✅ Pagination yang konsisten
- ✅ Desktop table + mobile cards responsive
- ✅ Icon integration (User, Mail, Phone, Info) untuk visual clarity
- ✅ Consistent empty state messages
### **2. Table & Card Layout**
- ✅ Fixed layout table untuk consistency
- ✅ Column headers dengan icon yang descriptive
- ✅ Row numbering otomatis (index + 1)
- ✅ Text truncation dengan lineClamp untuk long text
- ✅ Mobile card view dengan proper information hierarchy
- ✅ Proper spacing dan gap untuk readability
**Code Example (✅ GOOD):**
```typescript
// page.tsx - Line ~130-180
<Table highlightOnHover
layout="fixed" // ✅ PENTING - consistent column widths
withColumnBorders={false}>
<TableThead>
<TableTr>
<TableTh fz="sm" fw={600} lh={1.4} ta="center">No</TableTh>
<TableTh fz="sm" fw={600} lh={1.4}>
<Group gap={5}>
<IconUser size={16} />
Nama
</Group>
</TableTh>
<TableTh fz="sm" fw={600} lh={1.4}>
<Group gap={5}>
<IconMail size={16} />
Email
</Group>
</TableTh>
// ...
</TableTr>
</TableThead>
```
**Verdict:****BAIK** - Table layout dengan icon yang helpful!
---
### **3. State Management**
- ✅ Proper typing dengan Prisma types
- ✅ Loading state management dengan finally block
- ✅ Error handling yang comprehensive
-**ApiFetch consistency** untuk create & findMany! ✅
- ✅ Zod validation untuk form data dengan specific rules
- ✅ Return boolean untuk create operation (success/failure handling)
**Code Example (✅ EXCELLENT):**
```typescript
// state file - Line ~30-55
create: {
form: {} as PermohonanKeberatanInformasiForm,
loading: false,
async create() {
const cek = templateForm.safeParse(permohonanKeberatanInformasi.create.form);
if (!cek.success) {
toast.error(cek.error.issues.map((i) => i.message).join("\n"));
return false; // ✅ GOOD - Return false untuk failure
}
try {
permohonanKeberatanInformasi.create.loading = true;
const res = await ApiFetch.api.ppid.permohonankeberataninformasipublik["create"].post(form);
if (res.data?.success === false) {
toast.error(res.data?.message);
return false; // ✅ GOOD - Return false untuk API failure
}
toast.success("Sukses menambahkan");
return true; // ✅ GOOD - Return true untuk success
} catch {
toast.error("Terjadi kesalahan server");
return false;
} finally {
permohonanKeberatanInformasi.create.loading = false;
}
},
}
```
**Verdict:****EXCELLENT** - Proper return value handling untuk create operation!
---
### **4. Zod Schema Validation**
- ✅ Comprehensive validation untuk semua fields
- ✅ Specific error messages untuk setiap field
- ✅ Phone number length validation (3-15 chars)
- ✅ Minimum character validation (3 characters)
**Code Example (✅ GOOD):**
```typescript
// state file - Line ~8-15
const templateForm = z.object({
name: z.string().min(3, "Nama minimal 3 karakter"),
email: z.string().min(3, "Email minimal 3 karakter"),
notelp: z
.string()
.min(3, "Nomor Telepon minimal 3 karakter")
.max(15, "Nomor Telepon maksimal 15 angka"), // ✅ Specific validation
alasan: z.string().min(3, "Alasan minimal 3 karakter"),
});
```
**Verdict:****BAIK** - Validation yang proper dengan specific rules!
---
### **5. Empty State Handling**
- ✅ Different messages untuk search vs empty data
- ✅ Icon integration untuk visual clarity
- ✅ Proper text formatting dan centering
**Code Example (✅ GOOD):**
```typescript
// page.tsx - Line ~70-85
<Stack align="center" py="xl" ta="center">
<IconInfoCircle size={40} stroke={1.5} color={colors['blue-button']} />
<Text fz={{ base: 'sm', md: 'md' }} fw={500} c="dimmed" lh={1.5}>
{search
? 'Tidak ditemukan data yang sesuai dengan pencarian'
: 'Belum ada permohonan keberatan yang tercatat'
}
</Text>
</Stack>
```
**Verdict:****BAIK** - Empty state dengan conditional messages yang helpful!
---
## ⚠️ ISSUES & SARAN PERBAIKAN
### **🔴 CRITICAL**
#### **1. Schema - deletedAt Default Value SALAH**
**Lokasi:** `prisma/schema.prisma` (line 478)
**Masalah:**
```prisma
model FormulirPermohonanKeberatan {
id String @id @default(cuid())
name String
email String
notelp String
alasan String
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now()) // ❌ SALAH - selalu punya default value
isActive Boolean @default(true)
}
```
**Dampak:**
- **LOGIC ERROR!** Setiap record baru langsung punya `deletedAt` value (timestamp creation)
- Soft delete tidak berfungsi dengan benar
- Query dengan `where: { deletedAt: null }` tidak akan pernah return data
- Data yang "dihapus" vs data "aktif" tidak bisa dibedakan
**Rekomendasi:** Fix schema:
```prisma
model FormulirPermohonanKeberatan {
id String @id @default(cuid())
name String
email String
notelp String
alasan String
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime? @default(null) // ✅ Nullable, null = not deleted
isActive Boolean @default(true)
}
```
**Priority:** 🔴 **CRITICAL**
**Effort:** Medium (perlu migration)
**Impact:** **HIGH** (data integrity & soft delete logic)
---
#### **2. State Management - Fetch Pattern Inconsistency**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/permohonan_keberatan_informasi_publik/permohonanKeberatanInformasi.ts`
**Masalah:** Ada 2 pattern berbeda untuk fetch API:
```typescript
// ❌ Pattern 1: ApiFetch (create, findMany)
const res = await ApiFetch.api.ppid.permohonankeberataninformasipublik["create"].post(form);
const res = await ApiFetch.api.ppid.permohonankeberataninformasipublik["find-many"].get({ query });
// ❌ Pattern 2: fetch manual (findUnique)
const res = await fetch(`/api/ppid/permohonankeberataninformasipublik/${id}`);
```
**Dampak:**
- Code consistency buruk
- Sulit maintenance
- Type safety tidak konsisten
- Duplikasi logic error handling
**Rekomendasi:** Gunakan **ApiFetch** untuk semua operasi:
```typescript
// ✅ Unified pattern
async load(id: string) {
try {
const res = await ApiFetch.api.ppid.permohonankeberataninformasipublik[id].get();
if (res.data?.success) {
permohonanKeberatanInformasi.findUnique.data = res.data.data;
} else {
toast.error(res.data?.message || "Gagal memuat data");
}
} catch (error) {
console.error("Error:", error);
toast.error("Gagal memuat data");
}
}
```
**Priority:** 🔴 High
**Effort:** Medium (refactor di findUnique method)
---
#### **3. Missing Delete Function**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/permohonan_keberatan_informasi_publik/permohonanKeberatanInformasi.ts`
**Masalah:**
```typescript
// state file - Line ~100-120
// ❌ MISSING: delete method
const permohonanKeberatanInformasi = proxy({
create: { ... },
findMany: { ... },
findUnique: { ... },
// ❌ NO delete method!
});
```
**Issue:** Tidak ada cara untuk menghapus data permohonan keberatan.
**Rekomendasi:** Add delete method:
```typescript
delete: {
loading: false,
async byId(id: string) {
if (!id) return toast.warn("ID tidak valid");
try {
permohonanKeberatanInformasi.delete.loading = true;
const res = await ApiFetch.api.ppid.permohonankeberataninformasipublik["del"][id].delete();
if (res.data?.success) {
toast.success(res.data.message || "Berhasil hapus permohonan keberatan");
await permohonanKeberatanInformasi.findMany.load();
} else {
toast.error(res.data?.message || "Gagal hapus permohonan keberatan");
}
} catch (error) {
console.error("Gagal delete:", error);
toast.error("Terjadi kesalahan saat menghapus");
} finally {
permohonanKeberatanInformasi.delete.loading = false;
}
},
}
```
**Priority:** 🔴 Medium
**Effort:** Medium (perlu add method + API endpoint)
---
### **🟡 MEDIUM**
#### **4. Console.log di Production**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/permohonan_keberatan_informasi_publik/permohonanKeberatanInformasi.ts`
**Masalah:**
```typescript
// Line ~85
console.error("Failed to load permohonan keberatan informasi:", res.data?.message);
// Line ~90
console.error("Error loading permohonan keberatan informasi:", error);
// Line ~110
console.error("Failed to fetch permohonan keberatan informasi:", res.statusText);
// Line ~114
console.error("Error fetching permohonan keberatan informasi:", error);
```
**Rekomendasi:** Gunakan conditional logging:
```typescript
if (process.env.NODE_ENV === 'development') {
console.error("Error:", error);
}
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **5. Type Safety - Any Usage**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/permohonan_keberatan_informasi_publik/permohonanKeberatanInformasi.ts`
**Masalah:**
```typescript
// Line ~75
const query: any = { page, limit }; // ❌ Using 'any'
if (search) query.search = search;
```
**Rekomendasi:** Gunakan typed query:
```typescript
// Define type
interface FindManyQuery {
page: number | string;
limit?: number | string;
search?: string;
}
// Use typed query
const query: FindManyQuery = { page, limit };
if (search) query.search = search;
```
**Priority:** 🟡 Medium
**Effort:** Low
---
#### **6. Missing Edit Function**
**Lokasi:** Module structure
**Masalah:**
- ❌ Tidak ada halaman edit untuk permohonan keberatan
- ❌ Tidak ada edit method di state
- ⚠️ **QUESTION:** Apakah permohonan keberatan harus bisa diedit?
**Issue:** Jika ada kesalahan input, user tidak bisa mengoreksi data.
**Rekomendasi:** Consider adding edit functionality jika diperlukan:
```typescript
// Add edit method di state
edit: {
id: "",
form: { ... },
loading: false,
async load(id: string) { ... },
async update() { ... },
}
```
**Priority:** 🟡 Low (depends on business requirement)
**Effort:** Medium
---
#### **7. Pagination onChange Tidak Include Search**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~250-260
<Pagination
value={page}
onChange={(newPage) => {
load(newPage, 10); // ⚠️ Missing search parameter
window.scrollTo(0, 0);
}}
total={totalPages}
// ...
/>
```
**Issue:** Saat ganti page, search query hilang.
**Rekomendasi:** Include search:
```typescript
onChange={(newPage) => {
load(newPage, 10, debouncedSearch); // ✅ Include search
window.scrollTo(0, 0);
}}
```
**Priority:** 🟡 Low
**Effort:** Low
---
### **🟢 LOW (Minor Polish)**
#### **8. Missing Loading State di Detail Page**
**Lokasi:** `[id]/page.tsx`
**Masalah:**
```typescript
// Line ~20-25
useShallowEffect(() => {
state.findUnique.load(params?.id as string)
}, [params?.id])
if (!state.findUnique.data) {
return (
<Stack py={10}>
<Skeleton height={500} radius="md" />
</Stack>
)
}
```
**Issue:** Skeleton ditampilkan untuk semua kondisi (loading, error, not found).
**Rekomendasi:** Add proper loading state:
```typescript
if (state.findUnique.loading) {
return (
<Stack py={10}>
<Skeleton height={500} radius="md" />
</Stack>
);
}
if (!state.findUnique.data) {
return (
<Alert icon={<IconAlertCircle />} color="red">
Data tidak ditemukan
</Alert>
);
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **9. Duplicate Error Logging**
**Lokasi:** `page.tsx`, state file
**Masalah:**
```typescript
// state file - Line ~85-90
console.error("Failed to load permohonan keberatan informasi:", res.data?.message);
console.error("Error loading permohonan keberatan informasi:", error);
// state file - Line ~110-114
console.error("Failed to fetch permohonan keberatan informasi:", res.statusText);
console.error("Error fetching permohonan keberatan informasi:", error);
```
**Rekomendasi:** Cukup satu logging yang informatif:
```typescript
console.error('Failed to load Permohonan Keberatan:', err);
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **10. Search Placeholder Tidak Spesifik**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~70, 110
<TextInput
placeholder={"Cari nama..."} // ⚠️ Generic
// ...
/>
```
**Rekomendasi:** Lebih spesifik:
```typescript
placeholder={"Cari nama pemohon..."}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **11. Missing Data di Detail Page**
**Lokasi:** `[id]/page.tsx`
**Masalah:**
```typescript
// Line ~50-80
// Menampilkan: name, notelp, email, alasan
// ❌ MISSING: createdAt, updatedAt, atau status
```
**Issue:** Tidak menampilkan timestamp atau status permohonan.
**Rekomendasi:** Add missing fields jika ada di schema:
```typescript
<Box>
<Text fz="lg" fw="bold" mb={4}>Tanggal Pengajuan</Text>
<Text fz="md" c="dimmed">
{data.createdAt ? new Date(data.createdAt).toLocaleDateString('id-ID', {
day: '2-digit',
month: 'long',
year: 'numeric'
}) : '-'}
</Text>
</Box>
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **12. Title Inconsistency di Detail Page**
**Lokasi:** `[id]/page.tsx`
**Masalah:**
```typescript
// Line ~40
<Text fz="2xl" fw="bold" c={colors['blue-button']}>
Detail Informasi Publik // ⚠️ Generic title
</Text>
```
**Issue:** Title seharusnya lebih spesifik "Detail Permohonan Keberatan".
**Rekomendasi:** Fix title:
```typescript
<Text fz="2xl" fw="bold" c={colors['blue-button']}>
Detail Permohonan Keberatan Informasi Publik
</Text>
```
**Priority:** 🟢 Low
**Effort:** Low
---
## 📋 RINGKASAN ACTION ITEMS
| Priority | Issue | Module | Impact | Effort | Status |
|----------|-------|--------|--------|--------|--------|
| 🔴 P0 | **Schema deletedAt default SALAH** | Schema | **CRITICAL** | Medium | **MUST FIX** |
| 🔴 P0 | Fetch method inconsistency | State | Medium | Medium | Perlu refactor |
| 🔴 P1 | Missing delete function | State | Medium | Medium | Should add |
| 🟡 M | Console.log in production | State | Low | Low | Optional |
| 🟡 M | Type safety (any usage) | State | Low | Low | Optional |
| 🟡 M | Missing edit function | State/UI | Low | Medium | Optional (business decision) |
| 🟡 M | Pagination missing search param | UI | Low | Low | Should fix |
| 🟢 L | Missing loading state di detail page | UI | Low | Low | Optional |
| 🟢 L | Duplicate error logging | UI/State | Low | Low | Optional |
| 🟢 L | Search placeholder tidak spesifik | UI | Low | Low | Optional |
| 🟢 L | Missing data di detail page | UI | Low | Low | Optional |
| 🟢 L | Title inconsistency di detail page | UI | Low | Low | Should fix |
---
## ✅ KESIMPULAN
### **Overall Quality: 🟢 BAIK (7.5/10)**
**Strengths:**
1. ✅ UI/UX clean & responsive
2. ✅ Table layout dengan icon yang helpful
3. ✅ Search functionality dengan debounce
4. ✅ Empty state handling yang informatif (conditional messages)
5.**Zod validation** comprehensive dengan specific rules
6.**Proper return value handling** untuk create operation (return true/false)
7. ✅ State management dengan ApiFetch untuk create & findMany
8. ✅ Loading state management dengan finally block
9. ✅ Mobile cards responsive
10. ✅ Icon integration (User, Mail, Phone, Info)
**Critical Issues:**
1. ⚠️ **Schema deletedAt default SALAH** - Logic error untuk soft delete (CRITICAL)
2. ⚠️ Fetch method pattern inconsistency (ApiFetch vs fetch manual)
3. ⚠️ Missing delete function untuk hapus data
**Areas for Improvement:**
1. ⚠️ **Fix schema deletedAt** dari `@default(now())` ke `@default(null)` dengan nullable
2. ⚠️ **Refactor fetch methods** untuk gunakan ApiFetch consistently
3. ⚠️ **Add delete method** untuk hapus data
4. ⚠️ **Consider adding edit functionality** (business decision)
5. ⚠️ **Improve type safety** dengan remove `any` usage
**Recommended Next Steps:**
1. **🔴 CRITICAL: Fix schema deletedAt** - 30 menit (perlu migration)
2. **🔴 HIGH: Refactor findUnique** ke ApiFetch - 30 menit
3. **🔴 HIGH: Add delete method** - 45 menit
4. **🟡 MEDIUM: Add pagination search param** - 10 menit
5. **🟢 LOW: Fix title di detail page** - 5 menit
6. **🟢 LOW: Polish minor issues** - 30 menit
---
## 📈 COMPARISON WITH OTHER MODULES
| Module | Fetch Pattern | State | Validation | Schema | Delete | Edit | Overall |
|--------|--------------|-------|------------|--------|--------|------|---------|
| Profil | ⚠️ Mixed | ⚠️ Good | ✅ Good | ⚠️ deletedAt | ✅ Yes | ✅ Yes | 🟢 |
| Desa Anti Korupsi | ⚠️ Mixed | ⚠️ Good | ✅ Good | ⚠️ deletedAt | ✅ Yes | ✅ Yes | 🟢 |
| SDGs Desa | ⚠️ Mixed | ⚠️ Good | ✅ Good | ⚠️ deletedAt | ✅ Yes | ✅ Yes | 🟢 |
| APBDes | ⚠️ Mixed | ⚠️ Good | ✅ Good | ✅ Good | ✅ Yes | ✅ Yes | 🟢 |
| Prestasi Desa | ⚠️ Mixed | ⚠️ Good | ✅ Good | ❌ WRONG | ✅ Yes | ✅ Yes | 🟢 |
| PPID Profil | ⚠️ Mixed | ✅ **Best** | ✅ Good | ❌ WRONG | N/A | ✅ Yes | 🟢⭐ |
| Struktur PPID | ⚠️ Mixed | ✅ Good | ✅ Good | ⚠️ Inconsistent | ✅ Yes | ✅ Yes | 🟢 |
| Visi Misi PPID | ✅ **100% ApiFetch!** | ✅ Best | ✅ Good | ❌ WRONG | N/A | ✅ Yes | 🟢⭐⭐ |
| Dasar Hukum PPID | ✅ **100% ApiFetch!** | ✅ Best | ✅ Good | ❌ WRONG | N/A | ✅ Yes | 🟢⭐⭐ |
| Permohonan Informasi | ⚠️ Mixed | ⚠️ Good | ✅ **Best** | ❌ **4 models WRONG** | ❌ Missing | ❌ Missing | 🟡 |
| **Permohonan Keberatan** | ⚠️ Mixed | ⚠️ Good | ✅ Good | ❌ WRONG | ❌ **MISSING** | ❌ **MISSING** | 🟡 |
**Permohonan Keberatan PPID Highlights:**
-**Proper return value handling** - Return true/false untuk create operation
-**Icon integration** - User, Mail, Phone, Info icons di table headers
-**Conditional empty state messages** - Different messages untuk search vs empty
- ⚠️ **Same deletedAt issue** seperti modul PPID lain
- ⚠️ **Missing delete function** - Cannot delete data
- ⚠️ **Missing edit function** - Cannot edit data (same as Permohonan Informasi)
---
## 🎯 UNIQUE FEATURES OF PERMOHONAN KEBERATAN MODULE
**Simplest Read-Only Module:**
1.**Proper return value handling** - Return true/false untuk create operation (UNIQUE!)
2.**Conditional empty state messages** - Different messages untuk search vs empty
3.**Icon integration** - User, Mail, Phone, Info icons
4.**Missing delete function** - Cannot delete data
5.**Missing edit function** - Cannot edit data
**Best Practices:**
1.**Return value handling** - Best practice untuk create operation
2.**Conditional empty state** - Good UX untuk search feedback
3.**Loading state management** - Proper dengan finally block
4.**Icon integration** - Visual clarity di table headers
**Critical Issues:**
1.**Schema deletedAt SALAH** - Same issue seperti modul PPID lain
2.**Fetch pattern inconsistency** - findUnique pakai fetch manual
3.**Missing delete function** - Cannot delete data
4.**Missing edit function** - Cannot edit data (same as Permohonan Informasi)
---
**Catatan:** **Permohonan Keberatan PPID adalah MODULE DENGAN RETURN VALUE HANDLING TERBAIK** tapi juga **MISSING DELETE & EDIT FUNCTIONS**. Module ini mirip dengan Permohonan Informasi (read-only, no delete/edit).
**Unique Strengths:**
1.**Return value handling** - Best practice (return true/false)
2.**Conditional empty state** - Good UX
3.**Icon integration** - Visual clarity
4.**Validation comprehensive** - Phone length validation
**Priority Action:**
```diff
🔴 FIX INI SEKARANG (30 MENIT + MIGRATION):
File: prisma/schema.prisma
Line: 478
model FormulirPermohonanKeberatan {
id String @id @default(cuid())
name String
email String
notelp String
alasan String
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
# Lalu jalankan:
bunx prisma db push
# atau
bunx prisma migrate dev --name fix_deletedat_keberatan
```
```diff
🔴 ADD DELETE FUNCTION (45 MENIT):
File: state file
delete: {
loading: false,
async byId(id: string) {
if (!id) return toast.warn("ID tidak valid");
try {
permohonanKeberatanInformasi.delete.loading = true;
const res = await ApiFetch.api.ppid.permohonankeberataninformasipublik["del"][id].delete();
if (res.data?.success) {
toast.success(res.data.message || "Berhasil hapus permohonan keberatan");
await permohonanKeberatanInformasi.findMany.load();
} else {
toast.error(res.data?.message || "Gagal hapus permohonan keberatan");
}
} catch (error) {
console.error("Gagal delete:", error);
toast.error("Terjadi kesalahan saat menghapus");
} finally {
permohonanKeberatanInformasi.delete.loading = false;
}
},
}
```
Setelah fix critical issues, module ini **PRODUCTION-READY** dengan **BEST RETURN VALUE HANDLING**! 🎉
---
## 📚 RECOMMENDED AS REFERENCE FOR OTHER MODULES
**Permohonan Keberatan PPID Module adalah BEST PRACTICE untuk:**
1.**Return value handling** - Return true/false untuk create operation
2.**Conditional empty state** - Different messages untuk search vs empty
3.**Icon integration** - Visual clarity di table headers
4.**Phone validation** - Min/max length validation
**Modules lain bisa belajar dari Permohonan Keberatan:**
- **ALL MODULES:** Use return values untuk handle create success/failure
- **ALL MODULES:** Conditional empty state messages untuk better UX
- **ALL MODULES:** Icon integration untuk visual clarity
- **ALL MODULES:** Specific validation rules (min/max length)
---
**File Location:** `QC/PPID/QC-PERMOHONAN-KEBERATAN-INFORMASI-MODULE.md` 📄

View File

@@ -1,802 +0,0 @@
# QC Summary - PPID Profil Module
**Scope:** Profil PPID (Preview & Edit), Rich Text Editor Forms
**Date:** 2026-02-23
**Status:** ✅ Secara umum sudah baik, ada beberapa improvement yang diperlukan
---
## 📊 OVERVIEW
| Aspect | Schema | API | UI Admin | State Management | Overall |
|--------|--------|-----|----------|-----------------|---------|
| Profil PPID | ⚠️ Ada issue | ✅ Baik | ✅ Baik | ✅ Baik | 🟡 Perlu fix |
---
## ✅ YANG SUDAH BAIK
### **1. UI/UX Design**
- ✅ Preview layout yang clean dengan logo desa
- ✅ Responsive design (mobile & desktop)
- ✅ Loading states dengan Skeleton
- ✅ Error handling dengan Alert component
- ✅ Empty state handling yang informatif
- ✅ Edit button yang prominent
### **2. File Upload Handling**
- ✅ Dropzone dengan preview image
- ✅ Validasi format gambar (JPEG, JPG, PNG, WEBP)
- ✅ Validasi ukuran file (max 5MB)
- ✅ Tombol hapus preview (IconX di pojok kanan atas)
- ✅ URL.createObjectURL untuk preview lokal
- ✅ Error handling untuk image load (onError fallback)
### **3. Rich Text Editor (Tiptap)**
- ✅ Full-featured editor dengan toolbar lengkap
- ✅ Extensions: Bold, Italic, Underline, Highlight, Link, dll
- ✅ Text alignment (left, center, justify, right)
- ✅ Heading levels (H1-H4)
- ✅ Lists (bullet & ordered)
- ✅ Blockquote, code, superscript, subscript
- ✅ Undo/Redo
- ✅ Sticky toolbar untuk UX yang lebih baik
### **4. Form Component Structure**
- ✅ Modular form components (Biodata, Riwayat, Pengalaman, Unggulan)
- ✅ Reusable EditPPIDEditor component
- ✅ Proper TypeScript typing
- ✅ Error display untuk setiap field
- ✅ Controlled components dengan onChange handler
### **5. State Management - BEST PRACTICES**
- ✅ Proper typing dengan Prisma types
- ✅ Loading state management dengan finally block
- ✅ Error handling yang comprehensive
- ✅ Reset function untuk cleanup
-**originalForm tracking** untuk reset ke data awal
**Code Example (✅ EXCELLENT):**
```typescript
// state file - Line ~85-105
editForm: {
id: "",
form: { ...defaultForm },
originalForm: { ...defaultForm }, // ✅ Track original data
loading: false,
error: null as string | null,
initialize(profileData: ProfilePPIDForm) {
this.id = profileData.id;
const data = {
name: profileData.name || "",
biodata: profileData.biodata || "",
riwayat: profileData.riwayat || "",
pengalaman: profileData.pengalaman || "",
unggulan: profileData.unggulan || "",
imageId: profileData.imageId || "",
};
this.form = { ...data };
this.originalForm = { ...data }; // ✅ Save original
},
updateField(field: keyof typeof defaultForm, value: string) {
this.form[field] = value;
},
// ✅ Reset to original
resetToOriginal() {
this.form = { ...this.originalForm };
toast.info("Data dikembalikan ke kondisi awal");
},
};
```
**Verdict:****SANGAT BAIK** - State management paling baik dibanding modul lain!
---
### **6. Edit Form - Original Data Tracking**
- ✅ Original data state untuk reset form
- ✅ Load data existing dengan benar
- ✅ Preview image dari data lama
- ✅ Reset form mengembalikan ke data original
- ✅ File replacement logic (upload baru jika ada perubahan)
**Code Example (✅ EXCELLENT):**
```typescript
// edit/page.tsx - Line ~100-115
const handleResetForm = () => {
if (!allState.profile.data) return;
// Reset form ke data awal yang di-load
const original = allState.profile.data;
stateProfilePPID.editForm.form = {
name: original.name || '',
imageId: original.imageId || '',
biodata: original.biodata || '',
riwayat: original.riwayat || '',
pengalaman: original.pengalaman || '',
unggulan: original.unggulan || '',
};
// Reset preview gambar juga
setPreviewImage(original.image?.link || null);
setFile(null);
toast.info('Perubahan dibatalkan');
};
```
**Verdict:****SANGAT BAIK** - Original data tracking sudah implementasi dengan sempurna!
---
## ⚠️ ISSUES & SARAN PERBAIKAN
### **🔴 CRITICAL**
#### **1. Schema - deletedAt Default Value SALAH**
**Lokasi:** `prisma/schema.prisma` (line 401)
**Masalah:**
```prisma
model ProfilePPID {
// ...
deletedAt DateTime @default(now()) // ❌ SALAH - selalu punya default value
isActive Boolean @default(true)
}
```
**Dampak:**
- **LOGIC ERROR!** Setiap record baru langsung punya `deletedAt` value (timestamp creation)
- Soft delete tidak berfungsi dengan benar
- Query dengan `where: { deletedAt: null }` tidak akan pernah return data
- Data yang "dihapus" vs data "aktif" tidak bisa dibedakan
**Contoh Issue:**
```prisma
// Record baru dibuat
CREATE ProfilePPID {
name: "PPID 1",
// deletedAt otomatis ter-set ke now() ❌
// isActive: true ✅
}
// Query untuk data aktif (seharusnya return data ini)
prisma.profilePPID.findMany({
where: { deletedAt: null, isActive: true }
})
// ❌ Return kosong! Karena deletedAt sudah ter-set
```
**Rekomendasi:** Fix schema:
```prisma
model ProfilePPID {
// ...
deletedAt DateTime? @default(null) // ✅ Nullable, null = not deleted
isActive Boolean @default(true)
}
```
**Priority:** 🔴 **CRITICAL**
**Effort:** Medium (perlu migration)
**Impact:** **HIGH** (data integrity & soft delete logic)
---
#### **2. HTML Injection Risk - dangerouslySetInnerHTML**
**Lokasi:** `page.tsx` (preview page)
**Masalah:**
```typescript
// Line ~105-110
<Text
fz={{ base: 'sm', md: 'md' }}
ta="justify"
c={colors['blue-button']}
lh={1.5}
style={{ wordBreak: "break-word", whiteSpace: "normal" }}
dangerouslySetInnerHTML={{ __html: item.biodata }} // ❌ No sanitization
/>
// Line ~115-120 (Riwayat)
dangerouslySetInnerHTML={{ __html: item.riwayat }} // ❌ No sanitization
// Line ~125-130 (Pengalaman)
dangerouslySetInnerHTML={{ __html: item.pengalaman }} // ❌ No sanitization
// Line ~135-140 (Unggulan)
dangerouslySetInnerHTML={{ __html: item.unggulan }} // ❌ No sanitization
```
**Risk:**
- XSS attack jika admin input script malicious
- Bisa inject iframe, script tag, dll
- Security vulnerability
**Rekomendasi:** Gunakan DOMPurify atau library sanitization:
```typescript
import DOMPurify from 'dompurify';
// Sanitize sebelum render
const sanitizedBiodata = DOMPurify.sanitize(item.biodata);
const sanitizedRiwayat = DOMPurify.sanitize(item.riwayat);
const sanitizedPengalaman = DOMPurify.sanitize(item.pengalaman);
const sanitizedUnggulan = DOMPurify.sanitize(item.unggulan);
<Text
dangerouslySetInnerHTML={{ __html: sanitizedBiodata }}
// ...
/>
```
Atau validasi di backend untuk whitelist tag HTML yang diperbolehkan (hanya `<p>`, `<ul>`, `<li>`, `<strong>`, dll).
**Priority:** 🔴 **HIGH** (**Security concern**)
**Effort:** Low
---
#### **3. State Management - Fetch Pattern Inconsistency**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/profile_ppid/profile_PPID.ts`
**Masalah:** Ada 2 pattern berbeda untuk fetch API:
```typescript
// ❌ Pattern 1: fetch manual (profile.load)
const res = await fetch(`/api/ppid/profileppid/${id}`);
// ❌ Pattern 2: fetch manual (editForm.submit)
const res = await fetch(`/api/ppid/profileppid/${this.id}`, {
method: "PUT",
headers: { "Content-Type": "application/json" },
body: JSON.stringify(this.form),
});
```
**Dampak:**
- Code consistency buruk
- Sulit maintenance
- Type safety tidak konsisten
- Duplikasi logic error handling
- Tidak konsisten dengan modul lain yang sudah migrate ke ApiFetch
**Rekomendasi:** Gunakan **ApiFetch** untuk semua operasi:
```typescript
import ApiFetch from "@/lib/api-fetch";
// profile.load
async load(id: string) {
try {
this.loading = true;
this.error = null;
const res = await ApiFetch.api.ppid.profileppid[id].get();
if (res.data?.success) {
this.data = res.data.data;
return res.data.data;
} else {
if (res.data?.message === "Data tidak ditemukan" ||
res.data?.message === "Belum ada data profil PPID yang aktif") {
this.error = res.data.message;
return null;
} else {
throw new Error(res.data?.message || "Gagal memuat data profile");
}
}
} catch (err) {
const msg = (err as Error).message;
this.error = msg;
console.error("Load profile error:", msg);
if (msg !== "Data tidak ditemukan" && msg !== "Belum ada data profil PPID yang aktif") {
toast.error("Gagal memuat data profile");
}
return null;
} finally {
this.loading = false;
}
}
// editForm.submit
async submit() {
const check = templateForm.safeParse(this.form);
if (!check.success) {
toast.error(
check.error.issues.map((i) => `${i.path.join(".")}: ${i.message}`).join(", ")
);
return false;
}
this.loading = true;
this.error = null;
try {
const res = await ApiFetch.api.ppid.profileppid[this.id].put(this.form);
if (res.data?.success) {
toast.success("Berhasil update profile");
this.originalForm = { ...this.form };
return true;
} else {
throw new Error(res.data?.message || "Gagal update profile");
}
} catch (err) {
const msg = (err as Error).message;
this.error = msg;
toast.error(msg);
return false;
} finally {
this.loading = false;
}
}
```
**Priority:** 🔴 High
**Effort:** Medium (refactor di semua methods)
---
### **🟡 MEDIUM**
#### **4. Console.log di Production**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/profile_ppid/profile_PPID.ts`
**Masalah:**
```typescript
// Line ~65
console.error("Load profile error:", msg);
// edit/page.tsx - Line ~65
console.error("Error updating profile:", error);
```
**Rekomendasi:** Gunakan conditional logging:
```typescript
if (process.env.NODE_ENV === 'development') {
console.error("Load profile error:", msg);
}
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **5. Zod Schema - Error Message Tidak Konsisten**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/profile_ppid/profile_PPID.ts`
**Masalah:**
```typescript
// Line ~6
const templateForm = z.object({
name: z.string().min(3, "Nama minimal 3 karakter"), // ✅ OK
biodata: z.string().min(3, "Biodata minimal 3 karakter"), // ✅ OK
riwayat: z.string().min(3, "Riwayat minimal 3 karakter"), // ✅ OK
pengalaman: z.string().min(3, "Pengalaman minimal 3 karakter"), // ✅ OK
unggulan: z.string().min(3, "Unggulan minimal 3 karakter"), // ✅ OK
imageId: z.string().min(1, "Gambar wajib dipilih"), // ✅ OK
});
```
**Verdict:****SUDAH BENAR** - Error messages sudah spesifik dan konsisten!
**Priority:** 🟢 None
**Effort:** None
---
#### **6. Missing Validation di Submit Button**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~270-280
<Button
onClick={handleSubmit}
radius="md"
size="md"
style={{ ... }}
>
{isSubmitting ? <Loader size="sm" color="white" /> : 'Simpan'}
</Button>
```
**Issue:** Button tidak disabled saat submitting atau form invalid. User bisa click multiple times.
**Rekomendasi:** Add disabled state:
```typescript
<Button
onClick={handleSubmit}
radius="md"
size="md"
disabled={isSubmitting || allState.editForm.loading}
style={{
background: isSubmitting || allState.editForm.loading
? 'linear-gradient(135deg, #cccccc, #999999)'
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}
>
{isSubmitting ? <Loader size="sm" color="white" /> : 'Simpan'}
</Button>
```
**Priority:** 🟡 Low
**Effort:** Low
---
### **🟢 LOW (Minor Polish)**
#### **7. Duplicate useEffect di Editor Component**
**Lokasi:** `editPPIDEditor.tsx`
**Masalah:**
```typescript
// Line ~25-30
useEffect(() => {
if (editor && value && value !== editor.getHTML()) {
editor.commands.setContent(value);
}
}, [editor, value]);
// Line ~32-40
useEffect(() => {
if (!editor) return;
const updateHandler = () => onChange(editor.getHTML());
editor.on('update', updateHandler);
return () => {
editor.off('update', updateHandler);
};
}, [editor, onChange]);
```
**Issue:** Ada 2 useEffect yang handle editor update. Yang pertama set content, yang kedua handle onChange. Bisa digabung untuk clarity.
**Rekomendasi:** Simplify:
```typescript
const editor = useEditor({
extensions: [...],
content: value, // Set content directly
onUpdate({ editor }) {
onChange(editor.getHTML());
},
});
// Remove first useEffect, keep second for cleanup
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **8. Form Label Inconsistency**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~170
<Text fw="bold">Nama Perbekel</Text>
// Should be:
<Text fw="bold">Nama PPID</Text>
```
**Issue:** Label "Nama Perbekel" tidak sesuai dengan context PPID. Ini profil PPID, bukan perbekel.
**Rekomendasi:** Fix label:
```typescript
<Text fw="bold">Nama PPID</Text>
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **9. Image Label Text Size**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~180
<Text fz={"md"} fw={"bold"}>Gambar</Text>
// Should be more specific:
<Text fz={"md"} fw={"bold"}>Foto Profil PPID</Text>
```
**Rekomendasi:** More descriptive label:
```typescript
<Text fz={"md"} fw={"bold"}>Foto Profil PPID</Text>
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **10. Dropzone Accept Format**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~190
accept={{ 'image/*': ['.jpeg', '.jpg', '.png', '.webp'] }}
// Missing mime type specifications
```
**Rekomendasi:** Add full mime types:
```typescript
accept={{
'image/jpeg': ['.jpeg', '.jpg'],
'image/png': ['.png'],
'image/webp': ['.webp'],
}}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **11. Preview Page - Title Order Inconsistency**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~55
<Title order={4} ...>
PROFIL PIMPINAN BADAN PUBLIK DESA DARMASABA
</Title>
// Line ~90
<Title order={3} ...>
{item.name}
</Title>
// Line ~100
<Title order={3} ...>
Biodata
</Title>
```
**Issue:** Title hierarchy tidak konsisten. Subtitle (order 4) lebih kecil dari content titles (order 3).
**Rekomendasi:** Samakan hierarchy:
```typescript
// Main title: order={2} atau order={3}
// Section titles: order={4}
// Name: order={3}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **12. Missing Search Feature**
**Lokasi:** N/A (Single record module)
**Verdict:****NOT APPLICABLE** - Module ini hanya handle single record, search tidak diperlukan.
**Priority:** 🟢 None
**Effort:** None
---
#### **13. Button Loading State Tidak Konsisten**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~270-280
<Button
onClick={handleSubmit}
// ...
>
{isSubmitting ? <Loader size="sm" color="white" /> : 'Simpan'}
</Button>
```
**Issue:** Button hanya check `isSubmitting` local state, tidak check `allState.editForm.loading` dari global state.
**Rekomendasi:** Check both states:
```typescript
disabled={isSubmitting || allState.editForm.loading}
{isSubmitting || allState.editForm.loading ? (
<Loader size="sm" color="white" />
) : (
'Simpan'
)}
```
**Priority:** 🟢 Low
**Effort:** Low
---
## 📋 RINGKASAN ACTION ITEMS
| Priority | Issue | Module | Impact | Effort | Status |
|----------|-------|--------|--------|--------|--------|
| 🔴 P0 | **Schema deletedAt default SALAH** | Schema | **CRITICAL** | Medium | **MUST FIX** |
| 🔴 P0 | **HTML injection risk** | UI | **HIGH (Security)** | Low | **Should fix** |
| 🔴 P1 | Fetch method inconsistency | State | Medium | Medium | Perlu refactor |
| 🟡 M | Console.log in production | State | Low | Low | Optional |
| 🟡 M | Missing validation di submit button | UI | Low | Low | Should fix |
| 🟢 L | Duplicate useEffect di editor | Editor | Low | Low | Optional |
| 🟢 L | Form label inconsistency | UI | Low | Low | Should fix |
| 🟢 L | Image label text size | UI | Low | Low | Optional |
| 🟢 L | Dropzone accept format | UI | Low | Low | Optional |
| 🟢 L | Title order inconsistency | UI | Low | Low | Optional |
| 🟢 L | Button loading state inconsistency | UI | Low | Low | Optional |
---
## ✅ KESIMPULAN
### **Overall Quality: 🟢 BAIK (8/10)**
**Strengths:**
1. ✅ UI/UX clean & responsive
2. ✅ File upload handling solid
3.**Rich Text Editor** full-featured (Tiptap)
4.**Modular form components** (Biodata, Riwayat, Pengalaman, Unggulan)
5.**State management BEST PRACTICES** (originalForm tracking)
6.**Edit form reset SANGAT BAIK** (original data tracking sempurna)
7. ✅ Error handling comprehensive
8. ✅ Loading state management dengan finally block
9. ✅ Modal konfirmasi hapus untuk user safety
**Critical Issues:**
1. ⚠️ **Schema deletedAt default SALAH** - Logic error untuk soft delete (CRITICAL)
2. ⚠️ **HTML injection risk** - dangerouslySetInnerHTML tanpa sanitization (HIGH Security)
3. ⚠️ Fetch method pattern inconsistency (ApiFetch vs fetch manual)
**Areas for Improvement:**
1. ⚠️ **Fix schema deletedAt** dari `@default(now())` ke `@default(null)` dengan nullable
2. ⚠️ **Fix HTML injection** dengan DOMPurify atau backend validation
3. ⚠️ **Refactor fetch methods** untuk gunakan ApiFetch consistently
4. ⚠️ **Add disabled state** di submit button
5. ⚠️ **Fix form labels** (Nama Perbekel → Nama PPID)
**Recommended Next Steps:**
1. **🔴 CRITICAL: Fix schema deletedAt** - 30 menit (perlu migration)
2. **🔴 HIGH: Fix HTML injection** dengan DOMPurify - 30 menit
3. **🔴 HIGH: Refactor fetch methods** ke ApiFetch - 1 jam
4. **🟡 MEDIUM: Add disabled state** di submit button - 15 menit
5. **🟢 LOW: Fix form labels** - 10 menit
6. **🟢 LOW: Polish minor issues** - 30 menit
---
## 📈 COMPARISON WITH OTHER MODULES
| Aspect | Profil | Desa Anti Korupsi | SDGs Desa | APBDes | Prestasi Desa | **PPID Profil** | Notes |
|--------|--------|-------------------|-----------|--------|---------------|-----------------|-------|
| Fetch Pattern | ⚠️ Mixed | ⚠️ Mixed | ⚠️ Mixed | ⚠️ Mixed | ⚠️ Mixed | ⚠️ Mixed | All perlu refactor |
| Loading State | ⚠️ Some missing | ⚠️ Some missing | ⚠️ Missing | ✅ Good | ⚠️ findUnique missing | ✅ **Good** | PPID salah satu yang terbaik |
| Edit Form Reset | ✅ Good | ✅ Good | ✅ Good | ✅ Good | ✅ Good | ✅ **EXCELLENT** | **PPID paling baik** (originalForm tracking) |
| Type Safety | ⚠️ Some `any` | ⚠️ Some `any` | ⚠️ Some `any` | ⚠️ Some `any` | ⚠️ Some `any` | ✅ **Good** | PPID typing lebih baik |
| File Upload | ✅ Images | ✅ Documents | ✅ Images | ✅ Dual | ✅ Images | ✅ Images | Similar |
| Error Handling | ✅ Good | ✅ Good (better) | ✅ Good | ✅ Good | ✅ Good | ✅ **Good** | Consistent |
| **Schema deletedAt** | ⚠️ Issue | ⚠️ Issue | ⚠️ Issue | ✅ Good | ❌ **WRONG** | ❌ **WRONG** | **PPID CRITICAL** |
| HTML Injection | ⚠️ Present | ⚠️ Present | N/A | N/A | ⚠️ Present | ⚠️ **Present** | Security concern |
| Rich Text Editor | ✅ Present | ✅ Present | N/A | N/A | ✅ Present | ✅ **Best** | **PPID editor paling lengkap** |
| Modular Forms | ❌ None | ❌ None | N/A | ❌ None | ❌ None | ✅ **YES** | **PPID unique feature** |
| State Management | ⚠️ Good | ⚠️ Good | ⚠️ Good | ⚠️ Good | ⚠️ Good | ✅ **BEST** | **PPID state management terbaik** |
---
## 🎯 UNIQUE FEATURES OF PPID PROFIL MODULE
**Most Advanced Module:**
1.**Rich Text Editor (Tiptap)** - Full-featured dengan toolbar lengkap
2.**Modular Form Components** - Biodata, Riwayat, Pengalaman, Unggulan forms
3.**originalForm Tracking** - State management best practice (unique to PPID)
4.**Single Record Pattern** - Handle "edit" special ID untuk single profile
5.**Comprehensive Error Handling** - Special handling untuk "data not found" cases
**Best Practices:**
1.**State management PALING BAIK** dibanding semua modul lain
2.**Edit form reset PALING BAIK** (originalForm tracking sempurna)
3.**Type safety LEBIH BAIK** (minimal any usage)
4.**Loading state management PROPER** (dengan finally block)
5.**Modular component design** (reusable forms)
**Critical Issues:**
1.**Schema deletedAt SALAH** - sama seperti SDGs, Desa Anti Korupsi, Prestasi Desa
2.**HTML injection risk** - sama seperti modul lain yang pakai rich text
---
**Catatan:** Secara keseluruhan, modul **PPID Profil adalah YANG PALING BAIK** dibanding semua modul yang sudah di-QC. State management-nya adalah best practice dengan originalForm tracking yang sempurna. Rich Text Editor implementation juga paling advanced.
**Unique Strengths:**
1.**State management terbaik** - originalForm tracking untuk reset yang sempurna
2.**Rich Text Editor terlengkap** - Tiptap dengan semua extensions
3.**Modular form design** - Reusable components untuk setiap section
4.**Type safety lebih baik** - Minimal any usage
**Priority Action:**
```diff
🔴 FIX INI SEKARANG (30 MENIT + MIGRATION):
File: prisma/schema.prisma
Line: 401
model ProfilePPID {
// ...
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
# Lalu jalankan:
bunx prisma db push
# atau
bunx prisma migrate dev --name fix_deletedat_default_ppid
```
```diff
🔴 FIX HTML INJECTION (30 MENIT):
File: src/app/admin/(dashboard)/ppid/profil-ppid/page.tsx
+ import DOMPurify from 'dompurify';
// Line ~105
- dangerouslySetInnerHTML={{ __html: item.biodata }}
+ dangerouslySetInnerHTML={{ __html: DOMPurify.sanitize(item.biodata) }}
// Repeat for riwayat, pengalaman, unggulan
```
Setelah fix critical issues, module ini **PRODUCTION-READY** dan bisa jadi **REFERENCE** untuk modul lain! 🎉
---
## 📚 RECOMMENDED AS REFERENCE FOR OTHER MODULES
**PPID Profil Module adalah BEST PRACTICE untuk:**
1.**State management** - originalForm tracking pattern
2.**Edit form reset** - Comprehensive reset logic
3.**Modular form components** - Reusable design pattern
4.**Rich Text Editor** - Tiptap implementation
5.**Type safety** - Proper TypeScript typing
**Modules lain bisa belajar dari PPID Profil:**
- APBDes: Implement originalForm tracking
- Prestasi Desa: Implement originalForm tracking
- SDGs Desa: Implement originalForm tracking
- Desa Anti Korupsi: Implement originalForm tracking
- Profil (Media Sosial, Program Inovasi): Implement originalForm tracking
---
**File Location:** `QC/PPID/QC-PPID-PROFIL-MODULE.md` 📄

View File

@@ -1,936 +0,0 @@
# QC Summary - Struktur PPID Module
**Scope:** Struktur Organisasi (Organization Chart), Pegawai PPID, Posisi Organisasi
**Date:** 2026-02-23
**Status:** ✅ Secara umum sudah baik, ada beberapa improvement yang diperlukan
---
## 📊 OVERVIEW
| Sub-Module | Schema | API | UI Admin | State Management | Overall |
|------------|--------|-----|----------|-----------------|---------|
| Struktur Organisasi | ✅ Baik | ✅ Baik | ✅ **Excellent** | ✅ Baik | 🟢 |
| Posisi Organisasi | ⚠️ Ada issue | ✅ Baik | ✅ Baik | ⚠️ Ada issue | 🟡 |
| Pegawai PPID | ⚠️ Ada issue | ✅ Baik | ✅ Baik | ⚠️ Ada issue | 🟡 |
---
## ✅ YANG SUDAH BAIK
### **1. UI/UX - Organization Chart (UNIQUE FEATURE!)**
-**PrimeReact OrganizationChart** - Visual hierarchy yang excellent
- ✅ Interactive tree structure dengan expand/collapse
- ✅ Custom node template dengan foto, nama, dan posisi
- ✅ Responsive design dengan overflow handling
- ✅ Empty state yang informatif
- ✅ Loading state dengan spinner
**Code Example (✅ EXCELLENT):**
```typescript
// struktur-organisasi/page.tsx - Line ~45-75
const posisiMap = new Map<string, any>();
const aktifPegawai = stateOrganisasi.findManyAll.data?.filter(p => p.isActive);
for (const pegawai of aktifPegawai) {
const posisiId = pegawai.posisi.id;
if (!posisiMap.has(posisiId)) {
posisiMap.set(posisiId, {
...pegawai.posisi,
pegawaiList: [],
children: [],
});
}
posisiMap.get(posisiId)!.pegawaiList.push(pegawai);
}
// Build tree structure
let root: any[] = [];
posisiMap.forEach((posisi) => {
if (posisi.parentId) {
const parent = posisiMap.get(posisi.parentId);
if (parent) {
parent.children.push(posisi);
}
} else {
root.push(posisi);
}
});
// Convert to OrganizationChart format
function toOrgChartFormat(node: any): any {
return {
expanded: true,
type: 'person',
styleClass: 'p-person',
data: {
name: node.pegawaiList?.[0]?.namaLengkap || 'Belum ada pegawai',
status: node.nama,
image: node.pegawaiList?.[0]?.image?.link || '/img/default.png',
},
children: node.children.map(toOrgChartFormat),
};
}
```
**Verdict:****UNIQUE & EXCELLENT** - Satu-satunya modul dengan organization chart visual!
---
### **2. File Upload Handling**
- ✅ Dropzone dengan preview image
- ✅ Validasi format gambar (JPEG, JPG, PNG, WEBP)
- ✅ Validasi ukuran file (max 5MB)
- ✅ Tombol hapus preview (IconX di pojok kanan atas)
- ✅ URL.createObjectURL untuk preview lokal
### **3. Form Validation**
- ✅ Zod schema untuk validasi typed
- ✅ Email validation dengan regex
- ✅ Required field validation
- ✅ isFormValid() check sebelum submit
- ✅ Error toast dengan pesan spesifik
- ✅ Button disabled saat invalid/loading
### **4. CRUD Operations**
- ✅ Create dengan upload file
- ✅ FindMany dengan pagination & search
- ✅ FindUnique untuk detail
- ✅ Delete dengan hard delete
- ✅ Update dengan file replacement
-**Non-active feature** untuk soft disable pegawai
### **5. State Management**
- ✅ Proper typing dengan Prisma types
- ✅ Loading state management dengan finally block
- ✅ Error handling yang comprehensive
- ✅ Reset function untuk cleanup
- ✅ findManyAll untuk organization chart data
**Code Example (✅ GOOD):**
```typescript
// state file - Line ~270-290
findManyAll: {
data: null as Prisma.PegawaiPPIDGetPayload<{...}>[] | null,
loading: false,
search: "",
load: async (search = "") => {
posisiOrganisasi.findManyAll.loading = true; // ✅ Start loading
posisiOrganisasi.findManyAll.search = search;
try {
const query: any = { search };
if (search) query.search = search;
const res = await ApiFetch.api.ppid.strukturppid.pegawai["find-many-all"].get({ query });
if (res.status === 200 && res.data?.success) {
posisiOrganisasi.findManyAll.data = res.data.data || [];
}
} catch (error) {
console.error("Error loading pegawai:", error);
posisiOrganisasi.findManyAll.data = [];
} finally {
posisiOrganisasi.findManyAll.loading = false; // ✅ Stop loading
}
},
}
```
**Verdict:****BAIK** - Loading state management sudah proper!
---
### **6. Edit Form - Original Data Tracking**
- ✅ Original data state untuk reset form
- ✅ Load data existing dengan benar
- ✅ Preview image dari data lama
- ✅ Reset form mengembalikan ke data original
- ✅ File replacement logic (upload baru jika ada perubahan)
**Code Example (✅ GOOD):**
```typescript
// edit/page.tsx - Line ~80-115
const [originalData, setOriginalData] = useState({
namaLengkap: "",
gelarAkademik: "",
imageId: "",
tanggalMasuk: "",
email: "",
telepon: "",
alamat: "",
posisiId: "",
imageUrl: "",
isActive: true,
});
// Load data
const data = await stateOrganisasi.edit.load(id);
setOriginalData({
...data,
imageUrl: data.image?.link || '',
});
setPreviewImage(data.image?.link || null);
// Line ~135 - Handle reset
const handleResetForm = () => {
setFormData({
namaLengkap: originalData.namaLengkap,
gelarAkademik: originalData.gelarAkademik,
imageId: originalData.imageId,
tanggalMasuk: originalData.tanggalMasuk,
email: originalData.email,
telepon: originalData.telepon,
alamat: originalData.alamat,
posisiId: originalData.posisiId,
isActive: originalData.isActive,
});
setPreviewImage(originalData.imageUrl || null);
setFile(null);
toast.info("Form dikembalikan ke data awal");
};
```
**Verdict:****BAIK** - Original data tracking sudah implementasi dengan baik!
---
### **7. Unique Features**
-**Organization Chart** - Visual hierarchy tree (UNIQUE!)
-**Hierarchical Positions** - Parent-child relationships
-**Active/Non-active Toggle** - Soft disable untuk pegawai
-**Email Validation** - Regex validation untuk email format
-**Date Input Handling** - Proper date formatting untuk tanggal masuk
---
## ⚠️ ISSUES & SARAN PERBAIKAN
### **🔴 CRITICAL**
#### **1. Schema - Missing deletedAt for Soft Delete**
**Lokasi:** `prisma/schema.prisma` (line 327-332, 343-351)
**Masalah:**
```prisma
model PosisiOrganisasiPPID {
// ...
isActive Boolean @default(true)
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
// ❌ MISSING: deletedAt field untuk soft delete
}
model PegawaiPPID {
// ...
isActive Boolean @default(true)
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
// ❌ MISSING: deletedAt field untuk soft delete
}
```
**Dampak:**
- **INCONSISTENT!** Model `StrukturOrganisasiPPID` punya `deletedAt`, tapi Posisi dan Pegawai tidak
- Hard delete vs soft delete inconsistency
- Data integrity issue saat delete (data hilang permanen)
- Tidak bisa restore data yang ter-delete
**Rekomendasi:** Add deletedAt field:
```prisma
model PosisiOrganisasiPPID {
// ...
isActive Boolean @default(true)
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime? @default(null) // ✅ Add for soft delete
}
model PegawaiPPID {
// ...
isActive Boolean @default(true)
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime? @default(null) // ✅ Add for soft delete
}
```
**Priority:** 🔴 **HIGH**
**Effort:** Medium (perlu migration)
**Impact:** **HIGH** (data integrity & consistency)
---
#### **2. State Management - Fetch Pattern Inconsistency**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/struktur_ppid/struktur_PPID.ts`
**Masalah:** Ada 2 pattern berbeda untuk fetch API:
```typescript
// ❌ Pattern 1: ApiFetch (create, findMany, findManyAll)
const res = await ApiFetch.api.ppid.strukturppid.pegawai["create"].post(pegawai.create.form);
const res = await ApiFetch.api.ppid.strukturppid.pegawai["find-many"].get({ query });
const res = await ApiFetch.api.ppid.strukturppid.pegawai["find-many-all"].get({ query });
// ❌ Pattern 2: fetch manual (findUnique, edit, delete, nonActive)
const res = await fetch(`/api/ppid/strukturppid/pegawai/${id}`);
const res = await fetch(`/api/ppid/strukturppid/pegawai/del/${id}`, { method: "DELETE" });
const res = await fetch(`/api/ppid/strukturppid/pegawai/non-active/${id}`, { method: "DELETE" });
```
**Dampak:**
- Code consistency buruk
- Sulit maintenance
- Type safety tidak konsisten
- Duplikasi logic error handling
**Rekomendasi:** Gunakan **ApiFetch** untuk semua operasi:
```typescript
// ✅ Unified pattern
async load(id: string) {
try {
const res = await ApiFetch.api.ppid.strukturppid.pegawai[id].get();
if (res.data?.success) {
const data = res.data.data;
this.id = data.id;
this.form = {
namaLengkap: data.namaLengkap,
gelarAkademik: data.gelarAkademik,
imageId: data.imageId,
tanggalMasuk: data.tanggalMasuk,
email: data.email,
telepon: data.telepon,
alamat: data.alamat,
posisiId: data.posisiId,
isActive: data.isActive,
};
return data;
} else {
throw new Error(res.data?.message || "Gagal memuat data");
}
} catch (error) {
console.error("Error loading pegawai:", error);
toast.error(error instanceof Error ? error.message : "Gagal memuat data");
return null;
}
}
async byId(id: string) {
try {
const res = await ApiFetch.api.ppid.strukturppid.pegawai["del"][id].delete();
if (res.data?.success) {
toast.success(res.data.message || "Berhasil hapus pegawai");
await pegawai.findMany.load();
} else {
toast.error(res.data?.message || "Gagal hapus pegawai");
}
} catch (error) {
console.error("Gagal delete:", error);
toast.error("Terjadi kesalahan saat menghapus");
}
}
```
**Priority:** 🔴 High
**Effort:** Medium (refactor di semua methods)
---
#### **3. HTML Injection Risk - dangerouslySetInnerHTML**
**Lokasi:**
- `posisi-organisasi/page.tsx` (line ~95, 155)
- `posisi-organisasi/create/page.tsx` (CreateEditor component)
- `posisi-organisasi/[id]/edit/page.tsx` (EditEditor component)
**Masalah:**
```typescript
// ❌ Direct HTML render tanpa sanitization
<Text
fz="sm"
lh={1.5}
c="dimmed"
lineClamp={1}
dangerouslySetInnerHTML={{ __html: item.deskripsi || '-' }}
/>
```
**Risk:**
- XSS attack jika admin input script malicious
- Bisa inject iframe, script tag, dll
- Security vulnerability
**Rekomendasi:** Gunakan DOMPurify atau library sanitization:
```typescript
import DOMPurify from 'dompurify';
// Sanitize sebelum render
const sanitizedDeskripsi = DOMPurify.sanitize(item.deskripsi);
<Text
dangerouslySetInnerHTML={{ __html: sanitizedDeskripsi }}
// ...
/>
```
Atau validasi di backend untuk whitelist tag HTML yang diperbolehkan.
**Priority:** 🔴 **HIGH** (**Security concern**)
**Effort:** Low
---
### **🟡 MEDIUM**
#### **4. Console.log di Production**
**Lokasi:** Multiple places di state file
**Masalah:**
```typescript
// Line ~65
console.error("Load struktur error:", errorMessage);
// Line ~130
console.error("Update struktur error:", errorMessage);
// Line ~220
console.error("Failed to fetch posisiOrganisasi:", res.statusText);
// Line ~224
console.error("Error fetching posisiOrganisasi:", error);
// Line ~370
console.error("Gagal fetch posisi organisasi paginated:", err);
// Line ~400
console.error("Failed to load posisiOrganisasi:", res.data?.message);
// Line ~404
console.error("Error loading posisiOrganisasi:", error);
// ... dan banyak lagi
```
**Rekomendasi:** Gunakan conditional logging:
```typescript
if (process.env.NODE_ENV === 'development') {
console.error("Error:", error);
}
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **5. Type Safety - Any Usage**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/struktur_ppid/struktur_PPID.ts`
**Masalah:**
```typescript
// Line ~190
const query: any = { page, limit: appliedLimit }; // ❌ Using 'any'
if (search) query.search = search;
// Line ~215
const query: any = { search }; // ❌ Using 'any'
if (search) query.search = search;
// Line ~365
const query: any = { page, limit }; // ❌ Using 'any'
if (search) query.search = search;
// Line ~395
const query: any = { search }; // ❌ Using 'any'
if (search) query.search = search;
```
**Rekomendasi:** Gunakan typed query:
```typescript
// Define type
interface FindManyQuery {
page: number | string;
limit?: number | string;
search?: string;
}
// Use typed query
const query: FindManyQuery = { page, limit: appliedLimit };
if (search) query.search = search;
```
**Priority:** 🟡 Medium
**Effort:** Low
---
#### **6. Error Message Tidak Konsisten**
**Lokasi:** Multiple places
**Masalah:**
```typescript
// Create posisi - Line ~180
toast.error("Terjadi kesalahan saat menambahkan posisi");
// Create pegawai - Line ~280
toast.error("Terjadi kesalahan saat menambahkan pegawai");
// Delete - Line ~430
toast.error("Terjadi kesalahan saat menghapus posisi organisasi");
// Edit - Line ~520
toast.error("Gagal memuat data");
// Update - Line ~560
toast.error("Gagal mengupdate posisi organisasi");
```
**Issue:**
- Generic error messages
- Inconsistent patterns ("Terjadi kesalahan" vs "Gagal")
- Tidak spesifik ke resource type
**Rekomendasi:** Standardisasi error messages:
```typescript
// Pattern: "[Action] [resource] gagal"
toast.error("Menambahkan Posisi Organisasi gagal");
toast.error("Menghapus Posisi Organisasi gagal");
toast.error("Memuat data Posisi Organisasi gagal");
toast.error("Memperbarui data Posisi Organisasi gagal");
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **7. Zod Schema - Error Message Tidak Konsisten**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/struktur_ppid/struktur_PPID.ts`
**Masalah:**
```typescript
// Line ~170
const templatePosisiOrganisasi = z.object({
nama: z.string().min(1, "Nama harus diisi"), // ✅ OK
deskripsi: z.string().optional(), // ⚠️ No min message
hierarki: z.number().int().positive("Hierarki harus angka positif"), // ✅ OK
});
// Line ~450
const templatePegawai = z.object({
namaLengkap: z.string().min(1, "Nama wajib diisi"), // ✅ OK
gelarAkademik: z.string().min(1, "Gelar Akademik wajib diisi"), // ✅ OK
imageId: z.string().min(1, "Gambar wajib dipilih"), // ✅ OK
tanggalMasuk: z.string().min(1, "Tanggal masuk wajib diisi"), // ✅ OK
email: z.string().email("Email tidak valid").optional(), // ⚠️ Optional tapi ada validation
telepon: z.string().min(1, "Telepom wajib diisi"), // ❌ Typo: "Telepom"
alamat: z.string().min(1, "Alamat wajib diisi"), // ✅ OK
posisiId: z.string().min(1, "Posisi wajib diisi"), // ✅ OK
isActive: z.boolean().default(true), // ✅ OK
});
```
**Rekomendasi:** Fix typo dan standardisasi:
```typescript
const templatePegawai = z.object({
namaLengkap: z.string().min(1, "Nama lengkap wajib diisi"),
gelarAkademik: z.string().min(1, "Gelar akademik wajib diisi"),
imageId: z.string().min(1, "Foto profil wajib diunggah"),
tanggalMasuk: z.string().min(1, "Tanggal masuk wajib diisi"),
email: z.string().email("Format email tidak valid").optional().or(z.literal('')),
telepon: z.string().min(1, "Nomor telepon wajib diisi"), // ✅ Fix typo
alamat: z.string().min(1, "Alamat wajib diisi"),
posisiId: z.string().min(1, "Posisi wajib dipilih"),
isActive: z.boolean().default(true),
});
```
**Priority:** 🟡 Low
**Effort:** Low
---
### **🟢 LOW (Minor Polish)**
#### **8. Pagination onChange Tidak Include Search**
**Lokasi:** `pegawai/page.tsx`
**Masalah:**
```typescript
// Line ~170
<Pagination
value={page}
onChange={(newPage) => {
load(newPage, 10); // ⚠️ Missing search parameter
window.scrollTo(0, 0);
}}
total={totalPages}
// ...
/>
```
**Issue:** Saat ganti page, search query hilang.
**Rekomendasi:** Include search:
```typescript
onChange={(newPage) => {
load(newPage, 10, debouncedSearch); // ✅ Include search
window.scrollTo(0, 0);
}}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **9. Missing Loading State di Submit Button**
**Lokasi:** `pegawai/create/page.tsx`, `pegawai/[id]/edit/page.tsx`
**Masalah:**
```typescript
// create/page.tsx - Line ~240
<Button
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
// ...
>
{isSubmitting ? <Loader size="sm" color="white" /> : 'Simpan'}
</Button>
```
**Issue:** Button tidak check `stateOrganisasi.create.loading` dari global state.
**Rekomendasi:** Check both states:
```typescript
disabled={!isFormValid() || isSubmitting || stateOrganisasi.create.loading}
{isSubmitting || stateOrganisasi.create.loading ? (
<Loader size="sm" color="white" />
) : (
'Simpan'
)}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **10. Duplicate Error Logging**
**Lokasi:** Multiple files
**Masalah:**
```typescript
// edit/page.tsx - Line ~120
} catch (error) {
console.error('Error loading pegawai:', error); // ❌ Duplicate
toast.error(error instanceof Error ? error.message : 'Gagal memperbarui data pegawai');
}
// edit/page.tsx - Line ~160
} catch (error) {
console.error('Error updating pegawai:', error); // ❌ Duplicate
toast.error(error instanceof Error ? error.message : 'Gagal memperbarui data pegawai');
}
```
**Rekomendasi:** Cukup satu logging yang informatif:
```typescript
} catch (error) {
console.error('Failed to load Pegawai:', err);
toast.error('Gagal memuat data Pegawai');
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **11. Button Label Inconsistency**
**Lokasi:** Multiple files
**Masalah:**
```typescript
// create/page.tsx - Line ~230
<Button ...>Reset</Button>
// edit/page.tsx - Line ~140
<Button ...>Batal</Button>
// Should be consistent: "Reset" atau "Batal"
```
**Rekomendasi:** Standardisasi:
```typescript
// Create: "Reset"
// Edit: "Batal" (lebih descriptive untuk cancel changes)
// OR both: "Reset" / "Batal"
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **12. Search Placeholder Tidak Spesifik**
**Lokasi:**
- `pegawai/page.tsx`: `placeholder='Cari nama pegawai atau posisi...'` ✅ Spesifik
- `posisi-organisasi/page.tsx`: `placeholder='Cari posisi organisasi...'` ✅ OK
**Verdict:****SUDAH BENAR** - Placeholder sudah spesifik.
**Priority:** 🟢 None
**Effort:** None
---
#### **13. Non-Active Endpoint Method**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/struktur_ppid/struktur_PPID.ts`
**Masalah:**
```typescript
// Line ~490
nonActive: {
loading: false,
async byId(id: string) {
// ...
const res = await fetch(`/api/ppid/strukturppid/pegawai/non-active/${id}`, {
method: "DELETE", // ⚠️ Biasanya nonActive pakai PATCH atau PUT
});
// ...
},
}
```
**Issue:** Method "DELETE" untuk non-active agak confusing. Biasanya pakai "PATCH" atau "PUT".
**Rekomendasi:** Consider using PATCH:
```typescript
const res = await fetch(`/api/ppid/strukturppid/pegawai/non-active/${id}`, {
method: "PATCH", // ✅ More semantic for toggle active/inactive
headers: { "Content-Type": "application/json" },
body: JSON.stringify({ isActive: false }),
});
```
**Priority:** 🟢 Low
**Effort:** Low (perlu update API juga)
---
#### **14. OrganizationChart - Missing Expand/Collapse Controls**
**Lokasi:** `struktur-organisasi/page.tsx`
**Masalah:**
```typescript
// Line ~80
<OrganizationChart value={chartData} nodeTemplate={nodeTemplate} />
```
**Issue:** Tidak ada controls untuk expand/collapse all nodes.
**Rekomendasi:** Add toggle button:
```typescript
const [expanded, setExpanded] = useState(true);
const toggleAll = () => {
const newExpanded = !expanded;
setExpanded(newExpanded);
// Update chartData dengan expanded: newExpanded untuk semua nodes
};
return (
<Box>
<Group justify="flex-end" mb="md">
<Button size="xs" onClick={toggleAll}>
{expanded ? 'Collapse All' : 'Expand All'}
</Button>
</Group>
<OrganizationChart value={chartData} nodeTemplate={nodeTemplate} />
</Box>
);
```
**Priority:** 🟢 Low
**Effort:** Low
---
## 📋 RINGKASAN ACTION ITEMS
| Priority | Issue | Module | Impact | Effort | Status |
|----------|-------|--------|--------|--------|--------|
| 🔴 P0 | **Schema missing deletedAt** | Schema | **HIGH** | Medium | **MUST FIX** |
| 🔴 P0 | Fetch method inconsistency | State | Medium | Medium | Perlu refactor |
| 🔴 P1 | **HTML injection risk** | UI | **HIGH (Security)** | Low | **Should fix** |
| 🟡 M | Console.log in production | State | Low | Low | Optional |
| 🟡 M | Type safety (any usage) | State | Low | Low | Optional |
| 🟡 M | Error message inconsistency | State/UI | Low | Low | Optional |
| 🟡 M | Zod schema typo ("Telepom") | State | Low | Low | Should fix |
| 🟢 L | Pagination missing search param | Pegawai UI | Low | Low | Should fix |
| 🟢 L | Missing loading state di submit button | UI | Low | Low | Optional |
| 🟢 L | Duplicate error logging | UI | Low | Low | Optional |
| 🟢 L | Button label inconsistency | UI | Low | Low | Optional |
| 🟢 L | Non-active endpoint method | API | Low | Low | Optional |
| 🟢 L | OrganizationChart expand/collapse controls | UI | Low | Low | Nice to have |
---
## ✅ KESIMPULAN
### **Overall Quality: 🟢 BAIK (8/10)**
**Strengths:**
1.**Organization Chart** - Unique visual hierarchy feature (EXCELLENT!)
2. ✅ UI/UX clean & responsive
3. ✅ File upload handling solid
4. ✅ Form validation comprehensive (email validation, required fields)
5. ✅ State management terstruktur (Valtio)
6.**Edit form reset sudah benar** (original data tracking)
7.**Active/Non-active toggle** untuk pegawai
8. ✅ Loading state management dengan finally block
9. ✅ findManyAll untuk organization chart data
**Critical Issues:**
1. ⚠️ **Schema missing deletedAt** - Inconsistency dengan StrukturOrganisasiPPID (HIGH)
2. ⚠️ Fetch method pattern inconsistency (ApiFetch vs fetch manual)
3. ⚠️ **HTML injection risk** di deskripsi posisi (HIGH Security)
**Areas for Improvement:**
1. ⚠️ **Add deletedAt field** ke PosisiOrganisasiPPID dan PegawaiPPID
2. ⚠️ **Refactor fetch methods** untuk gunakan ApiFetch consistently
3. ⚠️ **Fix HTML injection** dengan DOMPurify atau backend validation
4. ⚠️ **Fix typo** "Telepom" → "Telepon" di Zod schema
5. ⚠️ **Improve type safety** dengan remove `any` usage
**Recommended Next Steps:**
1. **🔴 CRITICAL: Add schema deletedAt** - 30 menit (perlu migration)
2. **🔴 HIGH: Fix HTML injection** dengan DOMPurify - 30 menit
3. **🔴 HIGH: Refactor fetch methods** ke ApiFetch - 1 jam
4. **🟡 MEDIUM: Fix typo** di Zod schema - 5 menit
5. **🟢 LOW: Add pagination search param** - 10 menit
6. **🟢 LOW: Polish minor issues** - 30 menit
---
## 📈 COMPARISON WITH OTHER MODULES
| Module | Unique Features | Schema | State | Edit Reset | Overall |
|--------|----------------|--------|-------|------------|---------|
| Profil | ❌ None | ✅ Good | ⚠️ Good | ✅ Good | 🟢 |
| Desa Anti Korupsi | ❌ None | ⚠️ deletedAt | ⚠️ Good | ✅ Good | 🟢 |
| SDGs Desa | ❌ None | ⚠️ deletedAt | ⚠️ Good | ✅ Good | 🟢 |
| APBDes | ✅ Dual upload, Items hierarchy | ✅ **Best** | ⚠️ Good | ✅ Good | 🟢 |
| Prestasi Desa | ❌ None | ⚠️ deletedAt | ⚠️ Good | ✅ Good | 🟢 |
| PPID Profil | ✅ Rich Text, Modular forms | ⚠️ deletedAt | ✅ **Best** | ✅ **Excellent** | 🟢⭐ |
| **Struktur PPID** | ✅ **Org Chart**, Hierarchy, Non-active | ⚠️ Inconsistent | ✅ Good | ✅ Good | 🟢 |
**Struktur PPID Highlights:**
-**UNIQUE:** Organization Chart visualization (no other module has this!)
-**UNIQUE:** Hierarchical position structure (parent-child)
-**UNIQUE:** Active/Non-active toggle feature
-**GOOD:** Email validation dengan regex
- ⚠️ **ISSUE:** Schema inconsistency (deletedAt missing di 2 models)
---
## 🎯 UNIQUE FEATURES OF STRUKTUR PPID MODULE
**Most Unique Module:**
1.**PrimeReact OrganizationChart** - Visual tree hierarchy (UNIQUE!)
2.**Parent-child position relationships** - Hierarchical structure
3.**Active/Non-active toggle** - Soft disable tanpa delete
4.**Email validation** - Regex validation untuk email format
5.**findManyAll pattern** - Load all data untuk organization chart
**Best Practices:**
1. ✅ Organization chart implementation excellent
2. ✅ Loading state management proper (dengan finally block)
3. ✅ Edit form reset comprehensive (original data tracking)
4. ✅ Email validation di form (create & edit)
5. ✅ Date input handling untuk tanggal masuk
**Critical Issues:**
1.**Schema deletedAt missing** - Inconsistency issue
2.**HTML injection risk** - Same issue as modul lain dengan rich text
---
**Catatan:** Secara keseluruhan, modul **Struktur PPID adalah YANG PALING UNIQUE** dengan Organization Chart visualization yang excellent. Module ini punya fitur-fitur yang tidak ada di modul lain (hierarchical positions, org chart, active/non-active toggle).
**Unique Strengths:**
1.**Organization Chart** - Best visual representation
2.**Hierarchical data structure** - Parent-child relationships
3.**Active/Non-active feature** - Soft disable tanpa delete
4.**Email validation** - Comprehensive form validation
**Priority Action:**
```diff
🔴 FIX INI SEKARANG (30 MENIT + MIGRATION):
File: prisma/schema.prisma
Line: 327-332, 343-351
model PosisiOrganisasiPPID {
// ...
isActive Boolean @default(true)
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
+ deletedAt DateTime? @default(null) // ✅ Add for soft delete
}
model PegawaiPPID {
// ...
isActive Boolean @default(true)
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
+ deletedAt DateTime? @default(null) // ✅ Add for soft delete
}
# Lalu jalankan:
bunx prisma db push
# atau
bunx prisma migrate dev --name add_deletedat_struktur_ppid
```
```diff
🔴 FIX HTML INJECTION (30 MENIT):
File: posisi-organisasi/page.tsx
+ import DOMPurify from 'dompurify';
// Line ~95
- dangerouslySetInnerHTML={{ __html: item.deskripsi || '-' }}
+ dangerouslySetInnerHTML={{ __html: DOMPurify.sanitize(item.deskripsi) }}
// Repeat for mobile view line ~155
```
Setelah fix critical issues, module ini **PRODUCTION-READY** dan **ORGANIZATION CHART** adalah fitur yang bisa jadi **SHOWCASE**! 🎉
---
**File Location:** `QC/PPID/QC-STRUKTUR-PPID-MODULE.md` 📄

View File

@@ -1,797 +0,0 @@
# QC Summary - Visi Misi PPID Module
**Scope:** Preview Visi Misi, Edit Visi Misi dengan Rich Text Editor
**Date:** 2026-02-23
**Status:** ✅ Secara umum sudah baik, ada beberapa improvement yang diperlukan
---
## 📊 OVERVIEW
| Aspect | Schema | API | UI Admin | State Management | Overall |
|--------|--------|-----|----------|-----------------|---------|
| Visi Misi PPID | ⚠️ Ada issue | ✅ Baik | ✅ Baik | ✅ Baik | 🟡 Perlu fix |
---
## ✅ YANG SUDAH BAIK
### **1. UI/UX Design**
- ✅ Preview layout yang clean dengan logo desa
- ✅ Responsive design (mobile & desktop)
- ✅ Loading states dengan Skeleton
- ✅ Empty state handling yang informatif
- ✅ Edit button yang prominent
- ✅ Divider visual yang jelas antara Visi dan Misi
### **2. Rich Text Editor (Tiptap)**
- ✅ Full-featured editor dengan toolbar lengkap
- ✅ Extensions: Bold, Italic, Underline, Highlight, Link, dll
- ✅ Text alignment (left, center, justify, right)
- ✅ Heading levels (H1-H4)
- ✅ Lists (bullet & ordered)
- ✅ Blockquote, code, superscript, subscript
- ✅ Undo/Redo
- ✅ Sticky toolbar untuk UX yang lebih baik
-`immediatelyRender: false` untuk menghindari hydration mismatch
### **3. Form Component Structure**
- ✅ Modular form components (VisiPPID, MisiPPID)
- ✅ Reusable PPIDTextEditor component
- ✅ Proper TypeScript typing
- ✅ Controlled components dengan onChange handler
### **4. State Management**
- ✅ Proper typing dengan Prisma types
- ✅ Loading state management dengan finally block
- ✅ Error handling yang comprehensive
-**ApiFetch consistency** - Semua operasi pakai ApiFetch! ✅
- ✅ Zod validation untuk form data
**Code Example (✅ EXCELLENT):**
```typescript
// state file - Line ~30-50
findById: {
data: null as VisiMisiPPIDForm | null,
loading: false,
initialize() {
stateVisiMisiPPID.findById.data = {
id: "",
misi: "",
visi: "",
} as VisiMisiPPIDForm;
},
async load(id: string) {
try {
stateVisiMisiPPID.findById.loading = true; // ✅ Start loading
const res = await ApiFetch.api.ppid.visimisippid["find-by-id"].get({
query: { id },
});
if (res.status === 200) {
stateVisiMisiPPID.findById.data = res.data?.data ?? null;
}
} catch (error) {
console.error((error as Error).message);
toast.error("Terjadi kesalahan saat mengambil data visi misi");
} finally {
stateVisiMisiPPID.findById.loading = false; // ✅ Stop loading
}
},
}
```
**Verdict:****SANGAT BAIK** - State management sudah konsisten dengan ApiFetch!
---
### **5. Edit Form - Original Data Tracking**
- ✅ Original data state untuk reset form
- ✅ Load data existing dengan benar
- ✅ Reset form mengembalikan ke data original
- ✅ Rich text content handling yang proper
**Code Example (✅ GOOD):**
```typescript
// edit/page.tsx - Line ~20-45
const [formData, setFormData] = useState({ visi: '', misi: '' });
const [originalData, setOriginalData] = useState({ visi: '', misi: '' });
// Initialize from global state
useEffect(() => {
if (visiMisi.findById.data) {
setFormData({
visi: visiMisi.findById.data.visi ?? '',
misi: visiMisi.findById.data.misi ?? '',
});
setOriginalData({
visi: visiMisi.findById.data.visi ?? '',
misi: visiMisi.findById.data.misi ?? '',
});
}
}, [visiMisi.findById.data]);
// Line ~60 - Handle reset
const handleResetForm = () => {
setFormData({
visi: originalData.visi,
misi: originalData.misi,
});
toast.info('Form dikembalikan ke data awal');
};
```
**Verdict:****BAIK** - Original data tracking sudah implementasi dengan baik!
---
### **6. Rich Text Validation**
- ✅ Custom validation function untuk rich text content
- ✅ Check empty content setelah remove HTML tags
**Code Example (✅ GOOD):**
```typescript
// edit/page.tsx - Line ~25-35
const isRichTextEmpty = (content: string) => {
// Remove HTML tags and check if the resulting text is empty
const plainText = content.replace(/<[^>]*>/g, '').trim();
return plainText === '' || content.trim() === '<p></p>' || content.trim() === '<p><br></p>';
};
const isFormValid = () => {
return (
!isRichTextEmpty(formData.visi) &&
!isRichTextEmpty(formData.misi)
);
};
```
**Verdict:****EXCELLENT** - Rich text validation yang comprehensive!
---
## ⚠️ ISSUES & SARAN PERBAIKAN
### **🔴 CRITICAL**
#### **1. Schema - deletedAt Default Value SALAH**
**Lokasi:** `prisma/schema.prisma` (line 374)
**Masalah:**
```prisma
model VisiMisiPPID {
id String @id @default(cuid())
visi String @db.Text
misi String @db.Text
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now()) // ❌ SALAH - selalu punya default value
isActive Boolean @default(true)
}
```
**Dampak:**
- **LOGIC ERROR!** Setiap record baru langsung punya `deletedAt` value (timestamp creation)
- Soft delete tidak berfungsi dengan benar
- Query dengan `where: { deletedAt: null }` tidak akan pernah return data
- Data yang "dihapus" vs data "aktif" tidak bisa dibedakan
**Contoh Issue:**
```prisma
// Record baru dibuat
CREATE VisiMisiPPID {
visi: "Visi 1",
misi: "Misi 1",
// deletedAt otomatis ter-set ke now() ❌
// isActive: true ✅
}
// Query untuk data aktif (seharusnya return data ini)
prisma.visiMisiPPID.findMany({
where: { deletedAt: null, isActive: true }
})
// ❌ Return kosong! Karena deletedAt sudah ter-set
```
**Rekomendasi:** Fix schema:
```prisma
model VisiMisiPPID {
id String @id @default(cuid())
visi String @db.Text
misi String @db.Text
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime? @default(null) // ✅ Nullable, null = not deleted
isActive Boolean @default(true)
}
```
**Priority:** 🔴 **CRITICAL**
**Effort:** Medium (perlu migration)
**Impact:** **HIGH** (data integrity & soft delete logic)
---
#### **2. HTML Injection Risk - dangerouslySetInnerHTML**
**Lokasi:** `page.tsx` (preview page)
**Masalah:**
```typescript
// Line ~85-95
<Text
ta={{ base: "center", md: "justify" }}
dangerouslySetInnerHTML={{ __html: listVisiMisi.findById.data.visi }} // ❌ No sanitization
style={{ ... }}
/>
// Line ~105-115 (Misi)
<Text
ta={"justify"}
dangerouslySetInnerHTML={{ __html: listVisiMisi.findById.data.misi }} // ❌ No sanitization
style={{ ... }}
/>
```
**Risk:**
- XSS attack jika admin input script malicious
- Bisa inject iframe, script tag, dll
- Security vulnerability
**Rekomendasi:** Gunakan DOMPurify atau library sanitization:
```typescript
import DOMPurify from 'dompurify';
// Sanitize sebelum render
const sanitizedVisi = DOMPurify.sanitize(listVisiMisi.findById.data.visi);
const sanitizedMisi = DOMPurify.sanitize(listVisiMisi.findById.data.misi);
<Text
dangerouslySetInnerHTML={{ __html: sanitizedVisi }}
// ...
/>
```
Atau validasi di backend untuk whitelist tag HTML yang diperbolehkan (hanya `<p>`, `<ul>`, `<li>`, `<strong>`, dll).
**Priority:** 🔴 **HIGH** (**Security concern**)
**Effort:** Low
---
#### **3. Missing Delete/Hard Delete Protection**
**Lokasi:** `page.tsx`, `edit/page.tsx`
**Masalah:**
- ❌ Tidak ada tombol delete untuk Visi Misi (correct - single record)
-**GOOD:** Single record pattern yang benar
- ⚠️ **ISSUE:** Tidak ada konfirmasi sebelum update (direct save)
**Issue:** User bisa accidentally save changes tanpa konfirmasi.
**Rekomendasi:** Add confirmation dialog sebelum save:
```typescript
const submit = () => {
// Check if data has changed
if (formData.visi === originalData.visi && formData.misi === originalData.misi) {
toast.info('Tidak ada perubahan');
return;
}
// Show confirmation
const confirmed = window.confirm('Apakah Anda yakin ingin mengubah Visi Misi PPID?');
if (!confirmed) return;
// Then save...
};
```
**Priority:** 🔴 Medium
**Effort:** Low
---
### **🟡 MEDIUM**
#### **4. Console.log di Production**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/visi_misi_ppid/visimisiPPID.ts`
**Masalah:**
```typescript
// Line ~40
console.error((error as Error).message);
// Line ~65
console.error((error as Error).message);
```
**Rekomendasi:** Gunakan conditional logging:
```typescript
if (process.env.NODE_ENV === 'development') {
console.error("Error:", error);
}
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **5. Missing Loading State di Submit Button**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~120-130
<Button
onClick={submit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
// ...
>
{isSubmitting ? <Loader size="sm" color="white" /> : 'Simpan'}
</Button>
```
**Issue:** Button tidak check `visiMisi.update.loading` dari global state.
**Rekomendasi:** Check both states:
```typescript
disabled={!isFormValid() || isSubmitting || visiMisi.update.loading}
{isSubmitting || visiMisi.update.loading ? (
<Loader size="sm" color="white" />
) : (
'Simpan'
)}
```
**Priority:** 🟡 Low
**Effort:** Low
---
#### **6. Zod Schema - Could Be More Specific**
**Lokasi:** `src/app/admin/(dashboard)/_state/ppid/visi_misi_ppid/visimisiPPID.ts`
**Masalah:**
```typescript
// Line ~7
const templateForm = z.object({
misi: z.string().min(3, "Misi minimal 3 karakter"), // ⚠️ Generic
visi: z.string().min(3, "Visi minimal 3 karakter"), // ⚠️ Generic
});
```
**Rekomendasi:** More specific error messages:
```typescript
const templateForm = z.object({
misi: z.string().min(3, "Misi PPID minimal 3 karakter"),
visi: z.string().min(3, "Visi PPID minimal 3 karakter"),
});
```
**Priority:** 🟡 Low
**Effort:** Low
---
### **🟢 LOW (Minor Polish)**
#### **7. Missing Change Detection**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~70-80
const submit = () => {
try {
setIsSubmitting(true);
if (visiMisi.findById.data) {
// update nilai global hanya saat submit
visiMisi.findById.data.visi = formData.visi;
visiMisi.findById.data.misi = formData.misi;
visiMisi.update.save(visiMisi.findById.data);
}
router.push('/admin/ppid/visi-misi-ppid');
} catch (error) {
console.error("Error updating visi misi:", error);
toast.error("Terjadi kesalahan saat memperbarui visi misi");
} finally {
setIsSubmitting(false);
}
};
```
**Issue:** Tidak ada check apakah data sudah berubah. User bisa save tanpa perubahan.
**Rekomendasi:** Add change detection:
```typescript
const submit = () => {
// Check if data has changed
if (formData.visi === originalData.visi && formData.misi === originalData.misi) {
toast.info('Tidak ada perubahan');
return;
}
try {
setIsSubmitting(true);
// ... rest of save logic
}
};
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **8. Editor - Duplicate useEffect**
**Lokasi:** `PPIDTextEditor.tsx`
**Masalah:**
```typescript
// Line ~30-35
const editor = useEditor({
extensions: [...],
immediatelyRender: false,
content: initialContent, // ✅ Set content directly
onUpdate: ({editor}) => {
onChange(editor.getHTML()) // ✅ Handle changes
}
});
// Line ~37-42
useEffect(() => {
if (editor && initialContent !== editor.getHTML()) {
editor.commands.setContent(initialContent || '<p></p>');
}
}, [initialContent, editor]);
```
**Issue:** Ada useEffect tambahan untuk set content, padahal sudah ada di `useEditor`. Bisa menyebabkan double content update.
**Rekomendasi:** Simplify - remove useEffect:
```typescript
const editor = useEditor({
extensions: [...],
immediatelyRender: false,
content: initialContent || '<p></p>', // ✅ Set content directly
onUpdate: ({editor}) => {
onChange(editor.getHTML())
},
editorProps: {
// Optional: handle content updates better
}
});
// Remove useEffect completely
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **9. Missing Error Boundary**
**Lokasi:** `edit/page.tsx`
**Masalah:**
- Tidak ada error boundary untuk handle unexpected errors
- Jika editor gagal load, tidak ada fallback UI
**Rekomendasi:** Add error boundary:
```typescript
if (visiMisi.findById.error) {
return (
<Alert icon={<IconAlertCircle />} color="red">
<Text fw="bold">Error</Text>
<Text>{visiMisi.findById.error}</Text>
</Alert>
);
}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **10. Preview Page - Hardcoded Moto PPID**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~60-70
<Text
ta="center"
fz={{ base: 'sm', md: 'md' }}
lh={{ base: 1.5, md: 1.5 }}
mt="sm"
c="black"
>
MEMBERIKAN INFORMASI YANG CEPAT, MUDAH, TEPAT DAN TRANSPARAN
</Text>
```
**Issue:** Moto PPID hardcoded di UI. Seharusnya dari database/config.
**Rekomendasi:** Move to database or config file:
```typescript
// Add to schema
model VisiMisiPPID {
// ...
moto String? @db.Text
}
// Or use config
const PPID_MOTO = "MEMBERIKAN INFORMASI YANG CEPAT, MUDAH, TEPAT DAN TRANSPARAN";
```
**Priority:** 🟢 Low
**Effort:** Medium (perlu schema change)
---
#### **11. Title Order Inconsistency**
**Lokasi:** `page.tsx`
**Masalah:**
```typescript
// Line ~45
<Title order={3} ...>Preview Visi Misi PPID</Title>
// Line ~65
<Title order={2} ...>MOTO PPID DESA DARMASABA</Title>
// Line ~80
<Title order={2} ...>VISI PPID</Title>
// Line ~100
<Title order={2} ...>MISI PPID</Title>
```
**Issue:** Title hierarchy agak confusing. Page title (order 3) lebih kecil dari section titles (order 2).
**Rekomendasi:** Samakan hierarchy:
```typescript
// Page title: order={2}
// Section titles: order={3}
```
**Priority:** 🟢 Low
**Effort:** Low
---
#### **12. Missing Toast Success After Save**
**Lokasi:** `edit/page.tsx`
**Masalah:**
```typescript
// Line ~70-85
const submit = () => {
try {
setIsSubmitting(true);
if (visiMisi.findById.data) {
visiMisi.findById.data.visi = formData.visi;
visiMisi.findById.data.misi = formData.misi;
visiMisi.update.save(visiMisi.findById.data);
}
router.push('/admin/ppid/visi-misi-ppid'); // ✅ Redirect tanpa toast
} catch (error) {
console.error("Error updating visi misi:", error);
toast.error("Terjadi kesalahan saat memperbarui visi misi");
} finally {
setIsSubmitting(false);
}
};
```
**Issue:** Toast success ada di state `update.save()`, tapi user mungkin tidak lihat karena langsung redirect.
**Rekomendasi:** Add toast before redirect atau wait untuk toast selesai:
```typescript
const submit = async () => {
try {
setIsSubmitting(true);
if (visiMisi.findById.data) {
visiMisi.findById.data.visi = formData.visi;
visiMisi.findById.data.misi = formData.misi;
await visiMisi.update.save(visiMisi.findById.data);
toast.success("Visi Misi berhasil diperbarui!");
setTimeout(() => {
router.push('/admin/ppid/visi-misi-ppid');
}, 1000); // Wait 1 second for toast to show
}
} catch (error) {
console.error("Error updating visi misi:", error);
toast.error("Terjadi kesalahan saat memperbarui visi misi");
} finally {
setIsSubmitting(false);
}
};
```
**Priority:** 🟢 Low
**Effort:** Low
---
## 📋 RINGKASAN ACTION ITEMS
| Priority | Issue | Module | Impact | Effort | Status |
|----------|-------|--------|--------|--------|--------|
| 🔴 P0 | **Schema deletedAt default SALAH** | Schema | **CRITICAL** | Medium | **MUST FIX** |
| 🔴 P0 | **HTML injection risk** | UI | **HIGH (Security)** | Low | **Should fix** |
| 🔴 P1 | Missing delete confirmation | UI | Medium | Low | Should fix |
| 🟡 M | Console.log in production | State | Low | Low | Optional |
| 🟡 M | Missing loading state di submit button | UI | Low | Low | Should fix |
| 🟡 M | Zod schema error messages | State | Low | Low | Optional |
| 🟢 L | Missing change detection | Edit UI | Low | Low | Optional |
| 🟢 L | Duplicate useEffect di editor | Editor | Low | Low | Optional |
| 🟢 L | Missing error boundary | UI | Low | Low | Optional |
| 🟢 L | Hardcoded Moto PPID | UI | Low | Medium | Optional |
| 🟢 L | Title order inconsistency | UI | Low | Low | Optional |
| 🟢 L | Missing toast success timing | UI | Low | Low | Optional |
---
## ✅ KESIMPULAN
### **Overall Quality: 🟢 BAIK (8.5/10) - CLEANEST MODULE!**
**Strengths:**
1. ✅ UI/UX clean & responsive
2.**Rich Text Editor** full-featured (Tiptap)
3.**Modular form components** (Visi, Misi)
4.**State management BEST PRACTICES** - **ONLY MODULE YANG 100% ApiFetch!**
5.**Edit form reset sudah benar** (original data tracking)
6.**Rich text validation** comprehensive (check empty content)
7. ✅ Error handling comprehensive
8. ✅ Loading state management dengan finally block
9.`immediatelyRender: false` untuk menghindari hydration mismatch
**Critical Issues:**
1. ⚠️ **Schema deletedAt default SALAH** - Logic error untuk soft delete (CRITICAL)
2. ⚠️ **HTML injection risk** - dangerouslySetInnerHTML tanpa sanitization (HIGH Security)
3. ⚠️ Missing confirmation sebelum save (Medium UX)
**Areas for Improvement:**
1. ⚠️ **Fix schema deletedAt** dari `@default(now())` ke `@default(null)` dengan nullable
2. ⚠️ **Fix HTML injection** dengan DOMPurify atau backend validation
3. ⚠️ **Add confirmation dialog** sebelum save
4. ⚠️ **Add change detection** untuk avoid unnecessary saves
5. ⚠️ **Fix loading state** di submit button
**Recommended Next Steps:**
1. **🔴 CRITICAL: Fix schema deletedAt** - 30 menit (perlu migration)
2. **🔴 HIGH: Fix HTML injection** dengan DOMPurify - 30 menit
3. **🟡 MEDIUM: Add confirmation dialog** - 15 menit
4. **🟢 LOW: Add change detection** - 15 menit
5. **🟢 LOW: Polish minor issues** - 30 menit
---
## 📈 COMPARISON WITH OTHER MODULES
| Module | Fetch Pattern | State | Edit Reset | Rich Text | HTML Injection | deletedAt | Overall |
|--------|--------------|-------|------------|-----------|----------------|-----------|---------|
| Profil | ⚠️ Mixed | ⚠️ Good | ✅ Good | ❌ None | ⚠️ Present | ⚠️ Issue | 🟢 |
| Desa Anti Korupsi | ⚠️ Mixed | ⚠️ Good | ✅ Good | ✅ Present | ⚠️ Present | ⚠️ Issue | 🟢 |
| SDGs Desa | ⚠️ Mixed | ⚠️ Good | ✅ Good | ❌ None | N/A | ⚠️ Issue | 🟢 |
| APBDes | ⚠️ Mixed | ⚠️ Good | ✅ Good | ❌ None | N/A | ✅ Good | 🟢 |
| Prestasi Desa | ⚠️ Mixed | ⚠️ Good | ✅ Good | ✅ Present | ⚠️ Present | ❌ WRONG | 🟢 |
| PPID Profil | ⚠️ Mixed | ✅ **Best** | ✅ **Excellent** | ✅ **Best** | ⚠️ Present | ❌ WRONG | 🟢⭐ |
| Struktur PPID | ⚠️ Mixed | ✅ Good | ✅ Good | ✅ Present | ⚠️ Present | ⚠️ Inconsistent | 🟢 |
| **Visi Misi PPID** | ✅ **100% ApiFetch!** | ✅ **Best** | ✅ Good | ✅ Present | ⚠️ Present | ❌ WRONG | 🟢⭐⭐ |
**Visi Misi PPID Highlights:**
-**ONLY MODULE** yang 100% konsisten pakai ApiFetch! (NO fetch manual!)
-**CLEANEST CODE** - Simple, straightforward, no complexity
-**Rich text validation** paling comprehensive (check empty content)
-**Best state management** pattern (ApiFetch consistency)
- ⚠️ **Same deletedAt issue** seperti modul PPID lain
---
## 🎯 UNIQUE FEATURES OF VISI MISI PPID MODULE
**Simplest & Cleanest Module:**
1.**100% ApiFetch consistency** - NO fetch manual sama sekali! (UNIQUE!)
2.**Simple single record pattern** - Only 2 fields (visi, misi)
3.**Rich text validation** - Check empty content after remove HTML tags
4.**Modular editor components** - VisiPPID, MisiPPID separate
5.**No file upload** - Simplest form (text only)
**Best Practices:**
1.**ApiFetch 100%** - Best practice untuk API consistency
2.**Loading state management** proper (dengan finally block)
3.**Rich text validation** comprehensive
4.**Original data tracking** untuk reset form
5.**`immediatelyRender: false`** - Avoid hydration mismatch
**Critical Issues:**
1.**Schema deletedAt SALAH** - Same issue seperti modul PPID lain
2.**HTML injection risk** - Same issue seperti modul dengan rich text lain
---
**Catatan:** **Visi Misi PPID adalah MODULE PALING CLEAN** dengan codebase paling simple dan **SATU-SATUNYA MODULE YANG 100% PAKAI ApiFetch** (no fetch manual sama sekali!). Module ini bisa jadi **REFERENCE** untuk API consistency!
**Unique Strengths:**
1.**100% ApiFetch** - Best API consistency (NO fetch manual!)
2.**Simple & clean** - No unnecessary complexity
3.**Rich text validation** - Most comprehensive
4.**Best state management** pattern
**Priority Action:**
```diff
🔴 FIX INI SEKARANG (30 MENIT + MIGRATION):
File: prisma/schema.prisma
Line: 374
model VisiMisiPPID {
id String @id @default(cuid())
visi String @db.Text
misi String @db.Text
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
- deletedAt DateTime @default(now())
+ deletedAt DateTime? @default(null)
isActive Boolean @default(true)
}
# Lalu jalankan:
bunx prisma db push
# atau
bunx prisma migrate dev --name fix_deletedat_visimisi_ppid
```
```diff
🔴 FIX HTML INJECTION (30 MENIT):
File: page.tsx
+ import DOMPurify from 'dompurify';
// Line ~85
- dangerouslySetInnerHTML={{ __html: listVisiMisi.findById.data.visi }}
+ dangerouslySetInnerHTML={{ __html: DOMPurify.sanitize(listVisiMisi.findById.data.visi) }}
// Line ~105
- dangerouslySetInnerHTML={{ __html: listVisiMisi.findById.data.misi }}
+ dangerouslySetInnerHTML={{ __html: DOMPurify.sanitize(listVisiMisi.findById.data.misi) }}
```
Setelah fix critical issues, module ini **PRODUCTION-READY** dan bisa jadi **REFERENCE untuk API CONSISTENCY**! 🎉
---
## 📚 RECOMMENDED AS REFERENCE FOR OTHER MODULES
**Visi Misi PPID Module adalah BEST PRACTICE untuk:**
1.**API consistency** - 100% ApiFetch, NO fetch manual!
2.**Simple state management** - Clean, straightforward
3.**Rich text validation** - Check empty content pattern
4.**Modular editor components** - Separate Visi & Misi
**Modules lain bisa belajar dari Visi Misi PPID:**
- **ALL MODULES:** Use ApiFetch consistently (NO fetch manual!)
- **ALL MODULES:** Keep it simple (avoid unnecessary complexity)
- **Rich Text Modules:** Implement empty content validation
- **ALL MODULES:** Proper loading state management
---
**File Location:** `QC/PPID/QC-VISI-MISI-PPID-MODULE.md` 📄

BIN
bun.lockb

Binary file not shown.

169
darkMode.md Normal file
View File

@@ -0,0 +1,169 @@
# 🌙 Dark Mode Design Specification
## Admin Darmasaba Dashboard & CMS
Dokumen ini mendefinisikan standar **Dark Mode UI** agar:
- nyaman di mata
- konsisten
- tidak flat
- tetap profesional untuk aplikasi pemerintahan
---
## 🎨 Color Palette (Dark Mode)
### Background Layers
| Layer | Token | Warna | Fungsi |
|------|------|------|------|
| Base | `--bg-base` | `#0B1220` | Background utama aplikasi |
| App | `--bg-app` | `#0F172A` | Area kerja utama |
| Card | `--bg-card` | `#162235` | Card / container |
| Surface | `--bg-surface` | `#1E2A3D` | Table header, tab, input |
---
### Border & Divider
| Token | Warna | Catatan |
|-----|------|--------|
| `--border-default` | `#2A3A52` | Border utama |
| `--border-soft` | `#22314A` | Divider halus |
> ❗ Hindari border terlalu tipis (`opacity < 20%`)
---
### Text Colors
| Jenis | Token | Warna |
|-----|------|------|
| Primary | `--text-primary` | `#E5E7EB` |
| Secondary | `--text-secondary` | `#9CA3AF` |
| Muted | `--text-muted` | `#6B7280` |
| Inverse | `--text-inverse` | `#020617` |
---
### Accent & Action
| Fungsi | Warna |
|------|------|
| Primary Action | `#3B82F6` |
| Hover | `#2563EB` |
| Active | `#1D4ED8` |
| Link | `#60A5FA` |
---
### Status Colors
| Status | Warna |
|------|------|
| Success | `#22C55E` |
| Warning | `#FACC15` |
| Error | `#EF4444` |
| Info | `#38BDF8` |
---
## 🧱 Layout Rules
### Sidebar
- Background: `--bg-app`
- Active menu:
- Background: `rgba(59,130,246,0.15)`
- Text: Primary
- Indicator: kiri (23px accent bar)
- Hover:
- Background: `rgba(255,255,255,0.04)`
---
### Header / Topbar
- Background: `linear-gradient(#0F172A → #0B1220)`
- Border bawah wajib (`--border-soft`)
- Icon:
- Default: muted
- Hover: primary
---
## 📦 Card & Section
### Card
- Background: `--bg-card`
- Border: `--border-default`
- Radius: 1216px
- Jangan pakai shadow hitam
### Section Header
- Font weight lebih besar
- Text: primary
- Spacing jelas dari konten
---
## 📊 Table (Dark Mode Friendly)
### Table Header
- Background: `--bg-surface`
- Text: secondary
- Font weight: medium
### Table Row
- Default: transparent
- Hover:
- Background: `rgba(255,255,255,0.03)`
- Divider antar row wajib terlihat
### Link di Table
- Warna link **lebih terang dari text**
- Hover underline
---
## 🔘 Button Rules
### Primary Button
- Background: Primary Action
- Text: Inverse
- Hover: darker shade
### Secondary Button
- Background: transparent
- Border: `--border-default`
- Text: primary
### Icon Button
- Default: muted
- Hover: primary + bg soft
---
## 🧭 Tab Navigation
- Inactive:
- Text: muted
- Active:
- Background: `rgba(59,130,246,0.15)`
- Text: primary
- Icon ikut berubah
---
## 🌗 Dark vs Light Mode Rule
- Layout, spacing, typography **HARUS SAMA**
- Yang boleh beda:
- warna
- border intensity
- background layer
> ❌ Jangan ganti struktur UI antara dark & light
---
## ✅ Dark Mode Checklist
- [ ] Kontras teks terbaca
- [ ] Active state jelas
- [ ] Hover terasa hidup
- [ ] Tidak flat
- [ ] Tidak silau
---
Dokumen ini adalah **single source of truth** untuk Dark Mode.

View File

@@ -19,7 +19,6 @@ const nextConfig: NextConfig = {
},
];
},
};
export default nextConfig;

View File

@@ -33,7 +33,7 @@
"@mantine/modals": "^8.3.6",
"@mantine/tiptap": "^7.17.4",
"@paljs/types": "^8.1.0",
"@prisma/client": "^6.3.1",
"@prisma/client": "6.3.1",
"@tabler/icons-react": "^3.30.0",
"@tiptap/extension-highlight": "^2.11.7",
"@tiptap/extension-link": "^2.11.7",
@@ -62,6 +62,7 @@
"colors": "^1.4.0",
"date-fns": "^4.1.0",
"dayjs": "^1.11.13",
"dompurify": "^3.3.1",
"dotenv": "^17.2.3",
"elysia": "^1.3.5",
"embla-carousel": "^8.6.0",
@@ -88,7 +89,7 @@
"p-limit": "^6.2.0",
"primeicons": "^7.0.0",
"primereact": "^10.9.6",
"prisma": "^6.3.1",
"prisma": "6.3.1",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"react-exif-orientation-img": "^0.1.5",
@@ -112,6 +113,7 @@
"@playwright/test": "^1.58.2",
"@testing-library/jest-dom": "^6.9.1",
"@types/cli-progress": "^3.11.6",
"@types/dompurify": "^3.2.0",
"@types/jsonwebtoken": "^9.0.10",
"@types/node": "^20",
"@types/react": "^19",

View File

@@ -26,7 +26,24 @@ export async function seedBerita() {
console.log("🔄 Seeding Berita...");
// Build a map of valid kategori IDs
const validKategoriIds = new Set<string>();
const kategoriList = await prisma.kategoriBerita.findMany({
select: { id: true, name: true },
});
kategoriList.forEach((k) => validKategoriIds.add(k.id));
console.log(`📋 Found ${validKategoriIds.size} valid kategori IDs in database`);
for (const b of beritaJson) {
// Validate kategoriBeritaId exists
if (!b.kategoriBeritaId || !validKategoriIds.has(b.kategoriBeritaId)) {
console.warn(
`⚠️ Skipping berita "${b.judul}": Invalid kategoriBeritaId "${b.kategoriBeritaId}"`,
);
continue;
}
let imageId: string | null = null;
if (b.imageName) {
@@ -44,26 +61,32 @@ export async function seedBerita() {
}
}
await prisma.berita.upsert({
where: { id: b.id },
update: {
judul: b.judul,
deskripsi: b.deskripsi,
content: b.content,
kategoriBeritaId: b.kategoriBeritaId,
imageId,
},
create: {
id: b.id,
judul: b.judul,
deskripsi: b.deskripsi,
content: b.content,
kategoriBeritaId: b.kategoriBeritaId,
imageId,
},
});
try {
await prisma.berita.upsert({
where: { id: b.id },
update: {
judul: b.judul,
deskripsi: b.deskripsi,
content: b.content,
kategoriBeritaId: b.kategoriBeritaId,
imageId,
},
create: {
id: b.id,
judul: b.judul,
deskripsi: b.deskripsi,
content: b.content,
kategoriBeritaId: b.kategoriBeritaId,
imageId,
},
});
console.log(`✅ Berita seeded: ${b.judul}`);
console.log(`✅ Berita seeded: ${b.judul}`);
} catch (error: any) {
console.error(
`❌ Failed to seed berita "${b.judul}": ${error.message}`,
);
}
}
console.log("🎉 Berita seed selesai");

View File

@@ -0,0 +1,170 @@
/*
Warnings:
- You are about to alter the column `nama` on the `KategoriPotensi` table. The data in that column could be lost. The data in that column will be cast from `Text` to `VarChar(100)`.
- You are about to alter the column `name` on the `PotensiDesa` table. The data in that column could be lost. The data in that column will be cast from `Text` to `VarChar(255)`.
- You are about to alter the column `kategoriId` on the `PotensiDesa` table. The data in that column could be lost. The data in that column will be cast from `Text` to `VarChar(36)`.
- A unique constraint covering the columns `[nama]` on the table `KategoriPotensi` will be added. If there are existing duplicate values, this will fail.
- A unique constraint covering the columns `[name]` on the table `PotensiDesa` will be added. If there are existing duplicate values, this will fail.
- Made the column `kategoriId` on table `PotensiDesa` required. This step will fail if there are existing NULL values in that column.
*/
-- DropForeignKey
ALTER TABLE "DataPerpustakaan" DROP CONSTRAINT "DataPerpustakaan_imageId_fkey";
-- DropForeignKey
ALTER TABLE "DesaDigital" DROP CONSTRAINT "DesaDigital_imageId_fkey";
-- DropForeignKey
ALTER TABLE "InfoTekno" DROP CONSTRAINT "InfoTekno_imageId_fkey";
-- DropForeignKey
ALTER TABLE "KegiatanDesa" DROP CONSTRAINT "KegiatanDesa_imageId_fkey";
-- DropForeignKey
ALTER TABLE "PengaduanMasyarakat" DROP CONSTRAINT "PengaduanMasyarakat_imageId_fkey";
-- DropForeignKey
ALTER TABLE "PotensiDesa" DROP CONSTRAINT "PotensiDesa_kategoriId_fkey";
-- DropForeignKey
ALTER TABLE "ProfileDesaImage" DROP CONSTRAINT "ProfileDesaImage_imageId_fkey";
-- AlterTable
ALTER TABLE "CaraMemperolehInformasi" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "CaraMemperolehSalinanInformasi" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "DaftarInformasiPublik" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "DasarHukumPPID" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "DataPerpustakaan" ALTER COLUMN "imageId" DROP NOT NULL;
-- AlterTable
ALTER TABLE "DesaDigital" ALTER COLUMN "imageId" DROP NOT NULL;
-- AlterTable
ALTER TABLE "FormulirPermohonanKeberatan" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "InfoTekno" ALTER COLUMN "imageId" DROP NOT NULL;
-- AlterTable
ALTER TABLE "JenisInformasiDiminta" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "JenisKelaminResponden" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "KategoriPotensi" ALTER COLUMN "nama" SET DATA TYPE VARCHAR(100),
ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "KategoriPrestasiDesa" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "KegiatanDesa" ALTER COLUMN "imageId" DROP NOT NULL;
-- AlterTable
ALTER TABLE "LambangDesa" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "MaskotDesa" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "PegawaiPPID" ADD COLUMN "deletedAt" TIMESTAMP(3);
-- AlterTable
ALTER TABLE "PengaduanMasyarakat" ALTER COLUMN "imageId" DROP NOT NULL;
-- AlterTable
ALTER TABLE "PermohonanInformasiPublik" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "PilihanRatingResponden" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "PosisiOrganisasiPPID" ADD COLUMN "deletedAt" TIMESTAMP(3);
-- AlterTable
ALTER TABLE "PotensiDesa" ALTER COLUMN "name" SET DATA TYPE VARCHAR(255),
ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT,
ALTER COLUMN "kategoriId" SET NOT NULL,
ALTER COLUMN "kategoriId" SET DATA TYPE VARCHAR(36);
-- AlterTable
ALTER TABLE "PrestasiDesa" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "ProfileDesaImage" ALTER COLUMN "imageId" DROP NOT NULL;
-- AlterTable
ALTER TABLE "ProfilePPID" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "Responden" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "SejarahDesa" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "UmurResponden" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "VisiMisiDesa" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- AlterTable
ALTER TABLE "VisiMisiPPID" ALTER COLUMN "deletedAt" DROP NOT NULL,
ALTER COLUMN "deletedAt" DROP DEFAULT;
-- CreateIndex
CREATE UNIQUE INDEX "KategoriPotensi_nama_key" ON "KategoriPotensi"("nama");
-- CreateIndex
CREATE UNIQUE INDEX "PotensiDesa_name_key" ON "PotensiDesa"("name");
-- AddForeignKey
ALTER TABLE "ProfileDesaImage" ADD CONSTRAINT "ProfileDesaImage_imageId_fkey" FOREIGN KEY ("imageId") REFERENCES "FileStorage"("id") ON DELETE SET NULL ON UPDATE CASCADE;
-- AddForeignKey
ALTER TABLE "PotensiDesa" ADD CONSTRAINT "PotensiDesa_kategoriId_fkey" FOREIGN KEY ("kategoriId") REFERENCES "KategoriPotensi"("id") ON DELETE RESTRICT ON UPDATE CASCADE;
-- AddForeignKey
ALTER TABLE "DesaDigital" ADD CONSTRAINT "DesaDigital_imageId_fkey" FOREIGN KEY ("imageId") REFERENCES "FileStorage"("id") ON DELETE SET NULL ON UPDATE CASCADE;
-- AddForeignKey
ALTER TABLE "InfoTekno" ADD CONSTRAINT "InfoTekno_imageId_fkey" FOREIGN KEY ("imageId") REFERENCES "FileStorage"("id") ON DELETE SET NULL ON UPDATE CASCADE;
-- AddForeignKey
ALTER TABLE "PengaduanMasyarakat" ADD CONSTRAINT "PengaduanMasyarakat_imageId_fkey" FOREIGN KEY ("imageId") REFERENCES "FileStorage"("id") ON DELETE SET NULL ON UPDATE CASCADE;
-- AddForeignKey
ALTER TABLE "KegiatanDesa" ADD CONSTRAINT "KegiatanDesa_imageId_fkey" FOREIGN KEY ("imageId") REFERENCES "FileStorage"("id") ON DELETE SET NULL ON UPDATE CASCADE;
-- AddForeignKey
ALTER TABLE "DataPerpustakaan" ADD CONSTRAINT "DataPerpustakaan_imageId_fkey" FOREIGN KEY ("imageId") REFERENCES "FileStorage"("id") ON DELETE SET NULL ON UPDATE CASCADE;

View File

@@ -1,3 +1,3 @@
# Please do not edit this file manually
# It should be added in your version-control system (e.g., Git)
provider = "postgresql"
provider = "postgresql"

View File

@@ -60,8 +60,9 @@ model FileStorage {
deletedAt DateTime?
isActive Boolean @default(true)
link String
category String // "image" / "document" / "other"
Berita Berita[]
category String // "image" / "document" / "audio" / "other"
Berita Berita[] @relation("BeritaFeaturedImage")
BeritaImages Berita[] @relation("BeritaImages")
PotensiDesa PotensiDesa[]
Posyandu Posyandu[]
StrukturPPID StrukturPPID[]
@@ -102,6 +103,9 @@ model FileStorage {
ArtikelKesehatan ArtikelKesehatan[]
StrukturBumDes StrukturBumDes[]
MusikDesaAudio MusikDesa[] @relation("MusikAudioFile")
MusikDesaCover MusikDesa[] @relation("MusikCoverImage")
}
//========================================= MENU LANDING PAGE ========================================= //
@@ -205,16 +209,22 @@ model APBDesItem {
kode String // contoh: "4", "4.1", "4.1.2"
uraian String // nama item, contoh: "Pendapatan Asli Desa", "Hasil Usaha"
anggaran Float // dalam satuan Rupiah (bisa DECIMAL di DB, tapi Float umum di TS/JS)
realisasi Float
selisih Float // realisasi - anggaran
persentase Float
tipe String? // (realisasi / anggaran) * 100
tipe String? // "pendapatan" | "belanja" | "pembiayaan" | null
level Int // 1 = kelompok utama, 2 = sub-kelompok, 3 = detail
parentId String? // untuk relasi hierarki
parent APBDesItem? @relation("APBDesItemParent", fields: [parentId], references: [id])
children APBDesItem[] @relation("APBDesItemParent")
apbdesId String
apbdes APBDes @relation(fields: [apbdesId], references: [id])
// Field kalkulasi (auto-calculated dari realisasi items)
totalRealisasi Float @default(0) // Sum dari semua realisasi
selisih Float @default(0) // totalRealisasi - anggaran
persentase Float @default(0) // (totalRealisasi / anggaran) * 100
// Relasi ke realisasi items
realisasiItems RealisasiItem[]
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime?
@@ -225,6 +235,28 @@ model APBDesItem {
@@index([apbdesId])
}
// Model baru untuk multiple realisasi per item
model RealisasiItem {
id String @id @default(cuid())
kode String? // Kode realisasi, mirip dengan APBDesItem
apbdesItemId String
apbdesItem APBDesItem @relation(fields: [apbdesItemId], references: [id], onDelete: Cascade)
jumlah Float // Jumlah realisasi dalam Rupiah
tanggal DateTime @db.Date // Tanggal realisasi
keterangan String? @db.Text // Keterangan tambahan (opsional)
buktiFileId String? // FileStorage ID untuk bukti/foto (opsional)
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime?
isActive Boolean @default(true)
@@index([kode])
@@index([apbdesItemId])
@@index([tanggal])
}
//========================================= PRESTASI DESA ========================================= //
model PrestasiDesa {
id String @id @default(cuid())
@@ -236,7 +268,7 @@ model PrestasiDesa {
imageId String?
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
}
@@ -245,7 +277,7 @@ model KategoriPrestasiDesa {
name String @unique
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
PrestasiDesa PrestasiDesa[]
}
@@ -263,7 +295,7 @@ model Responden {
kelompokUmurId String
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
}
@@ -272,7 +304,7 @@ model JenisKelaminResponden {
name String @unique
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
Responden Responden[]
}
@@ -282,7 +314,7 @@ model PilihanRatingResponden {
name String @unique
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
Responden Responden[]
}
@@ -292,7 +324,7 @@ model UmurResponden {
name String @unique
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
Responden Responden[]
}
@@ -326,6 +358,7 @@ model PosisiOrganisasiPPID {
isActive Boolean @default(true)
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime?
parent PosisiOrganisasiPPID? @relation("Parent", fields: [parentId], references: [id])
children PosisiOrganisasiPPID[] @relation("Parent")
StrukturOrganisasiPPID StrukturOrganisasiPPID[]
@@ -345,6 +378,7 @@ model PegawaiPPID {
isActive Boolean @default(true)
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime?
posisi PosisiOrganisasiPPID @relation(fields: [posisiId], references: [id])
strukturOrganisasi StrukturPPID[] // Relasi balik
StrukturOrganisasiPPID StrukturOrganisasiPPID[]
@@ -370,7 +404,7 @@ model VisiMisiPPID {
misi String @db.Text
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
}
@@ -381,7 +415,7 @@ model DasarHukumPPID {
content String @db.Text
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
}
@@ -398,7 +432,7 @@ model ProfilePPID {
imageId String?
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
}
@@ -410,7 +444,7 @@ model DaftarInformasiPublik {
tanggal DateTime @db.Date
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
}
@@ -431,7 +465,7 @@ model PermohonanInformasiPublik {
caraMemperolehSalinanInformasiId String?
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
}
@@ -440,7 +474,7 @@ model JenisInformasiDiminta {
name String @unique
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
PermohonanInformasiPublik PermohonanInformasiPublik[]
}
@@ -450,7 +484,7 @@ model CaraMemperolehInformasi {
name String @unique
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
PermohonanInformasiPublik PermohonanInformasiPublik[]
}
@@ -460,7 +494,7 @@ model CaraMemperolehSalinanInformasi {
name String @unique
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
PermohonanInformasiPublik PermohonanInformasiPublik[]
}
@@ -474,7 +508,7 @@ model FormulirPermohonanKeberatan {
alasan String
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
}
@@ -531,7 +565,7 @@ model SejarahDesa {
deskripsi String @db.Text
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
}
@@ -541,7 +575,7 @@ model VisiMisiDesa {
misi String @db.Text
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
}
@@ -551,7 +585,7 @@ model LambangDesa {
deskripsi String @db.Text
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
}
@@ -562,7 +596,7 @@ model MaskotDesa {
images ProfileDesaImage[]
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
}
@@ -607,15 +641,19 @@ model Berita {
id String @id @default(cuid())
judul String
deskripsi String
image FileStorage? @relation(fields: [imageId], references: [id])
image FileStorage? @relation("BeritaFeaturedImage", fields: [imageId], references: [id])
imageId String?
images FileStorage[] @relation("BeritaImages")
content String @db.Text
linkVideo String? @db.VarChar(500)
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
isActive Boolean @default(true)
kategoriBerita KategoriBerita? @relation(fields: [kategoriBeritaId], references: [id])
kategoriBeritaId String?
@@index([kategoriBeritaId])
}
model KategoriBerita {
@@ -631,25 +669,25 @@ model KategoriBerita {
// ========================================= POTENSI DESA ========================================= //
model PotensiDesa {
id String @id @default(cuid())
name String
deskripsi String
name String @unique @db.VarChar(255)
deskripsi String @db.Text
kategori KategoriPotensi? @relation(fields: [kategoriId], references: [id])
kategoriId String?
kategoriId String @db.VarChar(36)
image FileStorage? @relation(fields: [imageId], references: [id])
imageId String?
content String @db.Text
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
}
model KategoriPotensi {
id String @id @default(cuid())
nama String
nama String @unique @db.VarChar(100)
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime @default(now())
deletedAt DateTime?
isActive Boolean @default(true)
PotensiDesa PotensiDesa[]
}
@@ -2261,3 +2299,25 @@ model UserMenuAccess {
@@unique([userId, menuId]) // Satu user tidak bisa punya akses menu yang sama dua kali
}
// ========================================= MUSIK DESA ========================================= //
model MusikDesa {
id String @id @default(cuid())
judul String @db.VarChar(255)
artis String @db.VarChar(255)
deskripsi String? @db.Text
durasi String @db.VarChar(20) // format: "MM:SS"
audioFile FileStorage? @relation("MusikAudioFile", fields: [audioFileId], references: [id])
audioFileId String?
coverImage FileStorage? @relation("MusikCoverImage", fields: [coverImageId], references: [id])
coverImageId String?
genre String? @db.VarChar(100)
tahunRilis Int?
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
deletedAt DateTime?
isActive Boolean @default(true)
@@index([judul])
@@index([artis])
}

BIN
public/mp3-logo.png Normal file

Binary file not shown.

After

Width:  |  Height:  |  Size: 82 KiB

View File

@@ -1,7 +1,11 @@
'use client';
import React from 'react';
import { Grid, GridCol, Paper, TextInput, Title } from '@mantine/core';
import { Grid, GridCol, Paper, TextInput } from '@mantine/core';
import { IconSearch } from '@tabler/icons-react';
import colors from '@/con/colors';
import { useDarkMode } from '@/state/darkModeStore';
import { themeTokens } from '@/utils/themeTokens';
import { UnifiedTitle } from '@/components/admin/UnifiedTypography';
type HeaderSearchProps = {
title: string;
@@ -18,13 +22,16 @@ const HeaderSearch = ({
value,
onChange,
}: HeaderSearchProps) => {
const { isDark } = useDarkMode();
const tokens = themeTokens(isDark);
return (
<Grid mb={10}>
<GridCol span={{ base: 12, md: 9 }}>
<Title order={3}>{title}</Title>
<UnifiedTitle order={3}>{title}</UnifiedTitle>
</GridCol>
<GridCol span={{ base: 12, md: 3 }}>
<Paper radius="lg" bg={colors['white-1']}>
<Paper radius="lg" bg={tokens.colors.bg.surface}>
<TextInput
radius="lg"
placeholder={placeholder}
@@ -32,6 +39,16 @@ const HeaderSearch = ({
w="100%"
value={value}
onChange={onChange}
style={{
input: {
backgroundColor: tokens.colors.bg.surface,
color: tokens.colors.text.primary,
borderColor: tokens.colors.border.default,
'::placeholder': {
color: tokens.colors.text.muted,
},
},
}}
/>
</Paper>
</GridCol>

View File

@@ -1,12 +1,16 @@
'use client'
import colors from '@/con/colors';
import { Grid, GridCol, Button, Text } from '@mantine/core';
import { Grid, GridCol, Button } from '@mantine/core';
import { IconCircleDashedPlus } from '@tabler/icons-react';
import { useRouter } from 'next/navigation';
import React from 'react';
import { useDarkMode } from '@/state/darkModeStore';
import { themeTokens } from '@/utils/themeTokens';
import { UnifiedText } from '@/components/admin/UnifiedTypography';
const JudulList = ({ title = "", href = "#" }) => {
const { isDark } = useDarkMode();
const tokens = themeTokens(isDark);
const router = useRouter();
const handleNavigate = () => {
@@ -16,10 +20,18 @@ const JudulList = ({ title = "", href = "#" }) => {
return (
<Grid align="center" mb={10}>
<GridCol span={{ base: 12, md: 11 }}>
<Text fz={"xl"} fw={"bold"}>{title}</Text>
<UnifiedText size="body" weight="bold" color="primary">{title}</UnifiedText>
</GridCol>
<GridCol span={{ base: 12, md: 1 }} ta="right">
<Button onClick={handleNavigate} bg={colors['blue-button']}>
<Button
onClick={handleNavigate}
bg={tokens.colors.primary}
style={{
background: `linear-gradient(135deg, ${tokens.colors.primary}, ${isDark ? '#60A5FA' : '#4facfe'})`,
color: tokens.colors.text.inverse,
boxShadow: isDark ? 'none' : `0 4px 15px rgba(79, 172, 254, 0.4)`,
}}
>
<IconCircleDashedPlus size={25} />
</Button>
</GridCol>

View File

@@ -1,9 +1,11 @@
'use client'
import colors from '@/con/colors';
import { Grid, GridCol, Button, Text, Paper, TextInput } from '@mantine/core';
import { Grid, GridCol, Button, Paper, TextInput } from '@mantine/core';
import { IconCircleDashedPlus, IconSearch } from '@tabler/icons-react';
import { useRouter } from 'next/navigation';
import React from 'react';
import { useDarkMode } from '@/state/darkModeStore';
import { themeTokens } from '@/utils/themeTokens';
import { UnifiedText } from '@/components/admin/UnifiedTypography';
type JudulListTabProps = {
title: string;
@@ -14,17 +16,16 @@ type JudulListTabProps = {
onChange?: (e: React.ChangeEvent<HTMLInputElement>) => void;
}
const JudulListTab = ({
title = "",
href = "#",
placeholder = "pencarian",
searchIcon = <IconSearch size={20} />,
value,
onChange
onChange
}: JudulListTabProps) => {
const { isDark } = useDarkMode();
const tokens = themeTokens(isDark);
const router = useRouter();
const handleNavigate = () => {
@@ -34,10 +35,17 @@ const JudulListTab = ({
return (
<Grid mb={10}>
<GridCol span={{ base: 12, md: 8 }}>
<Text fz={{ base: "md", md: "xl" }} fw={"bold"}>{title}</Text>
<UnifiedText
size="body"
weight="bold"
color="primary"
style={{ fontSize: 'clamp(1rem, 2vw, 1.25rem)' }}
>
{title}
</UnifiedText>
</GridCol>
<GridCol span={{ base: 9, md: 3 }} ta="right">
<Paper radius={"lg"} bg={colors['white-1']}>
<Paper radius={"lg"} bg={tokens.colors.bg.surface}>
<TextInput
radius="lg"
placeholder={placeholder}
@@ -45,11 +53,29 @@ const JudulListTab = ({
w="100%"
value={value}
onChange={onChange}
style={{
input: {
backgroundColor: tokens.colors.bg.surface,
color: tokens.colors.text.primary,
borderColor: tokens.colors.border.default,
'::placeholder': {
color: tokens.colors.text.muted,
},
},
}}
/>
</Paper>
</GridCol>
<GridCol span={{ base: 3, md: 1 }} ta="right">
<Button onClick={handleNavigate} bg={colors['blue-button']}>
<Button
onClick={handleNavigate}
bg={tokens.colors.primary}
style={{
background: `linear-gradient(135deg, ${tokens.colors.primary}, ${isDark ? '#60A5FA' : '#4facfe'})`,
color: tokens.colors.text.inverse,
boxShadow: isDark ? 'none' : `0 4px 15px rgba(79, 172, 254, 0.4)`,
}}
>
<IconCircleDashedPlus size={25} />
</Button>
</GridCol>

View File

@@ -12,6 +12,8 @@ const templateForm = z.object({
content: z.string().min(3, "Content minimal 3 karakter"),
kategoriBeritaId: z.string().nonempty(),
imageId: z.string().nonempty(),
imageIds: z.array(z.string()),
linkVideo: z.string().optional(),
});
// 2. Default value form berita (hindari uncontrolled input)
@@ -21,6 +23,8 @@ const defaultForm = {
imageId: "",
content: "",
kategoriBeritaId: "",
imageIds: [] as string[],
linkVideo: "",
};
// 4. Berita proxy
@@ -62,14 +66,7 @@ const berita = proxy({
// State untuk berita utama (hanya 1)
findMany: {
data: null as
| Prisma.BeritaGetPayload<{
include: {
image: true;
kategoriBerita: true;
};
}>[]
| null,
data: null as any[] | null,
page: 1,
totalPages: 1,
loading: false,
@@ -79,14 +76,14 @@ const berita = proxy({
berita.findMany.loading = true;
berita.findMany.page = page;
berita.findMany.search = search;
try {
const query: any = { page, limit };
if (search) query.search = search;
if (kategori) query.kategori = kategori;
const res = await ApiFetch.api.desa.berita["find-many"].get({ query });
if (res.status === 200 && res.data?.success) {
berita.findMany.data = res.data.data ?? [];
berita.findMany.totalPages = res.data.totalPages ?? 1;
@@ -103,18 +100,19 @@ const berita = proxy({
const elapsed = Date.now() - startTime;
const minDelay = 300;
const delay = elapsed < minDelay ? minDelay - elapsed : 0;
setTimeout(() => {
berita.findMany.loading = false;
}, delay);
}
},
},
},
findUnique: {
data: null as Prisma.BeritaGetPayload<{
include: {
image: true;
images: true;
kategoriBerita: true;
};
}> | null,
@@ -199,6 +197,8 @@ const berita = proxy({
content: data.content,
kategoriBeritaId: data.kategoriBeritaId || "",
imageId: data.imageId || "",
imageIds: data.images?.map((img: any) => img.id) || [],
linkVideo: data.linkVideo || "",
};
return data; // Return the loaded data
} else {
@@ -237,6 +237,8 @@ const berita = proxy({
content: this.form.content,
kategoriBeritaId: this.form.kategoriBeritaId || null,
imageId: this.form.imageId,
imageIds: this.form.imageIds,
linkVideo: this.form.linkVideo,
}),
});

View File

@@ -0,0 +1,297 @@
/* eslint-disable @typescript-eslint/no-explicit-any */
import ApiFetch from "@/lib/api-fetch";
import { Prisma } from "@prisma/client";
import { toast } from "react-toastify";
import { proxy } from "valtio";
import { z } from "zod";
// 1. Schema validasi dengan Zod
const templateForm = z.object({
judul: z.string().min(3, "Judul minimal 3 karakter"),
artis: z.string().min(3, "Artis minimal 3 karakter"),
deskripsi: z.string().optional(),
durasi: z.string().min(3, "Durasi minimal 3 karakter"),
audioFileId: z.string().nonempty(),
coverImageId: z.string().nonempty(),
genre: z.string().optional(),
tahunRilis: z.number().optional().or(z.literal(undefined)),
});
// 2. Default value form musik
const defaultForm = {
judul: "",
artis: "",
deskripsi: "",
durasi: "",
audioFileId: "",
coverImageId: "",
genre: "",
tahunRilis: undefined as number | undefined,
};
// 3. Musik proxy
const musik = proxy({
create: {
form: { ...defaultForm },
loading: false,
async create() {
const cek = templateForm.safeParse(musik.create.form);
if (!cek.success) {
const err = `[${cek.error.issues
.map((v) => `${v.path.join(".")}`)
.join("\n")}] required`;
return toast.error(err);
}
try {
musik.create.loading = true;
const res = await ApiFetch.api.desa.musik["create"].post(
musik.create.form
);
if (res.status === 200) {
musik.findMany.load();
return toast.success("Musik berhasil disimpan!");
}
return toast.error("Gagal menyimpan musik");
} catch (error) {
console.log((error as Error).message);
} finally {
musik.create.loading = false;
}
},
resetForm() {
musik.create.form = { ...defaultForm };
},
},
findMany: {
data: null as
| Prisma.MusikDesaGetPayload<{
include: {
audioFile: true;
coverImage: true;
};
}>[]
| null,
page: 1,
totalPages: 1,
loading: false,
search: "",
load: async (page = 1, limit = 10, search = "", genre = "") => {
const startTime = Date.now();
musik.findMany.loading = true;
musik.findMany.page = page;
musik.findMany.search = search;
try {
const query: any = { page, limit };
if (search) query.search = search;
if (genre) query.genre = genre;
const res = await ApiFetch.api.desa.musik["find-many"].get({ query });
if (res.status === 200 && res.data?.success) {
musik.findMany.data = res.data.data ?? [];
musik.findMany.totalPages = res.data.totalPages ?? 1;
} else {
musik.findMany.data = [];
musik.findMany.totalPages = 1;
}
} catch (err) {
console.error("Gagal fetch musik paginated:", err);
musik.findMany.data = [];
musik.findMany.totalPages = 1;
} finally {
const elapsed = Date.now() - startTime;
const minDelay = 300;
const delay = elapsed < minDelay ? minDelay - elapsed : 0;
setTimeout(() => {
musik.findMany.loading = false;
}, delay);
}
},
},
findUnique: {
data: null as Prisma.MusikDesaGetPayload<{
include: {
audioFile: true;
coverImage: true;
};
}> | null,
loading: false,
async load(id: string) {
try {
musik.findUnique.loading = true;
const res = await fetch(`/api/desa/musik/${id}`);
if (res.ok) {
const data = await res.json();
musik.findUnique.data = data.data ?? null;
} else {
console.error("Failed to fetch musik:", res.statusText);
musik.findUnique.data = null;
}
} catch (error) {
console.error("Error fetching musik:", error);
musik.findUnique.data = null;
} finally {
musik.findUnique.loading = false;
}
},
},
delete: {
loading: false,
async byId(id: string) {
if (!id) return toast.warn("ID tidak valid");
try {
musik.delete.loading = true;
const response = await fetch(`/api/desa/musik/delete/${id}`, {
method: "DELETE",
headers: {
"Content-Type": "application/json",
},
});
const result = await response.json();
if (response.ok && result?.success) {
toast.success(result.message || "Musik berhasil dihapus");
await musik.findMany.load();
} else {
toast.error(result?.message || "Gagal menghapus musik");
}
} catch (error) {
console.error("Gagal delete:", error);
toast.error("Terjadi kesalahan saat menghapus musik");
} finally {
musik.delete.loading = false;
}
},
},
edit: {
id: "",
form: { ...defaultForm },
loading: false,
async load(id: string) {
if (!id) {
toast.warn("ID tidak valid");
return null;
}
try {
const response = await fetch(`/api/desa/musik/${id}`, {
method: "GET",
headers: {
"Content-Type": "application/json",
},
});
if (!response.ok) {
throw new Error(`HTTP error! status: ${response.status}`);
}
const result = await response.json();
if (result?.success) {
const data = result.data;
this.id = data.id;
this.form = {
judul: data.judul,
artis: data.artis,
deskripsi: data.deskripsi || "",
durasi: data.durasi,
audioFileId: data.audioFileId || "",
coverImageId: data.coverImageId || "",
genre: data.genre || "",
tahunRilis: data.tahunRilis || undefined,
};
return data;
} else {
throw new Error(result?.message || "Gagal memuat data");
}
} catch (error) {
console.error("Error loading musik:", error);
toast.error(
error instanceof Error ? error.message : "Gagal memuat data"
);
return null;
}
},
async update() {
const cek = templateForm.safeParse(musik.edit.form);
if (!cek.success) {
const err = `[${cek.error.issues
.map((v) => `${v.path.join(".")}`)
.join("\n")}] required`;
toast.error(err);
return false;
}
try {
musik.edit.loading = true;
const response = await fetch(`/api/desa/musik/${this.id}`, {
method: "PUT",
headers: {
"Content-Type": "application/json",
},
body: JSON.stringify({
judul: this.form.judul,
artis: this.form.artis,
deskripsi: this.form.deskripsi,
durasi: this.form.durasi,
audioFileId: this.form.audioFileId,
coverImageId: this.form.coverImageId,
genre: this.form.genre,
tahunRilis: this.form.tahunRilis,
}),
});
if (!response.ok) {
const errorData = await response.json().catch(() => ({}));
throw new Error(
errorData.message || `HTTP error! status: ${response.status}`
);
}
const result = await response.json();
if (result.success) {
toast.success("Musik berhasil diupdate");
await musik.findMany.load();
return true;
} else {
throw new Error(result.message || "Gagal update musik");
}
} catch (error) {
console.error("Error updating musik:", error);
toast.error(
error instanceof Error
? error.message
: "Terjadi kesalahan saat update musik"
);
return false;
} finally {
musik.edit.loading = false;
}
},
reset() {
musik.edit.id = "";
musik.edit.form = { ...defaultForm };
},
},
});
// 4. State global
const stateDashboardMusik = proxy({
musik,
});
export default stateDashboardMusik;

View File

@@ -5,55 +5,52 @@ import { toast } from "react-toastify";
import { proxy } from "valtio";
import { z } from "zod";
// --- Zod Schema ---
// --- Zod Schema untuk APBDes Item (dengan field kalkulasi) ---
const ApbdesItemSchema = z.object({
kode: z.string().min(1, "Kode wajib diisi"),
uraian: z.string().min(1, "Uraian wajib diisi"),
anggaran: z.number().min(0),
realisasi: z.number().min(0),
selisih: z.number(),
persentase: z.number(),
anggaran: z.number().min(0, "Anggaran tidak boleh negatif"),
level: z.number().int().min(1).max(3),
tipe: z.enum(['pendapatan', 'belanja', 'pembiayaan']).nullable().optional(),
// Field kalkulasi dari realisasiItems (auto-calculated di backend)
realisasi: z.number().min(0).default(0),
selisih: z.number().default(0),
persentase: z.number().default(0),
});
const ApbdesFormSchema = z.object({
tahun: z.number().int().min(2000, "Tahun tidak valid"),
imageId: z.string().min(1, "Gambar wajib diunggah"),
fileId: z.string().min(1, "File wajib diunggah"),
name: z.string().optional(),
deskripsi: z.string().optional(),
jumlah: z.string().optional(),
// Image dan file opsional (bisa kosong)
imageId: z.string().optional(),
fileId: z.string().optional(),
items: z.array(ApbdesItemSchema).min(1, "Minimal ada 1 item"),
});
// --- Default Form ---
const defaultApbdesForm = {
tahun: new Date().getFullYear(),
name: "",
deskripsi: "",
jumlah: "",
imageId: "",
fileId: "",
items: [] as z.infer<typeof ApbdesItemSchema>[],
};
// --- Helper: hitung selisih & persentase otomatis (opsional di frontend) ---
// --- Helper: hitung selisih & persentase otomatis (opsional di frontend) ---
// --- Helper: Normalize item (dengan field kalkulasi) ---
function normalizeItem(item: Partial<z.infer<typeof ApbdesItemSchema>>): z.infer<typeof ApbdesItemSchema> {
const anggaran = item.anggaran ?? 0;
const realisasi = item.realisasi ?? 0;
// ✅ Formula yang benar
const selisih = anggaran - realisasi; // positif = sisa anggaran, negatif = over budget
const persentase = anggaran > 0 ? (realisasi / anggaran) * 100 : 0; // persentase realisasi terhadap anggaran
return {
kode: item.kode || "",
uraian: item.uraian || "",
anggaran,
realisasi,
selisih,
persentase,
anggaran: item.anggaran ?? 0,
level: item.level || 1,
tipe: item.tipe, // biarkan null jika memang null
tipe: item.tipe ?? null,
realisasi: item.realisasi ?? 0,
selisih: item.selisih ?? 0,
persentase: item.persentase ?? 0,
};
}
@@ -115,7 +112,7 @@ const apbdes = proxy({
findMany: {
data: null as
| Prisma.APBDesGetPayload<{
include: { image: true; file: true; items: true };
include: { image: true; file: true; items: { include: { realisasiItems: true } } };
}>[]
| null,
page: 1,
@@ -160,33 +157,37 @@ const apbdes = proxy({
findUnique: {
data: null as
| Prisma.APBDesGetPayload<{
include: { image: true; file: true; items: true };
include: { image: true; file: true; items: { include: { realisasiItems: true } } };
}>
| null,
loading: false,
error: null as string | null,
async load(id: string) {
if (!id || id.trim() === '') {
this.data = null;
this.error = "ID tidak valid";
return;
}
// Prevent multiple simultaneous loads
if (this.loading) {
console.log("⚠️ Already loading, skipping...");
return;
}
this.loading = true;
this.error = null;
try {
// Pastikan URL-nya benar
const url = `/api/landingpage/apbdes/${id}`;
console.log("🌐 Fetching:", url);
// Gunakan fetch biasa atau ApiFetch dengan cara yang benar
const response = await fetch(url);
const res = await response.json();
console.log("📦 Response:", res);
if (res.success && res.data) {
this.data = res.data;
} else {
@@ -246,15 +247,18 @@ const apbdes = proxy({
this.id = data.id;
this.form = {
tahun: data.tahun || new Date().getFullYear(),
name: data.name || "",
deskripsi: data.deskripsi || "",
jumlah: data.jumlah || "",
imageId: data.imageId || "",
fileId: data.fileId || "",
items: (data.items || []).map((item: any) => ({
kode: item.kode,
uraian: item.uraian,
anggaran: item.anggaran,
realisasi: item.realisasi,
selisih: item.selisih,
persentase: item.persentase,
realisasi: item.totalRealisasi || 0,
selisih: item.selisih || 0,
persentase: item.persentase || 0,
level: item.level,
tipe: item.tipe || 'pendapatan',
})),
@@ -282,11 +286,24 @@ const apbdes = proxy({
try {
this.loading = true;
// Include the ID in the request body
// Omit realisasi, selisih, persentase karena itu calculated fields di backend
const requestData = {
...parsed.data,
id: this.id, // Add the ID to the request body
tahun: parsed.data.tahun,
name: parsed.data.name,
deskripsi: parsed.data.deskripsi,
jumlah: parsed.data.jumlah,
imageId: parsed.data.imageId,
fileId: parsed.data.fileId,
id: this.id,
items: parsed.data.items.map(item => ({
kode: item.kode,
uraian: item.uraian,
anggaran: item.anggaran,
level: item.level,
tipe: item.tipe ?? null,
})),
};
const res = await (ApiFetch.api.landingpage.apbdes as any)[this.id].put(requestData);
if (res.data?.success) {
@@ -319,6 +336,82 @@ const apbdes = proxy({
this.form = { ...defaultApbdesForm };
},
},
// =========================================
// REALISASI STATE MANAGEMENT
// =========================================
realisasi: {
// Create realisasi
async create(itemId: string, data: { kode: string; jumlah: number; tanggal: string; keterangan?: string; buktiFileId?: string }) {
try {
const res = await (ApiFetch.api.landingpage.apbdes as any)[itemId].realisasi.post(data);
if (res.data?.success) {
toast.success("Realisasi berhasil ditambahkan");
// Reload findUnique untuk update data
const currentId = apbdes.findUnique.data?.id;
if (currentId) {
await apbdes.findUnique.load(currentId);
}
return true;
} else {
toast.error(res.data?.message || "Gagal menambahkan realisasi");
return false;
}
} catch (error: any) {
console.error("Create realisasi error:", error);
toast.error(error?.message || "Terjadi kesalahan saat menambahkan realisasi");
return false;
}
},
// Update realisasi
async update(realisasiId: string, data: { kode?: string; jumlah?: number; tanggal?: string; keterangan?: string; buktiFileId?: string }) {
try {
const res = await (ApiFetch.api.landingpage.apbdes as any).realisasi[realisasiId].put(data);
if (res.data?.success) {
toast.success("Realisasi berhasil diperbarui");
// Reload findUnique untuk update data
const currentId = apbdes.findUnique.data?.id;
if (currentId) {
await apbdes.findUnique.load(currentId);
}
return true;
} else {
toast.error(res.data?.message || "Gagal memperbarui realisasi");
return false;
}
} catch (error: any) {
console.error("Update realisasi error:", error);
toast.error(error?.message || "Terjadi kesalahan saat memperbarui realisasi");
return false;
}
},
// Delete realisasi
async delete(realisasiId: string) {
try {
const res = await (ApiFetch.api.landingpage.apbdes as any).realisasi[realisasiId].delete();
if (res.data?.success) {
toast.success("Realisasi berhasil dihapus");
// Reload findUnique untuk update data
if (apbdes.findUnique.data) {
await apbdes.findUnique.load(apbdes.findUnique.data.id);
}
return true;
} else {
toast.error(res.data?.message || "Gagal menghapus realisasi");
return false;
}
} catch (error: any) {
console.error("Delete realisasi error:", error);
toast.error(error?.message || "Terjadi kesalahan saat menghapus realisasi");
return false;
}
},
},
});
export default apbdes;

View File

@@ -55,10 +55,15 @@ const programInovasi = proxy({
programInovasi.findMany.load();
return toast.success("Sukses menambahkan");
}
console.log(res);
if (process.env.NODE_ENV === 'development') {
console.log(res);
}
return toast.error("failed create");
} catch (error) {
console.log((error as Error).message);
if (process.env.NODE_ENV === 'development') {
console.error("Create error:", error);
}
toast.error("Gagal menambahkan data");
} finally {
programInovasi.create.loading = false;
}
@@ -91,13 +96,17 @@ const programInovasi = proxy({
programInovasi.findMany.total = res.data.total || 0;
programInovasi.findMany.totalPages = res.data.totalPages || 1;
} else {
console.error("Failed to load pegawai:", res.data?.message);
if (process.env.NODE_ENV === 'development') {
console.error("Failed to load pegawai:", res.data?.message);
}
programInovasi.findMany.data = [];
programInovasi.findMany.total = 0;
programInovasi.findMany.totalPages = 1;
}
} catch (error) {
console.error("Error loading pegawai:", error);
if (process.env.NODE_ENV === 'development') {
console.error("Error loading pegawai:", error);
}
programInovasi.findMany.data = [];
programInovasi.findMany.total = 0;
programInovasi.findMany.totalPages = 1;
@@ -112,19 +121,25 @@ const programInovasi = proxy({
image: true;
};
}> | null,
loading: false,
async load(id: string) {
try {
const res = await fetch(`/api/landingpage/programinovasi/${id}`);
if (res.ok) {
const data = await res.json();
programInovasi.findUnique.data = data.data ?? null;
programInovasi.findUnique.loading = true;
const res = await (ApiFetch.api.landingpage.programinovasi as any)[id].get();
if (res.data?.success) {
programInovasi.findUnique.data = res.data.data ?? null;
return res.data.data;
} else {
console.error("Failed to fetch program inovasi:", res.statusText);
toast.error(res.data?.message || "Gagal memuat data program inovasi");
programInovasi.findUnique.data = null;
return null;
}
} catch (error) {
console.error("Error fetching program inovasi:", error);
programInovasi.findUnique.data = null;
return null;
} finally {
programInovasi.findUnique.loading = false;
}
},
},
@@ -135,27 +150,18 @@ const programInovasi = proxy({
try {
programInovasi.delete.loading = true;
const res = await (ApiFetch.api.landingpage.programinovasi as any)["del"][id].delete();
const response = await fetch(
`/api/landingpage/programinovasi/del/${id}`,
{
method: "DELETE",
headers: {
"Content-Type": "application/json",
},
}
);
const result = await response.json();
if (response.ok && result?.success) {
toast.success(result.message || "Program inovasi berhasil dihapus");
await programInovasi.findMany.load(); // refresh list
if (res.data?.success) {
toast.success(res.data.message || "Program inovasi berhasil dihapus");
await programInovasi.findMany.load();
} else {
toast.error(result?.message || "Gagal menghapus program inovasi");
toast.error(res.data?.message || "Gagal menghapus program inovasi");
}
} catch (error) {
console.error("Gagal delete:", error);
if (process.env.NODE_ENV === 'development') {
console.error("Gagal delete:", error);
}
toast.error("Terjadi kesalahan saat menghapus program inovasi");
} finally {
programInovasi.delete.loading = false;
@@ -174,20 +180,11 @@ const programInovasi = proxy({
}
try {
const response = await fetch(`/api/landingpage/programinovasi/${id}`, {
method: "GET",
headers: {
"Content-Type": "application/json",
},
});
if (!response.ok) {
throw new Error(`HTTP error! status: ${response.status}`);
}
programInovasi.update.loading = true;
const res = await (ApiFetch.api.landingpage.programinovasi as any)[id].get();
const result = await response.json();
if (result?.success) {
const data = result.data;
if (res.data?.success) {
const data = res.data.data;
this.id = data.id;
this.form = {
name: data.name,
@@ -197,13 +194,15 @@ const programInovasi = proxy({
};
return data;
} else {
throw new Error(
result?.message || "Gagal mengambil data program inovasi"
);
toast.error(res.data?.message || "Gagal mengambil data program inovasi");
return null;
}
} catch (error) {
console.error((error as Error).message);
if (process.env.NODE_ENV === 'development') {
console.error("Error loading program inovasi:", error);
}
toast.error("Terjadi kesalahan saat mengambil data program inovasi");
return null;
} finally {
programInovasi.update.loading = false;
}
@@ -221,41 +220,25 @@ const programInovasi = proxy({
try {
programInovasi.update.loading = true;
const res = await (ApiFetch.api.landingpage.programinovasi as any)[this.id].put({
name: this.form.name,
description: this.form.description,
imageId: this.form.imageId,
link: this.form.link,
});
const response = await fetch(
`/api/landingpage/programinovasi/${this.id}`,
{
method: "PUT",
headers: {
"Content-Type": "application/json",
},
body: JSON.stringify({
name: this.form.name,
description: this.form.description,
imageId: this.form.imageId,
link: this.form.link,
}),
}
);
if (!response.ok) {
const errorData = await response.json().catch(() => ({}));
throw new Error(
errorData.message || `HTTP error! status: ${response.status}`
);
}
const result = await response.json();
if (result.success) {
if (res.data?.success) {
toast.success("Berhasil update program inovasi");
await programInovasi.findMany.load(); // refresh list
await programInovasi.findMany.load();
return true;
} else {
throw new Error(result.message || "Gagal update program inovasi");
toast.error(res.data?.message || "Gagal update program inovasi");
return false;
}
} catch (error) {
console.error("Error updating program inovasi:", error);
if (process.env.NODE_ENV === 'development') {
console.error("Error updating program inovasi:", error);
}
toast.error(
error instanceof Error
? error.message
@@ -443,7 +426,7 @@ const pejabatDesa = proxy({
const templateMediaSosial = z.object({
name: z.string().min(3, "Nama minimal 3 karakter"),
imageId: z.string().nullable().optional(),
iconUrl: z.string().min(3, "Icon URL minimal 3 karakter"),
iconUrl: z.string().optional(), // ✅ Optional - tidak selalu required
icon: z.string().nullable().optional(),
});
@@ -484,10 +467,15 @@ const mediaSosial = proxy({
mediaSosial.findMany.load();
return toast.success("Sukses menambahkan");
}
console.log(res);
if (process.env.NODE_ENV === 'development') {
console.log(res);
}
return toast.error("failed create");
} catch (error) {
console.log((error as Error).message);
if (process.env.NODE_ENV === 'development') {
console.log((error as Error).message);
}
toast.error("Gagal menambahkan data");
} finally {
mediaSosial.create.loading = false;
}
@@ -518,13 +506,17 @@ const mediaSosial = proxy({
mediaSosial.findMany.total = res.data.total || 0;
mediaSosial.findMany.totalPages = res.data.totalPages || 1;
} else {
console.error("Failed to load media sosial:", res.data?.message);
if (process.env.NODE_ENV === 'development') {
console.error("Failed to load media sosial:", res.data?.message);
}
mediaSosial.findMany.data = [];
mediaSosial.findMany.total = 0;
mediaSosial.findMany.totalPages = 1;
}
} catch (error) {
console.error("Error loading media sosial:", error);
if (process.env.NODE_ENV === 'development') {
console.error("Error loading media sosial:", error);
}
mediaSosial.findMany.data = [];
mediaSosial.findMany.total = 0;
mediaSosial.findMany.totalPages = 1;
@@ -539,25 +531,32 @@ const mediaSosial = proxy({
image: true;
};
}> | null,
loading: false,
async load(id: string) {
if (!id) {
toast.warn("ID tidak valid");
return null;
}
mediaSosial.update.loading = true;
mediaSosial.findUnique.loading = true;
try {
const res = await fetch(`/api/landingpage/mediasosial/${id}`);
if (res.ok) {
const data = await res.json();
mediaSosial.findUnique.data = data.data ?? null;
const res = await (ApiFetch.api.landingpage.mediasosial as any)[id].get();
if (res.data?.success) {
mediaSosial.findUnique.data = res.data.data ?? null;
return res.data.data;
} else {
console.error("Failed to fetch media sosial:", res.statusText);
toast.error(res.data?.message || "Gagal memuat data media sosial");
mediaSosial.findUnique.data = null;
return null;
}
} catch (error) {
console.error("Error fetching media sosial:", error);
if (process.env.NODE_ENV === 'development') {
console.error("Error fetching media sosial:", error);
}
mediaSosial.findUnique.data = null;
return null;
} finally {
mediaSosial.findUnique.loading = false;
}
},
},
@@ -568,24 +567,18 @@ const mediaSosial = proxy({
try {
mediaSosial.delete.loading = true;
const res = await (ApiFetch.api.landingpage.mediasosial as any)["del"][id].delete();
const response = await fetch(`/api/landingpage/mediasosial/del/${id}`, {
method: "DELETE",
headers: {
"Content-Type": "application/json",
},
});
const result = await response.json();
if (response.ok && result?.success) {
toast.success(result.message || "Media Sosial berhasil dihapus");
await mediaSosial.findMany.load(); // refresh list
if (res.data?.success) {
toast.success(res.data.message || "Media Sosial berhasil dihapus");
await mediaSosial.findMany.load();
} else {
toast.error(result?.message || "Gagal menghapus media sosial");
toast.error(res.data?.message || "Gagal menghapus media sosial");
}
} catch (error) {
console.error("Gagal delete:", error);
if (process.env.NODE_ENV === 'development') {
console.error("Gagal delete:", error);
}
toast.error("Terjadi kesalahan saat menghapus media sosial");
} finally {
mediaSosial.delete.loading = false;
@@ -603,43 +596,32 @@ const mediaSosial = proxy({
return null;
}
mediaSosial.update.loading = true; // ✅ Tambahkan ini di awal
mediaSosial.update.loading = true;
try {
const response = await fetch(`/api/landingpage/mediasosial/${id}`, {
method: "GET",
headers: {
"Content-Type": "application/json",
},
});
const res = await (ApiFetch.api.landingpage.mediasosial as any)[id].get();
if (!response.ok) {
throw new Error(`HTTP error! status: ${response.status}`);
}
const result = await response.json();
if (result?.success) {
const data = result.data;
if (res.data?.success) {
const data = res.data.data;
this.id = data.id;
this.form = {
name: data.name || "",
imageId: data.imageId || null,
iconUrl: data.iconUrl || "",
icon: data.icon || null,
};
return data;
} else {
throw new Error(
result?.message || "Gagal mengambil data media sosial"
);
toast.error(res.data?.message || "Gagal mengambil data media sosial");
return null;
}
} catch (error) {
console.error((error as Error).message);
if (process.env.NODE_ENV === 'development') {
console.error("Error loading media sosial:", error);
}
toast.error("Terjadi kesalahan saat mengambil data media sosial");
return null;
} finally {
mediaSosial.update.loading = false; // ✅ Supaya berhenti loading walau error
mediaSosial.update.loading = false;
}
},
@@ -655,41 +637,25 @@ const mediaSosial = proxy({
try {
mediaSosial.update.loading = true;
const res = await (ApiFetch.api.landingpage.mediasosial as any)[this.id].put({
name: this.form.name,
imageId: this.form.imageId,
iconUrl: this.form.iconUrl,
icon: this.form.icon,
});
const response = await fetch(
`/api/landingpage/mediasosial/${this.id}`,
{
method: "PUT",
headers: {
"Content-Type": "application/json",
},
body: JSON.stringify({
name: this.form.name,
imageId: this.form.imageId,
iconUrl: this.form.iconUrl,
icon: this.form.icon,
}),
}
);
if (!response.ok) {
const errorData = await response.json().catch(() => ({}));
throw new Error(
errorData.message || `HTTP error! status: ${response.status}`
);
}
const result = await response.json();
if (result.success) {
if (res.data?.success) {
toast.success("Berhasil update media sosial");
await mediaSosial.findMany.load(); // refresh list
await mediaSosial.findMany.load();
return true;
} else {
throw new Error(result.message || "Gagal update media sosial");
toast.error(res.data?.message || "Gagal update media sosial");
return false;
}
} catch (error) {
console.error("Error updating media sosial:", error);
if (process.env.NODE_ENV === 'development') {
console.error("Error updating media sosial:", error);
}
toast.error(
error instanceof Error
? error.message

View File

@@ -160,7 +160,7 @@ function ListKategoriBerita({ search }: { search: string }) {
))
) : (
<TableTr>
<TableTd colSpan={4}>
<TableTd colSpan={3}> {/* ✅ Match column count (3 columns) */}
<Center py={24}>
<Text c="dimmed" fz="sm" lh={1.4}>
Tidak ada data kategori berita yang cocok

View File

@@ -9,6 +9,8 @@ import {
ActionIcon,
Box,
Button,
Card,
Grid,
Group,
Image,
Paper,
@@ -17,7 +19,7 @@ import {
Text,
TextInput,
Title,
Loader
Loader,
} from "@mantine/core";
import { Dropzone } from "@mantine/dropzone";
import {
@@ -25,19 +27,51 @@ import {
IconPhoto,
IconUpload,
IconX,
IconVideo,
IconTrash,
} from "@tabler/icons-react";
import { useParams, useRouter } from "next/navigation";
import { useEffect, useState } from "react";
import { toast } from "react-toastify";
import { useProxy } from "valtio/utils";
import { convertYoutubeUrlToEmbed } from '@/app/admin/(dashboard)/desa/gallery/lib/youtube-utils';
interface ExistingImage {
id: string;
link: string;
name: string;
}
interface BeritaData {
id: string;
judul: string;
deskripsi: string;
content: string;
kategoriBeritaId: string | null;
imageId: string | null;
image?: { link: string } | null;
images?: ExistingImage[];
linkVideo?: string | null;
}
function EditBerita() {
const beritaState = useProxy(stateDashboardBerita);
const router = useRouter();
const params = useParams();
// Featured image state
const [previewImage, setPreviewImage] = useState<string | null>(null);
const [file, setFile] = useState<File | null>(null);
// Gallery images state
const [existingGalleryImages, setExistingGalleryImages] = useState<ExistingImage[]>([]);
const [galleryFiles, setGalleryFiles] = useState<File[]>([]);
const [galleryPreviews, setGalleryPreviews] = useState<string[]>([]);
// YouTube link state
const [youtubeLink, setYoutubeLink] = useState('');
const [originalYoutubeLink, setOriginalYoutubeLink] = useState('');
const [formData, setFormData] = useState({
judul: "",
deskripsi: "",
@@ -48,9 +82,17 @@ function EditBerita() {
const [isSubmitting, setIsSubmitting] = useState(false);
const [originalData, setOriginalData] = useState({
judul: "",
deskripsi: "",
kategoriBeritaId: "",
content: "",
imageId: "",
imageUrl: ""
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
@@ -61,21 +103,12 @@ function EditBerita() {
formData.judul?.trim() !== '' &&
formData.kategoriBeritaId !== '' &&
!isHtmlEmpty(formData.deskripsi) &&
(file !== null || originalData.imageId !== '') && // Either a new file is selected or an existing image exists
(file !== null || originalData.imageId !== '') &&
!isHtmlEmpty(formData.content)
);
};
const [originalData, setOriginalData] = useState({
judul: "",
deskripsi: "",
kategoriBeritaId: "",
content: "",
imageId: "",
imageUrl: ""
});
// Load kategori + berita
// Load data
useEffect(() => {
beritaState.kategoriBerita.findMany.load();
@@ -84,7 +117,7 @@ function EditBerita() {
if (!id) return;
try {
const data = await stateDashboardBerita.berita.edit.load(id);
const data = await stateDashboardBerita.berita.edit.load(id) as BeritaData | null;
if (data) {
setFormData({
judul: data.judul || "",
@@ -106,6 +139,17 @@ function EditBerita() {
if (data?.image?.link) {
setPreviewImage(data.image.link);
}
// Load gallery images
if (data?.images && data.images.length > 0) {
setExistingGalleryImages(data.images);
}
// Load YouTube link
if (data?.linkVideo) {
setYoutubeLink(data.linkVideo);
setOriginalYoutubeLink(data.linkVideo);
}
}
} catch (error) {
console.error("Error loading berita:", error);
@@ -120,27 +164,59 @@ function EditBerita() {
setFormData((prev) => ({ ...prev, [field]: value }));
};
const handleGalleryDrop = (files: File[]) => {
const maxImages = 10;
const currentCount = existingGalleryImages.length + galleryFiles.length;
const availableSlots = maxImages - currentCount;
if (availableSlots <= 0) {
toast.warn('Maksimal 10 gambar untuk galeri');
return;
}
const newFiles = files.slice(0, availableSlots);
if (newFiles.length === 0) {
toast.warn('Tidak ada slot tersisa untuk gambar galeri');
return;
}
setGalleryFiles([...galleryFiles, ...newFiles]);
const newPreviews = newFiles.map((f) => URL.createObjectURL(f));
setGalleryPreviews([...galleryPreviews, ...newPreviews]);
};
const removeGalleryImage = (index: number, isExisting: boolean = false) => {
if (isExisting) {
setExistingGalleryImages(existingGalleryImages.filter((_, i) => i !== index));
} else {
setGalleryFiles(galleryFiles.filter((_, i) => i !== index));
setGalleryPreviews(galleryPreviews.filter((_, i) => i !== index));
}
};
const handleSubmit = async () => {
if (!formData.judul?.trim()) {
toast.error('Judul wajib diisi');
return;
}
if (!formData.kategoriBeritaId) {
toast.error('Kategori wajib dipilih');
return;
}
if (isHtmlEmpty(formData.deskripsi)) {
toast.error('Deskripsi singkat wajib diisi');
return;
}
if (!file && !originalData.imageId) {
toast.error('Gambar wajib dipilih');
toast.error('Gambar utama wajib dipilih');
return;
}
if (isHtmlEmpty(formData.content)) {
toast.error('Konten wajib diisi');
return;
@@ -148,12 +224,14 @@ function EditBerita() {
try {
setIsSubmitting(true);
// Update global state hanya sekali di sini
// Update global state
beritaState.berita.edit.form = {
...beritaState.berita.edit.form,
...formData,
};
// Upload new featured image if changed
if (file) {
const res = await ApiFetch.api.fileStorage.create.post({
file,
@@ -162,12 +240,33 @@ function EditBerita() {
const uploaded = res.data?.data;
if (!uploaded?.id) {
return toast.error("Gagal upload gambar");
return toast.error("Gagal upload gambar utama");
}
beritaState.berita.edit.form.imageId = uploaded.id;
}
// Upload new gallery images
const newGalleryIds: string[] = [];
for (const galleryFile of galleryFiles) {
const galleryRes = await ApiFetch.api.fileStorage.create.post({
file: galleryFile,
name: galleryFile.name,
});
const galleryUploaded = galleryRes.data?.data;
if (galleryUploaded?.id) {
newGalleryIds.push(galleryUploaded.id);
}
}
// Combine existing (not removed) and new gallery images
const remainingExistingIds = existingGalleryImages.map(img => img.id);
beritaState.berita.edit.form.imageIds = [...remainingExistingIds, ...newGalleryIds];
// Set YouTube link
const embedLink = convertYoutubeUrlToEmbed(youtubeLink);
beritaState.berita.edit.form.linkVideo = embedLink || '';
await beritaState.berita.edit.update();
toast.success("Berita berhasil diperbarui!");
router.push("/admin/desa/berita/list-berita");
@@ -189,9 +288,12 @@ function EditBerita() {
});
setPreviewImage(originalData.imageUrl || null);
setFile(null);
setYoutubeLink(originalYoutubeLink);
toast.info("Form dikembalikan ke data awal");
};
const embedLink = convertYoutubeUrlToEmbed(youtubeLink);
return (
<Box px={{ base: 0, md: 'lg' }} py="xs">
{/* Header */}
@@ -219,6 +321,7 @@ function EditBerita() {
style={{ border: "1px solid #e0e0e0" }}
>
<Stack gap="md">
{/* Judul */}
<TextInput
label="Judul"
placeholder="Masukkan judul"
@@ -227,6 +330,7 @@ function EditBerita() {
required
/>
{/* Kategori */}
<Select
value={formData.kategoriBeritaId}
onChange={(val) => handleChange("kategoriBeritaId", val || "")}
@@ -241,9 +345,9 @@ function EditBerita() {
clearable
searchable
required
error={!formData.kategoriBeritaId ? "Pilih kategori" : undefined}
/>
{/* Deskripsi */}
<Box>
<Text fz="sm" fw="bold">
Deskripsi Singkat
@@ -256,11 +360,10 @@ function EditBerita() {
/>
</Box>
{/* Upload Gambar */}
{/* Featured Image */}
<Box>
<Text fw="bold" fz="sm" mb={6}>
Gambar Berita
Gambar Utama (Featured)
</Text>
<Dropzone
onDrop={(files) => {
@@ -274,17 +377,13 @@ function EditBerita() {
toast.error("File tidak valid, gunakan format gambar")
}
maxSize={5 * 1024 ** 2}
accept={{ "image/*": [] }}
accept={{ "image/*": ['.jpeg', '.jpg', '.png', '.webp'] }}
radius="md"
p="xl"
>
<Group justify="center" gap="xl" mih={180}>
<Dropzone.Accept>
<IconUpload
size={48}
color={colors["blue-button"]}
stroke={1.5}
/>
<IconUpload size={48} color={colors["blue-button"]} stroke={1.5} />
</Dropzone.Accept>
<Dropzone.Reject>
<IconX size={48} color="red" stroke={1.5} />
@@ -292,14 +391,6 @@ function EditBerita() {
<Dropzone.Idle>
<IconPhoto size={48} color="#868e96" stroke={1.5} />
</Dropzone.Idle>
<Stack gap="xs" align="center">
<Text size="md" fw={500}>
Seret gambar atau klik untuk memilih file
</Text>
<Text size="sm" c="dimmed">
Maksimal 5MB, format gambar .png, .jpg, .jpeg, webp
</Text>
</Stack>
</Group>
</Dropzone>
@@ -328,9 +419,7 @@ function EditBerita() {
setPreviewImage(null);
setFile(null);
}}
style={{
boxShadow: '0 2px 6px rgba(0,0,0,0.15)',
}}
style={{ boxShadow: '0 2px 6px rgba(0,0,0,0.15)' }}
>
<IconX size={14} />
</ActionIcon>
@@ -338,6 +427,138 @@ function EditBerita() {
)}
</Box>
{/* Gallery Images */}
<Box>
<Text fw="bold" fz="sm" mb={6}>
Galeri Gambar (Opsional - Maksimal 10)
</Text>
<Dropzone
onDrop={handleGalleryDrop}
onReject={() => toast.error("File tidak valid, gunakan format gambar")}
maxSize={5 * 1024 ** 2}
accept={{ "image/*": ['.jpeg', '.jpg', '.png', '.webp'] }}
radius="md"
p="md"
multiple
>
<Group justify="center" gap="xl" mih={120}>
<Dropzone.Accept>
<IconUpload size={40} color={colors["blue-button"]} stroke={1.5} />
</Dropzone.Accept>
<Dropzone.Reject>
<IconX size={40} color="red" stroke={1.5} />
</Dropzone.Reject>
<Dropzone.Idle>
<IconPhoto size={40} color="#868e96" stroke={1.5} />
</Dropzone.Idle>
</Group>
<Text ta="center" mt="sm" size="xs" color="dimmed">
Seret gambar untuk menambahkan ke galeri
</Text>
</Dropzone>
{/* Existing Gallery Images */}
{existingGalleryImages.length > 0 && (
<Box mt="sm">
<Text fz="xs" fw="bold" mb={6} c="dimmed">
Gambar Existing ({existingGalleryImages.length})
</Text>
<Grid gutter="sm">
{existingGalleryImages.map((img, index) => (
<Grid.Col span={4} key={img.id}>
<Card p="xs" radius="md" withBorder>
<Image src={img.link} alt={img.name} radius="sm" height={100} fit="cover" />
<ActionIcon
variant="filled"
color="red"
radius="xl"
size="sm"
pos="absolute"
top={5}
right={5}
onClick={() => removeGalleryImage(index, true)}
style={{ boxShadow: '0 2px 6px rgba(0,0,0,0.15)' }}
>
<IconTrash size={14} />
</ActionIcon>
</Card>
</Grid.Col>
))}
</Grid>
</Box>
)}
{/* New Gallery Images */}
{galleryPreviews.length > 0 && (
<Box mt="sm">
<Text fz="xs" fw="bold" mb={6} c="dimmed">
Gambar Baru ({galleryPreviews.length})
</Text>
<Grid gutter="sm">
{galleryPreviews.map((preview, index) => (
<Grid.Col span={4} key={index}>
<Card p="xs" radius="md" withBorder>
<Image src={preview} alt={`New ${index}`} radius="sm" height={100} fit="cover" />
<ActionIcon
variant="filled"
color="red"
radius="xl"
size="sm"
pos="absolute"
top={5}
right={5}
onClick={() => removeGalleryImage(index, false)}
style={{ boxShadow: '0 2px 6px rgba(0,0,0,0.15)' }}
>
<IconTrash size={14} />
</ActionIcon>
</Card>
</Grid.Col>
))}
</Grid>
</Box>
)}
</Box>
{/* YouTube Video */}
<Box>
<Text fw="bold" fz="sm" mb={6}>
Link Video YouTube (Opsional)
</Text>
<TextInput
placeholder="https://www.youtube.com/watch?v=..."
value={youtubeLink}
onChange={(e) => setYoutubeLink(e.currentTarget.value)}
leftSection={<IconVideo size={18} />}
rightSection={
youtubeLink && (
<ActionIcon
variant="subtle"
color="gray"
onClick={() => setYoutubeLink('')}
>
<IconX size={18} />
</ActionIcon>
)
}
/>
{embedLink && (
<Box mt="sm" pos="relative">
<iframe
style={{
borderRadius: 10,
width: '100%',
height: 250,
border: '1px solid #ddd',
}}
src={embedLink}
title="Preview Video"
allowFullScreen
/>
</Box>
)}
</Box>
{/* Konten */}
<Box>
<Text fz="sm" fw="bold">
@@ -351,9 +572,8 @@ function EditBerita() {
/>
</Box>
{/* Action */}
{/* Action Buttons */}
<Group justify="right">
{/* Tombol Batal */}
<Button
variant="outline"
color="gray"
@@ -363,8 +583,6 @@ function EditBerita() {
>
Batal
</Button>
{/* Tombol Simpan */}
<Button
onClick={handleSubmit}
radius="md"

View File

@@ -1,7 +1,7 @@
'use client'
import { Box, Button, Group, Image, Paper, Skeleton, Stack, Text } from '@mantine/core';
import { Box, Button, Card, Grid, Group, Image, Paper, Skeleton, Stack, Text, Badge, AspectRatio } from '@mantine/core';
import { useShallowEffect } from '@mantine/hooks';
import { IconArrowBack, IconEdit, IconTrash } from '@tabler/icons-react';
import { IconArrowBack, IconEdit, IconTrash, IconVideo } from '@tabler/icons-react';
import { useParams, useRouter } from 'next/navigation';
import { useState } from 'react';
import { useProxy } from 'valtio/utils';
@@ -10,6 +10,23 @@ import { ModalKonfirmasiHapus } from '@/app/admin/(dashboard)/_com/modalKonfirma
import stateDashboardBerita from '@/app/admin/(dashboard)/_state/desa/berita';
import colors from '@/con/colors';
interface ExistingImage {
id: string;
link: string;
name: string;
}
interface BeritaDetail {
id: string;
judul: string;
deskripsi: string;
content: string;
image?: { link: string } | null;
images?: ExistingImage[];
linkVideo?: string | null;
kategoriBerita?: { name: string } | null;
}
function DetailBerita() {
const beritaState = useProxy(stateDashboardBerita);
const [modalHapus, setModalHapus] = useState(false);
@@ -38,7 +55,7 @@ function DetailBerita() {
);
}
const data = beritaState.berita.findUnique.data;
const data = beritaState.berita.findUnique.data as unknown as BeritaDetail;
return (
<Box px={{ base: 0, md: 'xs' }} py="xs">
@@ -68,71 +85,131 @@ function DetailBerita() {
<Paper bg="#ECEEF8" p="md" radius="md" shadow="xs">
<Stack gap="sm">
{/* Kategori */}
<Box>
<Text fz="lg" fw="bold">Kategori</Text>
<Text fz="md" c="dimmed">{data.kategoriBerita?.name || '-'}</Text>
</Box>
{/* Judul */}
<Box>
<Text fz="lg" fw="bold">Judul</Text>
<Text fz="md" c="dimmed">{data.judul || '-'}</Text>
</Box>
{/* Deskripsi */}
<Box>
<Text fz="lg" fw="bold">Deskripsi</Text>
<Text fz="md" c="dimmed" style={{ wordBreak: "break-word", whiteSpace: "normal" }} dangerouslySetInnerHTML={{ __html: data.deskripsi || '-' }} />
<Text
fz="md"
c="dimmed"
style={{ wordBreak: "break-word", whiteSpace: "normal" }}
dangerouslySetInnerHTML={{ __html: data.deskripsi || '-' }}
/>
</Box>
{/* Gambar Utama (Featured) */}
<Box>
<Text fz="lg" fw="bold">Gambar</Text>
<Text fz="lg" fw="bold">Gambar Utama</Text>
{data.image?.link ? (
<Image
src={data.image.link}
alt={data.judul || 'Gambar Berita'}
w={200}
h={200}
w={{ base: '100%', md: 400 }}
h={300}
radius="md"
fit="cover"
loading='lazy'
loading="lazy"
/>
) : (
<Text fz="sm" c="dimmed">Tidak ada gambar</Text>
<Text fz="sm" c="dimmed">Tidak ada gambar utama</Text>
)}
</Box>
{/* Gallery Images */}
{data.images && data.images.length > 0 && (
<Box>
<Group gap="xs" mb="sm">
<Text fz="lg" fw="bold">Galeri Gambar</Text>
<Badge color="blue" variant="light">
{data.images.length}
</Badge>
</Group>
<Grid gutter="md">
{data.images.map((img, index) => (
<Grid.Col span={{ base: 6, md: 4 }} key={img.id}>
<Card p="xs" radius="md" withBorder>
<Image
src={img.link}
alt={img.name || `Gallery ${index + 1}`}
h={150}
radius="sm"
fit="cover"
loading="lazy"
/>
</Card>
</Grid.Col>
))}
</Grid>
</Box>
)}
{/* YouTube Video */}
{data.linkVideo && (
<Box>
<Group gap="xs" mb="sm">
<Text fz="lg" fw="bold">Video YouTube</Text>
<IconVideo size={20} color={colors['blue-button']} />
</Group>
<AspectRatio ratio={16 / 9} mah={400}>
<iframe
src={data.linkVideo}
title="YouTube Video"
allowFullScreen
style={{ borderRadius: 10, border: '1px solid #ddd' }}
/>
</AspectRatio>
</Box>
)}
{/* Konten */}
<Box>
<Text fz="lg" fw="bold">Konten</Text>
<Text
fz="md"
c="dimmed"
dangerouslySetInnerHTML={{ __html: data.content || '-' }}
/>
<Paper bg="white" p="md" radius="md" mt="xs">
<Text
fz="md"
c="dimmed"
dangerouslySetInnerHTML={{ __html: data.content || '-' }}
/>
</Paper>
</Box>
{/* Action Button */}
<Group gap="sm">
<Button
color="red"
onClick={() => {
setSelectedId(data.id);
setModalHapus(true);
}}
variant="light"
radius="md"
size="md"
>
<IconTrash size={20} />
</Button>
{/* Action Buttons */}
<Group gap="sm" mt="md">
<Button
color="red"
onClick={() => {
setSelectedId(data.id);
setModalHapus(true);
}}
variant="light"
radius="md"
size="md"
leftSection={<IconTrash size={20} />}
>
Hapus
</Button>
<Button
color="green"
onClick={() => router.push(`/admin/desa/berita/list-berita/${data.id}/edit`)}
variant="light"
radius="md"
size="md"
>
<IconEdit size={20} />
</Button>
<Button
color="green"
onClick={() => router.push(`/admin/desa/berita/list-berita/${data.id}/edit`)}
variant="light"
radius="md"
size="md"
leftSection={<IconEdit size={20} />}
>
Edit
</Button>
</Group>
</Stack>
</Paper>

View File

@@ -15,26 +15,38 @@ import {
TextInput,
Title,
Loader,
ActionIcon
ActionIcon,
Grid,
Card,
} from '@mantine/core';
import { Dropzone } from '@mantine/dropzone';
import { useShallowEffect } from '@mantine/hooks';
import { IconArrowBack, IconPhoto, IconUpload, IconX } from '@tabler/icons-react';
import { IconArrowBack, IconPhoto, IconUpload, IconX, IconVideo, IconTrash } from '@tabler/icons-react';
import { useRouter } from 'next/navigation';
import { useState } from 'react';
import { toast } from 'react-toastify';
import { useProxy } from 'valtio/utils';
import { convertYoutubeUrlToEmbed } from '@/app/admin/(dashboard)/desa/gallery/lib/youtube-utils';
export default function CreateBerita() {
const beritaState = useProxy(stateDashboardBerita);
const router = useRouter();
// Featured image state
const [previewImage, setPreviewImage] = useState<string | null>(null);
const [file, setFile] = useState<File | null>(null);
const router = useRouter();
// Gallery images state
const [galleryFiles, setGalleryFiles] = useState<File[]>([]);
const [galleryPreviews, setGalleryPreviews] = useState<string[]>([]);
// YouTube link state
const [youtubeLink, setYoutubeLink] = useState('');
const [isSubmitting, setIsSubmitting] = useState(false);
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
@@ -61,9 +73,35 @@ export default function CreateBerita() {
kategoriBeritaId: '',
imageId: '',
content: '',
imageIds: [],
linkVideo: '',
};
setPreviewImage(null);
setFile(null);
setGalleryFiles([]);
setGalleryPreviews([]);
setYoutubeLink('');
};
const handleGalleryDrop = (files: File[]) => {
const newFiles = files.filter(
(_, index) => galleryFiles.length + index < 10 // Max 10 images
);
if (newFiles.length === 0) {
toast.warn('Maksimal 10 gambar untuk galeri');
return;
}
setGalleryFiles([...galleryFiles, ...newFiles]);
const newPreviews = newFiles.map((f) => URL.createObjectURL(f));
setGalleryPreviews([...galleryPreviews, ...newPreviews]);
};
const removeGalleryImage = (index: number) => {
setGalleryFiles(galleryFiles.filter((_, i) => i !== index));
setGalleryPreviews(galleryPreviews.filter((_, i) => i !== index));
};
const handleSubmit = async () => {
@@ -71,22 +109,22 @@ export default function CreateBerita() {
toast.error('Judul wajib diisi');
return;
}
if (!beritaState.berita.create.form.kategoriBeritaId) {
toast.error('Kategori wajib dipilih');
return;
}
if (isHtmlEmpty(beritaState.berita.create.form.deskripsi)) {
toast.error('Deskripsi singkat wajib diisi');
return;
}
if (!file) {
toast.error('Gambar wajib dipilih');
toast.error('Gambar utama wajib dipilih');
return;
}
if (isHtmlEmpty(beritaState.berita.create.form.content)) {
toast.error('Konten wajib diisi');
return;
@@ -94,21 +132,37 @@ export default function CreateBerita() {
try {
setIsSubmitting(true);
if (!file) {
return toast.warn('Silakan pilih file gambar terlebih dahulu');
}
const res = await ApiFetch.api.fileStorage.create.post({
// Upload featured image
const featuredRes = await ApiFetch.api.fileStorage.create.post({
file,
name: file.name,
});
const uploaded = res.data?.data;
if (!uploaded?.id) {
return toast.error('Gagal mengunggah gambar, silakan coba lagi');
const featuredUploaded = featuredRes.data?.data;
if (!featuredUploaded?.id) {
return toast.error('Gagal mengunggah gambar utama');
}
beritaState.berita.create.form.imageId = featuredUploaded.id;
beritaState.berita.create.form.imageId = uploaded.id;
// Upload gallery images
const galleryIds: string[] = [];
for (const galleryFile of galleryFiles) {
const galleryRes = await ApiFetch.api.fileStorage.create.post({
file: galleryFile,
name: galleryFile.name,
});
const galleryUploaded = galleryRes.data?.data;
if (galleryUploaded?.id) {
galleryIds.push(galleryUploaded.id);
}
}
beritaState.berita.create.form.imageIds = galleryIds;
// Set YouTube link if provided
const embedLink = convertYoutubeUrlToEmbed(youtubeLink);
if (embedLink) {
beritaState.berita.create.form.linkVideo = embedLink;
}
await beritaState.berita.create.create();
@@ -122,16 +176,13 @@ export default function CreateBerita() {
}
};
const embedLink = convertYoutubeUrlToEmbed(youtubeLink);
return (
<Box px={{ base: 0, md: 'lg' }} py="xs">
{/* Header dengan tombol kembali */}
{/* Header */}
<Group mb="md">
<Button
variant="subtle"
onClick={() => router.back()}
p="xs"
radius="md"
>
<Button variant="subtle" onClick={() => router.back()} p="xs" radius="md">
<IconArrowBack color={colors['blue-button']} size={24} />
</Button>
<Title order={4} ml="sm" c="dark">
@@ -148,6 +199,7 @@ export default function CreateBerita() {
style={{ border: '1px solid #e0e0e0' }}
>
<Stack gap="md">
{/* Judul */}
<TextInput
label="Judul"
placeholder="Masukkan judul berita"
@@ -156,6 +208,7 @@ export default function CreateBerita() {
required
/>
{/* Kategori */}
<Select
label="Kategori"
placeholder="Pilih kategori"
@@ -182,6 +235,7 @@ export default function CreateBerita() {
required
/>
{/* Deskripsi */}
<Box>
<Text fz="sm" fw="bold" mb={6}>
Deskripsi Singkat
@@ -194,9 +248,10 @@ export default function CreateBerita() {
/>
</Box>
{/* Featured Image */}
<Box>
<Text fw="bold" fz="sm" mb={6}>
Gambar Berita
Gambar Utama (Featured)
</Text>
<Dropzone
onDrop={(files) => {
@@ -232,17 +287,11 @@ export default function CreateBerita() {
<Box mt="sm" pos="relative" style={{ textAlign: 'center' }}>
<Image
src={previewImage}
alt="Preview Gambar"
alt="Preview Gambar Utama"
radius="md"
style={{
maxHeight: 200,
objectFit: 'contain',
border: '1px solid #ddd',
}}
style={{ maxHeight: 200, objectFit: 'contain', border: '1px solid #ddd' }}
loading="lazy"
/>
{/* Tombol hapus (pojok kanan atas) */}
<ActionIcon
variant="filled"
color="red"
@@ -255,9 +304,7 @@ export default function CreateBerita() {
setPreviewImage(null);
setFile(null);
}}
style={{
boxShadow: '0 2px 6px rgba(0,0,0,0.15)',
}}
style={{ boxShadow: '0 2px 6px rgba(0,0,0,0.15)' }}
>
<IconX size={14} />
</ActionIcon>
@@ -265,6 +312,102 @@ export default function CreateBerita() {
)}
</Box>
{/* Gallery Images */}
<Box>
<Text fw="bold" fz="sm" mb={6}>
Galeri Gambar (Opsional - Maksimal 10)
</Text>
<Dropzone
onDrop={handleGalleryDrop}
onReject={() => toast.error('File tidak valid, gunakan format gambar')}
maxSize={5 * 1024 ** 2}
accept={{ 'image/*': ['.jpeg', '.jpg', '.png', '.webp'] }}
radius="md"
p="md"
multiple
>
<Group justify="center" gap="xl" mih={120}>
<Dropzone.Accept>
<IconUpload size={40} color="var(--mantine-color-blue-6)" stroke={1.5} />
</Dropzone.Accept>
<Dropzone.Reject>
<IconX size={40} color="var(--mantine-color-red-6)" stroke={1.5} />
</Dropzone.Reject>
<Dropzone.Idle>
<IconPhoto size={40} color="var(--mantine-color-dimmed)" stroke={1.5} />
</Dropzone.Idle>
</Group>
<Text ta="center" mt="sm" size="xs" color="dimmed">
Seret gambar atau klik untuk menambahkan ke galeri
</Text>
</Dropzone>
{galleryPreviews.length > 0 && (
<Grid mt="sm" gutter="sm">
{galleryPreviews.map((preview, index) => (
<Grid.Col span={4} key={index}>
<Card p="xs" radius="md" withBorder>
<Image src={preview} alt={`Gallery ${index}`} radius="sm" height={100} fit="cover" />
<ActionIcon
variant="filled"
color="red"
radius="xl"
size="sm"
pos="absolute"
top={5}
right={5}
onClick={() => removeGalleryImage(index)}
style={{ boxShadow: '0 2px 6px rgba(0,0,0,0.15)' }}
>
<IconTrash size={14} />
</ActionIcon>
</Card>
</Grid.Col>
))}
</Grid>
)}
</Box>
{/* YouTube Video */}
<Box>
<Text fw="bold" fz="sm" mb={6}>
Link Video YouTube (Opsional)
</Text>
<TextInput
placeholder="https://www.youtube.com/watch?v=..."
value={youtubeLink}
onChange={(e) => setYoutubeLink(e.currentTarget.value)}
leftSection={<IconVideo size={18} />}
rightSection={
youtubeLink && (
<ActionIcon
variant="subtle"
color="gray"
onClick={() => setYoutubeLink('')}
>
<IconX size={18} />
</ActionIcon>
)
}
/>
{embedLink && (
<Box mt="sm" pos="relative">
<iframe
style={{
borderRadius: 10,
width: '100%',
height: 250,
border: '1px solid #ddd',
}}
src={embedLink}
title="Preview Video"
allowFullScreen
/>
</Box>
)}
</Box>
{/* Konten */}
<Box>
<Text fz="sm" fw="bold" mb={6}>
Konten
@@ -277,6 +420,7 @@ export default function CreateBerita() {
/>
</Box>
{/* Buttons */}
<Group justify="right">
<Button
variant="outline"
@@ -287,8 +431,6 @@ export default function CreateBerita() {
>
Reset
</Button>
{/* Tombol Simpan */}
<Button
onClick={handleSubmit}
radius="md"

View File

@@ -187,7 +187,7 @@ function ListBerita({ search }: { search: string }) {
<Pagination
value={page}
onChange={(newPage) => {
load(newPage, 10);
load(newPage, 10, debouncedSearch); // ✅ Include search parameter
window.scrollTo({ top: 0, behavior: 'smooth' });
}}
total={totalPages}

View File

@@ -8,6 +8,7 @@ import { IconArrowBack, IconEdit, IconTrash } from '@tabler/icons-react';
import { useParams, useRouter } from 'next/navigation';
import { useState } from 'react';
import { useProxy } from 'valtio/utils';
import DOMPurify from 'dompurify';
export default function DetailPotensi() {
const router = useRouter();
@@ -77,7 +78,17 @@ export default function DetailPotensi() {
<Box>
<Text fz="lg" fw="bold">Deskripsi</Text>
<Text fz="md" c="dimmed" style={{ wordBreak: "break-word", whiteSpace: "normal" }} dangerouslySetInnerHTML={{ __html: data.deskripsi || '-' }}></Text>
<Text
fz="md"
c="dimmed"
style={{ wordBreak: "break-word", whiteSpace: "normal" }}
dangerouslySetInnerHTML={{
__html: DOMPurify.sanitize(data.deskripsi || '-', {
ALLOWED_TAGS: ['p', 'br', 'strong', 'em', 'u', 'ul', 'ol', 'li'],
ALLOWED_ATTR: []
})
}}
></Text>
</Box>
<Box>
@@ -102,7 +113,12 @@ export default function DetailPotensi() {
<Text
fz="md"
c="dimmed"
dangerouslySetInnerHTML={{ __html: data.content || '-' }}
dangerouslySetInnerHTML={{
__html: DOMPurify.sanitize(data.content || '-', {
ALLOWED_TAGS: ['p', 'br', 'strong', 'em', 'u', 'ul', 'ol', 'li'],
ALLOWED_ATTR: []
})
}}
style={{ wordBreak: "break-word", whiteSpace: "normal" }}
/>
</Box>

View File

@@ -27,6 +27,7 @@ import { useProxy } from 'valtio/utils';
import HeaderSearch from '../../../_com/header';
import potensiDesaState from '../../../_state/desa/potensi';
import { useDebouncedValue } from '@mantine/hooks';
import DOMPurify from 'dompurify';
function Potensi() {
const [search, setSearch] = useState("");
@@ -137,7 +138,12 @@ function ListPotensi({ search }: { search: string }) {
fz="sm"
lh={1.5}
lineClamp={2}
dangerouslySetInnerHTML={{ __html: item.deskripsi }}
dangerouslySetInnerHTML={{
__html: DOMPurify.sanitize(item.deskripsi, {
ALLOWED_TAGS: ['p', 'br', 'strong', 'em', 'u', 'ul', 'ol', 'li'],
ALLOWED_ATTR: []
})
}}
style={{ wordBreak: 'break-word' }}
/>
</TableTd>
@@ -199,7 +205,12 @@ function ListPotensi({ search }: { search: string }) {
<Text
fz="sm"
lh={1.5}
dangerouslySetInnerHTML={{ __html: item.deskripsi }}
dangerouslySetInnerHTML={{
__html: DOMPurify.sanitize(item.deskripsi, {
ALLOWED_TAGS: ['p', 'br', 'strong', 'em', 'u', 'ul', 'ol', 'li'],
ALLOWED_ATTR: []
})
}}
style={{ wordBreak: 'break-word' }}
/>
</Box>

View File

@@ -44,6 +44,21 @@ function EditDigitalSmartVillage() {
imageUrl: '',
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.name?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsi)
);
};
useEffect(() => {
const loadData = async () => {
const id = params?.id as string;
@@ -248,8 +263,11 @@ function EditDigitalSmartVillage() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -30,6 +30,22 @@ export default function CreateDesaDigital() {
const router = useRouter();
const [isSubmitting, setIsSubmitting] = useState(false);
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
stateDesaDigital.create.form.name?.trim() !== '' &&
!isHtmlEmpty(stateDesaDigital.create.form.deskripsi) &&
file !== null
);
};
const resetForm = () => {
stateDesaDigital.create.form = {
name: '',
@@ -227,8 +243,11 @@ export default function CreateDesaDigital() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -44,6 +44,21 @@ function EditInfoTeknologiTepatGuna() {
imageUrl: '',
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.name?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsi)
);
};
// Load data pertama kali
useEffect(() => {
const id = params?.id as string;
@@ -260,8 +275,11 @@ function EditInfoTeknologiTepatGuna() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -30,6 +30,22 @@ function CreateInfoTeknologiTepatGuna() {
const router = useRouter();
const [isSubmitting, setIsSubmitting] = useState(false);
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
stateInfoTekno.create.form.name?.trim() !== '' &&
!isHtmlEmpty(stateInfoTekno.create.form.deskripsi) &&
file !== null
);
};
const resetForm = () => {
stateInfoTekno.create.form = {
name: '',
@@ -202,8 +218,11 @@ function CreateInfoTeknologiTepatGuna() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -44,6 +44,23 @@ function EditKolaborasiInovasi() {
kolaborator: "",
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.name?.trim() !== '' &&
formData.slug?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsi) &&
formData.kolaborator?.trim() !== ''
);
};
// Load data awal dari server
useEffect(() => {
const loadKolaborasi = async () => {
@@ -199,8 +216,11 @@ function EditKolaborasiInovasi() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -16,6 +16,22 @@ function CreateProgramKreatifDesa() {
const router = useRouter();
const [isSubmitting, setIsSubmitting] = useState(false);
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
stateCreate.create.form.name?.trim() !== '' &&
stateCreate.create.form.slug?.trim() !== '' &&
!isHtmlEmpty(stateCreate.create.form.deskripsi)
);
};
const resetForm = () => {
stateCreate.create.form = {
name: "",
@@ -135,8 +151,11 @@ function CreateProgramKreatifDesa() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -51,6 +51,11 @@ function EditMitraKolaborasi() {
imageUrl: '',
});
// Check if form is valid
const isFormValid = () => {
return formData.name?.trim() !== '';
};
// Load data ke state lokal sekali saja
useEffect(() => {
const loadData = async () => {
@@ -263,8 +268,11 @@ function EditMitraKolaborasi() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -29,6 +29,14 @@ function CreateMitraKolaborasi() {
const [file, setFile] = useState<File | null>(null);
const [isSubmitting, setIsSubmitting] = useState(false);
// Check if form is valid
const isFormValid = () => {
return (
state.create.form.name?.trim() !== '' &&
file !== null
);
};
const resetForm = () => {
state.create.form = {
name: '',
@@ -181,8 +189,11 @@ function CreateMitraKolaborasi() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -51,6 +51,23 @@ function EditProgramKreatifDesa() {
const [isDataChanged, setIsDataChanged] = useState(false);
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.name?.trim() !== '' &&
formData.slug?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsi) &&
formData.icon?.trim() !== ''
);
};
// Load data hanya sekali berdasarkan params.id
useEffect(() => {
const loadProgramKreatif = async () => {
@@ -236,8 +253,11 @@ function EditProgramKreatifDesa() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -25,6 +25,23 @@ function CreateProgramKreatifDesa() {
const router = useRouter();
const [isSubmitting, setIsSubmitting] = useState(false);
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
stateCreate.create.form.name?.trim() !== '' &&
stateCreate.create.form.icon?.trim() !== '' &&
stateCreate.create.form.slug?.trim() !== '' &&
!isHtmlEmpty(stateCreate.create.form.deskripsi)
);
};
const resetForm = () => {
stateCreate.create.form = {
name: "",
@@ -127,8 +144,11 @@ function CreateProgramKreatifDesa() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -0,0 +1,429 @@
/* eslint-disable @typescript-eslint/no-explicit-any */
'use client';
import { useProxy } from 'valtio/utils';
import apbdes from '@/app/admin/(dashboard)/_state/landing-page/apbdes';
import { useState } from 'react';
import { toast } from 'react-toastify';
import {
Box,
Button,
Group,
Paper,
Stack,
Text,
TextInput,
NumberInput,
Title,
Table,
TableThead,
TableTbody,
TableTr,
TableTh,
TableTd,
ActionIcon,
Badge,
Modal,
Divider,
Center,
} from '@mantine/core';
import {
IconPlus,
IconEdit,
IconTrash,
IconCalendar,
IconCoin,
} from '@tabler/icons-react';
interface RealisasiManagerProps {
itemId: string;
itemKode: string;
itemUraian: string;
itemAnggaran: number;
itemTotalRealisasi: number;
itemPersentase: number;
realisasiItems: any[];
}
export default function RealisasiManager({
itemId,
itemKode,
itemUraian,
itemAnggaran,
itemTotalRealisasi,
itemPersentase,
realisasiItems,
}: RealisasiManagerProps) {
const state = useProxy(apbdes);
const [modalOpened, setModalOpened] = useState(false);
const [editingId, setEditingId] = useState<string | null>(null);
const [loading, setLoading] = useState(false);
// Form state
const [formData, setFormData] = useState({
kode: '',
jumlah: 0,
tanggal: new Date().toISOString().split('T')[0], // YYYY-MM-DD format for input
keterangan: '',
});
const resetForm = () => {
setFormData({
kode: '',
jumlah: 0,
tanggal: new Date().toISOString().split('T')[0],
keterangan: '',
});
setEditingId(null);
};
const handleOpenCreate = () => {
resetForm();
setModalOpened(true);
};
const handleOpenEdit = (realisasi: any) => {
const tanggal = new Date(realisasi.tanggal);
const tanggalStr = tanggal.toISOString().split('T')[0]; // YYYY-MM-DD
setFormData({
kode: realisasi.kode || '',
jumlah: realisasi.jumlah,
tanggal: tanggalStr,
keterangan: realisasi.keterangan || '',
});
setEditingId(realisasi.id);
setModalOpened(true);
};
const handleSubmit = async () => {
if (formData.jumlah <= 0) {
return toast.warn('Jumlah realisasi harus lebih dari 0');
}
if (!formData.kode || formData.kode.trim() === '') {
return toast.warn('Kode realisasi wajib diisi');
}
try {
setLoading(true);
if (editingId) {
// Update existing realisasi
const success = await state.realisasi.update(editingId, {
kode: formData.kode,
jumlah: formData.jumlah,
tanggal: new Date(formData.tanggal).toISOString(),
keterangan: formData.keterangan,
});
if (success) {
toast.success('Realisasi berhasil diperbarui');
}
} else {
// Create new realisasi
const success = await state.realisasi.create(itemId, {
kode: formData.kode,
jumlah: formData.jumlah,
tanggal: new Date(formData.tanggal).toISOString(),
keterangan: formData.keterangan,
});
if (success) {
toast.success('Realisasi berhasil ditambahkan');
}
}
setModalOpened(false);
resetForm();
} catch (error: any) {
console.error('Error saving realisasi:', error);
toast.error(error?.message || 'Gagal menyimpan realisasi');
} finally {
setLoading(false);
}
};
const handleDelete = async (realisasiId: string) => {
if (!confirm('Apakah Anda yakin ingin menghapus realisasi ini?')) {
return;
}
try {
setLoading(true);
const success = await state.realisasi.delete(realisasiId);
if (success) {
toast.success('Realisasi berhasil dihapus');
}
} catch (error: any) {
console.error('Error deleting realisasi:', error);
toast.error(error?.message || 'Gagal menghapus realisasi');
} finally {
setLoading(false);
}
};
const formatRupiah = (amount: number) => {
return new Intl.NumberFormat('id-ID', {
style: 'currency',
currency: 'IDR',
minimumFractionDigits: 0,
maximumFractionDigits: 0,
}).format(amount);
};
const formatDate = (dateString: string) => {
return new Date(dateString).toLocaleDateString('id-ID', {
year: 'numeric',
month: 'long',
day: 'numeric',
});
};
const getSisaAnggaran = () => {
return itemAnggaran - itemTotalRealisasi;
};
const getPersentaseColor = (persen: number) => {
if (persen >= 100) return 'teal';
if (persen >= 80) return 'blue';
if (persen >= 60) return 'yellow';
return 'red';
};
return (
<Paper withBorder p="md" radius="md" mt="md">
{/* Header */}
<Group justify="space-between" mb="md">
<Stack gap="xs">
<Title order={6}>
{itemKode} - {itemUraian}
</Title>
<Text fz="sm" c="dimmed">
Kelola realisasi untuk item ini
</Text>
</Stack>
<Button
leftSection={<IconPlus size={18} />}
onClick={handleOpenCreate}
color="blue"
variant="light"
radius="md"
>
Tambah Realisasi
</Button>
</Group>
{/* Summary Cards */}
<Group grow mb="md">
<Paper withBorder p="md" radius="md" bg="blue.0">
<Text fz="xs" c="blue.9" fw={600}>
ANGGARAN
</Text>
<Text fz="lg" c="blue.9" fw={700}>
{formatRupiah(itemAnggaran)}
</Text>
</Paper>
<Paper withBorder p="md" radius="md" bg="teal.0">
<Text fz="xs" c="teal.9" fw={600}>
TOTAL REALISASI
</Text>
<Text fz="lg" c="teal.9" fw={700}>
{formatRupiah(itemTotalRealisasi)}
</Text>
</Paper>
<Paper withBorder p="md" radius="md" bg={getSisaAnggaran() >= 0 ? 'green.0' : 'red.0'}>
<Text fz="xs" c={getSisaAnggaran() >= 0 ? 'green.9' : 'red.9'} fw={600}>
SISA ANGGARAN
</Text>
<Text fz="lg" c={getSisaAnggaran() >= 0 ? 'green.9' : 'red.9'} fw={700}>
{formatRupiah(getSisaAnggaran())}
</Text>
</Paper>
<Paper withBorder p="md" radius="md" bg={getPersentaseColor(itemPersentase) + '.0'}>
<Text fz="xs" c={getPersentaseColor(itemPersentase) + '.9'} fw={600}>
PERSENTASE
</Text>
<Text fz="lg" c={getPersentaseColor(itemPersentase) + '.9'} fw={700}>
{itemPersentase.toFixed(2)}%
</Text>
</Paper>
</Group>
{/* Realisasi List */}
{realisasiItems && realisasiItems.length > 0 ? (
<Box>
<Text fz="sm" fw={600} mb="xs">
Daftar Realisasi ({realisasiItems.length})
</Text>
<Box style={{ overflowX: 'auto' }}>
<Table striped highlightOnHover fz="sm">
<TableThead>
<TableTr>
<TableTh>Kode</TableTh>
<TableTh>Tanggal</TableTh>
<TableTh>Uraian</TableTh>
<TableTh ta="right">Jumlah</TableTh>
<TableTh ta="center">Aksi</TableTh>
</TableTr>
</TableThead>
<TableTbody>
{realisasiItems.map((realisasi) => (
<TableTr key={realisasi.id}>
<TableTd>
<Badge variant="light" color="blue" size="sm">
{realisasi.kode || '-'}
</Badge>
</TableTd>
<TableTd>
<Group gap="xs">
<IconCalendar size={16} />
<Text fz="sm">{formatDate(realisasi.tanggal)}</Text>
</Group>
</TableTd>
<TableTd>
<Text fz="sm">{realisasi.keterangan || '-'}</Text>
</TableTd>
<TableTd ta="right">
<Text fz="sm" fw={600} c="blue">
{formatRupiah(realisasi.jumlah)}
</Text>
</TableTd>
<TableTd ta="center">
<Group gap="xs" justify="center">
<ActionIcon
variant="light"
color="blue"
size="sm"
onClick={() => handleOpenEdit(realisasi)}
>
<IconEdit size={16} />
</ActionIcon>
<ActionIcon
variant="light"
color="red"
size="sm"
onClick={() => handleDelete(realisasi.id)}
disabled={loading}
>
<IconTrash size={16} />
</ActionIcon>
</Group>
</TableTd>
</TableTr>
))}
</TableTbody>
</Table>
</Box>
</Box>
) : (
<Center py="xl">
<Stack align="center" gap="xs">
<Text fz="sm" c="dimmed">
Belum ada realisasi untuk item ini
</Text>
<Text fz="xs" c="dimmed">
Klik tombol &quot;Tambah Realisasi&quot; untuk menambahkan
</Text>
</Stack>
</Center>
)}
{/* Modal Create/Edit */}
<Modal
opened={modalOpened}
onClose={() => {
setModalOpened(false);
resetForm();
}}
title={
<Text fz="lg" fw={600}>
{editingId ? 'Edit Realisasi' : 'Tambah Realisasi Baru'}
</Text>
}
size="md"
centered
>
<Stack gap="md">
{/* Info Item */}
<Paper p="sm" bg="gray.0" radius="md">
<Text fz="xs" c="dimmed">
Item: {itemKode} - {itemUraian}
</Text>
<Text fz="xs" c="dimmed">
Anggaran: {formatRupiah(itemAnggaran)}
</Text>
<Text fz="xs" c="dimmed">
Sudah terealisasi: {formatRupiah(itemTotalRealisasi)}
</Text>
</Paper>
<TextInput
label="Kode Realisasi"
placeholder="Contoh: 4.1.1-R1"
value={formData.kode}
onChange={(e) => setFormData({ ...formData, kode: e.target.value })}
description="Kode unik untuk realisasi ini"
required
/>
<NumberInput
label="Jumlah Realisasi (Rp)"
value={formData.jumlah}
onChange={(val) => setFormData({ ...formData, jumlah: Number(val) || 0 })}
leftSection={<IconCoin size={16} />}
thousandSeparator
min={0}
step={100000}
required
/>
<TextInput
label="Tanggal Realisasi"
type="date"
value={formData.tanggal}
onChange={(e) => setFormData({ ...formData, tanggal: e.target.value })}
leftSection={<IconCalendar size={18} />}
required
/>
<TextInput
label="Keterangan / Uraian"
placeholder="Contoh: Penyaluran BLT Tahap 1"
value={formData.keterangan}
onChange={(e) => setFormData({ ...formData, keterangan: e.target.value })}
description="Deskripsi singkat tentang realisasi ini"
/>
<Divider my="xs" />
<Group justify="right">
<Button
variant="outline"
color="gray"
onClick={() => {
setModalOpened(false);
resetForm();
}}
disabled={loading}
>
Batal
</Button>
<Button
onClick={handleSubmit}
loading={loading}
color="blue"
leftSection={editingId ? <IconEdit size={16} /> : <IconPlus size={16} />}
>
{editingId ? 'Perbarui' : 'Tambah'} Realisasi
</Button>
</Group>
</Stack>
</Modal>
</Paper>
);
}

View File

@@ -42,9 +42,11 @@ type ItemForm = {
kode: string;
uraian: string;
anggaran: number;
realisasi: number;
level: number;
tipe: 'pendapatan' | 'belanja' | 'pembiayaan';
realisasi?: number;
selisih?: number;
persentase?: number;
};
function EditAPBDes() {
@@ -53,7 +55,7 @@ function EditAPBDes() {
const params = useParams();
const [isSubmitting, setIsSubmitting] = useState(false);
// Check if form is valid
const isFormValid = () => {
return (
@@ -71,38 +73,78 @@ function EditAPBDes() {
kode: '',
uraian: '',
anggaran: 0,
realisasi: 0,
level: 1,
tipe: 'pendapatan',
realisasi: 0,
selisih: 0,
persentase: 0,
});
// Type for the API response
interface APBDesResponse {
id: string;
image?: {
link: string;
id: string;
};
file?: {
link: string;
id: string;
};
// Add other properties as needed
}
// Simpan data original untuk reset form
const [originalData, setOriginalData] = useState({
tahun: 0,
name: '',
deskripsi: '',
jumlah: '',
imageId: '',
fileId: '',
imageUrl: '',
fileUrl: '',
});
// Load data saat pertama kali
useEffect(() => {
const id = params?.id as string;
if (id) {
apbdesState.edit.load(id).then((response) => {
const data = response as unknown as APBDesResponse;
if (data) {
// ✅ Ambil link langsung dari response
setPreviewImage(data.image?.link || null);
setPreviewDoc(data.file?.link || null);
}
});
}
if (!id) return;
const loadData = async () => {
try {
const data = await apbdesState.edit.load(id);
if (!data) return;
// Set preview dari data lama
setPreviewImage(data.image?.link || null);
setPreviewDoc(data.file?.link || null);
// Simpan data original untuk reset
setOriginalData({
tahun: data.tahun || new Date().getFullYear(),
name: data.name || '',
deskripsi: data.deskripsi || '',
jumlah: data.jumlah || '',
imageId: data.imageId || '',
fileId: data.fileId || '',
imageUrl: data.image?.link || '',
fileUrl: data.file?.link || '',
});
// Set form dengan data lama (termasuk imageId dan fileId)
apbdesState.edit.form = {
tahun: data.tahun || new Date().getFullYear(),
name: data.name || '',
deskripsi: data.deskripsi || '',
jumlah: data.jumlah || '',
imageId: data.imageId || '',
fileId: data.fileId || '',
items: (data.items || []).map((item: any) => ({
kode: item.kode,
uraian: item.uraian,
anggaran: item.anggaran,
realisasi: item.totalRealisasi || 0,
selisih: item.selisih || 0,
persentase: item.persentase || 0,
level: item.level,
tipe: item.tipe || 'pendapatan',
})),
};
} catch (error) {
console.error('Error loading APBDes:', error);
toast.error('Gagal memuat data APBDes');
}
};
loadData();
}, [params?.id]);
const handleDrop = (fileType: 'image' | 'doc') => (files: File[]) => {
@@ -119,34 +161,33 @@ function EditAPBDes() {
};
const handleAddItem = () => {
const { kode, uraian, anggaran, realisasi, level, tipe } = newItem;
const { kode, uraian, anggaran, level, tipe, realisasi, selisih, persentase } = newItem;
if (!kode || !uraian) {
return toast.warn('Kode dan uraian wajib diisi');
}
const finalTipe = level === 1 ? null : tipe;
const selisih = realisasi - anggaran;
const persentase = anggaran > 0 ? (realisasi / anggaran) * 100 : 0;
apbdesState.edit.addItem({
kode,
uraian,
anggaran,
realisasi,
selisih,
persentase,
realisasi: realisasi || 0,
selisih: selisih || 0,
persentase: persentase || 0,
level,
tipe: finalTipe, // ✅ Tidak akan undefined
tipe: finalTipe,
});
setNewItem({
kode: '',
uraian: '',
anggaran: 0,
realisasi: 0,
level: 1,
tipe: 'pendapatan',
realisasi: 0,
selisih: 0,
persentase: 0,
});
};
@@ -162,14 +203,16 @@ function EditAPBDes() {
try {
setIsSubmitting(true);
// Upload file baru jika ada
// Upload file baru jika ada perubahan
if (imageFile) {
const res = await ApiFetch.api.fileStorage.create.post({
file: imageFile,
name: imageFile.name,
});
const imageId = res.data?.data?.id;
if (imageId) apbdesState.edit.form.imageId = imageId;
if (imageId) {
apbdesState.edit.form.imageId = imageId;
}
}
if (docFile) {
@@ -178,9 +221,12 @@ function EditAPBDes() {
name: docFile.name,
});
const fileId = res.data?.data?.id;
if (fileId) apbdesState.edit.form.fileId = fileId;
if (fileId) {
apbdesState.edit.form.fileId = fileId;
}
}
// Image dan file sekarang opsional, tidak perlu validasi
const success = await apbdesState.edit.update();
if (success) {
router.push('/admin/landing-page/apbdes');
@@ -194,21 +240,38 @@ function EditAPBDes() {
};
const handleReset = () => {
const id = params?.id as string;
if (id) {
apbdesState.edit.load(id);
setImageFile(null);
setDocFile(null);
setNewItem({
kode: '',
uraian: '',
anggaran: 0,
realisasi: 0,
level: 1,
tipe: 'pendapatan',
});
toast.info('Form dikembalikan ke data awal');
}
// Reset ke data original (tahun, name, deskripsi, jumlah, imageId, fileId)
apbdesState.edit.form = {
tahun: originalData.tahun,
name: originalData.name,
deskripsi: originalData.deskripsi,
jumlah: originalData.jumlah,
imageId: originalData.imageId,
fileId: originalData.fileId,
items: [...apbdesState.edit.form.items], // keep existing items
};
// Reset preview ke data original
setPreviewImage(originalData.imageUrl || null);
setPreviewDoc(originalData.fileUrl || null);
// Reset file uploads
setImageFile(null);
setDocFile(null);
// Reset new item form
setNewItem({
kode: '',
uraian: '',
anggaran: 0,
level: 1,
tipe: 'pendapatan',
realisasi: 0,
selisih: 0,
persentase: 0,
});
toast.info('Form dikembalikan ke data awal');
};
return (
@@ -232,6 +295,33 @@ function EditAPBDes() {
>
<Stack gap="md">
{/* Header Form */}
<TextInput
label="Nama APBDes"
placeholder="Contoh: APBDes Tahun 2025"
value={apbdesState.edit.form.name}
onChange={(e) =>
(apbdesState.edit.form.name = e.target.value)
}
description="Opsional - akan diisi otomatis jika kosong"
/>
<TextInput
label="Deskripsi"
placeholder="Deskripsi APBDes (opsional)"
value={apbdesState.edit.form.deskripsi}
onChange={(e) =>
(apbdesState.edit.form.deskripsi = e.target.value)
}
description="Opsional"
/>
<TextInput
label="Jumlah Total"
placeholder="Contoh: Rp 1.000.000.000"
value={apbdesState.edit.form.jumlah}
onChange={(e) =>
(apbdesState.edit.form.jumlah = e.target.value)
}
description="Opsional - total keseluruhan anggaran"
/>
<NumberInput
label="Tahun"
value={apbdesState.edit.form.tahun || new Date().getFullYear()}
@@ -243,11 +333,11 @@ function EditAPBDes() {
required
/>
{/* Gambar & Dokumen */}
{/* Gambar & Dokumen (Opsional) */}
<Stack gap="xs">
<Box>
<Text fw="bold" fz="sm" mb={6}>
Gambar APBDes
Gambar APBDes (Opsional)
</Text>
<Dropzone
onDrop={handleDrop('image')}
@@ -287,6 +377,7 @@ function EditAPBDes() {
onClick={() => {
setPreviewImage(null);
setImageFile(null);
apbdesState.edit.form.imageId = ''; // Clear imageId from form
}}
>
<IconX size={14} />
@@ -297,7 +388,7 @@ function EditAPBDes() {
<Box>
<Text fw="bold" fz="sm" mb={6}>
Dokumen APBDes
Dokumen APBDes (Opsional)
</Text>
<Dropzone
onDrop={handleDrop('doc')}
@@ -346,6 +437,7 @@ function EditAPBDes() {
onClick={() => {
setPreviewDoc(null);
setDocFile(null);
apbdesState.edit.form.fileId = ''; // Clear fileId from form
}}
>
<IconX size={14} />
@@ -419,13 +511,6 @@ function EditAPBDes() {
thousandSeparator
min={0}
/>
<NumberInput
label="Realisasi (Rp)"
value={newItem.realisasi}
onChange={(val) => setNewItem({ ...newItem, realisasi: Number(val) || 0 })}
thousandSeparator
min={0}
/>
</Group>
<Button
leftSection={<IconPlus size={16} />}
@@ -450,6 +535,8 @@ function EditAPBDes() {
<th>Uraian</th>
<th>Anggaran</th>
<th>Realisasi</th>
<th>Selisih</th>
<th>%</th>
<th>Level</th>
<th>Tipe</th>
<th style={{ width: '50px' }}>Aksi</th>
@@ -465,7 +552,11 @@ function EditAPBDes() {
</td>
<td>{item.uraian}</td>
<td>{item.anggaran.toLocaleString('id-ID')}</td>
<td>{item.realisasi.toLocaleString('id-ID')}</td>
<td>{item.realisasi?.toLocaleString('id-ID') || '0'}</td>
<td style={{ color: item.selisih && item.selisih > 0 ? 'red' : 'green' }}>
{item.selisih?.toLocaleString('id-ID') || '0'}
</td>
<td>{item.persentase?.toFixed(2) || '0'}%</td>
<td>
<Badge size="sm" color={item.level === 1 ? 'blue' : item.level === 2 ? 'green' : 'grape'}>
L{item.level}
@@ -477,7 +568,7 @@ function EditAPBDes() {
{item.tipe}
</Badge>
) : (
'-'
<Text size="sm" c="dimmed">-</Text>
)}
</td>
<td>

View File

@@ -25,6 +25,7 @@ import { useEffect, useState } from 'react';
import colors from '@/con/colors';
import { ModalKonfirmasiHapus } from '../../../_com/modalKonfirmasiHapus';
import apbdes from '../../../_state/landing-page/apbdes';
import RealisasiManager from './RealisasiManager';
@@ -94,7 +95,7 @@ function DetailAPBDes() {
<Box>
<Text fz="lg" fw="bold">Nama APBDes</Text>
<Text fz="md" c="dimmed">
{data.name || '-'}
{data.name || `APBDes Tahun ${data.tahun}`}
</Text>
</Box>
@@ -105,6 +106,24 @@ function DetailAPBDes() {
</Text>
</Box>
{data.deskripsi && (
<Box>
<Text fz="lg" fw="bold">Deskripsi</Text>
<Text fz="md" c="dimmed">
{data.deskripsi}
</Text>
</Box>
)}
{data.jumlah && (
<Box>
<Text fz="lg" fw="bold">Jumlah Total</Text>
<Text fz="md" c="dimmed">
{data.jumlah}
</Text>
</Box>
)}
<Box>
<Text fz="lg" fw="bold">Gambar</Text>
{data.image?.link ? (
@@ -173,48 +192,60 @@ function DetailAPBDes() {
{/* Tabel Items */}
{data.items && data.items.length > 0 ? (
<Paper withBorder p="md" radius="md">
<Text fz="lg" fw="bold" mb="sm">
<Stack gap="md">
<Text fz="lg" fw="bold">
Rincian Pendapatan & Belanja ({data.items.length} item)
</Text>
<Box style={{ overflowX: 'auto' }}>
<Table striped highlightOnHover>
<TableThead>
<TableTr>
<TableTh>Uraian</TableTh>
<TableTh>Anggaran (Rp)</TableTh>
<TableTh>Realisasi (Rp)</TableTh>
<TableTh>Selisih (Rp)</TableTh>
<TableTh>Persentase (%)</TableTh>
</TableTr>
</TableThead>
<TableTbody>
{[...data.items] // Create a new array before sorting
.sort((a, b) => a.kode.localeCompare(b.kode))
.map((item) => (
<TableTr key={item.id}>
<TableTd style={getIndent(item.level)}>
<Group>
<Text fw={item.level === 1 ? 'bold' : 'normal'}>{item.kode}</Text>
<Text fz="sm" c="dimmed">{item.uraian}</Text>
</Group>
</TableTd>
<TableTd>{item.anggaran.toLocaleString('id-ID')}</TableTd>
<TableTd>{item.realisasi.toLocaleString('id-ID')}</TableTd>
<TableTd>
<Text c={item.selisih >= 0 ? 'green' : 'red'}>
{item.selisih.toLocaleString('id-ID')}
</Text>
</TableTd>
<TableTd>
<Text fw={500}>{item.persentase.toFixed(2)}%</Text>
</TableTd>
</TableTr>
))}
</TableTbody>
</Table>
</Box>
</Paper>
<Table striped highlightOnHover>
<TableThead>
<TableTr>
<TableTh>Uraian</TableTh>
<TableTh>Anggaran (Rp)</TableTh>
<TableTh>Realisasi (Rp)</TableTh>
<TableTh>Selisih (Rp)</TableTh>
<TableTh>Persentase (%)</TableTh>
</TableTr>
</TableThead>
<TableTbody>
{[...data.items]
.sort((a, b) => a.kode.localeCompare(b.kode))
.map((item) => (
<TableTr key={item.id}>
<TableTd style={getIndent(item.level)}>
<Group>
<Text fw={item.level === 1 ? 'bold' : 'normal'}>{item.kode}</Text>
<Text fz="sm" c="dimmed">{item.uraian}</Text>
</Group>
</TableTd>
<TableTd>{item.anggaran.toLocaleString('id-ID')}</TableTd>
<TableTd>{item.totalRealisasi.toLocaleString('id-ID')}</TableTd>
<TableTd>
<Text c={item.selisih >= 0 ? 'green' : 'red'}>
{item.selisih.toLocaleString('id-ID')}
</Text>
</TableTd>
<TableTd>
<Text fw={500}>{item.persentase.toFixed(2)}%</Text>
</TableTd>
</TableTr>
))}
</TableTbody>
</Table>
{/* Realisasi Manager untuk setiap item */}
{data.items.map((item) => (
<RealisasiManager
key={item.id}
itemId={item.id}
itemKode={item.kode}
itemUraian={item.uraian}
itemAnggaran={item.anggaran}
itemTotalRealisasi={item.totalRealisasi}
itemPersentase={item.persentase}
realisasiItems={item.realisasiItems || []}
/>
))}
</Stack>
) : (
<Text>Belum ada data item</Text>
)}

View File

@@ -33,7 +33,6 @@ type ItemForm = {
kode: string;
uraian: string;
anggaran: number;
realisasi: number;
level: number;
tipe: 'pendapatan' | 'belanja' | 'pembiayaan';
};
@@ -47,13 +46,9 @@ function CreateAPBDes() {
const [docFile, setDocFile] = useState<File | null>(null);
const [isSubmitting, setIsSubmitting] = useState(false);
// Check if form is valid
// Check if form is valid - hanya cek items, gambar dan file opsional
const isFormValid = () => {
return (
imageFile !== null &&
docFile !== null &&
stateAPBDes.create.form.items.length > 0
);
return stateAPBDes.create.form.items.length > 0;
};
// Form sementara untuk input item baru
@@ -61,7 +56,6 @@ function CreateAPBDes() {
kode: '',
uraian: '',
anggaran: 0,
realisasi: 0,
level: 1,
tipe: 'pendapatan',
});
@@ -80,35 +74,40 @@ function CreateAPBDes() {
kode: '',
uraian: '',
anggaran: 0,
realisasi: 0,
level: 1,
tipe: 'pendapatan',
});
};
const handleSubmit = async () => {
if (!imageFile || !docFile) {
return toast.warn("Pilih gambar dan dokumen terlebih dahulu");
}
if (stateAPBDes.create.form.items.length === 0) {
return toast.warn("Minimal tambahkan 1 item APBDes");
}
try {
setIsSubmitting(true);
const [uploadImageRes, uploadDocRes] = await Promise.all([
ApiFetch.api.fileStorage.create.post({ file: imageFile, name: imageFile.name }),
ApiFetch.api.fileStorage.create.post({ file: docFile, name: docFile.name }),
]);
const imageId = uploadImageRes?.data?.data?.id;
const fileId = uploadDocRes?.data?.data?.id;
// Upload files hanya jika ada file yang dipilih
let imageId = '';
let fileId = '';
if (!imageId || !fileId) {
return toast.error("Gagal mengupload file");
if (imageFile) {
const uploadImageRes = await ApiFetch.api.fileStorage.create.post({
file: imageFile,
name: imageFile.name,
});
imageId = uploadImageRes?.data?.data?.id || '';
}
// Update form dengan ID file
if (docFile) {
const uploadDocRes = await ApiFetch.api.fileStorage.create.post({
file: docFile,
name: docFile.name,
});
fileId = uploadDocRes?.data?.data?.id || '';
}
// Update form dengan ID file (bisa kosong)
stateAPBDes.create.form.imageId = imageId;
stateAPBDes.create.form.fileId = fileId;
@@ -117,9 +116,9 @@ function CreateAPBDes() {
toast.success("Berhasil menambahkan APBDes");
resetForm();
router.push("/admin/landing-page/apbdes");
} catch (error) {
} catch (error: any) {
console.error("Gagal submit:", error);
toast.error("Gagal menyimpan data");
toast.error(error?.message || "Gagal menyimpan data");
} finally {
setIsSubmitting(false);
}
@@ -127,22 +126,17 @@ function CreateAPBDes() {
// Tambahkan item ke state
const handleAddItem = () => {
const { kode, uraian, anggaran, realisasi, level, tipe } = newItem;
const { kode, uraian, anggaran, level, tipe } = newItem;
if (!kode || !uraian) {
return toast.warn("Kode dan uraian wajib diisi");
}
const finalTipe = level === 1 ? null : tipe;
const selisih = realisasi - anggaran;
const persentase = anggaran > 0 ? (realisasi / anggaran) * 100 : 0;
stateAPBDes.create.addItem({
kode,
uraian,
anggaran,
realisasi,
selisih,
persentase,
level,
tipe: finalTipe,
});
@@ -152,7 +146,6 @@ function CreateAPBDes() {
kode: '',
uraian: '',
anggaran: 0,
realisasi: 0,
level: 1,
tipe: 'pendapatan',
});
@@ -183,12 +176,16 @@ function CreateAPBDes() {
style={{ border: '1px solid #e0e0e0' }}
>
<Stack gap="md">
{/* Gambar & Dokumen (dipendekkan untuk fokus pada items) */}
{/* Info: File opsional */}
<Text fz="sm" c="dimmed" mb="xs">
* Upload gambar dan dokumen bersifat opsional. Bisa dikosongkan jika belum ada.
</Text>
<Stack gap={"xs"}>
{/* Gambar APBDes */}
<Box>
<Text fw="bold" fz="sm" mb={6}>
Gambar APBDes
Gambar APBDes (Opsional)
</Text>
<Dropzone
onDrop={(files) => {
@@ -258,10 +255,10 @@ function CreateAPBDes() {
)}
</Box>
{/* Dokumen APBDes */}
{/* Dokumen APBDes (Opsional) */}
<Box>
<Text fw="bold" fz="sm" mb={6}>
Dokumen APBDes
Dokumen APBDes (Opsional)
</Text>
<Dropzone
onDrop={(files) => {
@@ -334,6 +331,27 @@ function CreateAPBDes() {
</Stack>
{/* Form Header */}
<TextInput
label="Nama APBDes"
placeholder="Contoh: APBDes Tahun 2025"
value={stateAPBDes.create.form.name}
onChange={(e) => (stateAPBDes.create.form.name = e.target.value)}
description="Opsional - akan diisi otomatis jika kosong"
/>
<TextInput
label="Deskripsi"
placeholder="Deskripsi APBDes (opsional)"
value={stateAPBDes.create.form.deskripsi}
onChange={(e) => (stateAPBDes.create.form.deskripsi = e.target.value)}
description="Opsional"
/>
<TextInput
label="Jumlah Total"
placeholder="Contoh: Rp 1.000.000.000"
value={stateAPBDes.create.form.jumlah}
onChange={(e) => (stateAPBDes.create.form.jumlah = e.target.value)}
description="Opsional - total keseluruhan anggaran"
/>
<NumberInput
label="Tahun"
value={stateAPBDes.create.form.tahun || new Date().getFullYear()}
@@ -406,13 +424,6 @@ function CreateAPBDes() {
thousandSeparator
min={0}
/>
<NumberInput
label="Realisasi (Rp)"
value={newItem.realisasi}
onChange={(val) => setNewItem({ ...newItem, realisasi: Number(val) || 0 })}
thousandSeparator
min={0}
/>
</Group>
<Button
leftSection={<IconPlus size={16} />}
@@ -434,28 +445,30 @@ function CreateAPBDes() {
<th>Kode</th>
<th>Uraian</th>
<th>Anggaran</th>
<th>Realisasi</th>
<th>Level</th>
<th>Tipe</th>
<th style={{ width: 50 }}>Aksi</th>
</tr>
</thead>
<tbody>
{stateAPBDes.create.form.items.map((item, idx) => (
{stateAPBDes.create.form.items.map((item: any, idx) => (
<tr key={idx}>
<td><Text size="sm" fw={500}>{item.kode}</Text></td>
<td>{item.uraian}</td>
<td>{item.anggaran.toLocaleString('id-ID')}</td>
<td>{item.realisasi.toLocaleString('id-ID')}</td>
<td>
<Badge size="sm" color={item.level === 1 ? 'blue' : item.level === 2 ? 'green' : 'grape'}>
L{item.level}
</Badge>
</td>
<td>
<Badge size="sm" color={item.tipe === 'pendapatan' ? 'teal' : 'red'}>
{item.tipe}
</Badge>
{item.tipe ? (
<Badge size="sm" color={item.tipe === 'pendapatan' ? 'teal' : 'red'}>
{item.tipe}
</Badge>
) : (
<Text size="sm" c="dimmed">-</Text>
)}
</td>
<td>
<ActionIcon color="red" onClick={() => handleRemoveItem(idx)}>

View File

@@ -45,7 +45,7 @@ function APBDes() {
function ListAPBDes({ search }: { search: string }) {
const listState = useProxy(apbdes);
const router = useRouter();
const [debouncedSearch] = useDebouncedValue(search, 1000);
const [debouncedSearch] = useDebouncedValue(search, 1000);
const { data, page, totalPages, loading, load } = listState.findMany;

View File

@@ -8,6 +8,7 @@ import { IconArrowBack, IconEdit, IconTrash } from '@tabler/icons-react';
import { useParams, useRouter } from 'next/navigation';
import { useState } from 'react';
import { useProxy } from 'valtio/utils';
import DOMPurify from 'dompurify';
function DetailProgramInovasi() {
const stateProgramInovasi = useProxy(profileLandingPageState.programInovasi)
@@ -85,7 +86,7 @@ function DetailProgramInovasi() {
<Box>
<Text fz="lg" fw="bold">Deskripsi</Text>
<Box pl={5}>
<Text fz="md" c="dimmed" style={{ wordBreak: "break-word", whiteSpace: "normal" }} dangerouslySetInnerHTML={{ __html: data.description || '-' }}></Text>
<Text fz="md" c="dimmed" style={{ wordBreak: "break-word", whiteSpace: "normal" }} dangerouslySetInnerHTML={{ __html: DOMPurify.sanitize(data.description || '-') }}></Text>
</Box>
</Box>

View File

@@ -6,6 +6,7 @@ import { IconDeviceImacCog, IconPlus, IconSearch } from '@tabler/icons-react';
import { useRouter } from 'next/navigation';
import { useState } from 'react';
import { useProxy } from 'valtio/utils';
import DOMPurify from 'dompurify';
import HeaderSearch from '../../../_com/header';
import profileLandingPageState from '../../../_state/landing-page/profile';
@@ -90,7 +91,7 @@ function ListProgramInovasi({ search }: { search: string }) {
<Text fw={500}>{item.name}</Text>
</TableTd>
<TableTd style={{ maxWidth: 250 }}>
<Text fz="sm" lineClamp={1} dangerouslySetInnerHTML={{ __html: item.description || '-' }}></Text>
<Text fz="sm" lineClamp={1} dangerouslySetInnerHTML={{ __html: DOMPurify.sanitize(item.description || '-') }}></Text>
</TableTd>
<TableTd style={{ maxWidth: 250 }}>
<Tooltip label="Buka tautan program" position="top" withArrow>
@@ -144,7 +145,7 @@ function ListProgramInovasi({ search }: { search: string }) {
{/* Description */}
<Box>
<Text fz="sm" fw={600} lh={1.4}>Deskripsi</Text>
<Text dangerouslySetInnerHTML={{ __html: item.description || '-' }} fz="sm" c="gray.7" lineClamp={2} />
<Text dangerouslySetInnerHTML={{ __html: DOMPurify.sanitize(item.description || '-') }} fz="sm" c="gray.7" lineClamp={2} />
</Box>
{/* Link */}

View File

@@ -67,6 +67,23 @@ export default function EditDataLingkunganDesa() {
icon: '',
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.name?.trim() !== '' &&
formData.jumlah?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsi) &&
formData.icon?.trim() !== ''
);
};
// Load data saat komponen mount
useEffect(() => {
const loadData = async () => {
@@ -211,8 +228,11 @@ export default function EditDataLingkunganDesa() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -25,6 +25,23 @@ function CreateDataLingkunganDesa() {
const router = useRouter();
const [isSubmitting, setIsSubmitting] = useState(false);
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
stateCreate.create.form.name?.trim() !== '' &&
stateCreate.create.form.icon?.trim() !== '' &&
stateCreate.create.form.jumlah?.trim() !== '' &&
!isHtmlEmpty(stateCreate.create.form.deskripsi)
);
};
const resetForm = () => {
stateCreate.create.form = {
name: '',
@@ -129,8 +146,11 @@ function CreateDataLingkunganDesa() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -38,6 +38,21 @@ export default function EditContohKegiatanDesaDarmasaba() {
deskripsi: '',
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
!isHtmlEmpty(formData.judul) &&
!isHtmlEmpty(formData.deskripsi)
);
};
// load data awal
useShallowEffect(() => {
if (!contohEdukasiState.findById.data) {
@@ -156,8 +171,11 @@ export default function EditContohKegiatanDesaDarmasaba() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -27,6 +27,21 @@ export default function EditMateriEdukasiYangDiberikan() {
content: '',
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
!isHtmlEmpty(formData.judul) &&
!isHtmlEmpty(formData.content)
);
};
// Initialize data kalau belum ada
useShallowEffect(() => {
if (!materiEdukasiState.findById.data) {
@@ -139,8 +154,11 @@ export default function EditMateriEdukasiYangDiberikan() {
onClick={submit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -28,6 +28,21 @@ export default function EditTujuanEdukasiLingkungan() {
deskripsi: '',
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
!isHtmlEmpty(formData.judul) &&
!isHtmlEmpty(formData.deskripsi)
);
};
// Initialize global state
useShallowEffect(() => {
if (!tujuanEdukasiState.findById.data) {
@@ -147,8 +162,11 @@ export default function EditTujuanEdukasiLingkungan() {
onClick={submit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -21,6 +21,11 @@ function EditKategoriKegiatan() {
const [originalData, setOriginalData] = useState({ nama: '' });
const [loading, setLoading] = useState(true);
// Check if form is valid
const isFormValid = () => {
return formData.nama?.trim() !== '';
};
// Load data once
useEffect(() => {
if (!id) return;
@@ -126,8 +131,11 @@ function EditKategoriKegiatan() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -14,6 +14,11 @@ function CreateKategoriKegiatan() {
const stateKategori = useProxy(gotongRoyongState.kategoriKegiatan)
const [isSubmitting, setIsSubmitting] = useState(false);
// Check if form is valid
const isFormValid = () => {
return stateKategori.create.form.nama?.trim() !== '';
};
useEffect(() => {
stateKategori.findMany.load();
}, []);
@@ -84,8 +89,11 @@ function CreateKategoriKegiatan() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -67,6 +67,27 @@ export default function EditKegiatanDesa() {
const [file, setFile] = useState<File | null>(null);
const [previewImage, setPreviewImage] = useState<string | null>(null);
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.judul?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsiSingkat) &&
!isHtmlEmpty(formData.deskripsiLengkap) &&
formData.tanggal?.trim() !== '' &&
formData.lokasi?.trim() !== '' &&
formData.partisipan !== null &&
formData.partisipan >= 0 &&
formData.kategoriKegiatanId?.trim() !== ''
);
};
const formatDateForInput = (dateString: string) => {
if (!dateString) return '';
return new Date(dateString).toISOString().split('T')[0];
@@ -312,8 +333,11 @@ export default function EditKegiatanDesa() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -38,6 +38,28 @@ function CreateKegiatanDesa() {
const [isSubmitting, setIsSubmitting] = useState(false);
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
stateKegiatanDesa.create.form.judul?.trim() !== '' &&
!isHtmlEmpty(stateKegiatanDesa.create.form.deskripsiSingkat) &&
stateKegiatanDesa.create.form.partisipan !== null &&
stateKegiatanDesa.create.form.partisipan >= 0 &&
stateKegiatanDesa.create.form.tanggal !== null &&
stateKegiatanDesa.create.form.lokasi?.trim() !== '' &&
!isHtmlEmpty(stateKegiatanDesa.create.form.deskripsiLengkap) &&
stateKegiatanDesa.create.form.kategoriKegiatanId?.trim() !== '' &&
file !== null
);
};
const resetForm = () => {
stateKegiatanDesa.create.form = {
judul: '',
@@ -273,8 +295,11 @@ function CreateKegiatanDesa() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -27,6 +27,21 @@ function EditBentukKonservasiBerdasarkanAdat() {
deskripsi: '',
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
!isHtmlEmpty(formData.judul) &&
!isHtmlEmpty(formData.deskripsi)
);
};
// Initialize data dari global state
useShallowEffect(() => {
if (!bentukKonservasiState.findById.data) {
@@ -137,8 +152,11 @@ function EditBentukKonservasiBerdasarkanAdat() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -31,6 +31,21 @@ function EditFilosofiTriHitaKarana() {
content: '',
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
!isHtmlEmpty(formData.judul) &&
!isHtmlEmpty(formData.content)
);
};
// Load data dari global state kalau belum ada
useShallowEffect(() => {
if (!filosofiTriHitaState.findById.data) {
@@ -142,8 +157,11 @@ function EditFilosofiTriHitaKarana() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -24,6 +24,21 @@ function EditNilaiKonservasiAdat() {
const [formData, setFormData] = useState({ judul: '', deskripsi: '' });
const [originalData, setOriginalData] = useState({ judul: '', deskripsi: '' });
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
!isHtmlEmpty(formData.judul) &&
!isHtmlEmpty(formData.deskripsi)
);
};
// load data awal
useShallowEffect(() => {
if (!nilaiKonservasiState.findById.data) {
@@ -136,8 +151,11 @@ function EditNilaiKonservasiAdat() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -35,6 +35,16 @@ function EditKeteranganBankSampahTerdekat() {
lng: 0,
});
// Check if form is valid
const isFormValid = () => {
return (
formData.name?.trim() !== '' &&
formData.alamat?.trim() !== '' &&
formData.namaTempatMaps?.trim() !== '' &&
markerPosition !== null
);
};
// Load data ketika component mount
useEffect(() => {
const loadKeterangan = async () => {
@@ -197,8 +207,11 @@ function EditKeteranganBankSampahTerdekat() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -19,6 +19,16 @@ function CreateKeteranganBankSampahTerdekat() {
const [markerPosition, setMarkerPosition] = useState<{ lat: number; lng: number } | null>(null);
const [isSubmitting, setIsSubmitting] = useState(false);
// Check if form is valid
const isFormValid = () => {
return (
keteranganState.create.form.name?.trim() !== '' &&
keteranganState.create.form.alamat?.trim() !== '' &&
keteranganState.create.form.namaTempatMaps?.trim() !== '' &&
markerPosition !== null
);
};
const resetForm = () => {
keteranganState.create.form = {
name: "",
@@ -135,8 +145,11 @@ function CreateKeteranganBankSampahTerdekat() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -34,6 +34,14 @@ function EditProgramKreatifDesa() {
icon: '',
});
// Check if form is valid
const isFormValid = () => {
return (
formData.name?.trim() !== '' &&
formData.icon?.trim() !== ''
);
};
useEffect(() => {
const loadProgramKreatif = async () => {
const id = params?.id as string;
@@ -143,8 +151,11 @@ function EditProgramKreatifDesa() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -13,6 +13,14 @@ function CreatePengelolaanSampahBankSampah() {
const router = useRouter();
const [isSubmitting, setIsSubmitting] = useState(false);
// Check if form is valid
const isFormValid = () => {
return (
stateCreate.create.form.name?.trim() !== '' &&
stateCreate.create.form.icon?.trim() !== ''
);
};
const resetForm = () => {
stateCreate.create.form = {
name: "",
@@ -91,8 +99,11 @@ function CreatePengelolaanSampahBankSampah() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -64,6 +64,23 @@ function EditProgramPenghijauan() {
icon: '',
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.name?.trim() !== '' &&
formData.judul?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsi) &&
formData.icon?.trim() !== ''
);
};
// Load data program penghijauan
useEffect(() => {
const loadProgram = async () => {
@@ -216,8 +233,11 @@ function EditProgramPenghijauan() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -25,6 +25,23 @@ function CreateProgramPenghijauan() {
const router = useRouter();
const [isSubmitting, setIsSubmitting] = useState(false);
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
stateCreate.create.form.name?.trim() !== '' &&
stateCreate.create.form.icon?.trim() !== '' &&
stateCreate.create.form.judul?.trim() !== '' &&
!isHtmlEmpty(stateCreate.create.form.deskripsi)
);
};
const resetForm = () => {
stateCreate.create.form = {
name: '',
@@ -128,8 +145,11 @@ function CreateProgramPenghijauan() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -0,0 +1,428 @@
'use client'
import CreateEditor from '../../../_com/createEditor';
import stateDashboardMusik from '../../../_state/desa/musik';
import colors from '@/con/colors';
import ApiFetch from '@/lib/api-fetch';
import {
Box,
Button,
Card,
Center,
Group,
Image,
Paper,
Stack,
Text,
TextInput,
Title,
Loader,
ActionIcon,
NumberInput
} from '@mantine/core';
import { Dropzone } from '@mantine/dropzone';
import { useShallowEffect } from '@mantine/hooks';
import { IconArrowBack, IconPhoto, IconUpload, IconX, IconMusic } from '@tabler/icons-react';
import { useRouter, useParams } from 'next/navigation';
import { useState } from 'react';
import { toast } from 'react-toastify';
import { useProxy } from 'valtio/utils';
export default function EditMusik() {
const musikState = useProxy(stateDashboardMusik);
const router = useRouter();
const params = useParams();
const id = params.id as string;
const [previewCover, setPreviewCover] = useState<string | null>(null);
const [coverFile, setCoverFile] = useState<File | null>(null);
const [previewAudio, setPreviewAudio] = useState<string | null>(null);
const [audioFile, setAudioFile] = useState<File | null>(null);
const [isExtractingDuration, setIsExtractingDuration] = useState(false);
const [isSubmitting, setIsSubmitting] = useState(false);
const [isLoading, setIsLoading] = useState(true);
// Fungsi untuk mendapatkan durasi dari file audio
const getAudioDuration = (file: File): Promise<string> => {
return new Promise((resolve) => {
const audio = new Audio();
const url = URL.createObjectURL(file);
audio.addEventListener('loadedmetadata', () => {
const duration = audio.duration;
const minutes = Math.floor(duration / 60);
const seconds = Math.floor(duration % 60);
const formatted = `${minutes}:${seconds.toString().padStart(2, '0')}`;
URL.revokeObjectURL(url);
resolve(formatted);
});
audio.addEventListener('error', () => {
URL.revokeObjectURL(url);
resolve('0:00');
});
audio.src = url;
});
};
useShallowEffect(() => {
if (id) {
musikState.musik.edit.load(id).then(() => setIsLoading(false));
}
}, [id]);
const isFormValid = () => {
return (
musikState.musik.edit.form.judul?.trim() !== '' &&
musikState.musik.edit.form.artis?.trim() !== '' &&
musikState.musik.edit.form.durasi?.trim() !== '' &&
(coverFile !== null || musikState.musik.edit.form.coverImageId !== '') &&
(audioFile !== null || musikState.musik.edit.form.audioFileId !== '')
);
};
const resetForm = () => {
musikState.musik.edit.reset();
setPreviewCover(null);
setCoverFile(null);
setPreviewAudio(null);
setAudioFile(null);
};
const handleSubmit = async () => {
if (!musikState.musik.edit.form.judul?.trim()) {
toast.error('Judul wajib diisi');
return;
}
if (!musikState.musik.edit.form.artis?.trim()) {
toast.error('Artis wajib diisi');
return;
}
if (!musikState.musik.edit.form.durasi?.trim()) {
toast.error('Durasi wajib diisi');
return;
}
try {
setIsSubmitting(true);
// Upload cover image if new file selected
if (coverFile) {
const res = await ApiFetch.api.fileStorage.create.post({
file: coverFile,
name: coverFile.name,
});
const uploaded = res.data?.data;
if (!uploaded?.id) {
return toast.error('Gagal mengunggah cover, silakan coba lagi');
}
musikState.musik.edit.form.coverImageId = uploaded.id;
}
// Upload audio file if new file selected
if (audioFile) {
const res = await ApiFetch.api.fileStorage.create.post({
file: audioFile,
name: audioFile.name,
});
const uploaded = res.data?.data;
if (!uploaded?.id) {
return toast.error('Gagal mengunggah audio, silakan coba lagi');
}
musikState.musik.edit.form.audioFileId = uploaded.id;
}
await musikState.musik.edit.update();
resetForm();
router.push('/admin/musik');
} catch (error) {
console.error('Error updating musik:', error);
toast.error('Terjadi kesalahan saat mengupdate musik');
} finally {
setIsSubmitting(false);
}
};
if (isLoading) {
return (
<Box px={{ base: 0, md: 'lg' }} py="xl">
<Center>
<Loader />
</Center>
</Box>
);
}
return (
<Box px={{ base: 0, md: 'lg' }} py="xs">
{/* Header dengan tombol kembali */}
<Group mb="md">
<Button
variant="subtle"
onClick={() => router.back()}
p="xs"
radius="md"
>
<IconArrowBack color={colors['blue-button']} size={24} />
</Button>
<Title order={4} ml="sm" c="dark">
Edit Musik
</Title>
</Group>
<Paper
w={{ base: '100%', md: '50%' }}
bg={colors['white-1']}
p="lg"
radius="md"
shadow="sm"
style={{ border: '1px solid #e0e0e0' }}
>
<Stack gap="md">
<TextInput
label="Judul"
placeholder="Masukkan judul lagu"
value={musikState.musik.edit.form.judul}
onChange={(e) => (musikState.musik.edit.form.judul = e.target.value)}
required
/>
<TextInput
label="Artis"
placeholder="Masukkan nama artis"
value={musikState.musik.edit.form.artis}
onChange={(e) => (musikState.musik.edit.form.artis = e.target.value)}
required
/>
<Box>
<Text fz="sm" fw="bold" mb={6}>
Deskripsi
</Text>
<CreateEditor
value={musikState.musik.edit.form.deskripsi}
onChange={(htmlContent) => {
musikState.musik.edit.form.deskripsi = htmlContent;
}}
/>
</Box>
<Group gap="md">
<TextInput
label="Durasi"
placeholder="Contoh: 3:45"
value={musikState.musik.edit.form.durasi}
onChange={(e) => (musikState.musik.edit.form.durasi = e.target.value)}
required
style={{ flex: 1 }}
/>
<TextInput
label="Genre"
placeholder="Contoh: Pop, Rock, Jazz"
value={musikState.musik.edit.form.genre}
onChange={(e) => (musikState.musik.edit.form.genre = e.target.value)}
style={{ flex: 1 }}
/>
</Group>
<NumberInput
label="Tahun Rilis"
placeholder="Contoh: 2024"
value={musikState.musik.edit.form.tahunRilis}
onChange={(val) => (musikState.musik.edit.form.tahunRilis = val as number | undefined)}
min={1900}
max={new Date().getFullYear() + 1}
/>
{/* Cover Image */}
<Box>
<Text fw="bold" fz="sm" mb={6}>
Cover Image
</Text>
<Dropzone
onDrop={(files) => {
const selectedFile = files[0];
if (selectedFile) {
setCoverFile(selectedFile);
setPreviewCover(URL.createObjectURL(selectedFile));
}
}}
onReject={() => toast.error('File tidak valid, gunakan format gambar')}
maxSize={5 * 1024 ** 2}
accept={{ 'image/*': ['.jpeg', '.jpg', '.png', '.webp'] }}
radius="md"
p="xl"
>
<Group justify="center" gap="xl" mih={180}>
<Dropzone.Accept>
<IconUpload size={48} color="var(--mantine-color-blue-6)" stroke={1.5} />
</Dropzone.Accept>
<Dropzone.Reject>
<IconX size={48} color="var(--mantine-color-red-6)" stroke={1.5} />
</Dropzone.Reject>
<Dropzone.Idle>
<IconPhoto size={48} color="var(--mantine-color-dimmed)" stroke={1.5} />
</Dropzone.Idle>
</Group>
<Text ta="center" mt="sm" size="sm" color="dimmed">
Seret gambar atau klik untuk memilih file (maks 5MB)
</Text>
</Dropzone>
{(previewCover || musikState.musik.edit.form.coverImageId) && (
<Box mt="sm" pos="relative" style={{ textAlign: 'center' }}>
<Image
src={previewCover || '/api/placeholder/200/200'}
alt="Preview Cover"
radius="md"
style={{
maxHeight: 200,
objectFit: 'contain',
border: '1px solid #ddd',
}}
loading="lazy"
/>
<ActionIcon
variant="filled"
color="red"
radius="xl"
size="sm"
pos="absolute"
top={5}
right={5}
onClick={() => {
setPreviewCover(null);
setCoverFile(null);
musikState.musik.edit.form.coverImageId = '';
}}
style={{
boxShadow: '0 2px 6px rgba(0,0,0,0.15)',
}}
>
<IconX size={14} />
</ActionIcon>
</Box>
)}
</Box>
{/* Audio File */}
<Box>
<Text fw="bold" fz="sm" mb={6}>
File Audio
</Text>
<Dropzone
onDrop={async (files) => {
const selectedFile = files[0];
if (selectedFile) {
setAudioFile(selectedFile);
setPreviewAudio(selectedFile.name);
// Extract durasi otomatis dari audio
setIsExtractingDuration(true);
try {
const duration = await getAudioDuration(selectedFile);
musikState.musik.edit.form.durasi = duration;
toast.success(`Durasi audio terdeteksi: ${duration}`);
} catch (error) {
console.error('Error extracting audio duration:', error);
toast.error('Gagal mendeteksi durasi audio, silakan isi manual');
} finally {
setIsExtractingDuration(false);
}
}
}}
onReject={() => toast.error('File tidak valid, gunakan format audio (MP3, WAV, OGG)')}
maxSize={50 * 1024 ** 2}
accept={{ 'audio/*': ['.mp3', '.wav', '.ogg', '.m4a'] }}
radius="md"
p="xl"
>
<Group justify="center" gap="xl" mih={180}>
<Dropzone.Accept>
<IconUpload size={48} color="var(--mantine-color-blue-6)" stroke={1.5} />
</Dropzone.Accept>
<Dropzone.Reject>
<IconX size={48} color="var(--mantine-color-red-6)" stroke={1.5} />
</Dropzone.Reject>
<Dropzone.Idle>
<IconMusic size={48} color="var(--mantine-color-dimmed)" stroke={1.5} />
</Dropzone.Idle>
</Group>
<Text ta="center" mt="sm" size="sm" color="dimmed">
Seret file audio atau klik untuk memilih file (maks 50MB)
</Text>
</Dropzone>
{(previewAudio || musikState.musik.edit.form.audioFileId) && (
<Box mt="sm">
<Card p="sm" withBorder>
<Group gap="sm">
<IconMusic size={20} color={colors['blue-button']} />
<Text fz="sm" truncate style={{ flex: 1 }}>
{previewAudio || 'File audio tersimpan'}
</Text>
{isExtractingDuration && (
<Text fz="xs" c="blue">
Mendeteksi durasi...
</Text>
)}
<ActionIcon
variant="filled"
color="red"
radius="xl"
size="sm"
onClick={() => {
setPreviewAudio(null);
setAudioFile(null);
musikState.musik.edit.form.audioFileId = '';
}}
>
<IconX size={14} />
</ActionIcon>
</Group>
</Card>
</Box>
)}
</Box>
<Group justify="right">
<Button
variant="outline"
color="gray"
radius="md"
size="md"
onClick={resetForm}
>
Reset
</Button>
<Button
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}
>
{isSubmitting ? <Loader size="sm" color="white" /> : 'Update'}
</Button>
</Group>
</Stack>
</Paper>
</Box>
);
}

View File

@@ -0,0 +1,271 @@
'use client'
import colors from '@/con/colors';
import {
Box,
Button,
Card,
Center,
Group,
Image,
Modal,
Paper,
Skeleton,
Stack,
Text,
Title
} from '@mantine/core';
import { useShallowEffect } from '@mantine/hooks';
import { IconArrowBack, IconEdit, IconTrash } from '@tabler/icons-react';
import { useParams, useRouter } from 'next/navigation';
import { useState } from 'react';
import { useProxy } from 'valtio/utils';
import stateDashboardMusik from '../../_state/desa/musik';
export default function DetailMusik() {
const musikState = useProxy(stateDashboardMusik);
const router = useRouter();
const params = useParams();
const id = params.id as string;
const [showDeleteModal, setShowDeleteModal] = useState(false);
const [isDeleting, setIsDeleting] = useState(false);
const { data, loading, load } = musikState.musik.findUnique;
useShallowEffect(() => {
if (id) {
load(id);
}
}, [id]);
if (loading || !data) {
return (
<Box px={{ base: 0, md: 'lg' }} py="xs">
<Stack>
<Skeleton height={50} radius="md" />
<Skeleton height={400} radius="md" />
</Stack>
</Box>
);
}
if (!data) {
return (
<Box px={{ base: 0, md: 'lg' }} py="xl">
<Center>
<Text c="dimmed">Musik tidak ditemukan</Text>
</Center>
</Box>
);
}
const handleDelete = async () => {
try {
setIsDeleting(true);
await musikState.musik.delete.byId(id);
setShowDeleteModal(false);
router.push('/admin/musik');
} catch (error) {
console.error('Error deleting musik:', error);
} finally {
setIsDeleting(false);
}
};
return (
<Box px={{ base: 0, md: 'lg' }} py="xs">
{/* Header dengan tombol kembali */}
<Group mb="md">
<Button
variant="subtle"
onClick={() => router.push('/admin/musik')}
p="xs"
radius="md"
>
<IconArrowBack color={colors['blue-button']} size={24} />
</Button>
<Title order={4} ml="sm" c="dark">
Detail Musik
</Title>
</Group>
<Paper
w={{ base: '100%', md: '50%' }}
bg={colors['white-1']}
p="lg"
radius="md"
shadow="sm"
style={{ border: '1px solid #e0e0e0' }}
>
<Stack gap="md">
{/* Cover Image */}
{data.coverImage && (
<Box
style={{
width: '100%',
maxWidth: 400,
margin: '0 auto',
}}
>
<Image
src={data.coverImage.link}
alt={data.judul}
radius="md"
style={{
width: '100%',
aspectRatio: '1/1',
objectFit: 'cover',
display: 'block',
}}
/>
</Box>
)}
{/* Info Section */}
<Stack gap="sm">
<Box>
<Text fz="sm" fw={600} c="dimmed">
Judul
</Text>
<Text fz="md" fw={600}>
{data.judul}
</Text>
</Box>
<Box>
<Text fz="sm" fw={600} c="dimmed">
Artis
</Text>
<Text fz="md" fw={500}>
{data.artis}
</Text>
</Box>
{data.deskripsi && (
<Box>
<Text fz="sm" fw={600} c="dimmed">
Deskripsi
</Text>
<Text fz="sm" fw={500} dangerouslySetInnerHTML={{ __html: data.deskripsi }} />
</Box>
)}
<Group gap="xl">
<Box>
<Text fz="sm" fw={600} c="dimmed">
Durasi
</Text>
<Text fz="md" fw={500}>
{data.durasi}
</Text>
</Box>
{data.genre && (
<Box>
<Text fz="sm" fw={600} c="dimmed">
Genre
</Text>
<Text fz="md" fw={500}>
{data.genre}
</Text>
</Box>
)}
{data.tahunRilis && (
<Box>
<Text fz="sm" fw={600} c="dimmed">
Tahun Rilis
</Text>
<Text fz="md" fw={500}>
{data.tahunRilis}
</Text>
</Box>
)}
</Group>
{/* Audio File */}
{data.audioFile && (
<Box>
<Text fz="sm" fw={600} c="dimmed">
File Audio
</Text>
<Card mt="xs" p="sm" withBorder>
<Group gap="sm">
<Text fz="sm" truncate style={{ flex: 1 }}>
{data.audioFile.realName}
</Text>
<Button
component="a"
href={data.audioFile.link}
target="_blank"
variant="light"
size="sm"
>
Putar
</Button>
</Group>
</Card>
</Box>
)}
</Stack>
{/* Action Buttons */}
<Group justify="right" mt="md">
<Button
variant="outline"
color="red"
radius="md"
size="md"
leftSection={<IconTrash size={18} />}
onClick={() => setShowDeleteModal(true)}
>
Hapus
</Button>
<Button
variant="filled"
color="blue"
radius="md"
size="md"
leftSection={<IconEdit size={18} />}
onClick={() => router.push(`/admin/musik/${id}/edit`)}
>
Edit
</Button>
</Group>
</Stack>
</Paper>
{/* Delete Confirmation Modal */}
<Modal
opened={showDeleteModal}
onClose={() => setShowDeleteModal(false)}
title="Konfirmasi Hapus"
centered
>
<Stack gap="md">
<Text>
Apakah Anda yakin ingin menghapus musik &quot;{data.judul}&quot;?
</Text>
<Text c="red" fz="sm">
Tindakan ini tidak dapat dibatalkan.
</Text>
<Group justify="right" mt="md">
<Button
variant="outline"
color="gray"
onClick={() => setShowDeleteModal(false)}
>
Batal
</Button>
<Button
color="red"
onClick={handleDelete}
loading={isDeleting}
>
Hapus
</Button>
</Group>
</Stack>
</Modal>
</Box>
);
}

View File

@@ -0,0 +1,426 @@
'use client'
import CreateEditor from '../../_com/createEditor';
import stateDashboardMusik from '../../_state/desa/musik';
import colors from '@/con/colors';
import ApiFetch from '@/lib/api-fetch';
import {
Box,
Button,
Card,
Group,
Image,
Paper,
Stack,
Text,
TextInput,
Title,
Loader,
ActionIcon,
NumberInput
} from '@mantine/core';
import { Dropzone } from '@mantine/dropzone';
import { useShallowEffect } from '@mantine/hooks';
import { IconArrowBack, IconPhoto, IconUpload, IconX, IconMusic } from '@tabler/icons-react';
import { useRouter } from 'next/navigation';
import { useState } from 'react';
import { toast } from 'react-toastify';
import { useProxy } from 'valtio/utils';
export default function CreateMusik() {
const musikState = useProxy(stateDashboardMusik);
const [previewCover, setPreviewCover] = useState<string | null>(null);
const [coverFile, setCoverFile] = useState<File | null>(null);
const [previewAudio, setPreviewAudio] = useState<string | null>(null);
const [audioFile, setAudioFile] = useState<File | null>(null);
const [isExtractingDuration, setIsExtractingDuration] = useState(false);
const router = useRouter();
const [isSubmitting, setIsSubmitting] = useState(false);
// Fungsi untuk mendapatkan durasi dari file audio
const getAudioDuration = (file: File): Promise<string> => {
return new Promise((resolve) => {
const audio = new Audio();
const url = URL.createObjectURL(file);
audio.addEventListener('loadedmetadata', () => {
const duration = audio.duration;
const minutes = Math.floor(duration / 60);
const seconds = Math.floor(duration % 60);
const formatted = `${minutes}:${seconds.toString().padStart(2, '0')}`;
URL.revokeObjectURL(url);
resolve(formatted);
});
audio.addEventListener('error', () => {
URL.revokeObjectURL(url);
resolve('0:00');
});
audio.src = url;
});
};
const isFormValid = () => {
return (
musikState.musik.create.form.judul?.trim() !== '' &&
musikState.musik.create.form.artis?.trim() !== '' &&
musikState.musik.create.form.durasi?.trim() !== '' &&
audioFile !== null &&
coverFile !== null
);
};
useShallowEffect(() => {
return () => {
musikState.musik.create.resetForm();
};
}, []);
const resetForm = () => {
musikState.musik.create.form = {
judul: '',
artis: '',
deskripsi: '',
durasi: '',
audioFileId: '',
coverImageId: '',
genre: '',
tahunRilis: undefined,
};
setPreviewCover(null);
setCoverFile(null);
setPreviewAudio(null);
setAudioFile(null);
};
const handleSubmit = async () => {
if (!musikState.musik.create.form.judul?.trim()) {
toast.error('Judul wajib diisi');
return;
}
if (!musikState.musik.create.form.artis?.trim()) {
toast.error('Artis wajib diisi');
return;
}
if (!musikState.musik.create.form.durasi?.trim()) {
toast.error('Durasi wajib diisi');
return;
}
if (!coverFile) {
toast.error('Cover image wajib dipilih');
return;
}
if (!audioFile) {
toast.error('File audio wajib dipilih');
return;
}
try {
setIsSubmitting(true);
// Upload cover image
const coverRes = await ApiFetch.api.fileStorage.create.post({
file: coverFile,
name: coverFile.name,
});
const coverUploaded = coverRes.data?.data;
if (!coverUploaded?.id) {
return toast.error('Gagal mengunggah cover, silakan coba lagi');
}
musikState.musik.create.form.coverImageId = coverUploaded.id;
// Upload audio file
const audioRes = await ApiFetch.api.fileStorage.create.post({
file: audioFile,
name: audioFile.name,
});
const audioUploaded = audioRes.data?.data;
if (!audioUploaded?.id) {
return toast.error('Gagal mengunggah audio, silakan coba lagi');
}
musikState.musik.create.form.audioFileId = audioUploaded.id;
await musikState.musik.create.create();
resetForm();
router.push('/admin/musik');
} catch (error) {
console.error('Error creating musik:', error);
toast.error('Terjadi kesalahan saat membuat musik');
} finally {
setIsSubmitting(false);
}
};
return (
<Box px={{ base: 0, md: 'lg' }} py="xs">
{/* Header dengan tombol kembali */}
<Group mb="md">
<Button
variant="subtle"
onClick={() => router.back()}
p="xs"
radius="md"
>
<IconArrowBack color={colors['blue-button']} size={24} />
</Button>
<Title order={4} ml="sm" c="dark">
Tambah Musik
</Title>
</Group>
<Paper
w={{ base: '100%', md: '50%' }}
bg={colors['white-1']}
p="lg"
radius="md"
shadow="sm"
style={{ border: '1px solid #e0e0e0' }}
>
<Stack gap="md">
<TextInput
label="Judul"
placeholder="Masukkan judul lagu"
value={musikState.musik.create.form.judul}
onChange={(e) => (musikState.musik.create.form.judul = e.target.value)}
required
/>
<TextInput
label="Artis"
placeholder="Masukkan nama artis"
value={musikState.musik.create.form.artis}
onChange={(e) => (musikState.musik.create.form.artis = e.target.value)}
required
/>
<Box>
<Text fz="sm" fw="bold" mb={6}>
Deskripsi
</Text>
<CreateEditor
value={musikState.musik.create.form.deskripsi}
onChange={(htmlContent) => {
musikState.musik.create.form.deskripsi = htmlContent;
}}
/>
</Box>
<Group gap="md">
<TextInput
label="Durasi"
placeholder="Contoh: 3:45"
value={musikState.musik.create.form.durasi}
onChange={(e) => (musikState.musik.create.form.durasi = e.target.value)}
required
style={{ flex: 1 }}
/>
<TextInput
label="Genre"
placeholder="Contoh: Pop, Rock, Jazz"
value={musikState.musik.create.form.genre}
onChange={(e) => (musikState.musik.create.form.genre = e.target.value)}
style={{ flex: 1 }}
/>
</Group>
<NumberInput
label="Tahun Rilis"
placeholder="Contoh: 2024"
value={musikState.musik.create.form.tahunRilis}
onChange={(val) => (musikState.musik.create.form.tahunRilis = val as number | undefined)}
min={1900}
max={new Date().getFullYear() + 1}
/>
{/* Cover Image */}
<Box>
<Text fw="bold" fz="sm" mb={6}>
Cover Image
</Text>
<Dropzone
onDrop={(files) => {
const selectedFile = files[0];
if (selectedFile) {
setCoverFile(selectedFile);
setPreviewCover(URL.createObjectURL(selectedFile));
}
}}
onReject={() => toast.error('File tidak valid, gunakan format gambar')}
maxSize={5 * 1024 ** 2}
accept={{ 'image/*': ['.jpeg', '.jpg', '.png', '.webp'] }}
radius="md"
p="xl"
>
<Group justify="center" gap="xl" mih={180}>
<Dropzone.Accept>
<IconUpload size={48} color="var(--mantine-color-blue-6)" stroke={1.5} />
</Dropzone.Accept>
<Dropzone.Reject>
<IconX size={48} color="var(--mantine-color-red-6)" stroke={1.5} />
</Dropzone.Reject>
<Dropzone.Idle>
<IconPhoto size={48} color="var(--mantine-color-dimmed)" stroke={1.5} />
</Dropzone.Idle>
</Group>
<Text ta="center" mt="sm" size="sm" color="dimmed">
Seret gambar atau klik untuk memilih file (maks 5MB)
</Text>
</Dropzone>
{previewCover && (
<Box mt="sm" pos="relative" style={{ textAlign: 'center' }}>
<Image
src={previewCover}
alt="Preview Cover"
radius="md"
style={{
maxHeight: 200,
objectFit: 'contain',
border: '1px solid #ddd',
}}
loading="lazy"
/>
<ActionIcon
variant="filled"
color="red"
radius="xl"
size="sm"
pos="absolute"
top={5}
right={5}
onClick={() => {
setPreviewCover(null);
setCoverFile(null);
}}
style={{
boxShadow: '0 2px 6px rgba(0,0,0,0.15)',
}}
>
<IconX size={14} />
</ActionIcon>
</Box>
)}
</Box>
{/* Audio File */}
<Box>
<Text fw="bold" fz="sm" mb={6}>
File Audio
</Text>
<Dropzone
onDrop={async (files) => {
const selectedFile = files[0];
if (selectedFile) {
setAudioFile(selectedFile);
setPreviewAudio(selectedFile.name);
// Extract durasi otomatis dari audio
setIsExtractingDuration(true);
try {
const duration = await getAudioDuration(selectedFile);
musikState.musik.create.form.durasi = duration;
toast.success(`Durasi audio terdeteksi: ${duration}`);
} catch (error) {
console.error('Error extracting audio duration:', error);
toast.error('Gagal mendeteksi durasi audio, silakan isi manual');
} finally {
setIsExtractingDuration(false);
}
}
}}
onReject={() => toast.error('File tidak valid, gunakan format audio (MP3, WAV, OGG)')}
maxSize={50 * 1024 ** 2}
accept={{ 'audio/*': ['.mp3', '.wav', '.ogg', '.m4a'] }}
radius="md"
p="xl"
>
<Group justify="center" gap="xl" mih={180}>
<Dropzone.Accept>
<IconUpload size={48} color="var(--mantine-color-blue-6)" stroke={1.5} />
</Dropzone.Accept>
<Dropzone.Reject>
<IconX size={48} color="var(--mantine-color-red-6)" stroke={1.5} />
</Dropzone.Reject>
<Dropzone.Idle>
<IconMusic size={48} color="var(--mantine-color-dimmed)" stroke={1.5} />
</Dropzone.Idle>
</Group>
<Text ta="center" mt="sm" size="sm" color="dimmed">
Seret file audio atau klik untuk memilih file (maks 50MB)
</Text>
</Dropzone>
{previewAudio && (
<Box mt="sm">
<Card p="sm" withBorder>
<Group gap="sm">
<IconMusic size={20} color={colors['blue-button']} />
<Text fz="sm" truncate style={{ flex: 1 }}>
{previewAudio}
</Text>
{isExtractingDuration && (
<Text fz="xs" c="blue">
Mendeteksi durasi...
</Text>
)}
<ActionIcon
variant="filled"
color="red"
radius="xl"
size="sm"
onClick={() => {
setPreviewAudio(null);
setAudioFile(null);
}}
>
<IconX size={14} />
</ActionIcon>
</Group>
</Card>
</Box>
)}
</Box>
<Group justify="right">
<Button
variant="outline"
color="gray"
radius="md"
size="md"
onClick={resetForm}
>
Reset
</Button>
<Button
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}
>
{isSubmitting ? <Loader size="sm" color="white" /> : 'Simpan'}
</Button>
</Group>
</Stack>
</Paper>
</Box>
);
}

View File

@@ -0,0 +1,231 @@
'use client'
import colors from '@/con/colors';
import {
Box,
Button,
Center,
Group,
Pagination,
Paper,
Skeleton,
Stack,
Table,
TableTbody,
TableTd,
TableTh,
TableThead,
TableTr,
Text,
Title
} from '@mantine/core';
import { useDebouncedValue, useShallowEffect } from '@mantine/hooks';
import { IconCircleDashedPlus, IconDeviceImacCog, IconSearch } from '@tabler/icons-react';
import { useRouter } from 'next/navigation';
import { useState } from 'react';
import { useProxy } from 'valtio/utils';
import HeaderSearch from '../_com/header';
import stateDashboardMusik from '../_state/desa/musik';
function Musik() {
const [search, setSearch] = useState("");
return (
<Box>
<HeaderSearch
title="Musik Desa"
placeholder="Cari judul, artis, atau genre..."
searchIcon={<IconSearch size={20} />}
value={search}
onChange={(e) => setSearch(e.currentTarget.value)}
/>
<ListMusik search={search} />
</Box>
);
}
function ListMusik({ search }: { search: string }) {
const musikState = useProxy(stateDashboardMusik);
const router = useRouter();
const [debouncedSearch] = useDebouncedValue(search, 1000);
const { data, page, totalPages, loading, load } = musikState.musik.findMany;
useShallowEffect(() => {
load(page, 10, debouncedSearch);
}, [page, debouncedSearch]);
if (loading || !data) {
return (
<Stack py="md">
<Skeleton height={600} radius="md" />
</Stack>
);
}
const filteredData = data || [];
return (
<Box py="md">
<Paper withBorder bg={colors['white-1']} p="lg" shadow="md" radius="md">
<Group justify="space-between" mb="md">
<Title order={4}>Daftar Musik</Title>
<Button
leftSection={<IconCircleDashedPlus size={18} />}
color="blue"
variant="light"
onClick={() => router.push('/admin/musik/create')}
>
Tambah Baru
</Button>
</Group>
{/* Desktop Table */}
<Box visibleFrom="md" style={{ overflowX: 'auto' }}>
<Table highlightOnHover
layout="fixed"
withColumnBorders={false} miw={0}>
<TableThead>
<TableTr>
<TableTh w="30%">Judul</TableTh>
<TableTh w="20%">Artis</TableTh>
<TableTh w="15%">Durasi</TableTh>
<TableTh w="15%">Genre</TableTh>
<TableTh w="20%">Aksi</TableTh>
</TableTr>
</TableThead>
<TableTbody>
{filteredData.length > 0 ? (
filteredData.map((item) => (
<TableTr key={item.id}>
<TableTd>
<Text fz="md" fw={600} lh={1.45} truncate="end">
{item.judul}
</Text>
</TableTd>
<TableTd>
<Text fz="sm" c="dimmed" lh={1.45}>
{item.artis}
</Text>
</TableTd>
<TableTd>
<Text fz="sm" c="dimmed" lh={1.45}>
{item.durasi}
</Text>
</TableTd>
<TableTd>
<Text fz="sm" c="dimmed" lh={1.45}>
{item.genre || '-'}
</Text>
</TableTd>
<TableTd>
<Button
variant="light"
color="blue"
onClick={() =>
router.push(`/admin/musik/${item.id}`)
}
fz="sm"
px="sm"
h={36}
>
<IconDeviceImacCog size={18} />
<Text ml="xs">Detail</Text>
</Button>
</TableTd>
</TableTr>
))
) : (
<TableTr>
<TableTd colSpan={5}>
<Center py="xl">
<Text c="dimmed" fz="sm" lh={1.4}>
Tidak ada data musik yang cocok
</Text>
</Center>
</TableTd>
</TableTr>
)}
</TableTbody>
</Table>
</Box>
{/* Mobile Cards */}
<Stack hiddenFrom="md" gap="sm" mt="sm">
{filteredData.length > 0 ? (
filteredData.map((item) => (
<Paper key={item.id} withBorder p="md" radius="md">
<Stack gap={"xs"}>
<Text fz="sm" fw={600} lh={1.4} c="dimmed">
Judul
</Text>
<Text fz="sm" fw={500} lh={1.45}>
{item.judul}
</Text>
<Text fz="sm" fw={600} lh={1.4} c="dimmed" mt="xs">
Artis
</Text>
<Text fz="sm" lh={1.45} fw={500}>
{item.artis}
</Text>
<Text fz="sm" fw={600} lh={1.4} c="dimmed" mt="xs">
Durasi
</Text>
<Text fz="sm" lh={1.45} fw={500}>
{item.durasi}
</Text>
<Text fz="sm" fw={600} lh={1.4} c="dimmed" mt="xs">
Genre
</Text>
<Text fz="sm" lh={1.45} fw={500}>
{item.genre || '-'}
</Text>
<Button
variant="light"
color="blue"
fullWidth
mt="sm"
onClick={() =>
router.push(`/admin/musik/${item.id}`)
}
fz="sm"
h={36}
>
<IconDeviceImacCog size={18} />
<Text ml="xs">Detail</Text>
</Button>
</Stack>
</Paper>
))
) : (
<Center py="xl">
<Text c="dimmed" fz="sm" lh={1.4}>
Tidak ada data musik yang cocok
</Text>
</Center>
)}
</Stack>
</Paper>
<Center>
<Pagination
value={page}
onChange={(newPage) => {
load(newPage, 10, debouncedSearch);
window.scrollTo({ top: 0, behavior: 'smooth' });
}}
total={totalPages}
mt="md"
mb="md"
color="blue"
radius="md"
/>
</Center>
</Box>
);
}
export default Musik;

View File

@@ -24,6 +24,21 @@ function EditProgramKreatifDesa() {
deskripsi: '',
})
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.judul?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsi)
);
};
useEffect(() => {
const loadProgramKreatif = async () => {
const id = params?.id as string;
@@ -160,8 +175,11 @@ function EditProgramKreatifDesa() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -16,6 +16,21 @@ function CreateKeunggulanProgram() {
const router = useRouter();
const [isSubmitting, setIsSubmitting] = useState(false);
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
stateCreate.create.form.judul?.trim() !== '' &&
!isHtmlEmpty(stateCreate.create.form.deskripsi)
);
};
const resetForm = () => {
stateCreate.create.form = {
judul: "",
@@ -97,8 +112,11 @@ function CreateKeunggulanProgram() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -42,6 +42,21 @@ function EditFasilitasYangDisediakan() {
deskripsi: '',
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.judul?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsi)
);
};
// Load data pertama kali
useShallowEffect(() => {
if (!editState.findById.data) {
@@ -76,11 +91,6 @@ function EditFasilitasYangDisediakan() {
};
const handleSubmit = async () => {
if (!formData.judul.trim()) {
toast.error('Judul wajib diisi');
return;
}
setIsSubmitting(true);
try {
if (editState.findById.data) {
@@ -180,8 +190,11 @@ function EditFasilitasYangDisediakan() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -39,6 +39,21 @@ function EditLokasiDanJadwal() {
const [isSubmitting, setIsSubmitting] = useState(false);
const [originalData, setOriginalData] = useState({ judul: '', deskripsi: '' });
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.judul?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsi)
);
};
// Load data sekali
useShallowEffect(() => {
if (!editState.findById.data) {
@@ -73,11 +88,6 @@ function EditLokasiDanJadwal() {
};
const handleSubmit = async () => {
if (!formData.judul.trim()) {
toast.error('Judul wajib diisi');
return;
}
setIsSubmitting(true);
try {
if (editState.findById.data) {
@@ -178,8 +188,11 @@ function EditLokasiDanJadwal() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -39,6 +39,21 @@ function EditTujuanProgram() {
const [isSubmitting, setIsSubmitting] = useState(false);
const [originalData, setOriginalData] = useState({ judul: '', deskripsi: '' });
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.judul?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsi)
);
};
// load data sekali
useShallowEffect(() => {
if (!editState.findById.data) editState.findById.initialize();
@@ -71,11 +86,6 @@ function EditTujuanProgram() {
};
const handleSubmit = async () => {
if (!formData.judul.trim()) {
toast.error('Judul wajib diisi');
return;
}
setIsSubmitting(true);
try {
if (editState.findById.data) {
@@ -170,8 +180,11 @@ function EditTujuanProgram() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -28,6 +28,14 @@ export default function EditDataPendidikan() {
jumlah: '',
});
// Check if form is valid
const isFormValid = () => {
return (
formData.name?.trim() !== '' &&
formData.jumlah?.trim() !== ''
);
};
// Load data saat mount
useEffect(() => {
if (id) {
@@ -127,8 +135,11 @@ export default function EditDataPendidikan() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -15,6 +15,14 @@ export default function CreateDataPendidikan() {
const router = useRouter();
const [isSubmitting, setIsSubmitting] = useState(false);
// Check if form is valid
const isFormValid = () => {
return (
stateDPM.create.form.name?.trim() !== '' &&
stateDPM.create.form.jumlah?.trim() !== ''
);
};
const resetForm = () => {
stateDPM.create.form = { name: '', jumlah: '' };
};
@@ -90,8 +98,11 @@ export default function CreateDataPendidikan() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -31,6 +31,11 @@ function EditJenjangPendidikan() {
const [isSubmitting, setIsSubmitting] = useState(false);
const [loading, setLoading] = useState(true);
// Check if form is valid
const isFormValid = () => {
return formData.nama?.trim() !== '';
};
// Load data sekali saat component mount
useEffect(() => {
if (!id) return;
@@ -136,8 +141,11 @@ function EditJenjangPendidikan() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -23,6 +23,11 @@ function CreateJenjangPendidikan() {
const stateJenjang = useProxy(infoSekolahPaud.jenjangPendidikan);
const [isSubmitting, setIsSubmitting] = useState(false);
// Check if form is valid
const isFormValid = () => {
return stateJenjang.create.form.nama?.trim() !== '';
};
useEffect(() => {
stateJenjang.findMany.load();
}, []);
@@ -101,8 +106,11 @@ function CreateJenjangPendidikan() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -37,6 +37,14 @@ export default function EditLembaga() {
jenjangId: '',
});
// Check if form is valid
const isFormValid = () => {
return (
form.nama?.trim() !== '' &&
form.jenjangId?.trim() !== ''
);
};
// Load jenjang pendidikan dan data lembaga
useEffect(() => {
infoSekolahPaud.jenjangPendidikan.findMany.load();
@@ -161,8 +169,11 @@ export default function EditLembaga() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -25,6 +25,14 @@ function CreateLembaga() {
const stateLembaga = useProxy(infoSekolahPaud.lembagaPendidikan);
const [isSubmitting, setIsSubmitting] = useState(false);
// Check if form is valid
const isFormValid = () => {
return (
stateLembaga.create.form.nama?.trim() !== '' &&
stateLembaga.create.form.jenjangId?.trim() !== ''
);
};
useEffect(() => {
stateLembaga.findMany.load();
infoSekolahPaud.jenjangPendidikan.findMany.load();
@@ -116,8 +124,11 @@ function CreateLembaga() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -40,6 +40,14 @@ function EditPengajar() {
lembagaId: ''
});
// Check if form is valid
const isFormValid = () => {
return (
formData.nama?.trim() !== '' &&
formData.lembagaId?.trim() !== ''
);
};
useEffect(() => {
const loadData = async () => {
const id = params?.id as string;
@@ -157,8 +165,11 @@ function EditPengajar() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -25,6 +25,14 @@ function CreatePengajar() {
const stateCreate = useProxy(infoSekolahPaud.pengajar);
const [isSubmitting, setIsSubmitting] = useState(false);
// Check if form is valid
const isFormValid = () => {
return (
stateCreate.create.form.nama?.trim() !== '' &&
stateCreate.create.form.lembagaId?.trim() !== ''
);
};
useEffect(() => {
stateCreate.findMany.load();
infoSekolahPaud.lembagaPendidikan.findMany.load();
@@ -116,8 +124,11 @@ function CreatePengajar() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -42,6 +42,14 @@ function EditSiswa() {
lembagaId: '',
});
// Check if form is valid
const isFormValid = () => {
return (
formData.nama?.trim() !== '' &&
formData.lembagaId?.trim() !== ''
);
};
// Load data siswa
useEffect(() => {
const loadSiswa = async () => {
@@ -166,8 +174,11 @@ function EditSiswa() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -25,6 +25,14 @@ function CreateSiswa() {
const stateCreate = useProxy(infoSekolahPaud.siswa);
const [isSubmitting, setIsSubmitting] = useState(false);
// Check if form is valid
const isFormValid = () => {
return (
stateCreate.create.form.nama?.trim() !== '' &&
stateCreate.create.form.lembagaId?.trim() !== ''
);
};
useEffect(() => {
stateCreate.findMany.load();
infoSekolahPaud.lembagaPendidikan.findMany.load();
@@ -115,8 +123,11 @@ function CreateSiswa() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -37,6 +37,21 @@ function EditJenisProgramYangDiselenggarakan() {
const [isSubmitting, setIsSubmitting] = useState(false);
const [originalData, setOriginalData] = useState({ judul: '', content: '' });
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.judul?.trim() !== '' &&
!isHtmlEmpty(formData.content)
);
};
// Load data pertama kali
useShallowEffect(() => {
if (!editState.findById.data) {
@@ -71,11 +86,6 @@ function EditJenisProgramYangDiselenggarakan() {
};
const handleSubmit = async () => {
if (!formData.judul.trim()) {
toast.error('Judul wajib diisi');
return;
}
setIsSubmitting(true);
try {
if (editState.findById.data) {
@@ -168,8 +178,11 @@ function EditJenisProgramYangDiselenggarakan() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -45,6 +45,21 @@ function EditTempatKegiatan() {
deskripsi: '',
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.judul?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsi)
);
};
// load data pertama kali
useShallowEffect(() => {
if (!editState.findById.data) {
@@ -79,11 +94,6 @@ function EditTempatKegiatan() {
};
const handleSubmit = async () => {
if (!formData.judul.trim()) {
toast.error('Judul wajib diisi');
return;
}
setIsSubmitting(true);
try {
if (editState.findById.data) {
@@ -177,8 +187,11 @@ function EditTempatKegiatan() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -38,6 +38,21 @@ function EditTujuanProgram() {
deskripsi: '',
});
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.judul?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsi)
);
};
// Load data pertama kali
useShallowEffect(() => {
if (!editState.findById.data) {
@@ -72,11 +87,6 @@ function EditTujuanProgram() {
};
const handleSubmit = async () => {
if (!formData.judul.trim()) {
toast.error('Judul wajib diisi');
return;
}
if (!editState.findById.data) return;
setIsSubmitting(true);
@@ -163,8 +173,11 @@ function EditTujuanProgram() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -38,6 +38,22 @@ function EditPerpustakaanDigital() {
const [previewImage, setPreviewImage] = useState<string | null>(null);
const [file, setFile] = useState<File | null>(null);
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.judul?.trim() !== '' &&
!isHtmlEmpty(formData.deskripsi) &&
formData.kategoriId?.trim() !== ''
);
};
// Load kategori & data awal
useEffect(() => {
perpustakaanDigitalState.kategoriBuku.findManyAll.load();
@@ -254,8 +270,11 @@ function EditPerpustakaanDigital() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -18,6 +18,23 @@ function CreateDataPerpustakaan() {
const [file, setFile] = useState<File | null>(null);
const [isSubmitting, setIsSubmitting] = useState(false);
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
createState.create.form.judul?.trim() !== '' &&
!isHtmlEmpty(createState.create.form.deskripsi) &&
createState.create.form.kategoriId?.trim() !== '' &&
file !== null
);
};
useEffect(() => {
perpustakaanDigitalState.kategoriBuku.findManyAll.load();
}, []);
@@ -196,8 +213,11 @@ function CreateDataPerpustakaan() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -23,6 +23,11 @@ function EditKategoriBuku() {
const [formData, setFormData] = useState({ name: '' });
const [loading, setLoading] = useState(true);
// Check if form is valid
const isFormValid = () => {
return formData.name?.trim() !== '';
};
useEffect(() => {
const loadKategori = async () => {
const id = params?.id as string;
@@ -120,8 +125,11 @@ function EditKategoriBuku() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -13,6 +13,11 @@ function CreateKategoriBuku() {
const router = useRouter();
const [isSubmitting, setIsSubmitting] = useState(false);
// Check if form is valid
const isFormValid = () => {
return createState.create.form.name?.trim() !== '';
};
const resetForm = () => {
createState.create.form = {
name: "",
@@ -81,8 +86,11 @@ function CreateKategoriBuku() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

View File

@@ -70,6 +70,26 @@ function EditPeminjam() {
catatan: "",
})
// Helper function to check if HTML content is empty
const isHtmlEmpty = (html: string) => {
// Remove all HTML tags and check if there's any text content
const textContent = html.replace(/<[^>]*>/g, '').trim();
return textContent === '';
};
// Check if form is valid
const isFormValid = () => {
return (
formData.nama?.trim() !== '' &&
formData.noTelp?.trim() !== '' &&
formData.alamat?.trim() !== '' &&
formData.bukuId?.trim() !== '' &&
formData.tanggalPinjam?.trim() !== '' &&
formData.status?.trim() !== '' &&
!isHtmlEmpty(formData.catatan)
);
};
useShallowEffect(() => {
perpustakaanDigitalState.dataPerpustakaan.findManyAll.load()
})
@@ -296,8 +316,11 @@ function EditPeminjam() {
onClick={handleSubmit}
radius="md"
size="md"
disabled={!isFormValid() || isSubmitting}
style={{
background: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
background: !isFormValid() || isSubmitting
? `linear-gradient(135deg, #cccccc, #eeeeee)`
: `linear-gradient(135deg, ${colors['blue-button']}, #4facfe)`,
color: '#fff',
boxShadow: '0 4px 15px rgba(79, 172, 254, 0.4)',
}}

Some files were not shown because too many files have changed in this diff Show More